)]}'
{"id":"openstack%2Fgrenade~125930","triplet_id":"openstack%2Fgrenade~master~Ia3c6ed321f5a5939ff950ec3a6cd0a6c1ec9dc6c","project":"openstack/grenade","branch":"master","topic":"cd/no-stop-in-upgrade","hashtags":[],"change_id":"Ia3c6ed321f5a5939ff950ec3a6cd0a6c1ec9dc6c","subject":"Enable ceilometer in default base and target","status":"ABANDONED","created":"2014-10-03 11:14:48.000000000","updated":"2014-10-10 15:38:36.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"86c4675133b08be4db4a44826d3324f2d52e6154","_number":125930,"virtual_id_number":125930,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":1,"date":"2014-10-03 12:52:21.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2014-10-06 23:11:15.000000000","_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"date":"2014-10-03 12:58:43.000000000","_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"disliked":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"all":[{"value":1,"date":"2014-10-03 19:58:59.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":-1,"date":"2014-10-09 22:28:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"all":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":-1,"date":"2014-10-10 11:31:58.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-10-03 11:48:49.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2014-10-03 12:52:21.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-10-03 19:58:59.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2014-10-06 23:11:15.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2014-10-09 22:28:50.000000000","updated_by":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"reviewer":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"state":"REVIEWER"}],"messages":[{"id":"200eeed44fddeb8ceff6cd12ee197c92d791bcfc","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2014-10-03 11:14:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"87da3262354c86a39d7162e5c5e6e81481bf93e4","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2014-10-03 11:28:45.000000000","message":"Topic changed from cd/run-ceilometer to cd/no-stop-in-upgrade","accounts_in_message":[],"_revision_number":1},{"id":"4a6d7ae61127d297af5eb47319c8e26c805956df","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2014-10-03 11:48:49.000000000","message":"Patch Set 1:\n\nhonestly, we should just change the default javelin config I think.","accounts_in_message":[],"_revision_number":1},{"id":"e58f2981ce3b0b15a86b3240427f0214884f5d83","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2014-10-03 11:59:33.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"bf09dea641e04ce9f6564eff714705452391f582","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-03 12:52:21.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- check-grenade-dsvm http://logs.openstack.org/30/125930/2/check/check-grenade-dsvm/e2be7cb : SUCCESS in 49m 03s\n- check-grenade-dsvm-neutron http://logs.openstack.org/30/125930/2/check/check-grenade-dsvm-neutron/39d563a : FAILURE in 39m 25s (non-voting)\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/30/125930/2/check/check-grenade-dsvm-partial-ncpu/f140d15 : SUCCESS in 48m 57s\n- check-grenade-dsvm-ironic-sideways-nv http://logs.openstack.org/30/125930/2/check/check-grenade-dsvm-ironic-sideways-nv/be95727 : FAILURE in 19m 26s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e63800f6010361faed718ce21545f1966e456f89","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2014-10-03 12:58:43.000000000","message":"Patch Set 2:\n\nThe current javelin code runs ceilometer without directly responding to the config. It checks for notifications from any servers that were started. If there are no servers presumably it won\u0027t do anything, but I would expect there to usually be servers.\n\nBetter would be what Sean said (paraphrase) in IRC: run tests based on what\u0027s enabled, somehow.","accounts_in_message":[],"_revision_number":2},{"id":"d4a026f51b11d67febcd0955c71f74a8b8c32116","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2014-10-03 19:58:59.000000000","message":"Patch Set 2: Code-Review+1\n\n(2 comments)\n\njust a quick question. It looks good otherwise.","accounts_in_message":[],"_revision_number":2},{"id":"626006be2073d17f5993210a8ea810c80f24372d","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2014-10-04 11:22:47.000000000","message":"Patch Set 2:\n\nResponse inline.","accounts_in_message":[],"_revision_number":2},{"id":"e9dc387c6dabfdcae9efefc3416b63f21d8c16fd","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2014-10-06 23:11:15.000000000","message":"Patch Set 2:\n\nI didn\u0027t see any inline answer","accounts_in_message":[],"_revision_number":2},{"id":"b5887bdaefbf6cdab18a747630b5cfc629865025","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2014-10-06 23:11:52.000000000","message":"Patch Set 2:\n\nI don\u0027t see any inline answers","accounts_in_message":[],"_revision_number":2},{"id":"2ace27c0993b759788db38d5270b79894e20a922","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2014-10-07 01:17:21.000000000","message":"Patch Set 2:\n\nStrange, I recall typing them in, guess I never saved them. The gist was:\n\nI intentionally left out alarming because I was only adding the services required to get javelin happy. It\u0027s probably actually still a bit too much but there\u0027s a general pattern of listing the ceilometer devstack services in two groups: alarming + everything else.\n\nI essentially agree with Sean\u0027s suggestion but until we figure out how that\u0027s supposed to work it would be nice if the default grenade.sh run (what you get if you just check it out and run it) worked; without a change like this, it does not.","accounts_in_message":[],"_revision_number":2},{"id":"67d3e35cdf5b7bb2d607fb475be819b73c2cb1ed","author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"date":"2014-10-09 22:28:50.000000000","message":"Patch Set 2: Code-Review-1\n\nI think we need to come up with a way of expressing ceilometer resources via javelin config, and then generate the resources.yaml we pass to javelin based on whats deployed.  I have a patch up to do the latter @ https://review.openstack.org/#/c/127352/ to address similar issues with volumes and servers.","accounts_in_message":[],"_revision_number":2},{"id":"f79ac7e57a0d1c51a8824d80c19c620361f10d5f","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2014-10-10 11:31:58.000000000","message":"Patch Set 2: Workflow-1\n\n\"I think we need to come up with a way of expressing ceilometer resources via javelin config\"\n\nSeems reasonable. I\u0027ll go ahead and cook something and make another patch.","accounts_in_message":[],"_revision_number":2},{"id":"86c4675133b08be4db4a44826d3324f2d52e6154","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2014-10-10 15:38:36.000000000","message":"Abandoned\n\nAbandoned in favor of I84e0f5938ec808537043dba29a896f991779b04c","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2e26ea61a0809308868749edfb7542edb91c9d85","revisions":{"bb54c443b04b47798269e3acb9f6ad8ac8aa81d2":{"kind":"REWORK","_number":1,"created":"2014-10-03 11:14:48.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/30/125930/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/grenade","ref":"refs/changes/30/125930/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/grenade refs/changes/30/125930/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/grenade refs/changes/30/125930/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/grenade refs/changes/30/125930/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/grenade refs/changes/30/125930/1"}}},"commit":{"parents":[{"commit":"990f381e89c94f96def189faa1ef486589a8f4ec","subject":"Ensure log directory has correct ownership.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/990f381e89c94f96def189faa1ef486589a8f4ec"}]}],"author":{"name":"Chris Dent","email":"chdent@redhat.com","date":"2014-10-03 10:58:48.000000000","tz":60},"committer":{"name":"Chris Dent","email":"chdent@redhat.com","date":"2014-10-03 11:14:32.000000000","tz":60},"subject":"Enable ceilometer in default base and target","message":"Enable ceilometer in default base and target\n\nOtherwise javelin fails and you\u0027ve got to start all over again.\n\nChange-Id: Ia3c6ed321f5a5939ff950ec3a6cd0a6c1ec9dc6c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/bb54c443b04b47798269e3acb9f6ad8ac8aa81d2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/bb54c443b04b47798269e3acb9f6ad8ac8aa81d2"}]},"branch":"refs/heads/master"},"2e26ea61a0809308868749edfb7542edb91c9d85":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2014-10-03 11:59:33.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/30/125930/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/grenade","ref":"refs/changes/30/125930/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/grenade refs/changes/30/125930/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/grenade refs/changes/30/125930/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/grenade refs/changes/30/125930/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/grenade refs/changes/30/125930/2"}}},"commit":{"parents":[{"commit":"87e785e0e11c9e180635b82598fdaee513f812c3","subject":"Ensure log directory has correct ownership.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/87e785e0e11c9e180635b82598fdaee513f812c3"}]}],"author":{"name":"Chris Dent","email":"chdent@redhat.com","date":"2014-10-03 10:58:48.000000000","tz":60},"committer":{"name":"Chris Dent","email":"chdent@redhat.com","date":"2014-10-03 11:59:08.000000000","tz":60},"subject":"Enable ceilometer in default base and target","message":"Enable ceilometer in default base and target\n\nOtherwise javelin fails and you\u0027ve got to start all over again.\n\nChange-Id: Ia3c6ed321f5a5939ff950ec3a6cd0a6c1ec9dc6c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/2e26ea61a0809308868749edfb7542edb91c9d85"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/2e26ea61a0809308868749edfb7542edb91c9d85"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}