)]}'
{"devstack.localrc.base":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"cad7fd1b2aea3985c80ebd6b824b6e3e979925d5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"SWIFT_HASH\u003d8213897fads879789asdf789"},{"line_number":32,"context_line":"SWIFT_REPLICAS\u003d1"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"enable_service trove tr-api tr-tmgr tr-cond"},{"line_number":35,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"da86d52c_565cd025","line":34,"updated":"2015-02-09 12:20:37.000000000","message":"we shouldn\u0027t be adding services here","commit_id":"f4ba48ad7db1161e16541816c95c2765303aaf9f"}],"devstack.localrc.target":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"cad7fd1b2aea3985c80ebd6b824b6e3e979925d5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"SWIFT_HASH\u003d8213897fads879789asdf789"},{"line_number":32,"context_line":"SWIFT_REPLICAS\u003d1"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"enable_service trove tr-api tr-tmgr tr-cond"},{"line_number":35,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"da86d52c_7640f435","line":34,"updated":"2015-02-09 12:20:37.000000000","message":"or here","commit_id":"f4ba48ad7db1161e16541816c95c2765303aaf9f"}],"from-juno/upgrade-trove":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"cad7fd1b2aea3985c80ebd6b824b6e3e979925d5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    # any configuration changes/overrides between juno and kilo"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    $XTRACE"},{"line_number":13,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"da86d52c_f67304b2","line":13,"updated":"2015-02-09 12:20:37.000000000","message":"this file is a no-op, no reason to add it.","commit_id":"f4ba48ad7db1161e16541816c95c2765303aaf9f"},{"author":{"_account_id":1870,"name":"Anna Shen","email":"ruiyuan.shen@hp.com","username":"ruiyuan-shen"},"change_message_id":"0d244550562d0f19de576f2e0d0ca63898f45f41","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    # any configuration changes/overrides between juno and kilo"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    $XTRACE"},{"line_number":13,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"da86d52c_401b10ca","line":13,"in_reply_to":"da86d52c_f67304b2","updated":"2015-02-09 19:02:52.000000000","message":"can you please explain in more details about what kind of scripts should be hosted inside this folder? I believe any service that grenade touches should have their function scripts hosted here. correct me if i am wrong.","commit_id":"f4ba48ad7db1161e16541816c95c2765303aaf9f"}],"functions":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"cad7fd1b2aea3985c80ebd6b824b6e3e979925d5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"function save_data {"},{"line_number":20,"context_line":"    local release\u003d$1"},{"line_number":21,"context_line":"    local dir\u003d$2"},{"line_number":22,"context_line":"    local mysql_services\u003d\"keystone glance nova cinder ironic trove\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    echo_summary \"Sourcing $release DevStack config\""},{"line_number":25,"context_line":"    source $dir/functions"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"da86d52c_366e7cca","line":22,"updated":"2015-02-09 12:20:37.000000000","message":"hmmm.... it feels like we need a better way to deal with this, what happens if trove isn\u0027t in the upgrade model?","commit_id":"f4ba48ad7db1161e16541816c95c2765303aaf9f"},{"author":{"_account_id":1870,"name":"Anna Shen","email":"ruiyuan.shen@hp.com","username":"ruiyuan-shen"},"change_message_id":"0d244550562d0f19de576f2e0d0ca63898f45f41","unresolved":false,"context_lines":[{"line_number":19,"context_line":"function save_data {"},{"line_number":20,"context_line":"    local release\u003d$1"},{"line_number":21,"context_line":"    local dir\u003d$2"},{"line_number":22,"context_line":"    local mysql_services\u003d\"keystone glance nova cinder ironic trove\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    echo_summary \"Sourcing $release DevStack config\""},{"line_number":25,"context_line":"    source $dir/functions"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"da86d52c_80e0a8cd","line":22,"in_reply_to":"da86d52c_366e7cca","updated":"2015-02-09 19:02:52.000000000","message":"If trove database is not present, mysqldump will error out and proceed: \n\n2015-01-29 19:41:08.211 | + for db in \u0027$mysql_services\u0027\n2015-01-29 19:41:08.211 | + mysql -uroot -psuperstack -c keystone -e \u0027\u0027\n2015-01-29 19:41:08.216 | + mysqldump -uroot -psuperstack keystone\n2015-01-29 19:41:08.295 | + for db in \u0027$mysql_services\u0027\n2015-01-29 19:41:08.295 | + mysql -uroot -psuperstack -c glance -e \u0027\u0027\n2015-01-29 19:41:08.299 | + mysqldump -uroot -psuperstack glance\n2015-01-29 19:41:08.328 | + for db in \u0027$mysql_services\u0027\n2015-01-29 19:41:08.328 | + mysql -uroot -psuperstack -c nova -e \u0027\u0027\n2015-01-29 19:41:08.332 | + mysqldump -uroot -psuperstack nova\n2015-01-29 19:41:08.685 | + for db in \u0027$mysql_services\u0027\n2015-01-29 19:41:08.685 | + mysql -uroot -psuperstack -c cinder -e \u0027\u0027\n2015-01-29 19:41:08.689 | + mysqldump -uroot -psuperstack cinder\n2015-01-29 19:41:08.731 | + for db in \u0027$mysql_services\u0027\n2015-01-29 19:41:08.731 | + mysql -uroot -psuperstack -c ironic -e \u0027\u0027\n2015-01-29 19:41:08.734 | ERROR 1049 (42000): Unknown database \u0027ironic\u0027\n2015-01-29 19:41:08.734 | + for db in \u0027$mysql_services\u0027\n2015-01-29 19:41:08.735 | + mysql -uroot -psuperstack -c trove -e \u0027\u0027\n2015-01-29 19:41:08.738 | + ERROR 1049 (42000): Unknown database \u0027trove\u0027\n2015-01-29 19:41:08.786 | ++ grep neutron\n2015-01-29 19:41:08.789 | ++ :\n2015-01-29 19:41:08.790 | + neutron_db_names\u003d\n2015-01-29 19:41:08.790 | + sudo iptables-save\n2015-01-29 19:41:08.800 | + sudo ebtables -t broute -L\n2015-01-29 19:41:08.817 | + sudo ebtables -t filter -L\n2015-01-29 19:41:08.826 | + sudo ebtables -t nat -L\n2015-01-29 19:41:08.833 | *********************************************************************\n2015-01-29 19:41:08.834 | SUCCESS: End /home/ubuntu/grenade/save-state\n2015-01-29 19:41:08.834 | *********************************************************************\n\nThe same with ironic, ironic db not always show up and I think this is a harmless route for adding \"not-always-present\" db into mysql_services list. \n\nlet me know what you think.","commit_id":"f4ba48ad7db1161e16541816c95c2765303aaf9f"}],"grenade.sh":[{"author":{"_account_id":11783,"name":"Shayne Burgess","email":"shayne.burgess@hp.com","username":"shayne-burgess"},"change_message_id":"e77306fbe9fda871717dbbb894883f97d986b07a","unresolved":false,"context_lines":[{"line_number":373,"context_line":"    if [[ \"$ENABLE_TROVE\" \u003d\u003d \"True\" ]]; then"},{"line_number":374,"context_line":"        echo_summary \"Running upgrade-trove\""},{"line_number":375,"context_line":"        upgrade_service trove || die $LINENO \"Failure in upgrade-trove\""},{"line_number":376,"context_line":"        stop $STOP upgrade trove 360"},{"line_number":377,"context_line":"    fi"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    # Upgrade Tempest"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a930d6b_ca6a8bed","line":376,"updated":"2015-01-23 21:57:15.000000000","message":"should this be upgrade-trove?","commit_id":"8f4600b50f39bf8205f40af13aa4a0635ee9a50e"}],"grenaderc":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"cad7fd1b2aea3985c80ebd6b824b6e3e979925d5","unresolved":false,"context_lines":[{"line_number":68,"context_line":"ENABLE_TEMPEST\u003d${ENABLE_TEMPEST:\u003dTrue}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# Enable Trove"},{"line_number":71,"context_line":"ENABLE_TROVE\u003d${ENABLE_TROVE:\u003dTrue}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# We need RECLONE to get the updated branches; not everyone wants it though"},{"line_number":74,"context_line":"RECLONE\u003d${RECLONE:-no}"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"da86d52c_56aa10d5","line":71,"updated":"2015-02-09 12:20:37.000000000","message":"should be -False","commit_id":"f4ba48ad7db1161e16541816c95c2765303aaf9f"},{"author":{"_account_id":1870,"name":"Anna Shen","email":"ruiyuan.shen@hp.com","username":"ruiyuan-shen"},"change_message_id":"0d244550562d0f19de576f2e0d0ca63898f45f41","unresolved":false,"context_lines":[{"line_number":68,"context_line":"ENABLE_TEMPEST\u003d${ENABLE_TEMPEST:\u003dTrue}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# Enable Trove"},{"line_number":71,"context_line":"ENABLE_TROVE\u003d${ENABLE_TROVE:\u003dTrue}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# We need RECLONE to get the updated branches; not everyone wants it though"},{"line_number":74,"context_line":"RECLONE\u003d${RECLONE:-no}"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"da86d52c_00f4b8cd","line":71,"in_reply_to":"da86d52c_56aa10d5","updated":"2015-02-09 19:02:52.000000000","message":"set up True just for testing purpose. originally it should be False, as my previous patches indicated. sorry for the confusion.","commit_id":"f4ba48ad7db1161e16541816c95c2765303aaf9f"}],"prep-base":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"cad7fd1b2aea3985c80ebd6b824b6e3e979925d5","unresolved":false,"context_lines":[{"line_number":50,"context_line":"sed -e \""},{"line_number":51,"context_line":"    s|\\@BASE_RELEASE_DIR\\@|$BASE_RELEASE_DIR|"},{"line_number":52,"context_line":"    s|\\@DATA_DIR@|$DATA_DIR|"},{"line_number":53,"context_line":"    s|\\@ENABLE_TROVE@|$ENABLE_TROVE|"},{"line_number":54,"context_line":"\" $GRENADE_DIR/devstack.localrc.base \u003e$BASE_DEVSTACK_DIR/localrc"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# if localrc.orig exists, append it to localrc"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"da86d52c_96aba8d5","line":53,"updated":"2015-02-09 12:20:37.000000000","message":"why? This seems odd","commit_id":"f4ba48ad7db1161e16541816c95c2765303aaf9f"}]}