)]}'
{"grenade.sh":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8c0d1d7d35b3d23f1d19f789e84609a65f3f7fc9","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    resources verify"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    # Validate the upgrade"},{"line_number":319,"context_line":"    # This is used for testing grenade locally, and should not be used in the"},{"line_number":320,"context_line":"    # gate. Instead, smoke tests are run by the gate script after grenade.sh"},{"line_number":321,"context_line":"    # has finished."},{"line_number":322,"context_line":"    if [[ \"$TARGET_RUN_SMOKE\" \u003d\u003d \"True\" ]]; then"},{"line_number":323,"context_line":"        echo_summary \"Running tempest scenario and smoke tests\""},{"line_number":324,"context_line":"        cd $TARGET_RELEASE_DIR/tempest"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa7ab95a_8b268a14","line":321,"range":{"start_line":319,"start_character":0,"end_line":321,"end_character":19},"updated":"2016-09-01 00:35:36.000000000","message":"I am confused..\n\nOn the gate, Tempest smoke tests run on both old and new cloud like\n\n http://logs.openstack.org/24/359424/3/check/gate-grenade-dsvm-neutron-ubuntu-trusty/7ad3994/logs/old/testr_results.html.gz\n http://logs.openstack.org/24/359424/3/check/gate-grenade-dsvm-neutron-ubuntu-trusty/7ad3994/logs/testr_results.html.gz\n\nThis seems against current gate situation..","commit_id":"87583b35a9382606c5bf481abcc1b712ca7107fc"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1ab084aa0c79d79acec85f858063f42864014551","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    # Validate the upgrade"},{"line_number":319,"context_line":"    # This is used for testing grenade locally, and should not be used in the"},{"line_number":320,"context_line":"    # gate. Instead, smoke tests are run by the gate script after grenade.sh"},{"line_number":321,"context_line":"    # has finished."},{"line_number":322,"context_line":"    if [[ \"$TARGET_RUN_SMOKE\" \u003d\u003d \"True\" ]]; then"},{"line_number":323,"context_line":"        echo_summary \"Running tempest scenario and smoke tests\""},{"line_number":324,"context_line":"        cd $TARGET_RELEASE_DIR/tempest"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a8ec9b2_edb24e4b","line":321,"in_reply_to":"7a8ec9b2_a70153b1","updated":"2016-09-16 20:09:22.000000000","message":"A-ha, yeah I completely agree with necessity for writing this down :-)\nI have some suggestion for this comment like that for including above your good explanation:\n\n - line 320: gate.\n + line 320: gate because tempest runs twice(logs/new/ and logs/)\n             against a new cloud if enabling this option.","commit_id":"87583b35a9382606c5bf481abcc1b712ca7107fc"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"cb9f0c087be2d84b7d69805d136473508500475d","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    # Validate the upgrade"},{"line_number":319,"context_line":"    # This is used for testing grenade locally, and should not be used in the"},{"line_number":320,"context_line":"    # gate. Instead, smoke tests are run by the gate script after grenade.sh"},{"line_number":321,"context_line":"    # has finished."},{"line_number":322,"context_line":"    if [[ \"$TARGET_RUN_SMOKE\" \u003d\u003d \"True\" ]]; then"},{"line_number":323,"context_line":"        echo_summary \"Running tempest scenario and smoke tests\""},{"line_number":324,"context_line":"        cd $TARGET_RELEASE_DIR/tempest"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a8ec9b2_0ab99579","line":321,"in_reply_to":"7a8ec9b2_edb24e4b","updated":"2016-09-20 15:30:17.000000000","message":"Done","commit_id":"87583b35a9382606c5bf481abcc1b712ca7107fc"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"8f45a9a5cd9ef1393f42e0230760d3fc01cd8647","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    # Validate the upgrade"},{"line_number":319,"context_line":"    # This is used for testing grenade locally, and should not be used in the"},{"line_number":320,"context_line":"    # gate. Instead, smoke tests are run by the gate script after grenade.sh"},{"line_number":321,"context_line":"    # has finished."},{"line_number":322,"context_line":"    if [[ \"$TARGET_RUN_SMOKE\" \u003d\u003d \"True\" ]]; then"},{"line_number":323,"context_line":"        echo_summary \"Running tempest scenario and smoke tests\""},{"line_number":324,"context_line":"        cd $TARGET_RELEASE_DIR/tempest"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a8ec9b2_a70153b1","line":321,"in_reply_to":"fa7ab95a_8b268a14","updated":"2016-09-16 14:42:11.000000000","message":"The file logs/old/testr_results.html.gz is created when tempest is run on the old cloud by grenade.sh; the file logs/testr_results.html.gz is created after grenade.sh has exited, by whatever script ran grenade.sh. Hence, it\u0027s unnecessary to run tempest twice within grenade.sh.\n\nI agree that this situation is confusing - that\u0027s why I created this patch to document it!","commit_id":"87583b35a9382606c5bf481abcc1b712ca7107fc"}]}