)]}'
{"projects/60_nova/upgrade.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"774a90badc8740d8c755e4706ef456a4b9c5cfad","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Setup cellsv2 records, if necessary. Do this before db_sync is run so that"},{"line_number":67,"context_line":"# it migrates the cell0 database as well."},{"line_number":68,"context_line":"$NOVA_BIN_DIR/nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# Migrate the database"},{"line_number":71,"context_line":"$NOVA_BIN_DIR/nova-manage --config-file $NOVA_CONF db sync || die $LINENO \"DB sync error\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa7ab95a_23680587","line":68,"updated":"2016-08-29 13:40:58.000000000","message":"Are we missing something? The nova change which depends on this is failing in n-api like this:\n\nhttp://logs.openstack.org/38/356138/13/check/gate-grenade-dsvm-neutron-ubuntu-trusty/5011f3a/logs/new/screen-n-api.txt.gz?level\u003dTRACE#_2016-08-26_20_28_09_168","commit_id":"84429321f75da9b4288a95aa2a365aa6de1febb1"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"6a83a17c5c5e590d6e24e78ba33b23aee7ec2fec","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Setup cellsv2 records, if necessary. Do this before db_sync is run so that"},{"line_number":67,"context_line":"# it migrates the cell0 database as well."},{"line_number":68,"context_line":"$NOVA_BIN_DIR/nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# Migrate the database"},{"line_number":71,"context_line":"$NOVA_BIN_DIR/nova-manage --config-file $NOVA_CONF db sync || die $LINENO \"DB sync error\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa7ab95a_1e199a79","line":68,"in_reply_to":"fa7ab95a_034861cb","updated":"2016-08-29 13:52:30.000000000","message":"The database is never created. The connection string is setup and then migrations are attempted but the db does not exist. I mistakenly thought the migrations created the db.","commit_id":"84429321f75da9b4288a95aa2a365aa6de1febb1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3f747e14e8a4c737eef893da8e3d0e651f9cb047","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Setup cellsv2 records, if necessary. Do this before db_sync is run so that"},{"line_number":67,"context_line":"# it migrates the cell0 database as well."},{"line_number":68,"context_line":"$NOVA_BIN_DIR/nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# Migrate the database"},{"line_number":71,"context_line":"$NOVA_BIN_DIR/nova-manage --config-file $NOVA_CONF db sync || die $LINENO \"DB sync error\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa7ab95a_034861cb","line":68,"in_reply_to":"fa7ab95a_23680587","updated":"2016-08-29 13:45:49.000000000","message":"I guess you need this in the dependency chain:\n\nhttps://review.openstack.org/#/c/355602/","commit_id":"84429321f75da9b4288a95aa2a365aa6de1febb1"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"89830ea951939927b1e51bb9ba8865c8ae3e0927","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Setup cellsv2 records, if necessary. Do this before db_sync is run so that"},{"line_number":67,"context_line":"# it migrates the cell0 database as well."},{"line_number":68,"context_line":"$NOVA_BIN_DIR/nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# Migrate the database"},{"line_number":71,"context_line":"$NOVA_BIN_DIR/nova-manage --config-file $NOVA_CONF db sync || die $LINENO \"DB sync error\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa7ab95a_73a70abd","line":68,"range":{"start_line":68,"start_character":68,"end_line":68,"end_character":88},"updated":"2016-08-30 07:47:52.000000000","message":"Are we sure this is returning something valid? Asking because on my message queue switching patch, it looks as though it\u0027s doing a switch for a cell on the new side of grenade but doesn\u0027t have valid credentials for the mq (it\u0027s failing on using the default rabbit \u0027guest\u0027 user creds).","commit_id":"f6992af7bdcd36a265b885bd73393b4840f35be8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"190fcbb1f89d96c8b9c94d8eec76cb0e3a1c22cf","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Setup cellsv2 records, if necessary. Do this before db_sync is run so that"},{"line_number":67,"context_line":"# it migrates the cell0 database as well."},{"line_number":68,"context_line":"$NOVA_BIN_DIR/nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# Migrate the database"},{"line_number":71,"context_line":"$NOVA_BIN_DIR/nova-manage --config-file $NOVA_CONF db sync || die $LINENO \"DB sync error\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa7ab95a_9a3d612d","line":68,"range":{"start_line":68,"start_character":68,"end_line":68,"end_character":88},"in_reply_to":"fa7ab95a_73a70abd","updated":"2016-08-30 15:17:34.000000000","message":"It should return something legit, and the reason it\u0027s not right now is not related to moving this. So I think we should do it and fix the other problem in parallel. I have some patches up but need eyes to figure out the right place.","commit_id":"f6992af7bdcd36a265b885bd73393b4840f35be8"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"afb7e51a9bf21057700a815f9ef35e0d3f8881a1","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Setup cellsv2 records, if necessary. Do this before db_sync is run so that"},{"line_number":67,"context_line":"# it migrates the cell0 database as well."},{"line_number":68,"context_line":"$NOVA_BIN_DIR/nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# Migrate the database"},{"line_number":71,"context_line":"$NOVA_BIN_DIR/nova-manage --config-file $NOVA_CONF db sync || die $LINENO \"DB sync error\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa7ab95a_b0a4014b","line":68,"range":{"start_line":68,"start_character":68,"end_line":68,"end_character":88},"in_reply_to":"fa7ab95a_9a3d612d","updated":"2016-08-30 16:18:49.000000000","message":"Yep, I wrote this comment before I did the debug log statement in my patch and found only one piece of the url was missing: the rabbit userid.","commit_id":"f6992af7bdcd36a265b885bd73393b4840f35be8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4beb86c067f18cecfd660c96e584dadf547a0d03","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Setup cellsv2 records, if necessary. Do this before db_sync is run so that"},{"line_number":67,"context_line":"# it migrates the cell0 database as well."},{"line_number":68,"context_line":"$NOVA_BIN_DIR/nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# Migrate the database"},{"line_number":71,"context_line":"$NOVA_BIN_DIR/nova-manage --config-file $NOVA_CONF db sync || die $LINENO \"DB sync error\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"fa7ab95a_aedb671a","line":68,"updated":"2016-08-31 20:08:34.000000000","message":"This has to be conditional on:\n\nif [ \"$NOVA_CONFIGURE_CELLSV2\" \u003d\u003d \"True\" ]; then","commit_id":"18831d2b30c7aa6a04554cb4de5dc6d30f48b97a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8535cb11aa052490313be717fabd3afc79af03a7","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Setup cellsv2 records, if necessary. Do this before db_sync is run so that"},{"line_number":67,"context_line":"# it migrates the cell0 database as well."},{"line_number":68,"context_line":"if [ \"$NOVA_CONFIGURE_CELLSV2\" \u003d\u003d \"True\" ]; then"},{"line_number":69,"context_line":"    $NOVA_BIN_DIR/nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":70,"context_line":"fi"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"fa7ab95a_28f901c9","line":68,"updated":"2016-09-01 01:24:03.000000000","message":"I think we also have to be conditional here right?\n\nhttps://github.com/openstack-dev/grenade/blob/master/projects/60_nova/resources.sh#L117\n\nBecause https://review.openstack.org/#/c/363956/ depends on this change now and it\u0027s failing here:\n\nhttp://logs.openstack.org/56/363956/3/check/gate-grenade-dsvm-neutron-ubuntu-trusty/09a989d/logs/grenade.sh.txt.gz#_2016-09-01_00_11_34_072\n\nBecause we didn\u0027t do the mapping since that\u0027s conditional now.","commit_id":"cf184805e9d82ac268438c2d609069a19b1ce33d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e14bc60cc2ae50c7de77c07743d0267059139151","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    $NOVA_BIN_DIR/nova-manage --config-file $NOVA_CONF db online_data_migrations || die $LINENO \"Failed to run online_data_migrations\""},{"line_number":75,"context_line":"fi"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# Setup cellsv2 records, if necessary. Do this before db_sync is run so that"},{"line_number":78,"context_line":"# it migrates the cell0 database as well."},{"line_number":79,"context_line":"if [ \"$NOVA_CONFIGURE_CELLSV2\" \u003d\u003d \"True\" ]; then"},{"line_number":80,"context_line":"    $NOVA_BIN_DIR/nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":81,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":11,"id":"fa7ab95a_de074b1b","line":78,"range":{"start_line":77,"start_character":39,"end_line":78,"end_character":41},"updated":"2016-09-01 14:12:13.000000000","message":"We should remove this if we\u0027re not going to re-order it to be before db sync above.","commit_id":"b31db97df0c25d974ec03050978d6ae7a2017d3c"}]}