)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9558cd0ed49ce3270c92ed4aa3f2f05efacfacbb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add cell0 database during Nova upgrade"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova now has a third database that needs to be initialized. It will"},{"line_number":10,"context_line":"reside on the same host as the nova_api database, and migrations are"},{"line_number":11,"context_line":"handled by the \"nova-manage db sync\" command."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_c3b96417","line":9,"updated":"2016-08-31 19:38:15.000000000","message":"This makes it sound like cell0 is required, which it\u0027s not, and that\u0027s why we have the conditional in the code.","commit_id":"4063cf872f89f04b61633781f5c0684debb99bca"}],"projects/60_nova/from-mitaka/upgrade-nova":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c55dbdcf612f43ab655476bc27634678689bcf9b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"function configure_nova_upgrade() {"},{"line_number":2,"context_line":"    source $TARGET_DEVSTACK_DIR/lib/database"},{"line_number":3,"context_line":"    # We need to create the cell0 database before we can sync it"},{"line_number":4,"context_line":"    apidburl\u003d$(iniget $NOVA_CONF database connection | sed \"s#/nova#/${NOVA_API_DB}#\")"},{"line_number":5,"context_line":"    iniset $NOVA_CONF api_database connection \"$apidburl\""},{"line_number":6,"context_line":"    initialize_database_backends"},{"line_number":7,"context_line":"    recreate_database nova_api_cell0"},{"line_number":8,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa7ab95a_c95ef075","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":57},"updated":"2016-08-31 17:16:20.000000000","message":"Is this just needed for something that initialize_database_backends does?","commit_id":"e09b1279896405b89b6ff86ba7ff0ade9da39248"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"ef80bed18be30a043608d0b2121f121d2e970e6b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"function configure_nova_upgrade() {"},{"line_number":2,"context_line":"    source $TARGET_DEVSTACK_DIR/lib/database"},{"line_number":3,"context_line":"    # We need to create the cell0 database before we can sync it"},{"line_number":4,"context_line":"    apidburl\u003d$(iniget $NOVA_CONF database connection | sed \"s#/nova#/${NOVA_API_DB}#\")"},{"line_number":5,"context_line":"    iniset $NOVA_CONF api_database connection \"$apidburl\""},{"line_number":6,"context_line":"    initialize_database_backends"},{"line_number":7,"context_line":"    recreate_database nova_api_cell0"},{"line_number":8,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa7ab95a_acb53a7f","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":57},"in_reply_to":"fa7ab95a_c95ef075","updated":"2016-08-31 17:30:37.000000000","message":"This was copied from https://review.openstack.org/#/c/190399/. But I can\u0027t see that it\u0027s used anywhere. I was nervous to remove it because it\u0027s hard for me to tell if it\u0027s sourced somewhere and actually does have an impact. But let\u0027s try removing it.","commit_id":"e09b1279896405b89b6ff86ba7ff0ade9da39248"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9558cd0ed49ce3270c92ed4aa3f2f05efacfacbb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"function configure_nova_upgrade() {"},{"line_number":2,"context_line":"    if [ \"$NOVA_CONFIGURE_CELLSV2\" \u003d\u003d \"True\" ]; then"},{"line_number":3,"context_line":"        source $TARGET_DEVSTACK_DIR/lib/database"},{"line_number":4,"context_line":"        # We need to create the cell0 database before we can sync it"},{"line_number":5,"context_line":"        initialize_database_backends"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa7ab95a_235850fa","line":2,"updated":"2016-08-31 19:38:15.000000000","message":"Do we need to source $TARGET_DEVSTACK_DIR/lib/nova first?","commit_id":"4063cf872f89f04b61633781f5c0684debb99bca"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f04974900ee61770cd2a9a299a3e88f1b330c8a4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"function configure_nova_upgrade() {"},{"line_number":2,"context_line":"    if [ \"$NOVA_CONFIGURE_CELLSV2\" \u003d\u003d \"True\" ]; then"},{"line_number":3,"context_line":"        source $TARGET_DEVSTACK_DIR/lib/database"},{"line_number":4,"context_line":"        # We need to create the cell0 database before we can sync it"},{"line_number":5,"context_line":"        initialize_database_backends"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa7ab95a_e3b908ee","line":2,"in_reply_to":"fa7ab95a_235850fa","updated":"2016-08-31 19:41:03.000000000","message":"Oh I see it\u0027s done here:\n\nhttps://github.com/openstack-dev/grenade/blob/master/projects/60_nova/upgrade.sh#L43","commit_id":"4063cf872f89f04b61633781f5c0684debb99bca"}]}