)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"f0223207e60672b66a89611d224eb43a1243df46","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John L. Villalovos \u003cjohn.l.villalovos@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-22 08:47:05 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix grenade runs which don\u0027t use tempest"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A bug was reported for a grenade job that doesn\u0027t use tempest. Fix is to"},{"line_number":10,"context_line":"check for existence of tempest.conf file before copying it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5201f7_6dc6e717","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":40},"updated":"2017-01-10 09:32:07.000000000","message":"upgrade-tempest shouldn\u0027t be called if tempest is not enabled [0], however it is always enabled on grenade builds [1]\n\nThis update fixes the bug, but it looks like a proper place to fix it is [1].\n\n[0] https://github.com/openstack-dev/grenade/blob/master/grenade.sh#L309-L313\n\n[1] https://github.com/openstack-infra/devstack-gate/blob/a3255a7253abf56ed8ea71284037b77d167f33ef/devstack-vm-gate-wrap.sh#L268-L270","commit_id":"192234dea95ca5727d9da3a21374a128cf0baba0"}],"upgrade-tempest":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d9a5def264468baa00b3d9f16af049ccec76f08a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"if [[ -f $BASE_RELEASE_DIR/tempest/etc/tempest.conf ]]; then"},{"line_number":84,"context_line":"    # Use the same config to target smoke tests."},{"line_number":85,"context_line":"    cp $BASE_RELEASE_DIR/tempest/etc/tempest.conf $TARGET_RELEASE_DIR/tempest/etc/tempest.conf"},{"line_number":86,"context_line":"fi"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"DEST\u003d$DEST_BACKUP"},{"line_number":89,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"da4df55a_2e5f9573","line":86,"updated":"2016-12-22 08:00:27.000000000","message":"upgrade_tempest function is called only tempest is enabled\n\nhttps://github.com/openstack-dev/grenade/blob/master/grenade.sh#L309\n\nThe case when tempest wasn\u0027t installed on base environment and going to be installed on target environment looks like job miss configuration.\n\nBut if we want to support this case, we should call here configure_tempest() instead of copying config.","commit_id":"3b58f240dbde437b699922fc5ab3632678547352"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e1a8d2cb51cb7503ccf8129a15d53748ab9e5d12","unresolved":false,"context_lines":[{"line_number":83,"context_line":"if [[ -f $BASE_RELEASE_DIR/tempest/etc/tempest.conf ]]; then"},{"line_number":84,"context_line":"    # Use the same config to target smoke tests."},{"line_number":85,"context_line":"    cp $BASE_RELEASE_DIR/tempest/etc/tempest.conf $TARGET_RELEASE_DIR/tempest/etc/tempest.conf"},{"line_number":86,"context_line":"fi"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"DEST\u003d$DEST_BACKUP"},{"line_number":89,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"da4df55a_81af6fe2","line":86,"in_reply_to":"da4df55a_2e5f9573","updated":"2016-12-22 10:14:54.000000000","message":"so we should add\nif [[ -f ... ]]; then\n  cp ...\nelse\n  configure_tempest\nfi","commit_id":"3b58f240dbde437b699922fc5ab3632678547352"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c791ac72b02b6d728b43551a58b1b4f430ae9bbf","unresolved":false,"context_lines":[{"line_number":83,"context_line":"if [[ -f $BASE_RELEASE_DIR/tempest/etc/tempest.conf ]]; then"},{"line_number":84,"context_line":"    # Use the same config to target smoke tests."},{"line_number":85,"context_line":"    cp $BASE_RELEASE_DIR/tempest/etc/tempest.conf $TARGET_RELEASE_DIR/tempest/etc/tempest.conf"},{"line_number":86,"context_line":"fi"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"DEST\u003d$DEST_BACKUP"},{"line_number":89,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"da4df55a_0f0558c1","line":86,"in_reply_to":"da4df55a_81af6fe2","updated":"2016-12-22 15:26:32.000000000","message":"Done","commit_id":"3b58f240dbde437b699922fc5ab3632678547352"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ddd1d76aa7d4b64fcf4e1075ed45c25759980ad6","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"if [[ ! -f $BASE_RELEASE_DIR/tempest/etc/tempest.conf ]]; then"},{"line_number":82,"context_line":"    configure_tempest"},{"line_number":83,"context_line":"fi"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"install_tempest_plugins"},{"line_number":86,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da4df55a_0ac62667","line":83,"updated":"2016-12-22 15:50:20.000000000","message":"It is not important what will be first install_tempest_plugins or cp ....\n\nbetter to do at L81:\nif [[ -f $BASE_RELEASE_DIR/tempest/etc/tempest.conf ]]; then\n    # Use the same config to target smoke tests.\n    cp $BASE_RELEASE_DIR/tempest/etc/tempest.conf $TARGET_RELEASE_DIR/tempest/etc/tempest.conf\nelse\n    configure_tempest\nfi","commit_id":"7aa3734e34b361cf1c1aac5955fcdc2e88c55017"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"f30c226e309a041383b62a0db804530a4c850d90","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"if [[ ! -f $BASE_RELEASE_DIR/tempest/etc/tempest.conf ]]; then"},{"line_number":82,"context_line":"    configure_tempest"},{"line_number":83,"context_line":"fi"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"install_tempest_plugins"},{"line_number":86,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da4df55a_fbe7f50f","line":83,"in_reply_to":"da4df55a_0ac62667","updated":"2016-12-22 17:01:23.000000000","message":"Done","commit_id":"7aa3734e34b361cf1c1aac5955fcdc2e88c55017"}]}