)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15784,"name":"Igor Pukha","email":"ipukha@mirantis.com","username":"ingwarr"},"change_message_id":"a1a468914610562f97985467dfcbd5e7ca4d344b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use generic-switch plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch solves the issue during the upgrade process,"},{"line_number":10,"context_line":"which comes up when generic switch plugin is enabled in devstack"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1653664"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a3c09a3_c999b2d2","line":10,"range":{"start_line":10,"start_character":15,"end_line":10,"end_character":19},"updated":"2017-01-18 21:16:17.000000000","message":"then","commit_id":"3678997bb46c5409cfc944d1471cea7a825f87c0"}],"projects/50_neutron/upgrade.sh":[{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"95d74f3483438cfa508f12f7b4fa08abdca5517c","unresolved":false,"context_lines":[{"line_number":137,"context_line":"AGENT_VPN_BINARY\u003d${AGENT_VPN_BINARY:-\"$NEUTRON_BIN_DIR/neutron-vpn-agent\"}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"# If we use plugin generic switch, it help find configuration file"},{"line_number":140,"context_line":"check_generik\u003d$(echo $DEVSTACK_PLUGINS | awk -F\",\" \u0027{print $3}\u0027)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"if [ \"$check_generik\" \u003d\u003d \"networking-generic-switch\" ]; then"},{"line_number":143,"context_line":"\tQ_PLUGIN_EXTRA_CONF_FILES[\u0027networking-generic-switch\u0027]\u003d\"/etc/neutron/plugins/ml2/ml2_conf_genericswitch.ini\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a3c09a3_c2b736d6","line":140,"range":{"start_line":140,"start_character":12,"end_line":140,"end_character":13},"updated":"2017-01-17 11:32:34.000000000","message":"s/generik/generic","commit_id":"af67fbf5dc4338e9c9559856d835fca89375f29b"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"95d74f3483438cfa508f12f7b4fa08abdca5517c","unresolved":false,"context_lines":[{"line_number":139,"context_line":"# If we use plugin generic switch, it help find configuration file"},{"line_number":140,"context_line":"check_generik\u003d$(echo $DEVSTACK_PLUGINS | awk -F\",\" \u0027{print $3}\u0027)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"if [ \"$check_generik\" \u003d\u003d \"networking-generic-switch\" ]; then"},{"line_number":143,"context_line":"\tQ_PLUGIN_EXTRA_CONF_FILES[\u0027networking-generic-switch\u0027]\u003d\"/etc/neutron/plugins/ml2/ml2_conf_genericswitch.ini\""},{"line_number":144,"context_line":"fi"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a3c09a3_a2bf8aa8","line":142,"range":{"start_line":142,"start_character":19,"end_line":142,"end_character":20},"updated":"2017-01-17 11:32:34.000000000","message":"ditoo","commit_id":"af67fbf5dc4338e9c9559856d835fca89375f29b"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"1ea67c99f31d7f7daa409f60f069ba20a0256205","unresolved":false,"context_lines":[{"line_number":137,"context_line":"AGENT_VPN_BINARY\u003d${AGENT_VPN_BINARY:-\"$NEUTRON_BIN_DIR/neutron-vpn-agent\"}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"# If we use plugin generic switch, it help find configuration file"},{"line_number":140,"context_line":"check_generic\u003d$(echo $DEVSTACK_PLUGINS | awk -F\",\" \u0027{print $3}\u0027)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"if [ \"$check_generic\" \u003d\u003d \"networking-generic-switch\" ]; then"},{"line_number":143,"context_line":"\tQ_PLUGIN_EXTRA_CONF_FILES[\u0027networking-generic-switch\u0027]\u003d\"/etc/neutron/plugins/ml2/ml2_conf_genericswitch.ini\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"7a3c09a3_9844b6b7","line":140,"range":{"start_line":140,"start_character":21,"end_line":140,"end_character":38},"updated":"2017-01-17 15:17:54.000000000","message":"Better to double-quote variables.","commit_id":"91d8f868b8f2c69f65a1311754a1bb36a948c0e5"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"926dfe6697fe64ade22e402356ee7ae25a145538","unresolved":false,"context_lines":[{"line_number":137,"context_line":"AGENT_VPN_BINARY\u003d${AGENT_VPN_BINARY:-\"$NEUTRON_BIN_DIR/neutron-vpn-agent\"}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"# If we use plugin generic switch, it help find configuration file"},{"line_number":140,"context_line":"check_generic\u003d$(echo $DEVSTACK_PLUGINS | awk -F\",\" \u0027{print $3}\u0027)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"if [ \"$check_generic\" \u003d\u003d \"networking-generic-switch\" ]; then"},{"line_number":143,"context_line":"\tQ_PLUGIN_EXTRA_CONF_FILES[\u0027networking-generic-switch\u0027]\u003d\"/etc/neutron/plugins/ml2/ml2_conf_genericswitch.ini\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"7a3c09a3_f344f8b7","line":140,"range":{"start_line":140,"start_character":20,"end_line":140,"end_character":21},"updated":"2017-01-17 16:16:10.000000000","message":"Thanks, Kerylo\ndouble-quote in this case don\u0027t important, because it\u0027s not affect to define delimiter and we will be have the same result","commit_id":"91d8f868b8f2c69f65a1311754a1bb36a948c0e5"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"1ea67c99f31d7f7daa409f60f069ba20a0256205","unresolved":false,"context_lines":[{"line_number":140,"context_line":"check_generic\u003d$(echo $DEVSTACK_PLUGINS | awk -F\",\" \u0027{print $3}\u0027)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"if [ \"$check_generic\" \u003d\u003d \"networking-generic-switch\" ]; then"},{"line_number":143,"context_line":"\tQ_PLUGIN_EXTRA_CONF_FILES[\u0027networking-generic-switch\u0027]\u003d\"/etc/neutron/plugins/ml2/ml2_conf_genericswitch.ini\""},{"line_number":144,"context_line":"fi"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# Start neutron and agents"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7a3c09a3_78f0ea91","line":143,"range":{"start_line":143,"start_character":57,"end_line":143,"end_character":70},"updated":"2017-01-17 15:17:54.000000000","message":"You can use $NEUTRON_CONF_DIR for `/etc/neutron/`\n\nBTW, can we reuse this path? https://github.com/openstack-dev/devstack/blob/master/lib/neutron#L51","commit_id":"91d8f868b8f2c69f65a1311754a1bb36a948c0e5"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"926dfe6697fe64ade22e402356ee7ae25a145538","unresolved":false,"context_lines":[{"line_number":140,"context_line":"check_generic\u003d$(echo $DEVSTACK_PLUGINS | awk -F\",\" \u0027{print $3}\u0027)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"if [ \"$check_generic\" \u003d\u003d \"networking-generic-switch\" ]; then"},{"line_number":143,"context_line":"\tQ_PLUGIN_EXTRA_CONF_FILES[\u0027networking-generic-switch\u0027]\u003d\"/etc/neutron/plugins/ml2/ml2_conf_genericswitch.ini\""},{"line_number":144,"context_line":"fi"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# Start neutron and agents"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7a3c09a3_f02f8e85","line":143,"range":{"start_line":143,"start_character":57,"end_line":143,"end_character":70},"in_reply_to":"7a3c09a3_78f0ea91","updated":"2017-01-17 16:16:10.000000000","message":"When we deploy devstack we use local.conf and set identified variable there\nAndQ_PLUGIN_EXTRA_CONF_FILES[\u0027networking-generic-switch\u0027] is set in local.conf.\nBut when grenade call upgrade phase, it don\u0027t use local.conf","commit_id":"91d8f868b8f2c69f65a1311754a1bb36a948c0e5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2115fe2d0b12bffe222799444d6ffaa45ee37ff3","unresolved":false,"context_lines":[{"line_number":140,"context_line":"check_generic\u003d$(echo \"$DEVSTACK_PLUGINS\" | awk -F\",\" \u0027{print $3}\u0027)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"if [ \"$check_generic\" \u003d\u003d \"networking-generic-switch\" ]; then"},{"line_number":143,"context_line":"\tQ_PLUGIN_EXTRA_CONF_FILES[\u0027networking-generic-switch\u0027]\u003d\"/etc/neutron/plugins/ml2/ml2_conf_genericswitch.ini\""},{"line_number":144,"context_line":"fi"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# Start neutron and agents"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3a461143_e0a79f08","line":143,"range":{"start_line":143,"start_character":1,"end_line":143,"end_character":26},"updated":"2017-01-31 11:49:21.000000000","message":"this variable is deprecated https://github.com/openstack-dev/devstack/blob/bd14f7f23e01968aba70f0025b85dc15f110abc1/lib/neutron-legacy#L295\n\nshouldn\u0027t this config added during upgrade phase of networking-generic-switch?","commit_id":"985f7595cb4db8d7ba27e59d26112c50e0cea01d"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"19683f46ab208d0291042f4807a146697725a197","unresolved":false,"context_lines":[{"line_number":140,"context_line":"check_generic\u003d$(echo \"$DEVSTACK_PLUGINS\" | awk -F\",\" \u0027{print $3}\u0027)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"if [ \"$check_generic\" \u003d\u003d \"networking-generic-switch\" ]; then"},{"line_number":143,"context_line":"\tQ_PLUGIN_EXTRA_CONF_FILES[\u0027networking-generic-switch\u0027]\u003d\"/etc/neutron/plugins/ml2/ml2_conf_genericswitch.ini\""},{"line_number":144,"context_line":"fi"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# Start neutron and agents"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3a461143_c043836a","line":143,"range":{"start_line":143,"start_character":1,"end_line":143,"end_character":26},"in_reply_to":"3a461143_e0a79f08","updated":"2017-01-31 12:04:49.000000000","message":"Thanks, Vasyl I\u0027ll abandoned this patch","commit_id":"985f7595cb4db8d7ba27e59d26112c50e0cea01d"}]}