)]}'
{"projects/60_nova/from-mitaka/upgrade-nova":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7c9e0fccdb4f19a1da042adf44905c5fee9da2c6","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        source $TARGET_DEVSTACK_DIR/lib/database"},{"line_number":4,"context_line":"        # We need to create the cell0 database before we can sync it"},{"line_number":5,"context_line":"        initialize_database_backends"},{"line_number":6,"context_line":"        recreate_database nova_cell0"},{"line_number":7,"context_line":"    fi"},{"line_number":8,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a3c09a3_34696a26","line":6,"updated":"2017-01-15 19:05:26.000000000","message":"This is fine for consistency but it\u0027s probably not needed. We probably had this here to make the cells v2 grenade job work in newton (when newton was master), but cell0 wasn\u0027t used in newton anyway so this isn\u0027t critical. Not sure how sdague will feel about this one.","commit_id":"e12cf1ac1eb1b3efb06b16dcb5a3d387e87657a3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"26b3ce67edca155c85d9366cf5e63ca9db3f95ce","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        source $TARGET_DEVSTACK_DIR/lib/database"},{"line_number":4,"context_line":"        # We need to create the cell0 database before we can sync it"},{"line_number":5,"context_line":"        initialize_database_backends"},{"line_number":6,"context_line":"        recreate_database nova_cell0"},{"line_number":7,"context_line":"    fi"},{"line_number":8,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7a3c09a3_18c8f821","line":6,"updated":"2017-01-16 17:29:42.000000000","message":"For some reason in my newton backport of the nova change which depends on this grenade patch, this isn\u0027t getting picked up:\n\nhttp://logs.openstack.org/61/420461/1/check/gate-grenade-dsvm-neutron-ubuntu-trusty/62f7c6d/logs/grenade.sh.txt.gz#_2017-01-16_15_21_21_399","commit_id":"74ce189956730572d0ef53c1fba4352cb230a279"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2d733053902c5d6df9ba94ea191292e07d9dd167","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        source $TARGET_DEVSTACK_DIR/lib/database"},{"line_number":4,"context_line":"        # We need to create the cell0 database before we can sync it"},{"line_number":5,"context_line":"        initialize_database_backends"},{"line_number":6,"context_line":"        recreate_database nova_cell0"},{"line_number":7,"context_line":"    fi"},{"line_number":8,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7a3c09a3_b88524ae","line":6,"in_reply_to":"7a3c09a3_18c8f821","updated":"2017-01-16 17:30:46.000000000","message":"Oh I didn\u0027t realize grenade had branches, so that\u0027s why, because this change isn\u0027t in stable/newton grenade...","commit_id":"74ce189956730572d0ef53c1fba4352cb230a279"}],"projects/60_nova/from-newton/upgrade-nova":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c97fed7e1ee45d9b53f61165654ff88289f99697","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    # We need to create the cell0 database before we can sync it"},{"line_number":7,"context_line":"    initialize_database_backends"},{"line_number":8,"context_line":"    recreate_database nova_cell0"},{"line_number":9,"context_line":"    ($NOVA_BIN_DIR/nova-manage cell_v2 map_cell0 --database_connection $(database_connection_url nova_cell0) || true)"},{"line_number":10,"context_line":"    $NOVA_BIN_DIR/nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a3c09a3_542196fa","line":9,"range":{"start_line":9,"start_character":39,"end_line":9,"end_character":48},"updated":"2017-01-15 19:02:35.000000000","message":"I\u0027d be willing to bet that sdague will want to see a nova change with a release note saying that you should run map_cell0 on upgrade from newton.","commit_id":"e12cf1ac1eb1b3efb06b16dcb5a3d387e87657a3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c97fed7e1ee45d9b53f61165654ff88289f99697","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    # We need to create the cell0 database before we can sync it"},{"line_number":7,"context_line":"    initialize_database_backends"},{"line_number":8,"context_line":"    recreate_database nova_cell0"},{"line_number":9,"context_line":"    ($NOVA_BIN_DIR/nova-manage cell_v2 map_cell0 --database_connection $(database_connection_url nova_cell0) || true)"},{"line_number":10,"context_line":"    $NOVA_BIN_DIR/nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a3c09a3_b4155a9c","line":9,"range":{"start_line":9,"start_character":109,"end_line":9,"end_character":117},"updated":"2017-01-15 19:02:35.000000000","message":"Why this?","commit_id":"e12cf1ac1eb1b3efb06b16dcb5a3d387e87657a3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"06376e7e2429f5ebe469b8fbbc3338daff063abe","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    # We need to create the cell0 database before we can sync it"},{"line_number":7,"context_line":"    initialize_database_backends"},{"line_number":8,"context_line":"    recreate_database nova_cell0"},{"line_number":9,"context_line":"    ($NOVA_BIN_DIR/nova-manage cell_v2 map_cell0 --database_connection $(database_connection_url nova_cell0) || true)"},{"line_number":10,"context_line":"    $NOVA_BIN_DIR/nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a3c09a3_ba02a307","line":9,"range":{"start_line":9,"start_character":109,"end_line":9,"end_character":117},"in_reply_to":"7a3c09a3_34feca38","updated":"2017-01-15 21:27:55.000000000","message":"Yeah I thought we fixed that but I guess not yet, dtp has a patch up for it though.","commit_id":"e12cf1ac1eb1b3efb06b16dcb5a3d387e87657a3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3c16abb5a4312f3efff0a67fb497a2657919531d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    # We need to create the cell0 database before we can sync it"},{"line_number":7,"context_line":"    initialize_database_backends"},{"line_number":8,"context_line":"    recreate_database nova_cell0"},{"line_number":9,"context_line":"    ($NOVA_BIN_DIR/nova-manage cell_v2 map_cell0 --database_connection $(database_connection_url nova_cell0) || true)"},{"line_number":10,"context_line":"    $NOVA_BIN_DIR/nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a3c09a3_f4eb6276","line":9,"range":{"start_line":9,"start_character":39,"end_line":9,"end_character":48},"in_reply_to":"7a3c09a3_542196fa","updated":"2017-01-15 19:09:00.000000000","message":"This is just because simple_cell_setup won\u0027t take the cell0 DB url, but will only work with the default.","commit_id":"e12cf1ac1eb1b3efb06b16dcb5a3d387e87657a3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3c16abb5a4312f3efff0a67fb497a2657919531d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    # We need to create the cell0 database before we can sync it"},{"line_number":7,"context_line":"    initialize_database_backends"},{"line_number":8,"context_line":"    recreate_database nova_cell0"},{"line_number":9,"context_line":"    ($NOVA_BIN_DIR/nova-manage cell_v2 map_cell0 --database_connection $(database_connection_url nova_cell0) || true)"},{"line_number":10,"context_line":"    $NOVA_BIN_DIR/nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a3c09a3_34feca38","line":9,"range":{"start_line":9,"start_character":109,"end_line":9,"end_character":117},"in_reply_to":"7a3c09a3_b4155a9c","updated":"2017-01-15 19:09:00.000000000","message":"Remember, we need to fix the return value of map_cell0 which is always nonzero now, and will always bail on errexit.","commit_id":"e12cf1ac1eb1b3efb06b16dcb5a3d387e87657a3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"06376e7e2429f5ebe469b8fbbc3338daff063abe","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    # We need to create the cell0 database before we can sync it"},{"line_number":7,"context_line":"    initialize_database_backends"},{"line_number":8,"context_line":"    recreate_database nova_cell0"},{"line_number":9,"context_line":"    ($NOVA_BIN_DIR/nova-manage cell_v2 map_cell0 --database_connection $(database_connection_url nova_cell0) || true)"},{"line_number":10,"context_line":"    $NOVA_BIN_DIR/nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a3c09a3_7702140d","line":9,"range":{"start_line":9,"start_character":39,"end_line":9,"end_character":48},"in_reply_to":"7a3c09a3_f4eb6276","updated":"2017-01-15 21:27:55.000000000","message":"Oh right which right now simple_cell_setup is calling map_cell0 without a db connection so nova creates the cell0 db connection itself using the API DB connection which is wrong, and we\u0027re doing this to fix that in nova:\n\nhttps://review.openstack.org/#/c/420439/\n\nYou might want to mention ^ in the commit message for clarity.","commit_id":"e12cf1ac1eb1b3efb06b16dcb5a3d387e87657a3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7bee02a696061a6ca7b008a953eedabd648a92c0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    # using the api_database connection for this in Newton. As long as the"},{"line_number":12,"context_line":"    # cell0 mapping exists before simple_cell_setup is called it will not be"},{"line_number":13,"context_line":"    # re-created."},{"line_number":14,"context_line":"    ($NOVA_BIN_DIR/nova-manage cell_v2 map_cell0 --database_connection $(database_connection_url nova_cell0) || true)"},{"line_number":15,"context_line":"    $NOVA_BIN_DIR/nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":16,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7a3c09a3_ea6e0b2e","line":14,"updated":"2017-01-16 09:43:31.000000000","message":"nit: a TODO explaining that map_cell0 returns 1 so it requires the true statement.","commit_id":"74ce189956730572d0ef53c1fba4352cb230a279"}],"projects/60_nova/upgrade.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7c9e0fccdb4f19a1da042adf44905c5fee9da2c6","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Setup cellsv2 records, if necessary."},{"line_number":77,"context_line":"if [ \"$NOVA_CONFIGURE_CELLSV2\" \u003d\u003d \"True\" ]; then"},{"line_number":78,"context_line":"    ($NOVA_BIN_DIR/nova-manage cell_v2 map_cell0 --database_connection $(database_connection_url nova_cell0) || true)"},{"line_number":79,"context_line":"    $NOVA_BIN_DIR/nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":80,"context_line":"fi"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a3c09a3_94605e37","line":78,"updated":"2017-01-15 19:05:26.000000000","message":"So to be clear, map_cell0 is here for cells v1, and simple_cell_setup is for non-cells v1? Just curious if I\u0027m understanding this correctly because simple_cell_setup will also call map_cell0.","commit_id":"e12cf1ac1eb1b3efb06b16dcb5a3d387e87657a3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6573eb1984f6227da62f0a65c47a55282b1bd7e5","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Setup cellsv2 records, if necessary."},{"line_number":77,"context_line":"if [ \"$NOVA_CONFIGURE_CELLSV2\" \u003d\u003d \"True\" ]; then"},{"line_number":78,"context_line":"    ($NOVA_BIN_DIR/nova-manage cell_v2 map_cell0 --database_connection $(database_connection_url nova_cell0) || true)"},{"line_number":79,"context_line":"    $NOVA_BIN_DIR/nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":80,"context_line":"fi"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a3c09a3_f4a2824a","line":78,"in_reply_to":"7a3c09a3_94605e37","updated":"2017-01-15 19:10:47.000000000","message":"No, map_cell0 is here for both, to setup cell0 to the right db url (because we can control it if we call map_cell0 ourselves). Then simple_cell_setup does its normal thing, sans cell0 because it\u0027s already done.\n\nI\u0027m doing this so we can land these changes before the one in nova to change the default. If we don\u0027t, then we can\u0027t change the default without breaking devstack before we land the devstack change.","commit_id":"e12cf1ac1eb1b3efb06b16dcb5a3d387e87657a3"}]}