)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"66dfe976a6aca88c36f98c99635b7a4c49863766","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dan Smith \u003cdansmith@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-24 16:23:31 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Run the placement service when upgrading to Ocata"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now the placement service is mandatory in Ocata, we need to modify Grenade"},{"line_number":10,"context_line":"to deploy that service even if the source local.conf is not providing it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a3905b3_7a6792ea","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"updated":"2017-01-25 04:31:25.000000000","message":"You\u0027re going to need to reference a nova change with an upgrade impact release note to justify the need for the change in grenade, which will most likely be this change:\n\nhttps://review.openstack.org/417961","commit_id":"4ba0aedc2ed8686ec3f8751a2effa4325b8025cf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f2bd8b6545e4ab001bfb1904ceb585b40e4f81b5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to deploy that service even if the source local.conf is not providing it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Note that we need to do this as part of nova right now because the"},{"line_number":13,"context_line":"code for placement is in the nova tree. If we do it before and separately,"},{"line_number":14,"context_line":"we end up starting a newton placement service, which is not enough for"},{"line_number":15,"context_line":"ocata nova (and/or we partially upgrade nova from 55_placement, which"},{"line_number":16,"context_line":"breaks within-$release and my brain)."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I573149b9415da2a8bb3951a4c4ce71c4c3e48c6f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"3a461143_2312c009","line":16,"range":{"start_line":13,"start_character":40,"end_line":16,"end_character":37},"updated":"2017-01-30 10:02:33.000000000","message":"thanks for explaining why you\u0027re back to a previous PS.\n\nI\u0027m fine with that, honestly the placement API is not a new service.","commit_id":"a1ea5cec068d59b9c2caa1c82d7ee2584d63aa08"}],"projects/55_placement/from-newton/upgrade-placement":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8220cd6d41fd8ac58cb38335379439e23b3ab062","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    FILES\u003d$TARGET_DEVSTACK_DIR/files"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    cleanup_placement"},{"line_number":17,"context_line":"    configure_placement"},{"line_number":18,"context_line":"    configure_placement_nova_compute"},{"line_number":19,"context_line":"    init_placement"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"3a461143_a504144a","line":16,"updated":"2017-01-27 23:17:42.000000000","message":"Do we need \"stack_install_service placement\" before this?\n\nUsed to do that here:\n\nhttps://review.openstack.org/#/c/424730/12/projects/60_nova/from-newton/upgrade-nova\n\nBut I guess we do it here now:\n\nhttps://review.openstack.org/#/c/424730/16/projects/55_placement/upgrade.sh@50","commit_id":"948f26afb8e44c9c29177181804c6a21cf8d283b"}],"projects/60_nova/resources.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1e96cc4bc1e09b6b3714c7ca20eab4f8a9d726fe","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    expected\u003d$(resource_get nova nova_compute_count)"},{"line_number":137,"context_line":"    echo \"Expecting $expected computes\""},{"line_number":138,"context_line":"    for try in $(seq 0 15); do"},{"line_number":139,"context_line":"\tfound\u003d$(_nova_count_computes)"},{"line_number":140,"context_line":"\tif [ $found -ge $expected ]; then"},{"line_number":141,"context_line":"\t    echo \"Found $found computes\""}],"source_content_type":"text/x-sh","patch_set":9,"id":"3a461143_2b3663e7","line":138,"updated":"2017-01-26 23:20:51.000000000","message":"Do we need to check $found after the loop is done and if $found -lt $expected we fail?","commit_id":"2ec104e3415fa8d92ae6c74d7aa06848757c73d7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2cf383fb0a5520e3b893fa684cb2ec8e4d456bc6","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    expected\u003d$(resource_get nova nova_compute_count)"},{"line_number":137,"context_line":"    echo \"Expecting $expected computes\""},{"line_number":138,"context_line":"    for try in $(seq 0 15); do"},{"line_number":139,"context_line":"\tfound\u003d$(_nova_count_computes)"},{"line_number":140,"context_line":"\tif [ $found -ge $expected ]; then"},{"line_number":141,"context_line":"\t    echo \"Found $found computes\""}],"source_content_type":"text/x-sh","patch_set":9,"id":"3a461143_8b0597c3","line":138,"in_reply_to":"3a461143_2b3663e7","updated":"2017-01-26 23:31:39.000000000","message":"I was going to not fail just because of this, in case we were just too impatient, since we\u0027re not waiting right now. I guess I thought people wouldn\u0027t like obsessing over this for some reason, but we surely can.","commit_id":"2ec104e3415fa8d92ae6c74d7aa06848757c73d7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"26da2320742b18f4ef13523183e38f7baa9b7979","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    expected\u003d$(resource_get nova nova_compute_count)"},{"line_number":137,"context_line":"    echo \"Expecting $expected computes\""},{"line_number":138,"context_line":"    for try in $(seq 0 15); do"},{"line_number":139,"context_line":"\tfound\u003d$(_nova_count_computes)"},{"line_number":140,"context_line":"\tif [ $found -ge $expected ]; then"},{"line_number":141,"context_line":"\t    echo \"Found $found computes\""}],"source_content_type":"text/x-sh","patch_set":9,"id":"3a461143_8b2bd7ea","line":138,"in_reply_to":"3a461143_8b0597c3","updated":"2017-01-26 23:44:02.000000000","message":"I\u0027m fine with that.","commit_id":"2ec104e3415fa8d92ae6c74d7aa06848757c73d7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"cbae5791c368936961e8e4078500a62bcf06d795","unresolved":false,"context_lines":[{"line_number":142,"context_line":"\t    break"},{"line_number":143,"context_line":"\tfi"},{"line_number":144,"context_line":"\techo \"Waiting for computes to show up... (found $found so far)\""},{"line_number":145,"context_line":"\tsleep(10)"},{"line_number":146,"context_line":"    done"},{"line_number":147,"context_line":"}"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"3a461143_904a2282","line":145,"range":{"start_line":145,"start_character":1,"end_line":145,"end_character":10},"updated":"2017-01-26 23:13:46.000000000","message":"FWIW sleep 10","commit_id":"2ec104e3415fa8d92ae6c74d7aa06848757c73d7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1e96cc4bc1e09b6b3714c7ca20eab4f8a9d726fe","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    expected\u003d$(resource_get nova nova_compute_count)"},{"line_number":137,"context_line":"    echo \"Expecting $expected computes\""},{"line_number":138,"context_line":"    for try in $(seq 0 15); do"},{"line_number":139,"context_line":"\tfound\u003d$(_nova_count_computes)"},{"line_number":140,"context_line":"\tif [ $found -ge $expected ]; then"},{"line_number":141,"context_line":"\t    echo \"Found $found computes\""},{"line_number":142,"context_line":"\t    break"},{"line_number":143,"context_line":"\tfi"},{"line_number":144,"context_line":"\techo \"Waiting for computes to show up... (found $found so far)\""},{"line_number":145,"context_line":"\tsleep(10)"},{"line_number":146,"context_line":"    done"},{"line_number":147,"context_line":"}"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"3a461143_eb0c5b3d","line":145,"range":{"start_line":139,"start_character":0,"end_line":145,"end_character":10},"updated":"2017-01-26 23:20:51.000000000","message":"tab ugliness","commit_id":"2ec104e3415fa8d92ae6c74d7aa06848757c73d7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1dce86b067b02f98adfa6861fa479b64e3b0d107","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    # ping check on the way up to ensure we\u0027re really running"},{"line_number":111,"context_line":"    ping_check_public $ip 30"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    resource_save nova nova_compute_count $(_nova_count_computes)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    # NOTE(sdague): for debugging when things go wrong, so we have a"},{"line_number":116,"context_line":"    # before and an after"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3a461143_bdbc566d","line":113,"updated":"2017-01-27 00:27:05.000000000","message":"Something is messed up here because in the multinode grenade run, this has 0 as the result:\n\nhttp://logs.openstack.org/30/424730/10/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/9a57ab4/logs/grenade_save/grenade_db.ini\n\nnova_compute_count \u003d 0","commit_id":"2a74b1da890b2cd21cbb44d0ea46b1f57361841a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1dce86b067b02f98adfa6861fa479b64e3b0d107","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        fi"},{"line_number":134,"context_line":"    fi"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    expected\u003d$(resource_get nova nova_compute_count)"},{"line_number":137,"context_line":"    echo \"Expecting $expected computes\""},{"line_number":138,"context_line":"    for try in $(seq 0 15); do"},{"line_number":139,"context_line":"        found\u003d$(_nova_count_computes)"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3a461143_1d5e4a76","line":136,"updated":"2017-01-27 00:27:05.000000000","message":"Should we restrict this to only when $side \u003d\u003d \u0027post-upgrade\u0027 because I\u0027m seeing this:\n\nhttp://logs.openstack.org/30/424730/10/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/9a57ab4/logs/grenade.sh.txt.gz#_2017-01-26_23_58_11_661\n\necho \u0027Expecting 0 computes\u0027","commit_id":"2a74b1da890b2cd21cbb44d0ea46b1f57361841a"}]}