)]}'
{"grenade.sh":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9000e368e95d51a1fac03be41607a5a12ad02ac5","unresolved":false,"context_lines":[{"line_number":227,"context_line":"devstack_localrc base \"NOVA_USE_MOD_WSGI\u003dFalse\""},{"line_number":228,"context_line":"devstack_localrc target \"NOVA_USE_MOD_WSGI\u003dFalse\""},{"line_number":229,"context_line":"devstack_localrc base \"CINDER_USE_MOD_WSGI\u003dFalse\""},{"line_number":230,"context_line":"devstack_localrc target \"CINDER_USE_MOD_WSGI\u003dFalse\""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"# Nova should use singleconductor as Grenade doesn\u0027t"},{"line_number":233,"context_line":"# setup multi-cell rabbit for now"}],"source_content_type":"text/x-sh","patch_set":13,"id":"7f287b81_fd2141b5","side":"PARENT","line":230,"updated":"2017-08-31 10:46:59.000000000","message":"heat seems to be breaking after this, maybe it doesn\u0027t do uwsgi?","commit_id":"3c74c6c3d7b38f39ca364f9dc2a24ccfb267d5a7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d1c99c2d5f0c52c39461c0520fcafcba1157328a","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        # By the time we get here the sub nodes are already setup with localrc files"},{"line_number":248,"context_line":"        # as those are transferred in devstack-gate even before grenade.sh is called"},{"line_number":249,"context_line":"        # We hack the ./post-stack.sh to inject what we need. if we don\u0027t set"},{"line_number":250,"context_line":"        # CELLSV2_SETUP, the default devstack assumes \"superconductor\" and fails. if"},{"line_number":251,"context_line":"        # we don\u0027t set WSGI_MODE, cinder fails to glance as the glance url is not"},{"line_number":252,"context_line":"        # set up correctly"},{"line_number":253,"context_line":"        export SUB_NODE_ENV_VARS\u003d\"CELLSV2_SETUP\u003dsingleconductor\""},{"line_number":254,"context_line":"        sed -i \u0027s/stdbuf/$SUB_NODE_ENV_VARS stdbuf/\u0027 ./post-stack.sh"},{"line_number":255,"context_line":"        cat ./post-stack.sh"}],"source_content_type":"text/x-sh","patch_set":15,"id":"1f9dbf25_ce523868","line":252,"range":{"start_line":250,"start_character":82,"end_line":252,"end_character":26},"updated":"2018-03-02 10:12:49.000000000","message":"This should have been removed.","commit_id":"03de9e0fc7f4fc50a00db5d547413e26cf0780dd"}],"inc/upgrade":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"319735f1ebf145ad308c9e2a1c43c8d886af6891","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"function is_service_running {"},{"line_number":114,"context_line":"    local name\u003d\"$1\""},{"line_number":115,"context_line":"    systemctl status $name"},{"line_number":116,"context_line":"    local exitcode\u003d$?"},{"line_number":117,"context_line":"    # If systemctl status returns 4 that\u0027s unit not found, so fallback to the ps"},{"line_number":118,"context_line":"    # approach"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"7f287b81_bf5d0a7a","line":115,"updated":"2017-08-30 14:09:54.000000000","message":"systemctl status \"devstack@${service}\"","commit_id":"09ddab3dd5460c2a29e6aee37807903f40664ce4"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"319735f1ebf145ad308c9e2a1c43c8d886af6891","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        deprecated \"Using the process name with ps for service status is deprecated, please update to use the systemd unit name\""},{"line_number":121,"context_line":"        ps auxw | grep -v grep | grep -v shutdown.sh | grep -v upgrade.sh | grep -e \"${name}\""},{"line_number":122,"context_line":"        exitcode\u003d$?"},{"line_number":123,"context_line":"    fi"},{"line_number":124,"context_line":"    return $exitcode"},{"line_number":125,"context_line":"}"},{"line_number":126,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"7f287b81_9f6fee29","line":123,"updated":"2017-08-30 14:09:54.000000000","message":"this part is good...","commit_id":"09ddab3dd5460c2a29e6aee37807903f40664ce4"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"319735f1ebf145ad308c9e2a1c43c8d886af6891","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        still_running\u003d\"\""},{"line_number":138,"context_line":"        local service\u003d\"\""},{"line_number":139,"context_line":"        for service in \"$@\"; do"},{"line_number":140,"context_line":"            if is_service_running \"devstack@${service}\"; then"},{"line_number":141,"context_line":"                still_running+\u003d\" $service\""},{"line_number":142,"context_line":"            fi"},{"line_number":143,"context_line":"        done"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"7f287b81_9f580e88","line":140,"updated":"2017-08-30 14:09:54.000000000","message":"the problem with making the change here, is that means everyone needs the new unit names for this function, so they won\u0027t roll over.\n\nIt should be:\n\n  if is_service_running \"${service}\"; then....\n\nstill","commit_id":"09ddab3dd5460c2a29e6aee37807903f40664ce4"}]}