)]}'
{"inc/upgrade":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"384fa1557cb1993fa700a8ef9a407d332e575241","unresolved":false,"context_lines":[{"line_number":113,"context_line":"function is_service_running {"},{"line_number":114,"context_line":"    local name\u003d\"$1\""},{"line_number":115,"context_line":"    if systemctl is-enabled \"devstack@$name\" ; then"},{"line_number":116,"context_line":"        systemctl status \"devstack@$name\""},{"line_number":117,"context_line":"        local exitcode\u003d$?"},{"line_number":118,"context_line":"    # If the unit is not found, so fallback to the ps approach"},{"line_number":119,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7f287b81_6efc8b6f","line":116,"updated":"2017-08-30 18:25:52.000000000","message":"this needs to be $SYSTEMCTL (in case we need sudo). Also, you\u0027ll need --no-pager on status otherwise it will hang on status.","commit_id":"020239b5f5330994c5aab100ac9cba8c50baf15d"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"a0973b701289705512ec0d87a4e24b3eacb8d938","unresolved":false,"context_lines":[{"line_number":113,"context_line":"function is_service_running {"},{"line_number":114,"context_line":"    local name\u003d\"$1\""},{"line_number":115,"context_line":"    if systemctl is-enabled \"devstack@$name\" ; then"},{"line_number":116,"context_line":"        systemctl status \"devstack@$name\""},{"line_number":117,"context_line":"        local exitcode\u003d$?"},{"line_number":118,"context_line":"    # If the unit is not found, so fallback to the ps approach"},{"line_number":119,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7f287b81_0f8bc167","line":116,"in_reply_to":"7f287b81_6efc8b6f","updated":"2017-08-30 19:57:19.000000000","message":"Done","commit_id":"020239b5f5330994c5aab100ac9cba8c50baf15d"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"384fa1557cb1993fa700a8ef9a407d332e575241","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    else"},{"line_number":120,"context_line":"        deprecated \"Using the process name with ps for service status is deprecated, please update to use the systemd unit name\""},{"line_number":121,"context_line":"        ps auxw | grep -v grep | grep -v shutdown.sh | grep -v upgrade.sh | grep -e \"${name}\""},{"line_number":122,"context_line":"        exitcode\u003d$?"},{"line_number":123,"context_line":"    fi"},{"line_number":124,"context_line":"    return $exitcode"},{"line_number":125,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7f287b81_ce301f59","line":122,"updated":"2017-08-30 18:25:52.000000000","message":"this exitcode is not localized, if you end up in this branch, you need to do that outside of the branches.","commit_id":"020239b5f5330994c5aab100ac9cba8c50baf15d"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"a0973b701289705512ec0d87a4e24b3eacb8d938","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    else"},{"line_number":120,"context_line":"        deprecated \"Using the process name with ps for service status is deprecated, please update to use the systemd unit name\""},{"line_number":121,"context_line":"        ps auxw | grep -v grep | grep -v shutdown.sh | grep -v upgrade.sh | grep -e \"${name}\""},{"line_number":122,"context_line":"        exitcode\u003d$?"},{"line_number":123,"context_line":"    fi"},{"line_number":124,"context_line":"    return $exitcode"},{"line_number":125,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7f287b81_efebd50f","line":122,"in_reply_to":"7f287b81_ce301f59","updated":"2017-08-30 19:57:19.000000000","message":"Done","commit_id":"020239b5f5330994c5aab100ac9cba8c50baf15d"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"8bbf9d60adde426e53e7cf4b57e6c8397cc50ffb","unresolved":false,"context_lines":[{"line_number":113,"context_line":"function is_service_running {"},{"line_number":114,"context_line":"    local name\u003d\"$1\""},{"line_number":115,"context_line":"    local exitcode\u003d0"},{"line_number":116,"context_line":"    if $SYSTEMCTL is-enabled \"devstack@$name\" --no-pager; then"},{"line_number":117,"context_line":"        $SYSTEMCTL status \"devstack@$name\" --no-pager"},{"line_number":118,"context_line":"        exitcode\u003d$?"},{"line_number":119,"context_line":"    # If the unit is not found, so fallback to the ps approach"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7f287b81_bd7979c5","line":116,"range":{"start_line":116,"start_character":46,"end_line":116,"end_character":56},"updated":"2017-08-31 10:44:58.000000000","message":"strictly you only need it on the status one, but this is fine","commit_id":"0965bc0dced806f51a4d4bd39642dab20dbec87e"}]}