)]}'
{".zuul.yaml":[{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"2046cd47f1c935bc73510f7ea32f71da043aa3bf","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    parent: grenade-base"},{"line_number":109,"context_line":"    required-projects:"},{"line_number":110,"context_line":"      # NOTE(andreaf) The devstack and grenade roles take care of setting up"},{"line_number":111,"context_line":"      # repos on the right branch for this job. Ansible jobs abd roles taken"},{"line_number":112,"context_line":"      # from devstack should be used on the \u0027grenade_from_branch\u0027 but since the"},{"line_number":113,"context_line":"      # runs against the \u0027grenade_to_branch\u0027 the only way to achieve this is"},{"line_number":114,"context_line":"      # to do a project specific override-checkout on devstack"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"bf659307_f770ecde","line":111,"range":{"start_line":111,"start_character":61,"end_line":111,"end_character":64},"updated":"2018-03-28 12:10:45.000000000","message":"nit: and","commit_id":"65ae07cedb4bf5e18b76cf5307cd2dd404e0bcf7"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"2046cd47f1c935bc73510f7ea32f71da043aa3bf","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    required-projects:"},{"line_number":110,"context_line":"      # NOTE(andreaf) The devstack and grenade roles take care of setting up"},{"line_number":111,"context_line":"      # repos on the right branch for this job. Ansible jobs abd roles taken"},{"line_number":112,"context_line":"      # from devstack should be used on the \u0027grenade_from_branch\u0027 but since the"},{"line_number":113,"context_line":"      # runs against the \u0027grenade_to_branch\u0027 the only way to achieve this is"},{"line_number":114,"context_line":"      # to do a project specific override-checkout on devstack"},{"line_number":115,"context_line":"      - name: openstack-dev/devstack"},{"line_number":116,"context_line":"      # NOTE(andreaf) For now use master, until we have patches backported"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"bf659307_d73b68e8","line":113,"range":{"start_line":112,"start_character":22,"end_line":113,"end_character":75},"updated":"2018-03-28 12:10:45.000000000","message":"there is something weird on the phrasing here","commit_id":"65ae07cedb4bf5e18b76cf5307cd2dd404e0bcf7"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"f9b13b56b6eb05e03018f2b80f87133d5f941a68","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    check:"},{"line_number":27,"context_line":"      jobs:"},{"line_number":28,"context_line":"        - grenade"},{"line_number":29,"context_line":"        # Skip other jobs while testing"},{"line_number":30,"context_line":"        # - neutron-grenade:"},{"line_number":31,"context_line":"        #     irrelevant-files: *grenade-irrelevant-files"},{"line_number":32,"context_line":"        # - grenade-heat:"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"9fdfeff1_c84eef6d","line":29,"updated":"2019-02-15 22:22:18.000000000","message":"How does it do with these now?  Or is it too soon?","commit_id":"ca0ed0ab30b0045efffe4be2cc97b5a7b46a4d30"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"66628d9d9d00375bc5c9271dd650b0d3ad934f63","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    check:"},{"line_number":27,"context_line":"      jobs:"},{"line_number":28,"context_line":"        - grenade"},{"line_number":29,"context_line":"        # Skip other jobs while testing"},{"line_number":30,"context_line":"        # - neutron-grenade:"},{"line_number":31,"context_line":"        #     irrelevant-files: *grenade-irrelevant-files"},{"line_number":32,"context_line":"        # - grenade-heat:"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"9fdfeff1_484c3f41","line":29,"in_reply_to":"9fdfeff1_c84eef6d","updated":"2019-02-15 22:31:54.000000000","message":"When the job is stable, I will re-enable all non-grenade jobs and replace the existing jobs with native grenade jobs.\n\nI still need to fix the logging (the logs of the target deployment are not saved), understand why the upgrade of swift fails (a function provided by devstack is not found) and test it with the plugins.\n\nBut any comment on the current status of this patch and the other new patch is more than welcome, so that I know that I don\u0027t need to rewrite everything.","commit_id":"ca0ed0ab30b0045efffe4be2cc97b5a7b46a4d30"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b7322e30aaf917fd232a6dab93da3af14d846465","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      This is the base grenade job for both single and multi node grenade"},{"line_number":45,"context_line":"      tests. It does not define any service to be used, so that this can"},{"line_number":46,"context_line":"      be used to build an upgrade test with a minimal number of services."},{"line_number":47,"context_line":"    nodeset: openstack-single-node"},{"line_number":48,"context_line":"    required-projects:"},{"line_number":49,"context_line":"      - openstack-dev/devstack"},{"line_number":50,"context_line":"      - openstack/tempest"}],"source_content_type":"text/x-yaml","patch_set":94,"id":"5fc1f717_9c93c85c","line":47,"range":{"start_line":47,"start_character":13,"end_line":47,"end_character":34},"updated":"2019-04-04 16:36:55.000000000","message":"we should use bionic nodeset now - openstack-single-node-bionic","commit_id":"93eb5c07402967b3cff44d2ab1b90173030c4f85"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"f89aa460aa974d759e9049654ce1c17e3999a886","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- project:"},{"line_number":2,"context_line":"    check:"},{"line_number":3,"context_line":"      jobs:"},{"line_number":4,"context_line":"        - grenade:"},{"line_number":5,"context_line":"            irrelevant-files: \u0026grenade-irrelevant-files"},{"line_number":6,"context_line":"              - ^.*\\.rst$"},{"line_number":7,"context_line":"              - ^doc/.*$"},{"line_number":8,"context_line":"        - grenade-heat:"},{"line_number":9,"context_line":"            voting: false"},{"line_number":10,"context_line":"            irrelevant-files: *grenade-irrelevant-files"},{"line_number":11,"context_line":"        - grenade-py3"},{"line_number":12,"context_line":"        - neutron-grenade-multinode:"},{"line_number":13,"context_line":"            irrelevant-files: *grenade-irrelevant-files"},{"line_number":14,"context_line":"        - tox-docs"},{"line_number":15,"context_line":"        - ironic-grenade-dsvm:"},{"line_number":16,"context_line":"            voting: false"},{"line_number":17,"context_line":"            irrelevant-files: *grenade-irrelevant-files"},{"line_number":18,"context_line":"    gate:"},{"line_number":19,"context_line":"      jobs:"},{"line_number":20,"context_line":"        - grenade-py3"},{"line_number":21,"context_line":"        - neutron-grenade:"},{"line_number":22,"context_line":"            irrelevant-files: *grenade-irrelevant-files"},{"line_number":23,"context_line":"        - neutron-grenade-multinode:"},{"line_number":24,"context_line":"            irrelevant-files: *grenade-irrelevant-files"},{"line_number":25,"context_line":"        - tox-docs"},{"line_number":26,"context_line":"    post:"},{"line_number":27,"context_line":"      jobs:"},{"line_number":28,"context_line":"        - publish-openstack-tox-docs"},{"line_number":29,"context_line":"    experimental:"},{"line_number":30,"context_line":"      jobs:"},{"line_number":31,"context_line":"        - grenade-postgresql"},{"line_number":32,"context_line":"        - legacy-grenade-dsvm-neutron-forward:"},{"line_number":33,"context_line":"            irrelevant-files: *grenade-irrelevant-files"},{"line_number":34,"context_line":"        - trove-grenade:"},{"line_number":35,"context_line":"            irrelevant-files: *grenade-irrelevant-files"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- job:"},{"line_number":38,"context_line":"    name: grenade-base"},{"line_number":39,"context_line":"    parent: multinode"}],"source_content_type":"text/x-yaml","patch_set":98,"id":"1fcbff3d_8eaa1b17","line":36,"range":{"start_line":1,"start_character":2,"end_line":36,"end_character":0},"updated":"2019-04-20 13:16:03.000000000","message":"Job grenade not defined","commit_id":"f752fc75d362d1db4601378a6e04b7131e623fba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"f89aa460aa974d759e9049654ce1c17e3999a886","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        - trove-grenade:"},{"line_number":35,"context_line":"            irrelevant-files: *grenade-irrelevant-files"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- job:"},{"line_number":38,"context_line":"    name: grenade-base"},{"line_number":39,"context_line":"    parent: multinode"},{"line_number":40,"context_line":"    abstract: true"},{"line_number":41,"context_line":"    description: |"},{"line_number":42,"context_line":"      Base grenade job"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"      This is the base grenade job for both single and multi node grenade"},{"line_number":45,"context_line":"      tests. It does not define any service to be used, so that this can"},{"line_number":46,"context_line":"      be used to build an upgrade test with a minimal number of services."},{"line_number":47,"context_line":"    nodeset: openstack-single-node-bionic"},{"line_number":48,"context_line":"    required-projects:"},{"line_number":49,"context_line":"      - openstack-dev/devstack"},{"line_number":50,"context_line":"      - openstack/tempest"},{"line_number":51,"context_line":"    roles:"},{"line_number":52,"context_line":"      - zuul: openstack-infra/openstack-zuul-jobs"},{"line_number":53,"context_line":"      - zuul: openstack-dev/devstack"},{"line_number":54,"context_line":"      - zuul: openstack/tempest"},{"line_number":55,"context_line":"    vars:"},{"line_number":56,"context_line":"      devstack_bases:"},{"line_number":57,"context_line":"        shared: /opt/stack"},{"line_number":58,"context_line":"        old: /opt/stack/old"},{"line_number":59,"context_line":"        new: /opt/stack/new"},{"line_number":60,"context_line":"        logs_old: /opt/stack/logs/old"},{"line_number":61,"context_line":"        logs_new: /opt/stack/logs/new"},{"line_number":62,"context_line":"      grenade_devstack_localrc: \u0026grenade_base_devstack_localrc"},{"line_number":63,"context_line":"        old:"},{"line_number":64,"context_line":"          DEST: \"{{ devstack_bases.old }}\""},{"line_number":65,"context_line":"          LOGFILE: \"{{ devstack_bases.old }}/logs/devstacklog.txt\""},{"line_number":66,"context_line":"        new:"},{"line_number":67,"context_line":"          DEST: \"{{ devstack_bases.new }}\""},{"line_number":68,"context_line":"          LOGFILE: \"{{ devstack_bases.new }}/logs/devstacklog.txt\""},{"line_number":69,"context_line":"        shared:"},{"line_number":70,"context_line":"          # Common settings for OpenStack CI"},{"line_number":71,"context_line":"          DATABASE_PASSWORD: secretdatabase"},{"line_number":72,"context_line":"          # FIXME: temporarily define MYSQL_PASSWORD too,"},{"line_number":73,"context_line":"          # because some code in devstack and in grenade"},{"line_number":74,"context_line":"          # still requires it to be defined."},{"line_number":75,"context_line":"          MYSQL_PASSWORD: secretdatabase"},{"line_number":76,"context_line":"          RABBIT_PASSWORD: secretrabbit"},{"line_number":77,"context_line":"          ADMIN_PASSWORD: secretadmin"},{"line_number":78,"context_line":"          SERVICE_PASSWORD: secretservice"},{"line_number":79,"context_line":"          NETWORK_GATEWAY: 10.1.0.1"},{"line_number":80,"context_line":"          FIXED_RANGE: 10.1.0.0/20"},{"line_number":81,"context_line":"          IPV4_ADDRS_SAFE_TO_USE: 10.1.0.0/20"},{"line_number":82,"context_line":"          FLOATING_RANGE: 172.24.5.0/24"},{"line_number":83,"context_line":"          PUBLIC_NETWORK_GATEWAY: 172.24.5.1"},{"line_number":84,"context_line":"          FIXED_NETWORK_SIZE: 4096"},{"line_number":85,"context_line":"          LOG_COLOR: false"},{"line_number":86,"context_line":"          VERBOSE: true"},{"line_number":87,"context_line":"          VERBOSE_NO_TIMESTAMP: true"},{"line_number":88,"context_line":"          NOVNC_FROM_PACKAGE: true"},{"line_number":89,"context_line":"          ERROR_ON_CLONE: true"},{"line_number":90,"context_line":"          # Gate jobs can\u0027t deal with nested virt. Disable it."},{"line_number":91,"context_line":"          LIBVIRT_TYPE: qemu"},{"line_number":92,"context_line":"      # grenade_from_branch is branch specific, it\u0027s the change branch \"-1\"."},{"line_number":93,"context_line":"      # This has to be updated on master when cutting a new stable branch."},{"line_number":94,"context_line":"      # grenade_to_branch is always the current patch on pullup jobs."},{"line_number":95,"context_line":"      grenade_from_branch: stable/rocky"},{"line_number":96,"context_line":"      grenade_localrc:"},{"line_number":97,"context_line":"        SAVE_DIR: \"{{ devstack_bases.shared }}/save\""},{"line_number":98,"context_line":"      # from tempest playbooks"},{"line_number":99,"context_line":"      devstack_local_conf:"},{"line_number":100,"context_line":"        test-config:"},{"line_number":101,"context_line":"          $TEMPEST_CONFIG:"},{"line_number":102,"context_line":"            compute:"},{"line_number":103,"context_line":"              min_compute_nodes: \"{{ groups[\u0027compute\u0027] | default([\u0027controller\u0027]) | length }}\""},{"line_number":104,"context_line":"      test_results_stage_name: test_results"},{"line_number":105,"context_line":"      zuul_copy_output:"},{"line_number":106,"context_line":"        \u0027{{ devstack_bases.logs_old }}\u0027: logs"},{"line_number":107,"context_line":"        \u0027{{ devstack_bases.logs_new }}\u0027: logs"},{"line_number":108,"context_line":"        \u0027{{ grenade_save_dir }}\u0027: logs"},{"line_number":109,"context_line":"        \u0027{{ grenade_log_dir }}/grenade.sh.log\u0027: logs"},{"line_number":110,"context_line":"        \u0027{{ grenade_log_dir }}/grenade.sh.log.summary\u0027: logs"},{"line_number":111,"context_line":"        \u0027{{ grenade_conf_dir }}/grenade_localrc\u0027: logs_txt"},{"line_number":112,"context_line":"        \u0027{{ grenade_conf_dir }}/grenade_pluginrc\u0027: logs_txt"},{"line_number":113,"context_line":"        \u0027{{ devstack_bases.new }}/tempest/etc/tempest.conf\u0027: logs"},{"line_number":114,"context_line":"        \u0027{{ devstack_bases.new }}/tempest/etc/accounts.yaml\u0027: logs"},{"line_number":115,"context_line":"        \u0027{{ devstack_bases.new }}/tempest/tempest.log\u0027: logs"},{"line_number":116,"context_line":"        \u0027{{ stage_dir }}/{{ test_results_stage_name }}.subunit\u0027: logs"},{"line_number":117,"context_line":"        \u0027{{ stage_dir }}/{{ test_results_stage_name }}.html\u0027: logs"},{"line_number":118,"context_line":"        \u0027{{ stage_dir }}/stackviz\u0027: logs"},{"line_number":119,"context_line":"        \u0027{{ stage_dir }}/apache\u0027: logs"},{"line_number":120,"context_line":"        \u0027{{ stage_dir }}/apache_config\u0027: logs"},{"line_number":121,"context_line":"        \u0027{{ stage_dir }}/etc\u0027: logs"},{"line_number":122,"context_line":"        \u0027/var/log/rabbitmq\u0027: logs"},{"line_number":123,"context_line":"        \u0027/var/log/postgresql\u0027: logs"},{"line_number":124,"context_line":"        \u0027/var/log/mysql.err\u0027: logs"},{"line_number":125,"context_line":"        \u0027/var/log/mysql.log\u0027: logs"},{"line_number":126,"context_line":"        \u0027/var/log/libvirt\u0027: logs"},{"line_number":127,"context_line":"        \u0027/etc/sudoers\u0027: logs"},{"line_number":128,"context_line":"        \u0027/etc/sudoers.d\u0027: logs"},{"line_number":129,"context_line":"        \u0027{{ stage_dir }}/iptables.txt\u0027: logs"},{"line_number":130,"context_line":"        \u0027{{ stage_dir }}/df.txt\u0027: logs"},{"line_number":131,"context_line":"        \u0027{{ stage_dir }}/pip2-freeze.txt\u0027: logs"},{"line_number":132,"context_line":"        \u0027{{ stage_dir }}/pip3-freeze.txt\u0027: logs"},{"line_number":133,"context_line":"        \u0027{{ stage_dir }}/dpkg-l.txt\u0027: logs"},{"line_number":134,"context_line":"        \u0027{{ stage_dir }}/rpm-qa.txt\u0027: logs"},{"line_number":135,"context_line":"        \u0027{{ stage_dir }}/core\u0027: logs"},{"line_number":136,"context_line":"        \u0027{{ stage_dir }}/listen53.txt\u0027: logs"},{"line_number":137,"context_line":"        \u0027{{ stage_dir }}/deprecations.log\u0027: logs"},{"line_number":138,"context_line":"        \u0027/var/log/ceph\u0027: logs"},{"line_number":139,"context_line":"        \u0027/var/log/openvswitch\u0027: logs"},{"line_number":140,"context_line":"        \u0027/var/log/glusterfs\u0027: logs"},{"line_number":141,"context_line":"        \u0027/etc/glusterfs/glusterd.vol\u0027: logs"},{"line_number":142,"context_line":"        \u0027/etc/resolv.conf\u0027: logs"},{"line_number":143,"context_line":"        \u0027/var/log/unbound.log\u0027: logs"},{"line_number":144,"context_line":"      extensions_to_txt:"},{"line_number":145,"context_line":"        auto: True"},{"line_number":146,"context_line":"        conf: True"},{"line_number":147,"context_line":"        log: True"},{"line_number":148,"context_line":"        localrc: True"},{"line_number":149,"context_line":"        stackenv: True"},{"line_number":150,"context_line":"        summary: True"},{"line_number":151,"context_line":"    group-vars:"},{"line_number":152,"context_line":"      subnode:"},{"line_number":153,"context_line":"        grenade_devstack_localrc:"},{"line_number":154,"context_line":"          \u003c\u003c: *grenade_base_devstack_localrc"},{"line_number":155,"context_line":"    pre-run: playbooks/pre.yaml"},{"line_number":156,"context_line":"    run: playbooks/grenade.yaml"},{"line_number":157,"context_line":"    post-run: playbooks/post.yaml"},{"line_number":158,"context_line":"    irrelevant-files:"},{"line_number":159,"context_line":"      # Documentation related"},{"line_number":160,"context_line":"      - ^.*\\.rst$"},{"line_number":161,"context_line":"      - ^api-ref/.*$"},{"line_number":162,"context_line":"      - ^doc/.*$"},{"line_number":163,"context_line":"      - ^releasenotes/.*$"},{"line_number":164,"context_line":"      # Translations"},{"line_number":165,"context_line":"      - ^.*/locale/.*po$"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"- job:"},{"line_number":168,"context_line":"    name: grenade"},{"line_number":169,"context_line":"    parent: grenade-base"}],"source_content_type":"text/x-yaml","patch_set":98,"id":"1fcbff3d_0eb70b89","line":166,"range":{"start_line":37,"start_character":2,"end_line":166,"end_character":0},"updated":"2019-04-20 13:16:03.000000000","message":"Unknown project openstack-dev/devstack","commit_id":"f752fc75d362d1db4601378a6e04b7131e623fba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"f89aa460aa974d759e9049654ce1c17e3999a886","unresolved":false,"context_lines":[{"line_number":164,"context_line":"      # Translations"},{"line_number":165,"context_line":"      - ^.*/locale/.*po$"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"- job:"},{"line_number":168,"context_line":"    name: grenade"},{"line_number":169,"context_line":"    parent: grenade-base"},{"line_number":170,"context_line":"    description: |"},{"line_number":171,"context_line":"      Default grenade job"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"      Usually grenade jobs should inherit from this job."},{"line_number":174,"context_line":"    required-projects:"},{"line_number":175,"context_line":"      # NOTE(andreaf) The devstack and grenade roles take care of setting up"},{"line_number":176,"context_line":"      # repos on the right branch for this job."},{"line_number":177,"context_line":"      - openstack-dev/devstack"},{"line_number":178,"context_line":"      - openstack/cinder"},{"line_number":179,"context_line":"      - openstack/glance"},{"line_number":180,"context_line":"      - openstack/keystone"},{"line_number":181,"context_line":"      - openstack/neutron"},{"line_number":182,"context_line":"      - openstack/nova"},{"line_number":183,"context_line":"      - openstack/placement"},{"line_number":184,"context_line":"      - openstack/requirements"},{"line_number":185,"context_line":"      - openstack/swift"},{"line_number":186,"context_line":"      - openstack/tempest"},{"line_number":187,"context_line":"    timeout: 7200"},{"line_number":188,"context_line":"    vars:"},{"line_number":189,"context_line":"      grenade_devstack_localrc:"},{"line_number":190,"context_line":"        shared:"},{"line_number":191,"context_line":"          # Common OpenStack services settings"},{"line_number":192,"context_line":"          SWIFT_REPLICAS: 1"},{"line_number":193,"context_line":"          SWIFT_START_ALL_SERVICES: false"},{"line_number":194,"context_line":"          SWIFT_HASH: 1234123412341234"},{"line_number":195,"context_line":"          CINDER_PERIODIC_INTERVAL: 10"},{"line_number":196,"context_line":"          DEBUG_LIBVIRT_COREDUMPS: True"},{"line_number":197,"context_line":"          # Multinode specific settings"},{"line_number":198,"context_line":"          SERVICE_HOST: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}\""},{"line_number":199,"context_line":"          HOST_IP: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}\""},{"line_number":200,"context_line":"          PUBLIC_BRIDGE_MTU: \"{{ external_bridge_mtu }}\""},{"line_number":201,"context_line":"          CELLSV2_SETUP: \"singleconductor\""},{"line_number":202,"context_line":"          # Node specific settings"},{"line_number":203,"context_line":"          DATABASE_TYPE: mysql"},{"line_number":204,"context_line":"      devstack_localconf:"},{"line_number":205,"context_line":"        post-config:"},{"line_number":206,"context_line":"          $NEUTRON_CONF:"},{"line_number":207,"context_line":"            DEFAULT:"},{"line_number":208,"context_line":"              global_physnet_mtu: \"{{ external_bridge_mtu }}\""},{"line_number":209,"context_line":"      grenade_localrc:"},{"line_number":210,"context_line":"        # disable the execution of the smoke tests by default"},{"line_number":211,"context_line":"        RUN_SMOKE: False"},{"line_number":212,"context_line":"      devstack_services:"},{"line_number":213,"context_line":"        # Core services enabled for this branch."},{"line_number":214,"context_line":"        # This list replaces the test-matrix."},{"line_number":215,"context_line":"        # Shared services"},{"line_number":216,"context_line":"        dstat: true"},{"line_number":217,"context_line":"        etcd3: true"},{"line_number":218,"context_line":"        mysql: true"},{"line_number":219,"context_line":"        peakmem_tracker: true"},{"line_number":220,"context_line":"        rabbit: true"},{"line_number":221,"context_line":"        # TODO: tls-proxy is not tested by legacy jobs;"},{"line_number":222,"context_line":"        # enable this after testing."},{"line_number":223,"context_line":"        tls-proxy: false"},{"line_number":224,"context_line":"        # Keystone services"},{"line_number":225,"context_line":"        key: true"},{"line_number":226,"context_line":"        # Glance services"},{"line_number":227,"context_line":"        g-api: true"},{"line_number":228,"context_line":"        g-reg: true"},{"line_number":229,"context_line":"        # Nova services"},{"line_number":230,"context_line":"        n-api: true"},{"line_number":231,"context_line":"        n-api-meta: true"},{"line_number":232,"context_line":"        n-cauth: true"},{"line_number":233,"context_line":"        n-cond: true"},{"line_number":234,"context_line":"        n-cpu: true"},{"line_number":235,"context_line":"        n-novnc: true"},{"line_number":236,"context_line":"        n-obj: true"},{"line_number":237,"context_line":"        n-sch: true"},{"line_number":238,"context_line":"        placement-api: true"},{"line_number":239,"context_line":"        # Neutron services"},{"line_number":240,"context_line":"        # We need to keep using the neutron-legacy based services for"},{"line_number":241,"context_line":"        # now until all issues with the new lib/neutron code are solved"},{"line_number":242,"context_line":"        q-agt: true"},{"line_number":243,"context_line":"        q-dhcp: true"},{"line_number":244,"context_line":"        q-l3: true"},{"line_number":245,"context_line":"        q-meta: true"},{"line_number":246,"context_line":"        q-metering: true"},{"line_number":247,"context_line":"        q-svc: true"},{"line_number":248,"context_line":"        # neutron-api: true"},{"line_number":249,"context_line":"        # neutron-agent: true"},{"line_number":250,"context_line":"        # neutron-dhcp: true"},{"line_number":251,"context_line":"        # neutron-l3: true"},{"line_number":252,"context_line":"        # neutron-metadata-agent: true"},{"line_number":253,"context_line":"        # neutron-metering: true"},{"line_number":254,"context_line":"        # Swift services"},{"line_number":255,"context_line":"        s-account: true"},{"line_number":256,"context_line":"        s-container: true"},{"line_number":257,"context_line":"        s-object: true"},{"line_number":258,"context_line":"        s-proxy: true"},{"line_number":259,"context_line":"        # Cinder services"},{"line_number":260,"context_line":"        c-api: true"},{"line_number":261,"context_line":"        c-bak: true"},{"line_number":262,"context_line":"        c-sch: true"},{"line_number":263,"context_line":"        c-vol: true"},{"line_number":264,"context_line":"        cinder: true"},{"line_number":265,"context_line":"        # Tempest was enabled by default even before the native Zuul v3 job"},{"line_number":266,"context_line":"        tempest: true"},{"line_number":267,"context_line":"        # Services we don\u0027t need."},{"line_number":268,"context_line":"        # This section is not really needed, it\u0027s for readability."},{"line_number":269,"context_line":"        horizon: false"},{"line_number":270,"context_line":"        # Test matrix emits ceilometer but ceilometer is not installed in the"},{"line_number":271,"context_line":"        # integrated gate, so specifying the services has not effect."},{"line_number":272,"context_line":"        # ceilometer-*: false"},{"line_number":273,"context_line":"    group-vars:"},{"line_number":274,"context_line":"      subnode:"},{"line_number":275,"context_line":"        devstack_services:"},{"line_number":276,"context_line":"          # Core services enabled for this branch."},{"line_number":277,"context_line":"          # This list replaces the test-matrix."},{"line_number":278,"context_line":"          # Shared services"},{"line_number":279,"context_line":"          dstat: true"},{"line_number":280,"context_line":"          peakmem_tracker: true"},{"line_number":281,"context_line":"          # TODO: tls-proxy is not tested by legacy jobs;"},{"line_number":282,"context_line":"          # enable this after testing."},{"line_number":283,"context_line":"          tls-proxy: false"},{"line_number":284,"context_line":"          # Nova services"},{"line_number":285,"context_line":"          n-cpu: true"},{"line_number":286,"context_line":"          placement-client: true"},{"line_number":287,"context_line":"          # Neutron services"},{"line_number":288,"context_line":"          neutron-agent: true"},{"line_number":289,"context_line":"          # Cinder services"},{"line_number":290,"context_line":"          c-bak: true"},{"line_number":291,"context_line":"          c-vol: true"},{"line_number":292,"context_line":"          # Services we don\u0027t run at all on subnode."},{"line_number":293,"context_line":"          # This section is not really needed, it\u0027s for readability."},{"line_number":294,"context_line":"          # keystone: false"},{"line_number":295,"context_line":"          # s-*: false"},{"line_number":296,"context_line":"          horizon: false"},{"line_number":297,"context_line":"          tempest: false"},{"line_number":298,"context_line":"          # Test matrix emits ceilometer but ceilomenter is not installed in the"},{"line_number":299,"context_line":"          # integrated gate, so specifying the services has not effect."},{"line_number":300,"context_line":"          # ceilometer-*: false"},{"line_number":301,"context_line":"        grenade_devstack_localrc:"},{"line_number":302,"context_line":"          shared:"},{"line_number":303,"context_line":"            # Multinode specific settings"},{"line_number":304,"context_line":"            HOST_IP: \"{{ hostvars[inventory_hostname][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}\""},{"line_number":305,"context_line":"            SERVICE_HOST: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}\""},{"line_number":306,"context_line":"            PUBLIC_BRIDGE_MTU: \"{{ external_bridge_mtu }}\""},{"line_number":307,"context_line":"            CELLSV2_SETUP: \"singleconductor\""},{"line_number":308,"context_line":"            # Subnode specific settings"},{"line_number":309,"context_line":"            DATABASE_TYPE: mysql"},{"line_number":310,"context_line":"            GLANCE_HOSTPORT: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}:9292\""},{"line_number":311,"context_line":"            Q_HOST: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}\""},{"line_number":312,"context_line":"            RABBIT_HOST: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}\""},{"line_number":313,"context_line":"            DATABASE_HOST: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}\""},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"- job:"},{"line_number":316,"context_line":"    name: grenade-py3"},{"line_number":317,"context_line":"    parent: grenade"}],"source_content_type":"text/x-yaml","patch_set":98,"id":"1fcbff3d_2ebc4768","line":314,"range":{"start_line":167,"start_character":2,"end_line":314,"end_character":0},"updated":"2019-04-20 13:16:03.000000000","message":"Unknown project openstack-dev/devstack","commit_id":"f752fc75d362d1db4601378a6e04b7131e623fba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"f89aa460aa974d759e9049654ce1c17e3999a886","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            RABBIT_HOST: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}\""},{"line_number":313,"context_line":"            DATABASE_HOST: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}\""},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"- job:"},{"line_number":316,"context_line":"    name: grenade-py3"},{"line_number":317,"context_line":"    parent: grenade"},{"line_number":318,"context_line":"    description: |"},{"line_number":319,"context_line":"      Default grenade job which uses Python 3"},{"line_number":320,"context_line":"    vars:"},{"line_number":321,"context_line":"      grenade_devstack_localrc:"},{"line_number":322,"context_line":"        shared:"},{"line_number":323,"context_line":"          USE_PYTHON3: true"},{"line_number":324,"context_line":"    irrelevant-files: *grenade-irrelevant-files"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"- job:"},{"line_number":327,"context_line":"    name: grenade-postgresql"},{"line_number":328,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":98,"id":"1fcbff3d_eeaddf31","line":325,"range":{"start_line":315,"start_character":2,"end_line":325,"end_character":0},"updated":"2019-04-20 13:16:03.000000000","message":"Job grenade not defined","commit_id":"f752fc75d362d1db4601378a6e04b7131e623fba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"f89aa460aa974d759e9049654ce1c17e3999a886","unresolved":false,"context_lines":[{"line_number":323,"context_line":"          USE_PYTHON3: true"},{"line_number":324,"context_line":"    irrelevant-files: *grenade-irrelevant-files"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"- job:"},{"line_number":327,"context_line":"    name: grenade-postgresql"},{"line_number":328,"context_line":"    description: |"},{"line_number":329,"context_line":"      Default grenade job which uses PostgreSQL"},{"line_number":330,"context_line":"    parent: grenade"},{"line_number":331,"context_line":"    vars:"},{"line_number":332,"context_line":"      grenade_devstack_localrc:"},{"line_number":333,"context_line":"        shared:"},{"line_number":334,"context_line":"          DATABASE_TYPE: postgresql"},{"line_number":335,"context_line":"      devstack_services:"},{"line_number":336,"context_line":"        mysql: false"},{"line_number":337,"context_line":"        postgresql: true"},{"line_number":338,"context_line":"    group-vars:"},{"line_number":339,"context_line":"      subnode:"},{"line_number":340,"context_line":"        devstack_services:"},{"line_number":341,"context_line":"        grenade_devstack_localrc:"},{"line_number":342,"context_line":"          shared:"},{"line_number":343,"context_line":"            DATABASE_TYPE: postgresql"},{"line_number":344,"context_line":"    irrelevant-files: *grenade-irrelevant-files"}],"source_content_type":"text/x-yaml","patch_set":98,"id":"1fcbff3d_ceb0238f","line":344,"range":{"start_line":326,"start_character":2,"end_line":344,"end_character":0},"updated":"2019-04-20 13:16:03.000000000","message":"Job grenade not defined","commit_id":"f752fc75d362d1db4601378a6e04b7131e623fba"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"213a9da766f9cea5bfeb7801f22295c6ba9aa09e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        logs_old: /opt/stack/logs/old"},{"line_number":61,"context_line":"        logs_new: /opt/stack/logs/new"},{"line_number":62,"context_line":"      grenade_devstack_localrc: \u0026grenade_base_devstack_localrc"},{"line_number":63,"context_line":"        old:"},{"line_number":64,"context_line":"          DEST: \"{{ devstack_bases.old }}\""},{"line_number":65,"context_line":"          LOGFILE: \"{{ devstack_bases.old }}/logs/devstacklog.txt\""},{"line_number":66,"context_line":"        new:"},{"line_number":67,"context_line":"          DEST: \"{{ devstack_bases.new }}\""},{"line_number":68,"context_line":"          LOGFILE: \"{{ devstack_bases.new }}/logs/devstacklog.txt\""},{"line_number":69,"context_line":"        shared:"},{"line_number":70,"context_line":"          # Common settings for OpenStack CI"},{"line_number":71,"context_line":"          DATABASE_PASSWORD: secretdatabase"},{"line_number":72,"context_line":"          # FIXME: temporarily define MYSQL_PASSWORD too,"}],"source_content_type":"text/x-yaml","patch_set":102,"id":"5faad753_2c1cc576","line":69,"range":{"start_line":63,"start_character":5,"end_line":69,"end_character":15},"updated":"2019-09-12 23:22:30.000000000","message":"so wheile there appears to be a way to have\nnew old and shared  groups for localrc generation\n\ni  dont see the same for\ndevstack_local_conf\n\nso if i need to set different post-config setting\ni cant do this\n\n    devstack_local_conf:\n      old:\n        post-config:\n          $NOVA_CONF:\n            DEFAULT:\n              vcpu_pin_set: 1-7\n            compute:\n              cpu_shared_set: 0\n      new:\n        post-config:\n          $NOVA_CONF:\n            compute:\n              cpu_dedicated_set: 1-7\n              cpu_shared_set: 0\n\n\nwhich means i cant test the placment reshap that is triggered\nwhen you upgrade to train and set cpu_dedicated_set\n\nvcpu_pin_set and cpu_dedicated set can be set at the same time. so i cant just set all 3 value either.","commit_id":"e9f7d252c001317509859c1735c3216d8a578f85"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8175cfa507aede314c041d7a36a8f254d60c9a6b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      # grenade_from_branch is branch specific, it\u0027s the change branch \"-1\"."},{"line_number":90,"context_line":"      # This has to be updated on master when cutting a new stable branch."},{"line_number":91,"context_line":"      # grenade_to_branch is always the current patch on pullup jobs."},{"line_number":92,"context_line":"      grenade_from_branch: stable/rocky"},{"line_number":93,"context_line":"      grenade_localrc:"},{"line_number":94,"context_line":"        SAVE_DIR: \"{{ devstack_bases.shared }}/save\""},{"line_number":95,"context_line":"      # from tempest playbooks"}],"source_content_type":"text/x-yaml","patch_set":103,"id":"3fa7e38b_e373851b","line":92,"range":{"start_line":92,"start_character":34,"end_line":92,"end_character":39},"updated":"2019-12-17 19:26:05.000000000","message":"OOPS","commit_id":"24c01ca65ef85c2222961dd3bf23b190b71c177e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"70eb4db0d86ef43f679ea9ebf6bfdc31b26c80d1","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        \u0027{{ stage_dir }}/etc\u0027: logs"},{"line_number":118,"context_line":"        \u0027/var/log/rabbitmq\u0027: logs"},{"line_number":119,"context_line":"        \u0027/var/log/postgresql\u0027: logs"},{"line_number":120,"context_line":"        \u0027/var/log/mysql.err\u0027: logs"},{"line_number":121,"context_line":"        \u0027/var/log/mysql.log\u0027: logs"},{"line_number":122,"context_line":"        \u0027/var/log/libvirt\u0027: logs"},{"line_number":123,"context_line":"        \u0027/etc/sudoers\u0027: logs"},{"line_number":124,"context_line":"        \u0027/etc/sudoers.d\u0027: logs"}],"source_content_type":"text/x-yaml","patch_set":106,"id":"3fa7e38b_87e63649","line":121,"range":{"start_line":120,"start_character":8,"end_line":121,"end_character":34},"updated":"2020-01-16 21:54:25.000000000","message":"I noticed the mysql logs aren\u0027t being collected when the \u0027grenade\u0027 job runs. I think this might need to be:\n\n /var/log/mysql: logs\n\ninstead based on this previous fix to devstack I found:\n\nhttps://review.opendev.org/678053","commit_id":"9c54407533a8cb633d8868b877e76730a54aa900"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"370bc3bc3594daa6f6b8c5daed2b8436ebc04333","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        \u0027{{ stage_dir }}/etc\u0027: logs"},{"line_number":118,"context_line":"        \u0027/var/log/rabbitmq\u0027: logs"},{"line_number":119,"context_line":"        \u0027/var/log/postgresql\u0027: logs"},{"line_number":120,"context_line":"        \u0027/var/log/mysql.err\u0027: logs"},{"line_number":121,"context_line":"        \u0027/var/log/mysql.log\u0027: logs"},{"line_number":122,"context_line":"        \u0027/var/log/libvirt\u0027: logs"},{"line_number":123,"context_line":"        \u0027/etc/sudoers\u0027: logs"},{"line_number":124,"context_line":"        \u0027/etc/sudoers.d\u0027: logs"}],"source_content_type":"text/x-yaml","patch_set":106,"id":"3fa7e38b_ad16b3a0","line":121,"range":{"start_line":120,"start_character":8,"end_line":121,"end_character":34},"in_reply_to":"3fa7e38b_87e63649","updated":"2020-01-17 01:41:40.000000000","message":"\u003e I noticed the mysql logs aren\u0027t being collected when the \u0027grenade\u0027\n \u003e job runs. I think this might need to be:\n \u003e \n \u003e /var/log/mysql: logs\n \u003e \n \u003e instead based on this previous fix to devstack I found:\n \u003e \n \u003e https://review.opendev.org/678053\n\nConfirmed that this works in the following nova change:\n\nhttps://review.opendev.org/701478\n\ngrenade job mysql log:\n\nhttps://6b10b0f40e67382c5796-d6fc217f0fd2640215baf33e187168fc.ssl.cf5.rackcdn.com/701478/4/check/grenade/118a70f/controller/logs/mysql/error_log.txt","commit_id":"9c54407533a8cb633d8868b877e76730a54aa900"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"38609e4d9e38f01675b3e1bd2a770ed328ef132f","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        \u0027{{ stage_dir }}/etc\u0027: logs"},{"line_number":118,"context_line":"        \u0027/var/log/rabbitmq\u0027: logs"},{"line_number":119,"context_line":"        \u0027/var/log/postgresql\u0027: logs"},{"line_number":120,"context_line":"        \u0027/var/log/mysql.err\u0027: logs"},{"line_number":121,"context_line":"        \u0027/var/log/mysql.log\u0027: logs"},{"line_number":122,"context_line":"        \u0027/var/log/libvirt\u0027: logs"},{"line_number":123,"context_line":"        \u0027/etc/sudoers\u0027: logs"},{"line_number":124,"context_line":"        \u0027/etc/sudoers.d\u0027: logs"}],"source_content_type":"text/x-yaml","patch_set":106,"id":"3fa7e38b_aab20e49","line":121,"range":{"start_line":120,"start_character":8,"end_line":121,"end_character":34},"in_reply_to":"3fa7e38b_8fdac419","updated":"2020-01-17 16:58:28.000000000","message":"Right, this code should be changed too (I applied it locally, but I\u0027m waiting to see if I can solve a few other issues). Thanks for that.\n\nJust pointing out that the poor devstack could benefit from a backport.","commit_id":"9c54407533a8cb633d8868b877e76730a54aa900"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"05244f26970d874ebae68d9c6f95d485c3450afe","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        \u0027{{ stage_dir }}/etc\u0027: logs"},{"line_number":118,"context_line":"        \u0027/var/log/rabbitmq\u0027: logs"},{"line_number":119,"context_line":"        \u0027/var/log/postgresql\u0027: logs"},{"line_number":120,"context_line":"        \u0027/var/log/mysql.err\u0027: logs"},{"line_number":121,"context_line":"        \u0027/var/log/mysql.log\u0027: logs"},{"line_number":122,"context_line":"        \u0027/var/log/libvirt\u0027: logs"},{"line_number":123,"context_line":"        \u0027/etc/sudoers\u0027: logs"},{"line_number":124,"context_line":"        \u0027/etc/sudoers.d\u0027: logs"}],"source_content_type":"text/x-yaml","patch_set":106,"id":"3fa7e38b_8fdac419","line":121,"range":{"start_line":120,"start_character":8,"end_line":121,"end_character":34},"in_reply_to":"3fa7e38b_a587a711","updated":"2020-01-17 15:42:43.000000000","message":"Well, you\u0027re adding new code here in this change so a backport wouldn\u0027t help. I\u0027m just telling you that the way you have it now will not collect the mysql logs. You have to use \"/var/log/mysql: logs\".\n\nIn the grenade run on this change there are no mysql logs. On my DNM change above this patch, there are mysql logs.","commit_id":"9c54407533a8cb633d8868b877e76730a54aa900"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"735cb7391b119aea282e002078c4a3c404a576ae","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        \u0027{{ stage_dir }}/etc\u0027: logs"},{"line_number":118,"context_line":"        \u0027/var/log/rabbitmq\u0027: logs"},{"line_number":119,"context_line":"        \u0027/var/log/postgresql\u0027: logs"},{"line_number":120,"context_line":"        \u0027/var/log/mysql.err\u0027: logs"},{"line_number":121,"context_line":"        \u0027/var/log/mysql.log\u0027: logs"},{"line_number":122,"context_line":"        \u0027/var/log/libvirt\u0027: logs"},{"line_number":123,"context_line":"        \u0027/etc/sudoers\u0027: logs"},{"line_number":124,"context_line":"        \u0027/etc/sudoers.d\u0027: logs"}],"source_content_type":"text/x-yaml","patch_set":106,"id":"3fa7e38b_5026a8bb","line":121,"range":{"start_line":120,"start_character":8,"end_line":121,"end_character":34},"in_reply_to":"3fa7e38b_aab20e49","updated":"2020-01-17 17:16:21.000000000","message":"Ah, gotcha, I misunderstood you the first time.\n\nWell, for reasons I don\u0027t understand, the gzip fix only helps for zuul v3 jobs, not legacy jobs:\n\nhttp://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2020-01-17.log.html#t2020-01-17T15:23:07\n\nIf we have zuul v3 jobs back on stable branches, then indeed backports would help out.","commit_id":"9c54407533a8cb633d8868b877e76730a54aa900"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"6a9258109a01918938ae325f4ef5fd66790352d4","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        \u0027{{ stage_dir }}/etc\u0027: logs"},{"line_number":118,"context_line":"        \u0027/var/log/rabbitmq\u0027: logs"},{"line_number":119,"context_line":"        \u0027/var/log/postgresql\u0027: logs"},{"line_number":120,"context_line":"        \u0027/var/log/mysql.err\u0027: logs"},{"line_number":121,"context_line":"        \u0027/var/log/mysql.log\u0027: logs"},{"line_number":122,"context_line":"        \u0027/var/log/libvirt\u0027: logs"},{"line_number":123,"context_line":"        \u0027/etc/sudoers\u0027: logs"},{"line_number":124,"context_line":"        \u0027/etc/sudoers.d\u0027: logs"}],"source_content_type":"text/x-yaml","patch_set":106,"id":"3fa7e38b_a587a711","line":121,"range":{"start_line":120,"start_character":8,"end_line":121,"end_character":34},"in_reply_to":"3fa7e38b_ad16b3a0","updated":"2020-01-17 08:44:21.000000000","message":"Thanks, but shouldn\u0027t https://review.opendev.org/#/c/678053/ be backported to all stable devstack branches?","commit_id":"9c54407533a8cb633d8868b877e76730a54aa900"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"00db6aaf67ad8e5ad56b31254c53a33951e41ca4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    check:"},{"line_number":5,"context_line":"      jobs:"},{"line_number":6,"context_line":"        - grenade:"},{"line_number":7,"context_line":"            irrelevant-files: \u0026grenade-irrelevant-files"},{"line_number":8,"context_line":"              - ^.*\\.rst$"},{"line_number":9,"context_line":"              - ^doc/.*$"},{"line_number":10,"context_line":"        - grenade-heat:"},{"line_number":11,"context_line":"            voting: false"},{"line_number":12,"context_line":"            irrelevant-files: *grenade-irrelevant-files"}],"source_content_type":"text/x-yaml","patch_set":107,"id":"1fa4df85_079b3bc9","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":24},"updated":"2020-02-27 02:19:57.000000000","message":"you do not need these as you are defining irrelevant-files in job definition.","commit_id":"f586cd11731cf763a07694e468a983b45b90bb1b"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"dd33b87dfa1955681fa1be8fa2cf84821cbfe77b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    check:"},{"line_number":5,"context_line":"      jobs:"},{"line_number":6,"context_line":"        - grenade:"},{"line_number":7,"context_line":"            irrelevant-files: \u0026grenade-irrelevant-files"},{"line_number":8,"context_line":"              - ^.*\\.rst$"},{"line_number":9,"context_line":"              - ^doc/.*$"},{"line_number":10,"context_line":"        - grenade-heat:"},{"line_number":11,"context_line":"            voting: false"},{"line_number":12,"context_line":"            irrelevant-files: *grenade-irrelevant-files"}],"source_content_type":"text/x-yaml","patch_set":107,"id":"1fa4df85_8156085c","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":24},"in_reply_to":"1fa4df85_079b3bc9","updated":"2020-03-02 11:45:19.000000000","message":"Chicking and egg: I need them for ironic-grenade-dsvm and the other legacy jobs, or I would need to copy the full content of grenade-irrelevant-files. Maybe that\u0027s the right thing to do.","commit_id":"f586cd11731cf763a07694e468a983b45b90bb1b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"00db6aaf67ad8e5ad56b31254c53a33951e41ca4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      This is the base grenade job for both single and multi node grenade"},{"line_number":40,"context_line":"      tests. It does not define any service to be used, so that this can"},{"line_number":41,"context_line":"      be used to build an upgrade test with a minimal number of services."},{"line_number":42,"context_line":"    nodeset: openstack-single-node-bionic"},{"line_number":43,"context_line":"    required-projects:"},{"line_number":44,"context_line":"      - openstack/devstack"},{"line_number":45,"context_line":"      - openstack/tempest"}],"source_content_type":"text/x-yaml","patch_set":107,"id":"1fa4df85_ce2e9ba4","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":41},"updated":"2020-02-27 02:19:57.000000000","message":"we should not define the nodeset in base job as you are telling this is for both single and multi node. \n\nwe can define it in \u0027grenade\u0027 job at L163.","commit_id":"f586cd11731cf763a07694e468a983b45b90bb1b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0d7fdd60f8df080ce887e1ed8d4591569520d1ea","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        logs_old: /opt/stack/logs/old"},{"line_number":56,"context_line":"        logs_new: /opt/stack/logs/new"},{"line_number":57,"context_line":"      grenade_devstack_localrc: \u0026grenade_base_devstack_localrc"},{"line_number":58,"context_line":"        old:"},{"line_number":59,"context_line":"          DEST: \"{{ devstack_bases.old }}\""},{"line_number":60,"context_line":"          LOGFILE: \"{{ devstack_bases.old }}/logs/devstacklog.txt\""},{"line_number":61,"context_line":"        new:"},{"line_number":62,"context_line":"          DEST: \"{{ devstack_bases.new }}\""},{"line_number":63,"context_line":"          LOGFILE: \"{{ devstack_bases.new }}/logs/devstacklog.txt\""}],"source_content_type":"text/x-yaml","patch_set":107,"id":"3fa7e38b_ec7d6a70","line":60,"range":{"start_line":58,"start_character":0,"end_line":60,"end_character":66},"updated":"2020-02-07 00:50:42.000000000","message":"Tempest is enabled default on devstack so that is installed on old side too. We need to run Tempest on new side only. \n\nSo we can disable this on old side but new side we have to installed it separately as ./stack.sh does not run on new side. \n\nWe are facing issue due to old side installing the Tempest and making Tempest fix if any to be backported in a reverse way. \n\n- http://eavesdrop.openstack.org/irclogs/%23openstack-qa/%23openstack-qa.2020-02-07.log.html#t2020-02-07T00:33:38\n\nWe do not need to do that in this patch but something to remember or add NOTE here in case we forget that.","commit_id":"f586cd11731cf763a07694e468a983b45b90bb1b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"29a1db0fe95bd3e62bc4758d26e247d51c73880c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        logs_old: /opt/stack/logs/old"},{"line_number":56,"context_line":"        logs_new: /opt/stack/logs/new"},{"line_number":57,"context_line":"      grenade_devstack_localrc: \u0026grenade_base_devstack_localrc"},{"line_number":58,"context_line":"        old:"},{"line_number":59,"context_line":"          DEST: \"{{ devstack_bases.old }}\""},{"line_number":60,"context_line":"          LOGFILE: \"{{ devstack_bases.old }}/logs/devstacklog.txt\""},{"line_number":61,"context_line":"        new:"},{"line_number":62,"context_line":"          DEST: \"{{ devstack_bases.new }}\""},{"line_number":63,"context_line":"          LOGFILE: \"{{ devstack_bases.new }}/logs/devstacklog.txt\""}],"source_content_type":"text/x-yaml","patch_set":107,"id":"3fa7e38b_6e196a89","line":60,"range":{"start_line":58,"start_character":0,"end_line":60,"end_character":66},"in_reply_to":"3fa7e38b_b869e8f7","updated":"2020-02-07 13:30:37.000000000","message":"on old node we should not need but it is being used to verify the installation. I did not think about plugins also doing that.\n\nanyways something to think later, we cannot disable it till we find some other way to check the old installation and for plugins too.","commit_id":"f586cd11731cf763a07694e468a983b45b90bb1b"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"f91c205acd7aec085f929d5a943860b78be73ad2","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        logs_old: /opt/stack/logs/old"},{"line_number":56,"context_line":"        logs_new: /opt/stack/logs/new"},{"line_number":57,"context_line":"      grenade_devstack_localrc: \u0026grenade_base_devstack_localrc"},{"line_number":58,"context_line":"        old:"},{"line_number":59,"context_line":"          DEST: \"{{ devstack_bases.old }}\""},{"line_number":60,"context_line":"          LOGFILE: \"{{ devstack_bases.old }}/logs/devstacklog.txt\""},{"line_number":61,"context_line":"        new:"},{"line_number":62,"context_line":"          DEST: \"{{ devstack_bases.new }}\""},{"line_number":63,"context_line":"          LOGFILE: \"{{ devstack_bases.new }}/logs/devstacklog.txt\""}],"source_content_type":"text/x-yaml","patch_set":107,"id":"3fa7e38b_b869e8f7","line":60,"range":{"start_line":58,"start_character":0,"end_line":60,"end_character":66},"in_reply_to":"3fa7e38b_ec7d6a70","updated":"2020-02-07 10:54:23.000000000","message":"grenade runs tempest by default on the old side as well (smoke); this could be disabled, and a few plugin do it, but it is enabled by default.\n(look for \"Running base smoke test\" and the values of RUN_SMOKE/BASE_RUN_SMOKE/TARGET_RUN_SMOKE).\nDo you suggest that we drop the current execution of tempest after the deployment?","commit_id":"f586cd11731cf763a07694e468a983b45b90bb1b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"00db6aaf67ad8e5ad56b31254c53a33951e41ca4","unresolved":false,"context_lines":[{"line_number":85,"context_line":"          ERROR_ON_CLONE: true"},{"line_number":86,"context_line":"          # Gate jobs can\u0027t deal with nested virt. Disable it."},{"line_number":87,"context_line":"          LIBVIRT_TYPE: qemu"},{"line_number":88,"context_line":"      # grenade_from_branch is branch specific, it\u0027s the change branch \"-1\"."},{"line_number":89,"context_line":"      # This has to be updated on master when cutting a new stable branch."},{"line_number":90,"context_line":"      # grenade_to_branch is always the current patch on pullup jobs."},{"line_number":91,"context_line":"      grenade_from_branch: stable/train"},{"line_number":92,"context_line":"      grenade_localrc:"},{"line_number":93,"context_line":"        SAVE_DIR: \"{{ devstack_bases.shared }}/save\""},{"line_number":94,"context_line":"      # from tempest playbooks"}],"source_content_type":"text/x-yaml","patch_set":107,"id":"1fa4df85_0e2833e0","line":91,"range":{"start_line":88,"start_character":0,"end_line":91,"end_character":39},"updated":"2020-02-27 02:19:57.000000000","message":"hard coding here will be difficult for forward testing and when we try to backport this job on stable branch.\n\nJob can take variable to define if it want to do forward testing or pullup and in write-grenade-conf role, we can easily map the from and to branch based on job is doing forward or pullup testing. \nbasically this mapping and we keep updating these mapping on each release cut\n- https://opendev.org/openstack/devstack-gate/src/commit/4985fd75b437e27c5c1e19ada0dd708f123ae0cd/devstack-vm-gate-wrap.sh#L298-L365\n\nditto for grenade_to_branch.","commit_id":"f586cd11731cf763a07694e468a983b45b90bb1b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9948f385120ff1f96769356a4bf787dc049b1003","unresolved":false,"context_lines":[{"line_number":85,"context_line":"          ERROR_ON_CLONE: true"},{"line_number":86,"context_line":"          # Gate jobs can\u0027t deal with nested virt. Disable it."},{"line_number":87,"context_line":"          LIBVIRT_TYPE: qemu"},{"line_number":88,"context_line":"      # grenade_from_branch is branch specific, it\u0027s the change branch \"-1\"."},{"line_number":89,"context_line":"      # This has to be updated on master when cutting a new stable branch."},{"line_number":90,"context_line":"      # grenade_to_branch is always the current patch on pullup jobs."},{"line_number":91,"context_line":"      grenade_from_branch: stable/train"},{"line_number":92,"context_line":"      grenade_localrc:"},{"line_number":93,"context_line":"        SAVE_DIR: \"{{ devstack_bases.shared }}/save\""},{"line_number":94,"context_line":"      # from tempest playbooks"}],"source_content_type":"text/x-yaml","patch_set":107,"id":"1fa4df85_a1f765d3","line":91,"range":{"start_line":88,"start_character":0,"end_line":91,"end_character":39},"in_reply_to":"1fa4df85_017a18f0","updated":"2020-03-03 18:29:38.000000000","message":"ok, we can avoid that mapping and change while backporting or defining the forward testing job or on new openstack release. \n\nI commented to move these on write-grenade-conf role and define with these default and a NOTE to update those for every new release of openstack.","commit_id":"f586cd11731cf763a07694e468a983b45b90bb1b"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"dd33b87dfa1955681fa1be8fa2cf84821cbfe77b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"          ERROR_ON_CLONE: true"},{"line_number":86,"context_line":"          # Gate jobs can\u0027t deal with nested virt. Disable it."},{"line_number":87,"context_line":"          LIBVIRT_TYPE: qemu"},{"line_number":88,"context_line":"      # grenade_from_branch is branch specific, it\u0027s the change branch \"-1\"."},{"line_number":89,"context_line":"      # This has to be updated on master when cutting a new stable branch."},{"line_number":90,"context_line":"      # grenade_to_branch is always the current patch on pullup jobs."},{"line_number":91,"context_line":"      grenade_from_branch: stable/train"},{"line_number":92,"context_line":"      grenade_localrc:"},{"line_number":93,"context_line":"        SAVE_DIR: \"{{ devstack_bases.shared }}/save\""},{"line_number":94,"context_line":"      # from tempest playbooks"}],"source_content_type":"text/x-yaml","patch_set":107,"id":"1fa4df85_017a18f0","line":91,"range":{"start_line":88,"start_character":0,"end_line":91,"end_character":39},"in_reply_to":"1fa4df85_0e2833e0","updated":"2020-03-02 11:45:19.000000000","message":"I disagree: I think this is the cleaner solution for most the testing (which is pullup). It just need to be changed once when backporting this change.\n\nFor forward testing, you would either need the map, or just set grenade_from_branch to zuul.branch and grenade_to_branch to master. I don\u0027t think it would be much of a burden and it\u0027d be clean enough.","commit_id":"f586cd11731cf763a07694e468a983b45b90bb1b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"00db6aaf67ad8e5ad56b31254c53a33951e41ca4","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    pre-run: playbooks/pre.yaml"},{"line_number":151,"context_line":"    run: playbooks/grenade.yaml"},{"line_number":152,"context_line":"    post-run: playbooks/post.yaml"},{"line_number":153,"context_line":"    irrelevant-files:"},{"line_number":154,"context_line":"      # Documentation related"},{"line_number":155,"context_line":"      - ^.*\\.rst$"},{"line_number":156,"context_line":"      - ^api-ref/.*$"}],"source_content_type":"text/x-yaml","patch_set":107,"id":"1fa4df85_ee54b723","line":153,"range":{"start_line":153,"start_character":0,"end_line":153,"end_character":21},"updated":"2020-02-27 02:19:57.000000000","message":"this you can define as grenade-irrelevant-files","commit_id":"f586cd11731cf763a07694e468a983b45b90bb1b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"00db6aaf67ad8e5ad56b31254c53a33951e41ca4","unresolved":false,"context_lines":[{"line_number":179,"context_line":"      - openstack/requirements"},{"line_number":180,"context_line":"      - openstack/swift"},{"line_number":181,"context_line":"      - openstack/tempest"},{"line_number":182,"context_line":"    timeout: 7200"},{"line_number":183,"context_line":"    vars:"},{"line_number":184,"context_line":"      grenade_devstack_localrc:"},{"line_number":185,"context_line":"        shared:"}],"source_content_type":"text/x-yaml","patch_set":107,"id":"1fa4df85_2e23af07","line":182,"range":{"start_line":182,"start_character":13,"end_line":182,"end_character":17},"updated":"2020-02-27 02:19:57.000000000","message":"we should keep old timeout as 10800","commit_id":"f586cd11731cf763a07694e468a983b45b90bb1b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"00db6aaf67ad8e5ad56b31254c53a33951e41ca4","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            DEFAULT:"},{"line_number":203,"context_line":"              global_physnet_mtu: \"{{ external_bridge_mtu }}\""},{"line_number":204,"context_line":"      grenade_localrc:"},{"line_number":205,"context_line":"        # disable the execution of the smoke tests by default"},{"line_number":206,"context_line":"        RUN_SMOKE: False"},{"line_number":207,"context_line":"      devstack_services:"},{"line_number":208,"context_line":"        # Core services enabled for this branch."},{"line_number":209,"context_line":"        # This list replaces the test-matrix."}],"source_content_type":"text/x-yaml","patch_set":107,"id":"1fa4df85_b11700a4","line":206,"range":{"start_line":205,"start_character":0,"end_line":206,"end_character":24},"updated":"2020-02-27 02:19:57.000000000","message":"This stop running the tempest smoke on old node to verify the installation. I am rethinking on this as it would take much time to run and fail early if something is not installed proporly. \n\nLet\u0027s keep it True by default and plugins job can disable it if they want. \n\nInstead of this you can set BASE_RUN_SMOKE\u003dTrue","commit_id":"f586cd11731cf763a07694e468a983b45b90bb1b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9948f385120ff1f96769356a4bf787dc049b1003","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            DEFAULT:"},{"line_number":203,"context_line":"              global_physnet_mtu: \"{{ external_bridge_mtu }}\""},{"line_number":204,"context_line":"      grenade_localrc:"},{"line_number":205,"context_line":"        # disable the execution of the smoke tests by default"},{"line_number":206,"context_line":"        RUN_SMOKE: False"},{"line_number":207,"context_line":"      devstack_services:"},{"line_number":208,"context_line":"        # Core services enabled for this branch."},{"line_number":209,"context_line":"        # This list replaces the test-matrix."}],"source_content_type":"text/x-yaml","patch_set":107,"id":"1fa4df85_55e18f29","line":206,"range":{"start_line":205,"start_character":0,"end_line":206,"end_character":24},"in_reply_to":"1fa4df85_844b7629","updated":"2020-03-03 18:29:38.000000000","message":"both works. It is ok to be explicit.","commit_id":"f586cd11731cf763a07694e468a983b45b90bb1b"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"dd33b87dfa1955681fa1be8fa2cf84821cbfe77b","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            DEFAULT:"},{"line_number":203,"context_line":"              global_physnet_mtu: \"{{ external_bridge_mtu }}\""},{"line_number":204,"context_line":"      grenade_localrc:"},{"line_number":205,"context_line":"        # disable the execution of the smoke tests by default"},{"line_number":206,"context_line":"        RUN_SMOKE: False"},{"line_number":207,"context_line":"      devstack_services:"},{"line_number":208,"context_line":"        # Core services enabled for this branch."},{"line_number":209,"context_line":"        # This list replaces the test-matrix."}],"source_content_type":"text/x-yaml","patch_set":107,"id":"1fa4df85_844b7629","line":206,"range":{"start_line":205,"start_character":0,"end_line":206,"end_character":24},"in_reply_to":"1fa4df85_b11700a4","updated":"2020-03-02 11:45:19.000000000","message":"It\u0027s the default value, should I just omit it?","commit_id":"f586cd11731cf763a07694e468a983b45b90bb1b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"00db6aaf67ad8e5ad56b31254c53a33951e41ca4","unresolved":false,"context_lines":[{"line_number":306,"context_line":"            Q_HOST: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}\""},{"line_number":307,"context_line":"            RABBIT_HOST: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}\""},{"line_number":308,"context_line":"            DATABASE_HOST: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}\""},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"- job:"},{"line_number":311,"context_line":"    name: grenade-postgresql"},{"line_number":312,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":107,"id":"1fa4df85_6e176753","line":309,"range":{"start_line":309,"start_character":0,"end_line":309,"end_character":0},"updated":"2020-02-27 02:19:57.000000000","message":"let\u0027s keep grenade-py3 job also which can be just alias to grenade job. because grenade-py3 name is being used in the integrated-gate-py3 template and other places also. \n\nOnce we migrate those usages to new job then we can remove it. Please add TODO comment.","commit_id":"f586cd11731cf763a07694e468a983b45b90bb1b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9948f385120ff1f96769356a4bf787dc049b1003","unresolved":false,"context_lines":[{"line_number":79,"context_line":"          ERROR_ON_CLONE: true"},{"line_number":80,"context_line":"          # Gate jobs can\u0027t deal with nested virt. Disable it."},{"line_number":81,"context_line":"          LIBVIRT_TYPE: qemu"},{"line_number":82,"context_line":"      # grenade_from_branch is branch specific, it\u0027s the change branch \"-1\"."},{"line_number":83,"context_line":"      # This has to be updated on master when cutting a new stable branch."},{"line_number":84,"context_line":"      # grenade_to_branch is always the current patch on pullup jobs."},{"line_number":85,"context_line":"      grenade_from_branch: stable/train"},{"line_number":86,"context_line":"      grenade_localrc:"},{"line_number":87,"context_line":"        SAVE_DIR: \"{{ devstack_bases.shared }}/save\""},{"line_number":88,"context_line":"      # from tempest playbooks"}],"source_content_type":"text/x-yaml","patch_set":110,"id":"1fa4df85_c1c941ac","line":85,"range":{"start_line":82,"start_character":0,"end_line":85,"end_character":39},"updated":"2020-03-03 18:29:38.000000000","message":"I commented on write-grenade-conf role, let\u0027s have them default there and if any job for example forward testing can override these var in job.","commit_id":"e1f56110dc4e908e48fece114ab450718b104acd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9948f385120ff1f96769356a4bf787dc049b1003","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        \u0027{{ grenade_log_dir }}/grenade.sh.log.summary\u0027: logs"},{"line_number":101,"context_line":"        \u0027{{ grenade_conf_dir }}/grenade_localrc\u0027: logs_txt"},{"line_number":102,"context_line":"        \u0027{{ grenade_conf_dir }}/grenade_pluginrc\u0027: logs_txt"},{"line_number":103,"context_line":"        \u0027{{ devstack_bases.new }}/tempest/etc/tempest.conf\u0027: logs"},{"line_number":104,"context_line":"        \u0027{{ devstack_bases.new }}/tempest/etc/accounts.yaml\u0027: logs"},{"line_number":105,"context_line":"        \u0027{{ devstack_bases.new }}/tempest/tempest.log\u0027: logs"},{"line_number":106,"context_line":"        \u0027{{ stage_dir }}/{{ test_results_stage_name }}.subunit\u0027: logs"},{"line_number":107,"context_line":"        \u0027{{ stage_dir }}/{{ test_results_stage_name }}.html\u0027: logs"},{"line_number":108,"context_line":"        \u0027{{ stage_dir }}/stackviz\u0027: logs"}],"source_content_type":"text/x-yaml","patch_set":110,"id":"1fa4df85_41055113","line":105,"range":{"start_line":103,"start_character":0,"end_line":105,"end_character":60},"updated":"2020-03-03 18:29:38.000000000","message":"we need to copy these to new node logs so that it will be clear which tempest run these logs/config are.\n\nalso we are missign to log the old node tempest files(these 3)","commit_id":"e1f56110dc4e908e48fece114ab450718b104acd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"390c8b213683013377d9ebc4da16a952f5a65324","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    experimental:"},{"line_number":20,"context_line":"      jobs:"},{"line_number":21,"context_line":"        - grenade-postgresql"},{"line_number":22,"context_line":"        - grenade-forward"},{"line_number":23,"context_line":"        - trove-grenade:"},{"line_number":24,"context_line":"            irrelevant-files: *legacy-irrelevant-files"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":113,"id":"1f493fa4_8e5d54eb","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":25},"updated":"2020-04-23 23:16:38.000000000","message":"We can remove this from here. there is no point of running the forward testing in master which will end up master-\u003emaster upgrade.\n\nWe can add this in the experimental pipeline on stable branch when we cut the ussuri branch for grenade. So that we can have this forward testing job running for ussuri-\u003emaster","commit_id":"1ede47438c5999717feeb5eb6cf59c60e2994d0c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"390c8b213683013377d9ebc4da16a952f5a65324","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        * grenade-dsvm-neutron-forward"},{"line_number":314,"context_line":"        * legacy-grenade-dsvm-neutron-forward"},{"line_number":315,"context_line":"    vars:"},{"line_number":316,"context_line":"      grenade_from_branch: master"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"- job:"},{"line_number":319,"context_line":"    name: grenade-dsvm-neutron-forward"}],"source_content_type":"text/x-yaml","patch_set":113,"id":"1f493fa4_8e7394b1","line":316,"range":{"start_line":316,"start_character":27,"end_line":316,"end_character":33},"updated":"2020-04-23 23:16:38.000000000","message":"mentioning master here is testing master -\u003e master upgrade.\n\nAs forward testing on master is no meaning, we can add a note here that this job is only relevant for stable branch gate so set the value of grenade_from_branch to the stable branch where this job needs to run.\n\nI mean keeping \u0027master\u0027 but with NOTE.","commit_id":"1ede47438c5999717feeb5eb6cf59c60e2994d0c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"7afc92673503bd7a7e8b5e4a177a40c92917169e","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        * grenade-dsvm-neutron-forward"},{"line_number":314,"context_line":"        * legacy-grenade-dsvm-neutron-forward"},{"line_number":315,"context_line":"    vars:"},{"line_number":316,"context_line":"      grenade_from_branch: master"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"- job:"},{"line_number":319,"context_line":"    name: grenade-dsvm-neutron-forward"}],"source_content_type":"text/x-yaml","patch_set":113,"id":"1f493fa4_8e86f4da","line":316,"range":{"start_line":316,"start_character":27,"end_line":316,"end_character":33},"in_reply_to":"1f493fa4_8e7394b1","updated":"2020-04-23 23:35:34.000000000","message":"I\u0027m going to add more text to the description, which already cover this, and a comment here to explain that, when stable/X is cut, this value should be updated inside stable/(X-1) to point to the new stable/X.\nThe job on stable/X will correctly run from the base branch (stable/X) to master.","commit_id":"1ede47438c5999717feeb5eb6cf59c60e2994d0c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fd98e9fe3c967808381c24f2e3dd1eaa20266cdb","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        * legacy-grenade-dsvm-neutron-forward"},{"line_number":316,"context_line":"    vars:"},{"line_number":317,"context_line":"      # When a stable branch stable/X is created from master,"},{"line_number":318,"context_line":"      # this value should be updated in the stable/(X-1) branch"},{"line_number":319,"context_line":"      # to point to the new stable branch."},{"line_number":320,"context_line":"      grenade_from_branch: master"},{"line_number":321,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":114,"id":"1f493fa4_0e8e64cf","line":318,"range":{"start_line":318,"start_character":44,"end_line":318,"end_character":56},"updated":"2020-04-23 23:44:56.000000000","message":"it should be stable/(X) then it will be forward testing from stable/(X) -\u003e master","commit_id":"4f1e0f130326b890c90e9299fd4458a7742d8e33"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"35f8b4cf9272ad544517bdc11a7f2ef5f927573f","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        * legacy-grenade-dsvm-neutron-forward"},{"line_number":316,"context_line":"    vars:"},{"line_number":317,"context_line":"      # When a stable branch stable/X is created from master,"},{"line_number":318,"context_line":"      # this value should be updated in the stable/(X-1) branch"},{"line_number":319,"context_line":"      # to point to the new stable branch."},{"line_number":320,"context_line":"      grenade_from_branch: master"},{"line_number":321,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":114,"id":"1f493fa4_5102cd0a","line":318,"range":{"start_line":318,"start_character":44,"end_line":318,"end_character":56},"in_reply_to":"1f493fa4_0e8e64cf","updated":"2020-04-23 23:47:32.000000000","message":"Right, sorry.","commit_id":"4f1e0f130326b890c90e9299fd4458a7742d8e33"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f3e26bbbd7ceddda2dbcbe9522e588c5f19eae1e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        \u0027{{ grenade_conf_dir }}/grenade_localrc\u0027: logs_txt"},{"line_number":96,"context_line":"        \u0027{{ grenade_conf_dir }}/grenade_pluginrc\u0027: logs_txt"},{"line_number":97,"context_line":"        \u0027{{ stage_dir }}/{{ test_results_stage_name }}.subunit\u0027: logs"},{"line_number":98,"context_line":"        \u0027{{ stage_dir }}/{{ test_results_stage_name }}.html\u0027: logs"},{"line_number":99,"context_line":"        \u0027{{ stage_dir }}/stackviz\u0027: logs"},{"line_number":100,"context_line":"        \u0027{{ stage_dir }}/apache\u0027: logs"},{"line_number":101,"context_line":"        \u0027{{ stage_dir }}/apache_config\u0027: logs"}],"source_content_type":"text/x-yaml","patch_set":115,"id":"1f493fa4_041da5bc","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":66},"updated":"2020-04-24 02:40:21.000000000","message":"there are no test_results.html for old node. I am not sure if we already talked about this ? \n\nThis is not so bad because we have base test run result in grenade.sh logs.\n\nBut do we store the base tempest run results? if it is not so easy then we can proceed with this and later we can do.","commit_id":"3152d6ea5b18c766fab7a0bbb2af97c49b60c865"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"7e90e090f541f0821a3b7d258beb4358445718e5","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        \u0027{{ grenade_conf_dir }}/grenade_localrc\u0027: logs_txt"},{"line_number":96,"context_line":"        \u0027{{ grenade_conf_dir }}/grenade_pluginrc\u0027: logs_txt"},{"line_number":97,"context_line":"        \u0027{{ stage_dir }}/{{ test_results_stage_name }}.subunit\u0027: logs"},{"line_number":98,"context_line":"        \u0027{{ stage_dir }}/{{ test_results_stage_name }}.html\u0027: logs"},{"line_number":99,"context_line":"        \u0027{{ stage_dir }}/stackviz\u0027: logs"},{"line_number":100,"context_line":"        \u0027{{ stage_dir }}/apache\u0027: logs"},{"line_number":101,"context_line":"        \u0027{{ stage_dir }}/apache_config\u0027: logs"}],"source_content_type":"text/x-yaml","patch_set":115,"id":"1f493fa4_4b7171e0","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":66},"in_reply_to":"1f493fa4_041da5bc","updated":"2020-04-24 13:44:01.000000000","message":"That\u0027s generated by fetch-subunit-output and I\u0027m not sure it\u0027s easy to change that part.\nIt\u0027s worth nothing that the role supports specifying multiple subunit files through fetch_subunit_output_additional_dirs, but the result is a combination of subunit files, which means that the results for the same test are reported together (i.e. you can distinguish them). I was planning to address this in the future.\n\nAnyway, as the result from old are just smoke tests, we just need a pass or fail (and check the logs). The important duty of grenade is the upgrade and the post-upgrade IMHO.","commit_id":"3152d6ea5b18c766fab7a0bbb2af97c49b60c865"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e6341a50890d43bccea7cd81204532896d0c737c","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        \u0027{{ grenade_conf_dir }}/grenade_localrc\u0027: logs_txt"},{"line_number":96,"context_line":"        \u0027{{ grenade_conf_dir }}/grenade_pluginrc\u0027: logs_txt"},{"line_number":97,"context_line":"        \u0027{{ stage_dir }}/{{ test_results_stage_name }}.subunit\u0027: logs"},{"line_number":98,"context_line":"        \u0027{{ stage_dir }}/{{ test_results_stage_name }}.html\u0027: logs"},{"line_number":99,"context_line":"        \u0027{{ stage_dir }}/stackviz\u0027: logs"},{"line_number":100,"context_line":"        \u0027{{ stage_dir }}/apache\u0027: logs"},{"line_number":101,"context_line":"        \u0027{{ stage_dir }}/apache_config\u0027: logs"}],"source_content_type":"text/x-yaml","patch_set":115,"id":"1f493fa4_717ffc66","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":66},"in_reply_to":"1f493fa4_4b7171e0","updated":"2020-04-24 14:22:11.000000000","message":"yeah that is what i was thinking. let\u0027s go with this as old node test run are just to verify the env not the end result of this job.","commit_id":"3152d6ea5b18c766fab7a0bbb2af97c49b60c865"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1af466f9dcbd4f2f15b4f1c6f276b07ec1998d5d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"          DEST: \"{{ devstack_bases.new }}\""},{"line_number":55,"context_line":"          LOGFILE: \"{{ devstack_bases.new }}/logs/devstacklog.txt\""},{"line_number":56,"context_line":"        shared:"},{"line_number":57,"context_line":"          USE_PYTHON3: true"},{"line_number":58,"context_line":"          # Common settings for OpenStack CI"},{"line_number":59,"context_line":"          DATABASE_PASSWORD: secretdatabase"},{"line_number":60,"context_line":"          # FIXME: temporarily define MYSQL_PASSWORD too,"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_3ecb6f72","line":57,"range":{"start_line":57,"start_character":10,"end_line":57,"end_character":27},"updated":"2020-04-25 15:12:15.000000000","message":"soon be noop","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"49cb5a93cc097fbe43678b42f64b8053d5167c54","unresolved":false,"context_lines":[{"line_number":54,"context_line":"          DEST: \"{{ devstack_bases.new }}\""},{"line_number":55,"context_line":"          LOGFILE: \"{{ devstack_bases.new }}/logs/devstacklog.txt\""},{"line_number":56,"context_line":"        shared:"},{"line_number":57,"context_line":"          USE_PYTHON3: true"},{"line_number":58,"context_line":"          # Common settings for OpenStack CI"},{"line_number":59,"context_line":"          DATABASE_PASSWORD: secretdatabase"},{"line_number":60,"context_line":"          # FIXME: temporarily define MYSQL_PASSWORD too,"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_7eefb7af","line":57,"range":{"start_line":57,"start_character":10,"end_line":57,"end_character":27},"in_reply_to":"1f493fa4_3ecb6f72","updated":"2020-04-25 15:35:55.000000000","message":"Right. If we backport this to train we need to remember to readd it though.","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bcbfda45b444c1d01408567f14e8fb3977538e95","unresolved":false,"context_lines":[{"line_number":54,"context_line":"          DEST: \"{{ devstack_bases.new }}\""},{"line_number":55,"context_line":"          LOGFILE: \"{{ devstack_bases.new }}/logs/devstacklog.txt\""},{"line_number":56,"context_line":"        shared:"},{"line_number":57,"context_line":"          USE_PYTHON3: true"},{"line_number":58,"context_line":"          # Common settings for OpenStack CI"},{"line_number":59,"context_line":"          DATABASE_PASSWORD: secretdatabase"},{"line_number":60,"context_line":"          # FIXME: temporarily define MYSQL_PASSWORD too,"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_9281d792","line":57,"range":{"start_line":57,"start_character":10,"end_line":57,"end_character":27},"in_reply_to":"1f493fa4_7eefb7af","updated":"2020-04-25 22:53:57.000000000","message":"stable/train devstack is not default to py3 so we need to explicitly enable the py3.\n\nThis is job is for upgrading the train to ussuri so we need this and while Victoria in master where upgrade will be Ussuri to Victoria then we can remove.","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1af466f9dcbd4f2f15b4f1c6f276b07ec1998d5d","unresolved":false,"context_lines":[{"line_number":153,"context_line":"      Usually grenade jobs should inherit from this job."},{"line_number":154,"context_line":"    nodeset: openstack-single-node-bionic"},{"line_number":155,"context_line":"    required-projects:"},{"line_number":156,"context_line":"      # NOTE(andreaf) The devstack and grenade roles take care of setting up"},{"line_number":157,"context_line":"      # repos on the right branch for this job."},{"line_number":158,"context_line":"      - opendev.org/openstack/devstack"},{"line_number":159,"context_line":"      - opendev.org/openstack/cinder"},{"line_number":160,"context_line":"      - opendev.org/openstack/glance"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_feae2796","line":157,"range":{"start_line":156,"start_character":6,"end_line":157,"end_character":47},"updated":"2020-04-25 15:12:15.000000000","message":"This should probably end up near \"roles:\" of base job.","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"49cb5a93cc097fbe43678b42f64b8053d5167c54","unresolved":false,"context_lines":[{"line_number":153,"context_line":"      Usually grenade jobs should inherit from this job."},{"line_number":154,"context_line":"    nodeset: openstack-single-node-bionic"},{"line_number":155,"context_line":"    required-projects:"},{"line_number":156,"context_line":"      # NOTE(andreaf) The devstack and grenade roles take care of setting up"},{"line_number":157,"context_line":"      # repos on the right branch for this job."},{"line_number":158,"context_line":"      - opendev.org/openstack/devstack"},{"line_number":159,"context_line":"      - opendev.org/openstack/cinder"},{"line_number":160,"context_line":"      - opendev.org/openstack/glance"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_1e367353","line":157,"range":{"start_line":156,"start_character":6,"end_line":157,"end_character":47},"in_reply_to":"1f493fa4_feae2796","updated":"2020-04-25 15:35:55.000000000","message":"I think it makes sense here because this is where the roles\u0027 behavior applies.","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1af466f9dcbd4f2f15b4f1c6f276b07ec1998d5d","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    required-projects:"},{"line_number":156,"context_line":"      # NOTE(andreaf) The devstack and grenade roles take care of setting up"},{"line_number":157,"context_line":"      # repos on the right branch for this job."},{"line_number":158,"context_line":"      - opendev.org/openstack/devstack"},{"line_number":159,"context_line":"      - opendev.org/openstack/cinder"},{"line_number":160,"context_line":"      - opendev.org/openstack/glance"},{"line_number":161,"context_line":"      - opendev.org/openstack/keystone"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_3e908f4e","line":158,"range":{"start_line":158,"start_character":6,"end_line":158,"end_character":38},"updated":"2020-04-25 15:12:15.000000000","message":"already in base job","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"49cb5a93cc097fbe43678b42f64b8053d5167c54","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    required-projects:"},{"line_number":156,"context_line":"      # NOTE(andreaf) The devstack and grenade roles take care of setting up"},{"line_number":157,"context_line":"      # repos on the right branch for this job."},{"line_number":158,"context_line":"      - opendev.org/openstack/devstack"},{"line_number":159,"context_line":"      - opendev.org/openstack/cinder"},{"line_number":160,"context_line":"      - opendev.org/openstack/glance"},{"line_number":161,"context_line":"      - opendev.org/openstack/keystone"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_fe38e73d","line":158,"range":{"start_line":158,"start_character":6,"end_line":158,"end_character":38},"in_reply_to":"1f493fa4_3e908f4e","updated":"2020-04-25 15:35:55.000000000","message":"Ok","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1af466f9dcbd4f2f15b4f1c6f276b07ec1998d5d","unresolved":false,"context_lines":[{"line_number":162,"context_line":"      - opendev.org/openstack/neutron"},{"line_number":163,"context_line":"      - opendev.org/openstack/nova"},{"line_number":164,"context_line":"      - opendev.org/openstack/placement"},{"line_number":165,"context_line":"      - opendev.org/openstack/requirements"},{"line_number":166,"context_line":"      - opendev.org/openstack/swift"},{"line_number":167,"context_line":"      - opendev.org/openstack/tempest"},{"line_number":168,"context_line":"    timeout: 10800"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_3e79af2e","line":165,"range":{"start_line":165,"start_character":6,"end_line":165,"end_character":42},"updated":"2020-04-25 15:12:15.000000000","message":"base doesn\u0027t sort alphabetically but logically so we could set it first here to easier read out really used projects, or even move this right to base because potential base consumers will likely want it anyway","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"49cb5a93cc097fbe43678b42f64b8053d5167c54","unresolved":false,"context_lines":[{"line_number":162,"context_line":"      - opendev.org/openstack/neutron"},{"line_number":163,"context_line":"      - opendev.org/openstack/nova"},{"line_number":164,"context_line":"      - opendev.org/openstack/placement"},{"line_number":165,"context_line":"      - opendev.org/openstack/requirements"},{"line_number":166,"context_line":"      - opendev.org/openstack/swift"},{"line_number":167,"context_line":"      - opendev.org/openstack/tempest"},{"line_number":168,"context_line":"    timeout: 10800"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_5e28fbe0","line":165,"range":{"start_line":165,"start_character":6,"end_line":165,"end_character":42},"in_reply_to":"1f493fa4_3e79af2e","updated":"2020-04-25 15:35:55.000000000","message":"Moved to grenade-base.","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1af466f9dcbd4f2f15b4f1c6f276b07ec1998d5d","unresolved":false,"context_lines":[{"line_number":164,"context_line":"      - opendev.org/openstack/placement"},{"line_number":165,"context_line":"      - opendev.org/openstack/requirements"},{"line_number":166,"context_line":"      - opendev.org/openstack/swift"},{"line_number":167,"context_line":"      - opendev.org/openstack/tempest"},{"line_number":168,"context_line":"    timeout: 10800"},{"line_number":169,"context_line":"    vars:"},{"line_number":170,"context_line":"      grenade_devstack_localrc:"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_9e9f235e","line":167,"range":{"start_line":167,"start_character":6,"end_line":167,"end_character":37},"updated":"2020-04-25 15:12:15.000000000","message":"ditto","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"49cb5a93cc097fbe43678b42f64b8053d5167c54","unresolved":false,"context_lines":[{"line_number":164,"context_line":"      - opendev.org/openstack/placement"},{"line_number":165,"context_line":"      - opendev.org/openstack/requirements"},{"line_number":166,"context_line":"      - opendev.org/openstack/swift"},{"line_number":167,"context_line":"      - opendev.org/openstack/tempest"},{"line_number":168,"context_line":"    timeout: 10800"},{"line_number":169,"context_line":"    vars:"},{"line_number":170,"context_line":"      grenade_devstack_localrc:"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_5e3f5b24","line":167,"range":{"start_line":167,"start_character":6,"end_line":167,"end_character":37},"in_reply_to":"1f493fa4_9e9f235e","updated":"2020-04-25 15:35:55.000000000","message":"Ok","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1af466f9dcbd4f2f15b4f1c6f276b07ec1998d5d","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        key: true"},{"line_number":207,"context_line":"        # Glance services"},{"line_number":208,"context_line":"        g-api: true"},{"line_number":209,"context_line":"        g-reg: true"},{"line_number":210,"context_line":"        # Nova services"},{"line_number":211,"context_line":"        n-api: true"},{"line_number":212,"context_line":"        n-api-meta: true"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_de8feb20","line":209,"range":{"start_line":209,"start_character":8,"end_line":209,"end_character":19},"updated":"2020-04-25 15:12:15.000000000","message":"just no","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"26aa9519f0ace1f68b9170d76248da7e15ce3203","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        key: true"},{"line_number":207,"context_line":"        # Glance services"},{"line_number":208,"context_line":"        g-api: true"},{"line_number":209,"context_line":"        g-reg: true"},{"line_number":210,"context_line":"        # Nova services"},{"line_number":211,"context_line":"        n-api: true"},{"line_number":212,"context_line":"        n-api-meta: true"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_86c6b947","line":209,"range":{"start_line":209,"start_character":8,"end_line":209,"end_character":19},"in_reply_to":"1f493fa4_5e6d9b30","updated":"2020-04-26 09:38:52.000000000","message":"I suspect we need it, because the upgrade starts from train. We will remove this after branching grenade and making it start from ussuri.","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"49cb5a93cc097fbe43678b42f64b8053d5167c54","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        key: true"},{"line_number":207,"context_line":"        # Glance services"},{"line_number":208,"context_line":"        g-api: true"},{"line_number":209,"context_line":"        g-reg: true"},{"line_number":210,"context_line":"        # Nova services"},{"line_number":211,"context_line":"        n-api: true"},{"line_number":212,"context_line":"        n-api-meta: true"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_5e6d9b30","line":209,"range":{"start_line":209,"start_character":8,"end_line":209,"end_character":19},"in_reply_to":"1f493fa4_de8feb20","updated":"2020-04-25 15:35:55.000000000","message":"Right, it was there when this review started.","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1af466f9dcbd4f2f15b4f1c6f276b07ec1998d5d","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    vars:"},{"line_number":302,"context_line":"      grenade_devstack_localrc:"},{"line_number":303,"context_line":"        shared:"},{"line_number":304,"context_line":"          USE_PYTHON3: true"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"- job:"},{"line_number":307,"context_line":"    name: grenade-forward"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_9ead638a","line":304,"range":{"start_line":304,"start_character":10,"end_line":304,"end_character":27},"updated":"2020-04-25 15:12:15.000000000","message":"this is already set on base job","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"81f6260c3a3ad4340d11ea5bd0953ce6a0ccfb29","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    vars:"},{"line_number":302,"context_line":"      grenade_devstack_localrc:"},{"line_number":303,"context_line":"        shared:"},{"line_number":304,"context_line":"          USE_PYTHON3: true"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"- job:"},{"line_number":307,"context_line":"    name: grenade-forward"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_52faaf74","line":304,"range":{"start_line":304,"start_character":10,"end_line":304,"end_character":27},"in_reply_to":"1f493fa4_3e236f07","updated":"2020-04-25 22:55:55.000000000","message":"Nevermind: we start from train, so it must be set explicitly.","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"49cb5a93cc097fbe43678b42f64b8053d5167c54","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    vars:"},{"line_number":302,"context_line":"      grenade_devstack_localrc:"},{"line_number":303,"context_line":"        shared:"},{"line_number":304,"context_line":"          USE_PYTHON3: true"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"- job:"},{"line_number":307,"context_line":"    name: grenade-forward"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_3e236f07","line":304,"range":{"start_line":304,"start_character":10,"end_line":304,"end_character":27},"in_reply_to":"1f493fa4_9ead638a","updated":"2020-04-25 15:35:55.000000000","message":"Better keep it explicitly in case of backport.","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1af466f9dcbd4f2f15b4f1c6f276b07ec1998d5d","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        grenade_devstack_localrc:"},{"line_number":342,"context_line":"          shared:"},{"line_number":343,"context_line":"            DATABASE_TYPE: postgresql"},{"line_number":344,"context_line":"    irrelevant-files: *grenade-irrelevant-files"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"- job:"},{"line_number":347,"context_line":"    name: grenade-multinode"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_deb88bc9","line":344,"range":{"start_line":344,"start_character":4,"end_line":344,"end_character":47},"updated":"2020-04-25 15:12:15.000000000","message":"already set on base","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"49cb5a93cc097fbe43678b42f64b8053d5167c54","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        grenade_devstack_localrc:"},{"line_number":342,"context_line":"          shared:"},{"line_number":343,"context_line":"            DATABASE_TYPE: postgresql"},{"line_number":344,"context_line":"    irrelevant-files: *grenade-irrelevant-files"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"- job:"},{"line_number":347,"context_line":"    name: grenade-multinode"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_7e1df7bb","line":344,"range":{"start_line":344,"start_character":4,"end_line":344,"end_character":47},"in_reply_to":"1f493fa4_deb88bc9","updated":"2020-04-25 15:35:55.000000000","message":"ok","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1af466f9dcbd4f2f15b4f1c6f276b07ec1998d5d","unresolved":false,"context_lines":[{"line_number":349,"context_line":"      Basic multinode grenade job"},{"line_number":350,"context_line":"    parent: grenade"},{"line_number":351,"context_line":"    nodeset: openstack-two-node-bionic"},{"line_number":352,"context_line":"    irrelevant-files: *grenade-irrelevant-files"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_bebbffc1","line":352,"range":{"start_line":352,"start_character":4,"end_line":352,"end_character":47},"updated":"2020-04-25 15:12:15.000000000","message":"already set on base","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"49cb5a93cc097fbe43678b42f64b8053d5167c54","unresolved":false,"context_lines":[{"line_number":349,"context_line":"      Basic multinode grenade job"},{"line_number":350,"context_line":"    parent: grenade"},{"line_number":351,"context_line":"    nodeset: openstack-two-node-bionic"},{"line_number":352,"context_line":"    irrelevant-files: *grenade-irrelevant-files"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_be7c9feb","line":352,"range":{"start_line":352,"start_character":4,"end_line":352,"end_character":47},"in_reply_to":"1f493fa4_bebbffc1","updated":"2020-04-25 15:35:55.000000000","message":"ok","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"}],"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bff3e5bc334e80e7edd6dd2121faebe7283b0d9b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- grenade from grenade_to_branch"},{"line_number":17,"context_line":"- projects in old from grenade_from_branch"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Still need to be sorted out: how do we manage branch setting and"},{"line_number":20,"context_line":"refspecs set by zuul for the current change and depends-on ones?"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"In a standard grenade job, the change is against new, so a"},{"line_number":23,"context_line":"depends-on a patch in stable will be ignored by zuul (?). If we"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"3f79a3b5_7d285984","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":64},"updated":"2018-09-13 15:29:46.000000000","message":"currnetly (with legacy jobs), grenade job is taking care of depends-on patch on stable brnach. \n\nhttps://review.openstack.org/#/c/602208//1\n\nhttp://logs.openstack.org/08/602208/1/check/neutron-grenade/f7605ed/logs/screen-n-api.txt.gz#_Sep_13_00_21_05_839340","commit_id":"65ae07cedb4bf5e18b76cf5307cd2dd404e0bcf7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9461133f5a81fe2840e3444431dda0badc45f61c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     a72bd29e (Add GRENADE_DEVSTACK_EXTERNAL to skip part of the setup)"},{"line_number":2,"context_line":"Author:     Luigi Toscano \u003cltoscano@redhat.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2019-03-29 16:10:17 +0100"},{"line_number":4,"context_line":"Commit:     Luigi Toscano \u003cltoscano@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-25 18:18:43 +0200"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":102,"id":"3fa7e38b_45c0617e","line":2,"updated":"2019-12-17 17:17:05.000000000","message":"Looks like Andrea was changed at some point...","commit_id":"e9f7d252c001317509859c1735c3216d8a578f85"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1af466f9dcbd4f2f15b4f1c6f276b07ec1998d5d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"- projects in old from grenade_from_branch"},{"line_number":19,"context_line":"and then tries to run grenade and then tempest."},{"line_number":20,"context_line":"The configure-grenade-branches role sets the base/target"},{"line_number":21,"context_line":"branch variables (grenade_{from,to}_branch) and must be"},{"line_number":22,"context_line":"updated when cutting a new branch."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Also, define the native versions of the grenade-postgresql"},{"line_number":25,"context_line":"and grenade-multinode jobs, replacing non-native jobs"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":116,"id":"1f493fa4_debc0bde","line":22,"range":{"start_line":21,"start_character":48,"end_line":22,"end_character":33},"updated":"2020-04-25 15:12:15.000000000","message":"Let\u0027s document this in a followup.","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"49cb5a93cc097fbe43678b42f64b8053d5167c54","unresolved":false,"context_lines":[{"line_number":18,"context_line":"- projects in old from grenade_from_branch"},{"line_number":19,"context_line":"and then tries to run grenade and then tempest."},{"line_number":20,"context_line":"The configure-grenade-branches role sets the base/target"},{"line_number":21,"context_line":"branch variables (grenade_{from,to}_branch) and must be"},{"line_number":22,"context_line":"updated when cutting a new branch."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Also, define the native versions of the grenade-postgresql"},{"line_number":25,"context_line":"and grenade-multinode jobs, replacing non-native jobs"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":116,"id":"1f493fa4_7ed697f3","line":22,"range":{"start_line":21,"start_character":48,"end_line":22,"end_character":33},"in_reply_to":"1f493fa4_debc0bde","updated":"2020-04-25 15:35:55.000000000","message":"Uh, where? I think there is a \"release TODO\" for the QA project but I\u0027m not sure it\u0027s here.","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"}],"grenade.sh":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7653ce85af78c4c29387091f4c9c83cb3800939c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"source $GRENADE_DIR/grenaderc"},{"line_number":41,"context_line":"source $GRENADE_DIR/inc/bootstrap"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"VERBOSE\u003d$(trueorfalse False VERBOSE)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"while getopts bqs:t c; do"},{"line_number":46,"context_line":"    case $c in"}],"source_content_type":"text/x-sh","patch_set":116,"id":"1f493fa4_18b7abf8","line":43,"updated":"2020-04-25 12:16:07.000000000","message":"grenaderc (included just before) has\n\nVERBOSE\u003d${VERBOSE:-True}\n\nwhich kind of contradicts this. Defaulting to false also kind of makes the -q option useless.","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"8d1dd3742a9c4f9cc11fa50f457133550b05943f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"source $GRENADE_DIR/grenaderc"},{"line_number":41,"context_line":"source $GRENADE_DIR/inc/bootstrap"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"VERBOSE\u003d$(trueorfalse False VERBOSE)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"while getopts bqs:t c; do"},{"line_number":46,"context_line":"    case $c in"}],"source_content_type":"text/x-sh","patch_set":116,"id":"1f493fa4_c37c38ed","line":43,"in_reply_to":"1f493fa4_18b7abf8","updated":"2020-04-25 13:41:32.000000000","message":"And also I set it as True in the job. I guess it was a debug statement that I left in place. Or maybe nothing works, because the way variables are overridden is a bit different. Let\u0027s see, I tried to remove it from the test review here:\nhttps://review.opendev.org/#/c/639774/","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7653ce85af78c4c29387091f4c9c83cb3800939c","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    # Set up output redirection without log files"},{"line_number":126,"context_line":"    # Copy stdout to fd 3"},{"line_number":127,"context_line":"    exec 3\u003e\u00261"},{"line_number":128,"context_line":"    if [[ \"$VERBOSE\" !\u003d \"yes\" ]]; then"},{"line_number":129,"context_line":"        # Throw away stdout and stderr"},{"line_number":130,"context_line":"        exec 1\u003e/dev/null 2\u003e\u00261"},{"line_number":131,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":116,"id":"1f493fa4_98ca9b6a","line":128,"updated":"2020-04-25 12:16:07.000000000","message":"FTR this use of VERBOSE seems wrong, too.","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"8d1dd3742a9c4f9cc11fa50f457133550b05943f","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    # Set up output redirection without log files"},{"line_number":126,"context_line":"    # Copy stdout to fd 3"},{"line_number":127,"context_line":"    exec 3\u003e\u00261"},{"line_number":128,"context_line":"    if [[ \"$VERBOSE\" !\u003d \"yes\" ]]; then"},{"line_number":129,"context_line":"        # Throw away stdout and stderr"},{"line_number":130,"context_line":"        exec 1\u003e/dev/null 2\u003e\u00261"},{"line_number":131,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":116,"id":"1f493fa4_633f2425","line":128,"in_reply_to":"1f493fa4_98ca9b6a","updated":"2020-04-25 13:41:32.000000000","message":"Uh, this was already there :/\nAnd that branch of code is never used, because LOGFILE is always defined in all jobs. I will send a separate patch for this.","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1af466f9dcbd4f2f15b4f1c6f276b07ec1998d5d","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        echo_summary \"Running base smoke test\""},{"line_number":294,"context_line":"        cd $BASE_RELEASE_DIR/tempest"},{"line_number":295,"context_line":"        tox -esmoke -- --concurrency\u003d$TEMPEST_CONCURRENCY"},{"line_number":296,"context_line":"        if [ \"${GRENADE_USE_EXTERNAL_DEVSTACK}\" !\u003d \"True\" ]; then"},{"line_number":297,"context_line":"            # once we are done, copy our created artifacts to the target"},{"line_number":298,"context_line":"            if [[ -e $TARGET_RELEASE_DIR/tempest ]]; then"},{"line_number":299,"context_line":"                rsync -a $BASE_RELEASE_DIR/tempest/.tox/ $TARGET_RELEASE_DIR/tempest/.tox/"}],"source_content_type":"text/x-sh","patch_set":116,"id":"1f493fa4_1eb313ec","line":296,"range":{"start_line":296,"start_character":8,"end_line":296,"end_character":65},"updated":"2020-04-25 15:12:15.000000000","message":"so with internal devstack we do it already elsewhere?","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"49cb5a93cc097fbe43678b42f64b8053d5167c54","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        echo_summary \"Running base smoke test\""},{"line_number":294,"context_line":"        cd $BASE_RELEASE_DIR/tempest"},{"line_number":295,"context_line":"        tox -esmoke -- --concurrency\u003d$TEMPEST_CONCURRENCY"},{"line_number":296,"context_line":"        if [ \"${GRENADE_USE_EXTERNAL_DEVSTACK}\" !\u003d \"True\" ]; then"},{"line_number":297,"context_line":"            # once we are done, copy our created artifacts to the target"},{"line_number":298,"context_line":"            if [[ -e $TARGET_RELEASE_DIR/tempest ]]; then"},{"line_number":299,"context_line":"                rsync -a $BASE_RELEASE_DIR/tempest/.tox/ $TARGET_RELEASE_DIR/tempest/.tox/"}],"source_content_type":"text/x-sh","patch_set":116,"id":"1f493fa4_de06cb86","line":296,"range":{"start_line":296,"start_character":8,"end_line":296,"end_character":65},"in_reply_to":"1f493fa4_1eb313ec","updated":"2020-04-25 15:35:55.000000000","message":"Legacy jobs. As long as we have legacy jobs, we need to keep this.","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"}],"playbooks/grenade.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6858c9c88f3333b515f535a31b45c3ed6769c784","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: all"},{"line_number":2,"context_line":"  roles:"},{"line_number":3,"context_line":"    - role: orchestrate-devstack"},{"line_number":4,"context_line":"      devstack_base_dir: \"{{ devstack_bases.old }}\""}],"source_content_type":"text/x-yaml","patch_set":105,"id":"3fa7e38b_14993579","line":1,"range":{"start_line":1,"start_character":9,"end_line":1,"end_character":12},"updated":"2019-12-17 22:10:54.000000000","message":"Typically you would always run devstack on the controller then the subnodes rather than in parallel.","commit_id":"51551d854ef557c3f555e9f415d92d65925b3507"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"20cb0b8681f9e1a3f0777f99e9beaf38a5f1d92e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: all"},{"line_number":2,"context_line":"  roles:"},{"line_number":3,"context_line":"    - role: orchestrate-devstack"},{"line_number":4,"context_line":"      devstack_base_dir: \"{{ devstack_bases.old }}\""}],"source_content_type":"text/x-yaml","patch_set":105,"id":"3fa7e38b_abd3df62","line":1,"range":{"start_line":1,"start_character":9,"end_line":1,"end_character":12},"in_reply_to":"3fa7e38b_14993579","updated":"2019-12-23 15:07:43.000000000","message":"I copied the playbook/devstack.yaml playbook from devstack.git. The only difference is the missing \u0027strategy: linear\u0027 statement here, even though a comment in the devstack playbook says that it is the default behavior. I\u0027m going to add it here.","commit_id":"51551d854ef557c3f555e9f415d92d65925b3507"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"00db6aaf67ad8e5ad56b31254c53a33951e41ca4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  strategy: linear"},{"line_number":3,"context_line":"  roles:"},{"line_number":4,"context_line":"    - role: orchestrate-devstack"},{"line_number":5,"context_line":"      devstack_base_dir: \"{{ devstack_bases.old }}\""},{"line_number":6,"context_line":"      devstack_data_base_dir: \"{{ devstack_bases.shared }}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- hosts: controller"}],"source_content_type":"text/x-yaml","patch_set":107,"id":"1fa4df85_912e8441","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":51},"updated":"2020-02-27 02:19:57.000000000","message":"yeah, we do not need to orchestrate devstack on new node.","commit_id":"f586cd11731cf763a07694e468a983b45b90bb1b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"00db6aaf67ad8e5ad56b31254c53a33951e41ca4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# Copied (with minimal changes) from tempest.git:playbooks/devstack-tempest.yaml"},{"line_number":19,"context_line":"# We run tests only on one node, regardless how many nodes are in the system"},{"line_number":20,"context_line":"- hosts: tempest"},{"line_number":21,"context_line":"  environment:"},{"line_number":22,"context_line":"    # This enviroment variable is used by the optional tempest-gabbi"},{"line_number":23,"context_line":"    # job provided by the gabbi-tempest plugin. It can be safely ignored"},{"line_number":24,"context_line":"    # if that plugin is not being used."},{"line_number":25,"context_line":"    GABBI_TEMPEST_PATH: \"{{ gabbi_tempest_path | default(\u0027\u0027) }}\""},{"line_number":26,"context_line":"  vars:"},{"line_number":27,"context_line":"    devstack_base_dir: \"{{ devstack_bases.new }}\""},{"line_number":28,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":107,"id":"1fa4df85_113cd4c6","line":25,"range":{"start_line":21,"start_character":0,"end_line":25,"end_character":64},"updated":"2020-02-27 02:19:57.000000000","message":"I am trying to move this var to gabbi-tempest side, but we have to include this till then - https://review.opendev.org/#/c/705339/1","commit_id":"f586cd11731cf763a07694e468a983b45b90bb1b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"00db6aaf67ad8e5ad56b31254c53a33951e41ca4","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    # if that plugin is not being used."},{"line_number":25,"context_line":"    GABBI_TEMPEST_PATH: \"{{ gabbi_tempest_path | default(\u0027\u0027) }}\""},{"line_number":26,"context_line":"  vars:"},{"line_number":27,"context_line":"    devstack_base_dir: \"{{ devstack_bases.new }}\""},{"line_number":28,"context_line":"  roles:"},{"line_number":29,"context_line":"    - setup-tempest-run-dir"},{"line_number":30,"context_line":"    - setup-tempest-data-dir"}],"source_content_type":"text/x-yaml","patch_set":107,"id":"1fa4df85_11e7f414","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":49},"updated":"2020-02-27 02:19:57.000000000","message":"can we add NOTE here to remember that tempest is run on new node here and run-grenade (grenade.sh) will run the tempest on old node to verify the installation.","commit_id":"f586cd11731cf763a07694e468a983b45b90bb1b"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"dd33b87dfa1955681fa1be8fa2cf84821cbfe77b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    # if that plugin is not being used."},{"line_number":25,"context_line":"    GABBI_TEMPEST_PATH: \"{{ gabbi_tempest_path | default(\u0027\u0027) }}\""},{"line_number":26,"context_line":"  vars:"},{"line_number":27,"context_line":"    devstack_base_dir: \"{{ devstack_bases.new }}\""},{"line_number":28,"context_line":"  roles:"},{"line_number":29,"context_line":"    - setup-tempest-run-dir"},{"line_number":30,"context_line":"    - setup-tempest-data-dir"}],"source_content_type":"text/x-yaml","patch_set":107,"id":"1fa4df85_c4464e7d","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":49},"in_reply_to":"1fa4df85_11e7f414","updated":"2020-03-02 11:45:19.000000000","message":"I\u0027d say that run-grenade may run a few smoke tests (yes by default)","commit_id":"f586cd11731cf763a07694e468a983b45b90bb1b"}],"playbooks/post.yaml":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a0f032646959232ab88ddea7c83fb485b0aac231","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        \u0027old\u0027: \"{{ devstack_bases.logs_old }}\""},{"line_number":13,"context_line":"        \u0027new\u0027: \"{{ devstack_bases.logs_new }}\""},{"line_number":14,"context_line":"      grenade_save_data_dir: \"{{ grenade_save_dir }}\""},{"line_number":15,"context_line":"    - export-devstack-journal"},{"line_number":16,"context_line":"    - apache-logs-conf"},{"line_number":17,"context_line":"    - devstack-project-conf"},{"line_number":18,"context_line":"    # capture-system-logs should be the last role before stage-output"}],"source_content_type":"text/x-yaml","patch_set":106,"id":"3fa7e38b_d84f2bbd","line":15,"updated":"2020-01-17 05:38:33.000000000","message":"This will also need to be:\n\n role: export-devstack-journal\n devstack_base_dir: \"{{ devstack_bases.old }}\"\n\nas of:\n\nhttps://opendev.org/openstack/devstack/commit/d02fa6f856ac5951b8a879c23b57d5a752f28918","commit_id":"9c54407533a8cb633d8868b877e76730a54aa900"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"05244f26970d874ebae68d9c6f95d485c3450afe","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        \u0027old\u0027: \"{{ devstack_bases.logs_old }}\""},{"line_number":13,"context_line":"        \u0027new\u0027: \"{{ devstack_bases.logs_new }}\""},{"line_number":14,"context_line":"      grenade_save_data_dir: \"{{ grenade_save_dir }}\""},{"line_number":15,"context_line":"    - export-devstack-journal"},{"line_number":16,"context_line":"    - apache-logs-conf"},{"line_number":17,"context_line":"    - devstack-project-conf"},{"line_number":18,"context_line":"    # capture-system-logs should be the last role before stage-output"}],"source_content_type":"text/x-yaml","patch_set":106,"id":"3fa7e38b_efd498be","line":15,"in_reply_to":"3fa7e38b_489feab2","updated":"2020-01-17 15:42:43.000000000","message":"Ah, sorry, it\u0027s not directly related but when it landed, it made a \"no file or directory found\" error become exposed because a pipe was removed from the command for copying the log files.\n\nSo, if you recheck this change, it will fail at that step with \"no file or directory found\". I found this while I was trying out grenade zuul v3 in nova using a depends-on this change.","commit_id":"9c54407533a8cb633d8868b877e76730a54aa900"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"735cb7391b119aea282e002078c4a3c404a576ae","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        \u0027old\u0027: \"{{ devstack_bases.logs_old }}\""},{"line_number":13,"context_line":"        \u0027new\u0027: \"{{ devstack_bases.logs_new }}\""},{"line_number":14,"context_line":"      grenade_save_data_dir: \"{{ grenade_save_dir }}\""},{"line_number":15,"context_line":"    - export-devstack-journal"},{"line_number":16,"context_line":"    - apache-logs-conf"},{"line_number":17,"context_line":"    - devstack-project-conf"},{"line_number":18,"context_line":"    # capture-system-logs should be the last role before stage-output"}],"source_content_type":"text/x-yaml","patch_set":106,"id":"3fa7e38b_3071acac","line":15,"in_reply_to":"3fa7e38b_4a435a6c","updated":"2020-01-17 17:16:21.000000000","message":"Yeah, you would pick it up in a rebase. I\u0027m actually not sure if this change will fail as-is if you recheck it with CI or if it would only happen after a rebase.\n\nEither way, my only point was that if this change lands in its current form, it would not pass the grenade job because of the removal of that pipe and exposure of the failure to copy the log-start-timestamp.txt file. I stumbled on it while testing this patch in nova in:\n\nhttps://review.opendev.org/701478","commit_id":"9c54407533a8cb633d8868b877e76730a54aa900"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"accf573854fe7559d3033a3bb556ed76d9c15ce0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        \u0027old\u0027: \"{{ devstack_bases.logs_old }}\""},{"line_number":13,"context_line":"        \u0027new\u0027: \"{{ devstack_bases.logs_new }}\""},{"line_number":14,"context_line":"      grenade_save_data_dir: \"{{ grenade_save_dir }}\""},{"line_number":15,"context_line":"    - export-devstack-journal"},{"line_number":16,"context_line":"    - apache-logs-conf"},{"line_number":17,"context_line":"    - devstack-project-conf"},{"line_number":18,"context_line":"    # capture-system-logs should be the last role before stage-output"}],"source_content_type":"text/x-yaml","patch_set":106,"id":"3fa7e38b_489feab2","line":15,"in_reply_to":"3fa7e38b_a5032775","updated":"2020-01-17 09:09:12.000000000","message":"Uhm, I\u0027m still not sure how that change and redefining devstack_base_dir are connected.","commit_id":"9c54407533a8cb633d8868b877e76730a54aa900"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"6a9258109a01918938ae325f4ef5fd66790352d4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        \u0027old\u0027: \"{{ devstack_bases.logs_old }}\""},{"line_number":13,"context_line":"        \u0027new\u0027: \"{{ devstack_bases.logs_new }}\""},{"line_number":14,"context_line":"      grenade_save_data_dir: \"{{ grenade_save_dir }}\""},{"line_number":15,"context_line":"    - export-devstack-journal"},{"line_number":16,"context_line":"    - apache-logs-conf"},{"line_number":17,"context_line":"    - devstack-project-conf"},{"line_number":18,"context_line":"    # capture-system-logs should be the last role before stage-output"}],"source_content_type":"text/x-yaml","patch_set":106,"id":"3fa7e38b_a5032775","line":15,"in_reply_to":"3fa7e38b_d84f2bbd","updated":"2020-01-17 08:44:21.000000000","message":"The change itself is just about removing the gz extension. I would argue that the change itself is needed regardless of https://opendev.org/openstack/devstack/commit/d02fa6f856ac5951b8a879c23b57d5a752f28918","commit_id":"9c54407533a8cb633d8868b877e76730a54aa900"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"38609e4d9e38f01675b3e1bd2a770ed328ef132f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        \u0027old\u0027: \"{{ devstack_bases.logs_old }}\""},{"line_number":13,"context_line":"        \u0027new\u0027: \"{{ devstack_bases.logs_new }}\""},{"line_number":14,"context_line":"      grenade_save_data_dir: \"{{ grenade_save_dir }}\""},{"line_number":15,"context_line":"    - export-devstack-journal"},{"line_number":16,"context_line":"    - apache-logs-conf"},{"line_number":17,"context_line":"    - devstack-project-conf"},{"line_number":18,"context_line":"    # capture-system-logs should be the last role before stage-output"}],"source_content_type":"text/x-yaml","patch_set":106,"id":"3fa7e38b_4a435a6c","line":15,"in_reply_to":"3fa7e38b_efd498be","updated":"2020-01-17 16:58:28.000000000","message":"I see, thanks. I don\u0027t seem to see the new files though O.o","commit_id":"9c54407533a8cb633d8868b877e76730a54aa900"}],"playbooks/pre.yaml":[{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"2046cd47f1c935bc73510f7ea32f71da043aa3bf","unresolved":false,"context_lines":[{"line_number":24,"context_line":"      devstack_sources_branch: \"{{ grenade_from_branch }}\""},{"line_number":25,"context_line":"    # NOTE(andreaf) Grenade pullup jobs migrate from a stable branch to"},{"line_number":26,"context_line":"    # the current patch(es). Zuul prepares all repos checked out to the right"},{"line_number":27,"context_line":"    # refspec to include all the right patchesm, so we should re-use that,"},{"line_number":28,"context_line":"    # and not specify any \"devstack_sources_branch\", unless a grenade_to_branch"},{"line_number":29,"context_line":"    # is set."},{"line_number":30,"context_line":"    - role: setup-devstack-source-dirs"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"bf659307_a2f55485","line":27,"range":{"start_line":27,"start_character":39,"end_line":27,"end_character":47},"updated":"2018-03-28 12:10:45.000000000","message":"nit: patches","commit_id":"65ae07cedb4bf5e18b76cf5307cd2dd404e0bcf7"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"2046cd47f1c935bc73510f7ea32f71da043aa3bf","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      devstack_base_dir: \"{{ devstack_bases.old }}\""},{"line_number":36,"context_line":"    - role: setup-devstack-log-dir"},{"line_number":37,"context_line":"      devstack_base_dir: \"{{ devstack_bases.new }}\""},{"line_number":38,"context_line":"    - role: start-fresh-logging"},{"line_number":39,"context_line":"      devstack_base_dir: \"{{ devstack_bases.old }}\""},{"line_number":40,"context_line":"    # Write devstack configuration for old and new (the same!)"},{"line_number":41,"context_line":"    - role: write-devstack-local-conf"},{"line_number":42,"context_line":"      devstack_base_dir: \"{{ devstack_bases.old }}\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"bf659307_62441cb8","line":39,"range":{"start_line":38,"start_character":6,"end_line":39,"end_character":51},"updated":"2018-03-28 12:10:45.000000000","message":"Should you comment why you are only calling this on one of the dirs only?\n\nFor clarity purposes, I think","commit_id":"65ae07cedb4bf5e18b76cf5307cd2dd404e0bcf7"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"2046cd47f1c935bc73510f7ea32f71da043aa3bf","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      devstack_base_dir: \"{{ devstack_bases.old }}\""},{"line_number":43,"context_line":"    - role: write-devstack-local-conf"},{"line_number":44,"context_line":"      devstack_base_dir: \"{{ devstack_bases.new }}\""},{"line_number":45,"context_line":"    - role: setup-devstack-cache"},{"line_number":46,"context_line":"      devstack_base_dir: \"{{ devstack_bases.old }}\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"bf659307_0215209c","line":46,"range":{"start_line":45,"start_character":1,"end_line":46,"end_character":51},"updated":"2018-03-28 12:10:45.000000000","message":"same as L38","commit_id":"65ae07cedb4bf5e18b76cf5307cd2dd404e0bcf7"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"6b2744ce591e3f2769af38e4856b29c151b09f58","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      devstack_base_dir: \"{{ devstack_bases.old }}\""},{"line_number":43,"context_line":"    - role: write-devstack-local-conf"},{"line_number":44,"context_line":"      devstack_base_dir: \"{{ devstack_bases.new }}\""},{"line_number":45,"context_line":"    - role: setup-devstack-cache"},{"line_number":46,"context_line":"      devstack_base_dir: \"{{ devstack_bases.old }}\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3f79a3b5_8305d6c3","line":46,"range":{"start_line":45,"start_character":1,"end_line":46,"end_character":51},"in_reply_to":"bf659307_0215209c","updated":"2018-09-13 16:48:59.000000000","message":"Andrea, just to be sure: is it because the caches are relevant only for the installation which happens only from old?","commit_id":"65ae07cedb4bf5e18b76cf5307cd2dd404e0bcf7"}],"roles/configure-grenade-branches/defaults/main.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1af466f9dcbd4f2f15b4f1c6f276b07ec1998d5d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"grenade_from_branch: stable/train"},{"line_number":3,"context_line":"grenade_to_branch: master"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_1ee833b2","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":25},"updated":"2020-04-25 15:12:15.000000000","message":"so these are the ones we wish to update on cutting the branch off?","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"49cb5a93cc097fbe43678b42f64b8053d5167c54","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"grenade_from_branch: stable/train"},{"line_number":3,"context_line":"grenade_to_branch: master"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_de624b3e","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":25},"in_reply_to":"1f493fa4_1ee833b2","updated":"2020-04-25 15:35:55.000000000","message":"Correct, the only place which should be updated.\n\nIt is documented in roles/configure-grenade-branches/README.rst","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"}],"roles/prepare-grenade-logs/defaults/main.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"390c8b213683013377d9ebc4da16a952f5a65324","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  - logs/devstacklog.txt.summary"},{"line_number":9,"context_line":"  - logs/dstat-csv.log"},{"line_number":10,"context_line":"  - tempest/etc/tempest.conf"},{"line_number":11,"context_line":"  - tempest/etc/accounts/tempest.conf"},{"line_number":12,"context_line":"  - tempest/tempest.log"}],"source_content_type":"text/x-yaml","patch_set":113,"id":"1f493fa4_6ed3a839","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":37},"updated":"2020-04-23 23:16:38.000000000","message":"there is no separate tempest.conf for pre-provisioned accounts\n\n- tempest/etc/accounts.yaml","commit_id":"1ede47438c5999717feeb5eb6cf59c60e2994d0c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"35f8b4cf9272ad544517bdc11a7f2ef5f927573f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  - logs/devstacklog.txt.summary"},{"line_number":9,"context_line":"  - logs/dstat-csv.log"},{"line_number":10,"context_line":"  - tempest/etc/tempest.conf"},{"line_number":11,"context_line":"  - tempest/etc/accounts/tempest.conf"},{"line_number":12,"context_line":"  - tempest/tempest.log"}],"source_content_type":"text/x-yaml","patch_set":113,"id":"1f493fa4_ae46507b","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":37},"in_reply_to":"1f493fa4_2e81a090","updated":"2020-04-23 23:47:32.000000000","message":"Ups, sorry, I\u0027ve got it in the meantime. New patch coming.","commit_id":"1ede47438c5999717feeb5eb6cf59c60e2994d0c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"7afc92673503bd7a7e8b5e4a177a40c92917169e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  - logs/devstacklog.txt.summary"},{"line_number":9,"context_line":"  - logs/dstat-csv.log"},{"line_number":10,"context_line":"  - tempest/etc/tempest.conf"},{"line_number":11,"context_line":"  - tempest/etc/accounts/tempest.conf"},{"line_number":12,"context_line":"  - tempest/tempest.log"}],"source_content_type":"text/x-yaml","patch_set":113,"id":"1f493fa4_6ef0c868","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":37},"in_reply_to":"1f493fa4_6ed3a839","updated":"2020-04-23 23:35:34.000000000","message":"So should it be captured only for old? But it does not hurt to have it here (if the file does not exist in a branch, it is simply skipped), and I believe it\u0027s better to keep all tempest logs file in the same place, maybe.\n\nOtherwise I will add it to vars.zuul_copy_output","commit_id":"1ede47438c5999717feeb5eb6cf59c60e2994d0c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fd98e9fe3c967808381c24f2e3dd1eaa20266cdb","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  - logs/devstacklog.txt.summary"},{"line_number":9,"context_line":"  - logs/dstat-csv.log"},{"line_number":10,"context_line":"  - tempest/etc/tempest.conf"},{"line_number":11,"context_line":"  - tempest/etc/accounts/tempest.conf"},{"line_number":12,"context_line":"  - tempest/tempest.log"}],"source_content_type":"text/x-yaml","patch_set":113,"id":"1f493fa4_2e81a090","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":37},"in_reply_to":"1f493fa4_6ef0c868","updated":"2020-04-23 23:44:56.000000000","message":"I mean there is no tempest.conf under etc/accounts. you want to copy tempest/etc/accounts.yaml here","commit_id":"1ede47438c5999717feeb5eb6cf59c60e2994d0c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"02fb07f87d00dfd47c1f441b6e5328ccb7bb6549","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  - logs/devstacklog.txt.summary"},{"line_number":9,"context_line":"  - logs/dstat-csv.log"},{"line_number":10,"context_line":"  - tempest/etc/tempest.conf"},{"line_number":11,"context_line":"  - tempest/etc/accounts/tempest.conf"},{"line_number":12,"context_line":"  - tempest/tempest.log"}],"source_content_type":"text/x-yaml","patch_set":113,"id":"1f493fa4_9173b5b1","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":37},"in_reply_to":"1f493fa4_ae46507b","updated":"2020-04-23 23:55:22.000000000","message":"cool, thanks. waiting for result and we are good to go.","commit_id":"1ede47438c5999717feeb5eb6cf59c60e2994d0c"}],"roles/prepare-grenade-logs/tasks/main.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1af466f9dcbd4f2f15b4f1c6f276b07ec1998d5d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    dest: \"{{ grenade_config_dir }}/grenade_{{ item }}\""},{"line_number":6,"context_line":"  loop:"},{"line_number":7,"context_line":"    - localrc"},{"line_number":8,"context_line":"    - pluginrc"},{"line_number":9,"context_line":"  ignore_errors: True"},{"line_number":10,"context_line":"- name: Create a link with a better name to the grenade save directory"},{"line_number":11,"context_line":"  file:"},{"line_number":12,"context_line":"    src: \"{{ grenade_devstack_shared_dir }}/save\""},{"line_number":13,"context_line":"    dest: \"{{ grenade_save_data_dir }}\""},{"line_number":14,"context_line":"    state: link"},{"line_number":15,"context_line":"  ignore_errors: True"},{"line_number":16,"context_line":"- name: Create the save directories"},{"line_number":17,"context_line":"  file:"},{"line_number":18,"context_line":"    path: \"{{ grenade_devstack_data_log_dirs[item] }}\""},{"line_number":19,"context_line":"    state: directory"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_bee01fce","line":16,"range":{"start_line":8,"start_character":8,"end_line":16,"end_character":28},"updated":"2020-04-25 15:12:15.000000000","message":"lack of spacing between tasks hurts","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"49cb5a93cc097fbe43678b42f64b8053d5167c54","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    dest: \"{{ grenade_config_dir }}/grenade_{{ item }}\""},{"line_number":6,"context_line":"  loop:"},{"line_number":7,"context_line":"    - localrc"},{"line_number":8,"context_line":"    - pluginrc"},{"line_number":9,"context_line":"  ignore_errors: True"},{"line_number":10,"context_line":"- name: Create a link with a better name to the grenade save directory"},{"line_number":11,"context_line":"  file:"},{"line_number":12,"context_line":"    src: \"{{ grenade_devstack_shared_dir }}/save\""},{"line_number":13,"context_line":"    dest: \"{{ grenade_save_data_dir }}\""},{"line_number":14,"context_line":"    state: link"},{"line_number":15,"context_line":"  ignore_errors: True"},{"line_number":16,"context_line":"- name: Create the save directories"},{"line_number":17,"context_line":"  file:"},{"line_number":18,"context_line":"    path: \"{{ grenade_devstack_data_log_dirs[item] }}\""},{"line_number":19,"context_line":"    state: directory"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_9e772303","line":16,"range":{"start_line":8,"start_character":8,"end_line":16,"end_character":28},"in_reply_to":"1f493fa4_bee01fce","updated":"2020-04-25 15:35:55.000000000","message":"Done","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c69597c9dc6ac949e54d1d1289bb7c9e2820db55","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    remote_src: yes"},{"line_number":25,"context_line":"    src: \"{{ grenade_devstack_shared_dir }}/{{ item.0 }}/{{ item.1 }}\""},{"line_number":26,"context_line":"    dest: \"{{ grenade_devstack_data_log_dirs[item.0] }}/{{ item.1|basename }}\""},{"line_number":27,"context_line":"  loop: \"{{ [\u0027old\u0027, \u0027new\u0027]|product(grenade_devstack_saved_files_default + grenade_devstack_saved_files)|list }}\""},{"line_number":28,"context_line":"  ignore_errors: True"},{"line_number":29,"context_line":"  no_log: True"}],"source_content_type":"text/x-yaml","patch_set":116,"id":"1f493fa4_6520d1b1","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":1},"updated":"2020-04-24 19:54:04.000000000","message":"there duplicate dir entry if we are copying the dir here.s This is few cases when we will be copying the dir like ironic so let\u0027s go wwih this and later we can make it better. \n\n- https://zuul.opendev.org/t/openstack/build/ce6c10bcb02a491eb0b51c463fab264d/log/job-output.txt#39100","commit_id":"73ff905ce1520ff4d2976db6eaf84cf5013695e5"}],"roles/run-grenade/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6858c9c88f3333b515f535a31b45c3ed6769c784","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      echo \"*** FINISHED ***\""},{"line_number":7,"context_line":"      exit $rc"},{"line_number":8,"context_line":"  environment:"},{"line_number":9,"context_line":"    GRENADE_DEVSTACK_EXTERNAL: True"},{"line_number":10,"context_line":"  args:"},{"line_number":11,"context_line":"    chdir: \"{{grenade_base_dir}}/grenade\""},{"line_number":12,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":105,"id":"3fa7e38b_d4895d1e","line":9,"updated":"2019-12-17 22:10:54.000000000","message":"I\u0027m not sure I understand this change to grenade. I\u0027ve double checked with the devstack-gate grenade driver and I believe it triggers grenade.sh on the primary node to do both the old and new sides of things.\n\nThat said it did farm out the old subnode install to devstack since the way grenade multinode jobs are set up is to only upgrade the primary and leave the old subnode in place to ensure old compute/etc can work with new controller code.\n\nI don\u0027t think this is necessarily wrong but it might help to explain why this choice was made for the zuulv3 version. Maybe a comment here?","commit_id":"51551d854ef557c3f555e9f415d92d65925b3507"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"20cb0b8681f9e1a3f0777f99e9beaf38a5f1d92e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      echo \"*** FINISHED ***\""},{"line_number":7,"context_line":"      exit $rc"},{"line_number":8,"context_line":"  environment:"},{"line_number":9,"context_line":"    GRENADE_DEVSTACK_EXTERNAL: True"},{"line_number":10,"context_line":"  args:"},{"line_number":11,"context_line":"    chdir: \"{{grenade_base_dir}}/grenade\""},{"line_number":12,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":105,"id":"3fa7e38b_4bbb4b0e","line":9,"in_reply_to":"3fa7e38b_d4895d1e","updated":"2019-12-23 15:07:43.000000000","message":"The idea is to reduce the duplication. We already have a proven method for driving devstack, which is made by the roles defined inside devstack.git. So we can just use it. \nThis is the reason for https://review.opendev.org/#/c/637265/.\nI suspect that going forward we could reduce grenade.sh just to the upgrade part. Separation of concerns, less clutter around.","commit_id":"51551d854ef557c3f555e9f415d92d65925b3507"}],"roles/write-grenade-conf/README.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2faf020e79afb108fee3c142a567cd94041d9f0a","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"   A list of grenade plugins that should be deployed."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":".. zuul:rolevar:: grenade_plugins"},{"line_number":37,"context_line":"   :default: 2"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"   The concurrency level for the tempest tests executed"},{"line_number":40,"context_line":"   by grenade."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. zuul:rolevar:: grenade_plugins"},{"line_number":43,"context_line":"   :default: 2"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"   The concurrency level for the tempest tests executed"},{"line_number":46,"context_line":"   by grenade."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":".. zuul:rolevar:: grenade_plugins"},{"line_number":49,"context_line":"   :default: 1200"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"   The timeout for the tests executed by grenade."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. zuul:rolevar:: grenade_to_branch"},{"line_number":54,"context_line":"   :default: master"}],"source_content_type":"text/x-rst","patch_set":106,"id":"3fa7e38b_772248bc","line":51,"range":{"start_line":36,"start_character":0,"end_line":51,"end_character":49},"updated":"2020-01-08 17:03:25.000000000","message":"this looks like a copy paste error i assume you meant to update the variable","commit_id":"9c54407533a8cb633d8868b877e76730a54aa900"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"0f44633a9d246e11fcf02323628d3590df0318ed","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"   A list of grenade plugins that should be deployed."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":".. zuul:rolevar:: grenade_plugins"},{"line_number":37,"context_line":"   :default: 2"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"   The concurrency level for the tempest tests executed"},{"line_number":40,"context_line":"   by grenade."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. zuul:rolevar:: grenade_plugins"},{"line_number":43,"context_line":"   :default: 2"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"   The concurrency level for the tempest tests executed"},{"line_number":46,"context_line":"   by grenade."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":".. zuul:rolevar:: grenade_plugins"},{"line_number":49,"context_line":"   :default: 1200"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"   The timeout for the tests executed by grenade."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. zuul:rolevar:: grenade_to_branch"},{"line_number":54,"context_line":"   :default: master"}],"source_content_type":"text/x-rst","patch_set":106,"id":"3fa7e38b_45403360","line":51,"range":{"start_line":36,"start_character":0,"end_line":51,"end_character":49},"in_reply_to":"3fa7e38b_772248bc","updated":"2020-01-17 08:54:41.000000000","message":"Yes, definitely, thanks.","commit_id":"9c54407533a8cb633d8868b877e76730a54aa900"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9948f385120ff1f96769356a4bf787dc049b1003","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"   The timeout (in seconds) for each test executed by grenade."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. zuul:rolevar:: grenade_to_branch"},{"line_number":48,"context_line":"   :default: master"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"   The target branch for the upgrade."}],"source_content_type":"text/x-rst","patch_set":110,"id":"1fa4df85_8b05a848","line":50,"range":{"start_line":47,"start_character":0,"end_line":50,"end_character":37},"updated":"2020-03-03 18:29:38.000000000","message":"here. we can define grenade_from_branch also here and default value to stable/train in default.yaml\n\nalso please add NOTES:\n\n# Updating grenade_from_branch \u0026 grenade_from_branch default # values on every new release of \n# OpenStack.\n# grenade job is setup for pullup testing by default. If you # want to do forward upgrade testing then you \n# need to override these two variables with appropriate\n# values in zuul job. for example:\n\n# For stable/stein forward testing:\n# grenade_from_branch\u003dstable/stein\n# grenade_to_branch\u003dstable/train\n\n# For stable/train forward testing (if stable/train is most recent stable branch):\n# grenade_from_branch\u003dstable/train\n# grenade_to_branch\u003dmaster","commit_id":"e1f56110dc4e908e48fece114ab450718b104acd"}],"roles/write-grenade-conf/defaults/main.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9948f385120ff1f96769356a4bf787dc049b1003","unresolved":false,"context_lines":[{"line_number":4,"context_line":"grenade_plugins: {}"},{"line_number":5,"context_line":"grenade_tempest_concurrency: 2"},{"line_number":6,"context_line":"grenade_test_timeout: 1200"},{"line_number":7,"context_line":"grenade_to_branch: master"}],"source_content_type":"text/x-yaml","patch_set":110,"id":"1fa4df85_6b8dccd1","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":25},"updated":"2020-03-03 18:29:38.000000000","message":"here we can add grenade_from_branch with default to stable/train.\n\n\ngrenade_from_branch: \"{{ grenade_from_branch | default(stable/train) }}\"\ngrenade_to_branch: \"{{ grenade_to_branch | default(master) }}\"","commit_id":"e1f56110dc4e908e48fece114ab450718b104acd"}],"roles/write-grenade-conf/templates/localrc.j2":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"00db6aaf67ad8e5ad56b31254c53a33951e41ca4","unresolved":false,"context_lines":[{"line_number":6,"context_line":"TARGET_RELEASE_DIR\u003d{{ base_dir }}/$TARGET_RELEASE"},{"line_number":7,"context_line":"TARGET_DEVSTACK_DIR\u003d$TARGET_RELEASE_DIR/devstack"},{"line_number":8,"context_line":"TARGET_DEVSTACK_BRANCH\u003d{{ grenade_to_branch }}"},{"line_number":9,"context_line":"TARGET_RUN_SMOKE\u003dFalse"},{"line_number":10,"context_line":"SAVE_DIR\u003d$BASE_RELEASE_DIR/save"},{"line_number":11,"context_line":"TEMPEST_CONCURRENCY\u003d{{ grenade_tempest_concurrency }}"},{"line_number":12,"context_line":"export OS_TEST_TIMEOUT\u003d{{ grenade_test_timeout }}"}],"source_content_type":"text/x-jinja2","patch_set":107,"id":"1fa4df85_711188ac","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":22},"updated":"2020-02-27 02:19:57.000000000","message":"+1","commit_id":"f586cd11731cf763a07694e468a983b45b90bb1b"}]}