)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"295818f0bae67fb81231e71f3b1c4f8a2f966e54","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support for upgrading neutron"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Testing patch for debugging issue with open handler on unmounted loop"},{"line_number":10,"context_line":"device"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-bug: #1235149"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":43,"id":"AAAAWH%2F%2BBmY%3D","line":9,"updated":"2014-03-31 13:29:23.000000000","message":"I must get rid of this too, it\u0027s not true anymore.","commit_id":"cdf6ba2d9be87d7c9ae3945197398bb0654df398"}],"grenade.sh":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3b811a41f35ec14b701d411d099653d7173e9d47","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Source params"},{"line_number":30,"context_line":"source $GRENADE_DIR/grenaderc"},{"line_number":31,"context_line":"source $BASE_DEVSTACK_DIR/stackrc"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"RUN_BASE\u003d$(trueorfalse True $RUN_BASE)"},{"line_number":34,"context_line":"RUN_TARGET\u003d$(trueorfalse True $RUN_TARGET)"}],"source_content_type":"text/x-sh","patch_set":43,"id":"AAAAWH%2F%2BAUA%3D","line":31,"updated":"2014-03-31 15:50:16.000000000","message":"I don\u0027t think this should be here, what is only coming out of this that we need to address in grenade?","commit_id":"cdf6ba2d9be87d7c9ae3945197398bb0654df398"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"90eb9dcfd1f0b34331bfbbe11e412ab13fa0101c","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Source params"},{"line_number":30,"context_line":"source $GRENADE_DIR/grenaderc"},{"line_number":31,"context_line":"source $BASE_DEVSTACK_DIR/stackrc"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"RUN_BASE\u003d$(trueorfalse True $RUN_BASE)"},{"line_number":34,"context_line":"RUN_TARGET\u003d$(trueorfalse True $RUN_TARGET)"}],"source_content_type":"text/x-sh","patch_set":43,"id":"AAAAWH%2F%2BAM4%3D","line":31,"in_reply_to":"AAAAWH%2F%2BAUA%3D","updated":"2014-03-31 16:09:54.000000000","message":"Done","commit_id":"cdf6ba2d9be87d7c9ae3945197398bb0654df398"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"808d499e448b669075ee4b2b1b679ceb2c629278","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    $GRENADE_DIR/upgrade-glance || die $LINENO \"Failure in upgrade-glance\""},{"line_number":261,"context_line":"    stop $STOP upgrade-glance 250"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    if is_service_enabled neutron; then"},{"line_number":264,"context_line":"        # Add target services for sanity check"},{"line_number":265,"context_line":"        TARGET_SERVICES\u003d\"${TARGET_SERVICES} neutron-server neutron-l3-agent neutron-dhcp-agent neutron-metadata-agent neutron-openvswitch-agent\""},{"line_number":266,"context_line":"        # Upgrade Neutron"}],"source_content_type":"text/x-sh","patch_set":46,"id":"AAAAWH%2F9%2BT0%3D","line":263,"updated":"2014-03-31 20:25:28.000000000","message":"don\u0027t make this conditional, always run.","commit_id":"5f2c7278e646b154f8acc67c5bbba13db152eafc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0d44a6758d85c4c01b767ff81dbb052fa08ee08c","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    $GRENADE_DIR/upgrade-glance || die $LINENO \"Failure in upgrade-glance\""},{"line_number":261,"context_line":"    stop $STOP upgrade-glance 250"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    if is_service_enabled neutron; then"},{"line_number":264,"context_line":"        # Add target services for sanity check"},{"line_number":265,"context_line":"        TARGET_SERVICES\u003d\"${TARGET_SERVICES} neutron-server neutron-l3-agent neutron-dhcp-agent neutron-metadata-agent neutron-openvswitch-agent\""},{"line_number":266,"context_line":"        # Upgrade Neutron"}],"source_content_type":"text/x-sh","patch_set":46,"id":"AAAAWH%2F99%2BQ%3D","line":263,"in_reply_to":"AAAAWH%2F9%2BT0%3D","updated":"2014-03-31 21:06:23.000000000","message":"Done","commit_id":"5f2c7278e646b154f8acc67c5bbba13db152eafc"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"808d499e448b669075ee4b2b1b679ceb2c629278","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    if is_service_enabled neutron; then"},{"line_number":264,"context_line":"        # Add target services for sanity check"},{"line_number":265,"context_line":"        TARGET_SERVICES\u003d\"${TARGET_SERVICES} neutron-server neutron-l3-agent neutron-dhcp-agent neutron-metadata-agent neutron-openvswitch-agent\""},{"line_number":266,"context_line":"        # Upgrade Neutron"},{"line_number":267,"context_line":"        echo_summary \"Running upgrade-neutron\""},{"line_number":268,"context_line":"        $GRENADE_DIR/upgrade-neutron || die $LINENO \"Failure in upgrade-neutron\""}],"source_content_type":"text/x-sh","patch_set":46,"id":"AAAAWH%2F9%2BTs%3D","line":265,"updated":"2014-03-31 20:25:28.000000000","message":"don\u0027t override","commit_id":"5f2c7278e646b154f8acc67c5bbba13db152eafc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0d44a6758d85c4c01b767ff81dbb052fa08ee08c","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    if is_service_enabled neutron; then"},{"line_number":264,"context_line":"        # Add target services for sanity check"},{"line_number":265,"context_line":"        TARGET_SERVICES\u003d\"${TARGET_SERVICES} neutron-server neutron-l3-agent neutron-dhcp-agent neutron-metadata-agent neutron-openvswitch-agent\""},{"line_number":266,"context_line":"        # Upgrade Neutron"},{"line_number":267,"context_line":"        echo_summary \"Running upgrade-neutron\""},{"line_number":268,"context_line":"        $GRENADE_DIR/upgrade-neutron || die $LINENO \"Failure in upgrade-neutron\""}],"source_content_type":"text/x-sh","patch_set":46,"id":"AAAAWH%2F99%2BE%3D","line":265,"in_reply_to":"AAAAWH%2F9%2BTs%3D","updated":"2014-03-31 21:06:23.000000000","message":"Done","commit_id":"5f2c7278e646b154f8acc67c5bbba13db152eafc"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"ed17e2e43a03f8cbfbce9fbe6d83571faabc2ef5","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        mysqldump -uroot -p$MYSQL_PASSWORD $db \u003e$SAVE_DIR/$db.sql.$TARGET_RELEASE"},{"line_number":315,"context_line":"    done"},{"line_number":316,"context_line":"    neutron_db_name\u003d$(mysql -uroot -p$MYSQL_PASSWORD -e \"show databases;\" | grep neutron || :)"},{"line_number":317,"context_line":"    if [ \"x$neutron_db_name\" !\u003d \"x\" ]; then"},{"line_number":318,"context_line":"        mysqldump -uroot -p$MYSQL_PASSWORD $neutron_db_name \u003e$SAVE_DIR/neutron.sql.$BASE_RELEASE"},{"line_number":319,"context_line":"    fi"},{"line_number":320,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":53,"id":"AAAAWH%2F9jq8%3D","line":317,"updated":"2014-04-03 18:04:43.000000000","message":"Please use -z or -n instead of this old style","commit_id":"e636f48f5edbf7fa325b7fe6758212967724d54a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d14fe8873ebc12e4eb7bc18a828a680b2f453843","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        mysqldump -uroot -p$MYSQL_PASSWORD $db \u003e$SAVE_DIR/$db.sql.$TARGET_RELEASE"},{"line_number":315,"context_line":"    done"},{"line_number":316,"context_line":"    neutron_db_name\u003d$(mysql -uroot -p$MYSQL_PASSWORD -e \"show databases;\" | grep neutron || :)"},{"line_number":317,"context_line":"    if [ \"x$neutron_db_name\" !\u003d \"x\" ]; then"},{"line_number":318,"context_line":"        mysqldump -uroot -p$MYSQL_PASSWORD $neutron_db_name \u003e$SAVE_DIR/neutron.sql.$BASE_RELEASE"},{"line_number":319,"context_line":"    fi"},{"line_number":320,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":53,"id":"AAAAWH%2F9jnk%3D","line":317,"in_reply_to":"AAAAWH%2F9jq8%3D","updated":"2014-04-03 18:09:29.000000000","message":"Done","commit_id":"e636f48f5edbf7fa325b7fe6758212967724d54a"}],"grenaderc":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"8fce2e0b522cbca7ef23f0b3a187caf2cd188c10","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# TODO(sdague): make these complete afterwards"},{"line_number":82,"context_line":"# The services we\u0027d expect at each release"},{"line_number":83,"context_line":"BASE_SERVICES\u003d\"nova-api nova-conductor nova-compute keystone glance-api cinder-api quantum-server quantum-l3-agent quantum-dhcp-agent quantum-metadata-agent quantum-openvswitch-agent\""},{"line_number":84,"context_line":"TARGET_SERVICES\u003d\"nova-api nova-conductor nova-compute keystone glance-api cinder-api\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Need this for global requirements"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAUH%2F%2FSD0%3D","line":83,"updated":"2014-01-15 14:42:16.000000000","message":"we should leave the defaults for the nova scenario, in the gate we\u0027ll set the right services.","commit_id":"1c489664c41d59db7b9a2297e66dc00243dca573"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c5dc424763cb503af08851181c0d128e800a5c59","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# TODO(sdague): make these complete afterwards"},{"line_number":82,"context_line":"# The services we\u0027d expect at each release"},{"line_number":83,"context_line":"BASE_SERVICES\u003d\"nova-api nova-conductor nova-compute keystone glance-api cinder-api quantum-server quantum-l3-agent quantum-dhcp-agent quantum-metadata-agent quantum-openvswitch-agent\""},{"line_number":84,"context_line":"TARGET_SERVICES\u003d\"nova-api nova-conductor nova-compute keystone glance-api cinder-api\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Need this for global requirements"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAUH%2F%2FRJs%3D","line":83,"in_reply_to":"AAAAUH%2F%2FSD0%3D","updated":"2014-01-15 17:23:06.000000000","message":"Done","commit_id":"1c489664c41d59db7b9a2297e66dc00243dca573"}],"save-state":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"ed17e2e43a03f8cbfbce9fbe6d83571faabc2ef5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    mysqldump -uroot -p$MYSQL_PASSWORD $db \u003e$SAVE_DIR/$db.sql.$BASE_RELEASE"},{"line_number":46,"context_line":"done"},{"line_number":47,"context_line":"neutron_db_name\u003d$(mysql -uroot -p$MYSQL_PASSWORD -e \"show databases;\" | grep neutron || :)"},{"line_number":48,"context_line":"if [ \"x$neutron_db_name\" !\u003d \"x\" ]; then"},{"line_number":49,"context_line":"    mysqldump -uroot -p$MYSQL_PASSWORD $neutron_db_name \u003e$SAVE_DIR/neutron.sql.$BASE_RELEASE"},{"line_number":50,"context_line":"fi"},{"line_number":51,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":53,"id":"AAAAWH%2F9jrQ%3D","line":48,"updated":"2014-04-03 18:04:43.000000000","message":"This is an old comparison style, please use -z or -n instead, we don\u0027t need to worry about old /bin/sh.","commit_id":"e636f48f5edbf7fa325b7fe6758212967724d54a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d14fe8873ebc12e4eb7bc18a828a680b2f453843","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    mysqldump -uroot -p$MYSQL_PASSWORD $db \u003e$SAVE_DIR/$db.sql.$BASE_RELEASE"},{"line_number":46,"context_line":"done"},{"line_number":47,"context_line":"neutron_db_name\u003d$(mysql -uroot -p$MYSQL_PASSWORD -e \"show databases;\" | grep neutron || :)"},{"line_number":48,"context_line":"if [ \"x$neutron_db_name\" !\u003d \"x\" ]; then"},{"line_number":49,"context_line":"    mysqldump -uroot -p$MYSQL_PASSWORD $neutron_db_name \u003e$SAVE_DIR/neutron.sql.$BASE_RELEASE"},{"line_number":50,"context_line":"fi"},{"line_number":51,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":53,"id":"AAAAWH%2F9jng%3D","line":48,"in_reply_to":"AAAAWH%2F9jrQ%3D","updated":"2014-04-03 18:09:29.000000000","message":"Done","commit_id":"e636f48f5edbf7fa325b7fe6758212967724d54a"}],"stop-base":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"8fce2e0b522cbca7ef23f0b3a187caf2cd188c10","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    # Unplumb the Swift data"},{"line_number":68,"context_line":"sudo umount ${DATA_DIR}/swift/drives/images/swift.img || /bin/true"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"if is_service_enabled quantum; then"},{"line_number":71,"context_line":"    # Kill dnsmasq processes"},{"line_number":72,"context_line":"    sudo kill -9 $(ps auxw | grep -v awk | awk \u0027/quantum-dhcp-agent/ { print $2 }\u0027)"},{"line_number":73,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAUH%2F%2FSDU%3D","line":70,"updated":"2014-01-15 14:42:16.000000000","message":"is there a more graceful way handle this in devstack instead? A kill -9 isn\u0027t very nice as part of the upgrade.","commit_id":"1c489664c41d59db7b9a2297e66dc00243dca573"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c5dc424763cb503af08851181c0d128e800a5c59","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    # Unplumb the Swift data"},{"line_number":68,"context_line":"sudo umount ${DATA_DIR}/swift/drives/images/swift.img || /bin/true"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"if is_service_enabled quantum; then"},{"line_number":71,"context_line":"    # Kill dnsmasq processes"},{"line_number":72,"context_line":"    sudo kill -9 $(ps auxw | grep -v awk | awk \u0027/quantum-dhcp-agent/ { print $2 }\u0027)"},{"line_number":73,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAUH%2F%2FRGc%3D","line":70,"in_reply_to":"AAAAUH%2F%2FSDU%3D","updated":"2014-01-15 17:23:06.000000000","message":"Done","commit_id":"1c489664c41d59db7b9a2297e66dc00243dca573"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"808d499e448b669075ee4b2b1b679ceb2c629278","unresolved":false,"context_lines":[{"line_number":25,"context_line":"source $BASE_DEVSTACK_DIR/stackrc"},{"line_number":26,"context_line":"DATA_DIR\u003d${STACK_ROOT}/data"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"TOP_DIR\u003d$BASE_DEVSTACK_DIR"},{"line_number":29,"context_line":"# We need base DevStack functions for this"},{"line_number":30,"context_line":"source $BASE_DEVSTACK_DIR/functions"},{"line_number":31,"context_line":"source $BASE_DEVSTACK_DIR/lib/keystone"}],"source_content_type":"application/octet-stream","patch_set":46,"id":"AAAAWH%2F9%2Bkw%3D","line":28,"updated":"2014-03-31 20:25:28.000000000","message":"I don\u0027t think we need this","commit_id":"5f2c7278e646b154f8acc67c5bbba13db152eafc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0d44a6758d85c4c01b767ff81dbb052fa08ee08c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"source $BASE_DEVSTACK_DIR/stackrc"},{"line_number":26,"context_line":"DATA_DIR\u003d${STACK_ROOT}/data"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"TOP_DIR\u003d$BASE_DEVSTACK_DIR"},{"line_number":29,"context_line":"# We need base DevStack functions for this"},{"line_number":30,"context_line":"source $BASE_DEVSTACK_DIR/functions"},{"line_number":31,"context_line":"source $BASE_DEVSTACK_DIR/lib/keystone"}],"source_content_type":"application/octet-stream","patch_set":46,"id":"AAAAWH%2F9994%3D","line":28,"in_reply_to":"AAAAWH%2F9%2Bkw%3D","updated":"2014-03-31 21:06:23.000000000","message":"Done","commit_id":"5f2c7278e646b154f8acc67c5bbba13db152eafc"}],"upgrade-neutron":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6f4831b5460db81c3e77736d51f5b30d44085e12","unresolved":false,"context_lines":[{"line_number":128,"context_line":"neutron-db-manage --config-file $NEUTRON_CONF --config-file /$Q_PLUGIN_CONF_FILE stamp $BASE_RELEASE"},{"line_number":129,"context_line":"neutron-db-manage --config-file $NEUTRON_CONF --config-file /$Q_PLUGIN_CONF_FILE upgrade $TARGET_RELEASE"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"sudo apt-get install python-qpid"},{"line_number":132,"context_line":"# Start neutron and agents"},{"line_number":133,"context_line":"start_neutron_third_party"},{"line_number":134,"context_line":"start_neutron_service_and_check"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAATn%2F9j0U%3D","line":131,"updated":"2013-12-10 08:54:25.000000000","message":"This is weird, it\u0027s a workaround because qpid package gets lost during upgrade.","commit_id":"87369e056246d9cf6cf672605fdd9c4f4e337af6"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ab197b9d64af760cef9cea56b398b8af29fa24a8","unresolved":false,"context_lines":[{"line_number":109,"context_line":"upgrade_project neutron $GRENADE_DIR $BASE_DEVSTACK_BRANCH"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# Get plugin config paths"},{"line_number":112,"context_line":"neutron_plugin_configure_common"},{"line_number":113,"context_line":"Q_PLUGIN_CONF_FILE\u003d$Q_PLUGIN_CONF_PATH/$Q_PLUGIN_CONF_FILENAME"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"# Migrate DB"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"AAAAU3%2F%2FecI%3D","line":112,"updated":"2014-02-26 12:14:13.000000000","message":"we shouldn\u0027t be doing this in a blanket way, configure operations should not be needed for an upgrade.","commit_id":"53d77b128e85e3c1c9171791be2099ab47b58ec6"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ea553cb8b13f88ce7bad55d3dde3948c32ecceff","unresolved":false,"context_lines":[{"line_number":109,"context_line":"upgrade_project neutron $GRENADE_DIR $BASE_DEVSTACK_BRANCH"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# Get plugin config paths"},{"line_number":112,"context_line":"neutron_plugin_configure_common"},{"line_number":113,"context_line":"Q_PLUGIN_CONF_FILE\u003d$Q_PLUGIN_CONF_PATH/$Q_PLUGIN_CONF_FILENAME"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"# Migrate DB"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"AAAAVX%2F%2Fv1M%3D","line":112,"in_reply_to":"AAAAU3%2F%2FecI%3D","updated":"2014-02-28 16:52:49.000000000","message":"This is harmless - it just gets the Q_PLUGIN_CONF_PATH for neutron-db-manage used later and appends to Q_SERVICE_PLUGIN_CLASSES variable which is not used later anyway.","commit_id":"53d77b128e85e3c1c9171791be2099ab47b58ec6"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"808d499e448b669075ee4b2b1b679ceb2c629278","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Duplicate some setup bits from target DevStack"},{"line_number":58,"context_line":"cd $TARGET_DEVSTACK_DIR"},{"line_number":59,"context_line":"source $TARGET_DEVSTACK_DIR/stackrc"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# From stack.sh"},{"line_number":62,"context_line":"FLOATING_RANGE\u003d${FLOATING_RANGE:-172.24.4.224/28}"}],"source_content_type":"application/octet-stream","patch_set":46,"id":"AAAAWH%2F9%2BTM%3D","line":59,"updated":"2014-03-31 20:25:28.000000000","message":"then exit 0 here if neutron is not enabled","commit_id":"5f2c7278e646b154f8acc67c5bbba13db152eafc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0d44a6758d85c4c01b767ff81dbb052fa08ee08c","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Duplicate some setup bits from target DevStack"},{"line_number":58,"context_line":"cd $TARGET_DEVSTACK_DIR"},{"line_number":59,"context_line":"source $TARGET_DEVSTACK_DIR/stackrc"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# From stack.sh"},{"line_number":62,"context_line":"FLOATING_RANGE\u003d${FLOATING_RANGE:-172.24.4.224/28}"}],"source_content_type":"application/octet-stream","patch_set":46,"id":"AAAAWH%2F999Y%3D","line":59,"in_reply_to":"AAAAWH%2F9%2BTM%3D","updated":"2014-03-31 21:06:23.000000000","message":"I think only BASE_DEVSTACK_DIR contains correct real ENABLED_SERVICES, right?","commit_id":"5f2c7278e646b154f8acc67c5bbba13db152eafc"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"ed17e2e43a03f8cbfbce9fbe6d83571faabc2ef5","unresolved":false,"context_lines":[{"line_number":43,"context_line":"set -o xtrace"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# Upgrade Neutron"},{"line_number":46,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Make sure neutron is available"},{"line_number":49,"context_line":"if $(source $BASE_DEVSTACK_DIR/stackrc; ! is_service_enabled neutron); then"}],"source_content_type":"application/octet-stream","patch_set":53,"id":"AAAAWH%2F9jr4%3D","line":46,"updated":"2014-04-03 18:04:43.000000000","message":"The underscores need to match the length of the line above","commit_id":"e636f48f5edbf7fa325b7fe6758212967724d54a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d14fe8873ebc12e4eb7bc18a828a680b2f453843","unresolved":false,"context_lines":[{"line_number":43,"context_line":"set -o xtrace"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# Upgrade Neutron"},{"line_number":46,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Make sure neutron is available"},{"line_number":49,"context_line":"if $(source $BASE_DEVSTACK_DIR/stackrc; ! is_service_enabled neutron); then"}],"source_content_type":"application/octet-stream","patch_set":53,"id":"AAAAWH%2F9jl8%3D","line":46,"in_reply_to":"AAAAWH%2F9jr4%3D","updated":"2014-04-03 18:09:29.000000000","message":"Done","commit_id":"e636f48f5edbf7fa325b7fe6758212967724d54a"}],"upgrade-swift":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"3873417560e9bd6506a7c1b4e041e21ccd224784","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"# Mount backing disk"},{"line_number":97,"context_line":"if ! egrep -q ${SWIFT_DATA_DIR}/drives/sdb1 /proc/mounts; then"},{"line_number":98,"context_line":"    sudo mount -t xfs -o nouuid,loop,noatime,nodiratime,nobarrier,logbufs\u003d8  \\"},{"line_number":99,"context_line":"        ${SWIFT_DATA_DIR}/drives/images/swift.img ${SWIFT_DATA_DIR}/drives/sdb1"},{"line_number":100,"context_line":"fi"},{"line_number":101,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":16,"id":"AAAAUH%2F%2BkdI%3D","line":98,"updated":"2014-01-24 09:53:59.000000000","message":"why would you want nouuid? is the xfs uuid table get messed around between upgrades?","commit_id":"96b64ff7650a0728b1b39575a3d974f0db92010b"}],"upgrade-tempest":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0b83177475343f4779f820f275c30153d6e48c0a","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# Set for DevStack compatibility"},{"line_number":52,"context_line":"TOP_DIR\u003d$TARGET_DEVSTACK_DIR"},{"line_number":53,"context_line":"OLD_TEMPEST_CONFIG\u003d$TEMPEST_CONFIG"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"cd $TARGET_DEVSTACK_DIR"},{"line_number":56,"context_line":"source $TARGET_DEVSTACK_DIR/functions"}],"source_content_type":"application/octet-stream","patch_set":43,"id":"AAAAWH%2F%2BCNo%3D","line":53,"updated":"2014-03-31 12:16:08.000000000","message":"This can be removed.","commit_id":"cdf6ba2d9be87d7c9ae3945197398bb0654df398"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"f2dd1ea3fe4535bf9e16eae4e61714c8b72add9f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"source $TARGET_DEVSTACK_DIR/lib/tempest"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"if is_service_enabled neutron; then"},{"line_number":71,"context_line":"    source $TARGET_DEVSTACK_DIR/lib/neutron"},{"line_number":72,"context_line":"fi"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"# install_tempest()"}],"source_content_type":"application/octet-stream","patch_set":43,"id":"AAAAWH%2F%2BChg%3D","line":71,"updated":"2014-03-31 11:34:39.000000000","message":"why is this conditional?","commit_id":"cdf6ba2d9be87d7c9ae3945197398bb0654df398"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"90eb9dcfd1f0b34331bfbbe11e412ab13fa0101c","unresolved":false,"context_lines":[{"line_number":68,"context_line":"source $TARGET_DEVSTACK_DIR/lib/tempest"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"if is_service_enabled neutron; then"},{"line_number":71,"context_line":"    source $TARGET_DEVSTACK_DIR/lib/neutron"},{"line_number":72,"context_line":"fi"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"# install_tempest()"}],"source_content_type":"application/octet-stream","patch_set":43,"id":"AAAAWH%2F%2BAMw%3D","line":71,"in_reply_to":"AAAAWH%2F%2BCXA%3D","updated":"2014-03-31 16:09:54.000000000","message":"Done","commit_id":"cdf6ba2d9be87d7c9ae3945197398bb0654df398"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"aadafc8fc90df63d1cddaaba7cf262c1d510e20f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"source $TARGET_DEVSTACK_DIR/lib/tempest"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"if is_service_enabled neutron; then"},{"line_number":71,"context_line":"    source $TARGET_DEVSTACK_DIR/lib/neutron"},{"line_number":72,"context_line":"fi"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"# install_tempest()"}],"source_content_type":"application/octet-stream","patch_set":43,"id":"AAAAWH%2F%2BCXA%3D","line":71,"in_reply_to":"AAAAWH%2F%2BChg%3D","updated":"2014-03-31 12:03:13.000000000","message":"It adds \"neutron\" to TEMPEST_SERVICES global variable causing tempest to think there is neutron. If grenade is running with nova-network, we need to configure tempest accordingly (i.e. without neutron).","commit_id":"cdf6ba2d9be87d7c9ae3945197398bb0654df398"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"f2dd1ea3fe4535bf9e16eae4e61714c8b72add9f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"ENABLED_SERVICES\u003dn-api,nova,glance,cinder,keystone,swift,q-svc"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"configure_tempest"},{"line_number":87,"context_line":"configure_tempest_neutron"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"DEST\u003d$DEST_BACKUP"},{"line_number":90,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":43,"id":"AAAAWH%2F%2BChQ%3D","line":87,"updated":"2014-03-31 11:34:39.000000000","message":"why isn\u0027t this getting picked up by the tempest configuration?","commit_id":"cdf6ba2d9be87d7c9ae3945197398bb0654df398"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"90eb9dcfd1f0b34331bfbbe11e412ab13fa0101c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"ENABLED_SERVICES\u003dn-api,nova,glance,cinder,keystone,swift,q-svc"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"configure_tempest"},{"line_number":87,"context_line":"configure_tempest_neutron"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"DEST\u003d$DEST_BACKUP"},{"line_number":90,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":43,"id":"AAAAWH%2F%2BAMs%3D","line":87,"in_reply_to":"AAAAWH%2F%2BCTo%3D","updated":"2014-03-31 16:09:54.000000000","message":"I\u0027ll try to figure this out.","commit_id":"cdf6ba2d9be87d7c9ae3945197398bb0654df398"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"aadafc8fc90df63d1cddaaba7cf262c1d510e20f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"ENABLED_SERVICES\u003dn-api,nova,glance,cinder,keystone,swift,q-svc"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"configure_tempest"},{"line_number":87,"context_line":"configure_tempest_neutron"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"DEST\u003d$DEST_BACKUP"},{"line_number":90,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":43,"id":"AAAAWH%2F%2BCTo%3D","line":87,"in_reply_to":"AAAAWH%2F%2BChQ%3D","updated":"2014-03-31 12:03:13.000000000","message":"If I understand your question correctly you are asking why \"configure_tempest\" doesn\u0027t set public_network_id tenant_network_cidr?\n\nIf so then the answer is that at this point bash doesn\u0027t know global variables Q_L3_ENABLED, Q_USE_NAMESPACE, PUBLIC_NETWORK_NAME and Q_ROUTER_NAME that are defined when configuring neutron. Frankly, I don\u0027t know why. So I solved it by using values from previous tempest run.","commit_id":"cdf6ba2d9be87d7c9ae3945197398bb0654df398"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"808d499e448b669075ee4b2b1b679ceb2c629278","unresolved":false,"context_lines":[{"line_number":50,"context_line":"source $TARGET_DEVSTACK_DIR/stackrc"},{"line_number":51,"context_line":"source $TARGET_DEVSTACK_DIR/openrc"},{"line_number":52,"context_line":"FILES\u003d$TARGET_DEVSTACK_DIR/files"},{"line_number":53,"context_line":"BASE_TEMPEST_CONFIG\u003d$BASE_RELEASE_DIR/tempest/etc/tempest.conf"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Get functions from current DevStack"},{"line_number":56,"context_line":"source $TARGET_DEVSTACK_DIR/lib/rpc_backend"}],"source_content_type":"application/octet-stream","patch_set":46,"id":"AAAAWH%2F9%2BUI%3D","line":53,"updated":"2014-03-31 20:25:28.000000000","message":"I don\u0027t think this is needed","commit_id":"5f2c7278e646b154f8acc67c5bbba13db152eafc"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"808d499e448b669075ee4b2b1b679ceb2c629278","unresolved":false,"context_lines":[{"line_number":70,"context_line":"OS_USERNAME\u003dadmin"},{"line_number":71,"context_line":"if is_service_enabled neutron; then"},{"line_number":72,"context_line":"    ENABLED_SERVICES\u003d\"q-svc,\""},{"line_number":73,"context_line":"    Q_L3_ENABLED\u003d\"True\""},{"line_number":74,"context_line":"else"},{"line_number":75,"context_line":"    ENABLED_SERVICES\u003d\"\""},{"line_number":76,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":46,"id":"AAAAWH%2F9%2BUg%3D","line":73,"updated":"2014-03-31 20:25:28.000000000","message":"why is this needed?","commit_id":"5f2c7278e646b154f8acc67c5bbba13db152eafc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0d44a6758d85c4c01b767ff81dbb052fa08ee08c","unresolved":false,"context_lines":[{"line_number":70,"context_line":"OS_USERNAME\u003dadmin"},{"line_number":71,"context_line":"if is_service_enabled neutron; then"},{"line_number":72,"context_line":"    ENABLED_SERVICES\u003d\"q-svc,\""},{"line_number":73,"context_line":"    Q_L3_ENABLED\u003d\"True\""},{"line_number":74,"context_line":"else"},{"line_number":75,"context_line":"    ENABLED_SERVICES\u003d\"\""},{"line_number":76,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":46,"id":"AAAAWH%2F998o%3D","line":73,"in_reply_to":"AAAAWH%2F9%2BUg%3D","updated":"2014-03-31 21:06:23.000000000","message":"It\u0027s needed for setting public_network_id in tempest conf","commit_id":"5f2c7278e646b154f8acc67c5bbba13db152eafc"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"808d499e448b669075ee4b2b1b679ceb2c629278","unresolved":false,"context_lines":[{"line_number":77,"context_line":"# NOTE(maurosr): Set enabled only the projects that we have the upgrade file"},{"line_number":78,"context_line":"# This avoid tempest to run heat tests in a moment that we don\u0027t activate it"},{"line_number":79,"context_line":"# during upgrade."},{"line_number":80,"context_line":"ENABLED_SERVICES+\u003dn-api,nova,glance,cinder,keystone,swift"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"configure_tempest"},{"line_number":83,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":46,"id":"AAAAWH%2F9%2BUs%3D","line":80,"updated":"2014-03-31 20:25:28.000000000","message":"what if we delete this entirely?","commit_id":"5f2c7278e646b154f8acc67c5bbba13db152eafc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0d44a6758d85c4c01b767ff81dbb052fa08ee08c","unresolved":false,"context_lines":[{"line_number":77,"context_line":"# NOTE(maurosr): Set enabled only the projects that we have the upgrade file"},{"line_number":78,"context_line":"# This avoid tempest to run heat tests in a moment that we don\u0027t activate it"},{"line_number":79,"context_line":"# during upgrade."},{"line_number":80,"context_line":"ENABLED_SERVICES+\u003dn-api,nova,glance,cinder,keystone,swift"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"configure_tempest"},{"line_number":83,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":46,"id":"AAAAWH%2F998E%3D","line":80,"in_reply_to":"AAAAWH%2F9%2BUs%3D","updated":"2014-03-31 21:06:23.000000000","message":"I don\u0027t know...","commit_id":"5f2c7278e646b154f8acc67c5bbba13db152eafc"}]}