)]}'
{"projects/60_nova/resources.sh":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"99b53ab63e2e90158c17e8c90f67533a671237b9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"VIRT_DRIVER\u003d${VIRT_DRIVER:-$DEFAULT_VIRT_DRIVER}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"if [[ \"$VIRT_DRIVER\" \u003d\u003d ironic ]]; then"},{"line_number":35,"context_line":"    NOVA_VERIFY_RESOURCE_CLASSES\u003d"},{"line_number":36,"context_line":"else"},{"line_number":37,"context_line":"    NOVA_VERIFY_RESOURCE_CLASSES\u003d\"VCPU MEMORY_MB DISK_GB\""},{"line_number":38,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_e72f13f3","line":35,"updated":"2018-10-08 12:44:26.000000000","message":"Maybe worth using $IRONIC_DEFAULT_RESOURCE_CLASS here, if it is available?","commit_id":"375e7b6b670e39929b149db5db71030fe6c31dab"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f5f8bb8be8d96ddcf923515986a0380e4e0ea6fe","unresolved":false,"context_lines":[{"line_number":32,"context_line":"VIRT_DRIVER\u003d${VIRT_DRIVER:-$DEFAULT_VIRT_DRIVER}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"if [[ \"$VIRT_DRIVER\" \u003d\u003d ironic ]]; then"},{"line_number":35,"context_line":"    NOVA_VERIFY_RESOURCE_CLASSES\u003d"},{"line_number":36,"context_line":"else"},{"line_number":37,"context_line":"    NOVA_VERIFY_RESOURCE_CLASSES\u003d\"VCPU MEMORY_MB DISK_GB\""},{"line_number":38,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_87473fa4","line":35,"in_reply_to":"3f79a3b5_e72f13f3","updated":"2018-10-08 12:50:32.000000000","message":"Maybe, let\u0027s wait for this one to pass.","commit_id":"375e7b6b670e39929b149db5db71030fe6c31dab"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ed6e3b47aafd80afee7d3944768b4ba2f00a8c42","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # verify its custom resource class instead."},{"line_number":39,"context_line":"        NOVA_VERIFY_RESOURCE_CLASSES\u003dCUSTOM_${NOVA_IRONIC_RESOURCE_CLASS^^}"},{"line_number":40,"context_line":"    else"},{"line_number":41,"context_line":"        # This should never happen, but just to be on the safe side."},{"line_number":42,"context_line":"        NOVA_VERIFY_RESOURCE_CLASSES\u003d"},{"line_number":43,"context_line":"    fi"},{"line_number":44,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_c5de8f3b","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":68},"updated":"2018-10-08 14:11:54.000000000","message":"We shouldn\u0027t have been able to get this far if this is the case, right? I\u0027d rather add this in if/when we find a legit case where it doesn\u0027t make sense. AFAICT, the default class would have to be set to an empty string to even hit this, right?","commit_id":"1717f0ae246a558a3dca69e9cbc5f75109e9e08f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8bc3d7dea30d7153f155896e35d7a1b151f49c99","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # verify its custom resource class instead."},{"line_number":39,"context_line":"        NOVA_VERIFY_RESOURCE_CLASSES\u003dCUSTOM_${NOVA_IRONIC_RESOURCE_CLASS^^}"},{"line_number":40,"context_line":"    else"},{"line_number":41,"context_line":"        # This should never happen, but just to be on the safe side."},{"line_number":42,"context_line":"        NOVA_VERIFY_RESOURCE_CLASSES\u003d"},{"line_number":43,"context_line":"    fi"},{"line_number":44,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_c5368f50","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":68},"in_reply_to":"3f79a3b5_45b83fc6","updated":"2018-10-08 14:22:39.000000000","message":"Ack cool.","commit_id":"1717f0ae246a558a3dca69e9cbc5f75109e9e08f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5a80fcf256907605b3c4be6afddf12487e878a4d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # verify its custom resource class instead."},{"line_number":39,"context_line":"        NOVA_VERIFY_RESOURCE_CLASSES\u003dCUSTOM_${NOVA_IRONIC_RESOURCE_CLASS^^}"},{"line_number":40,"context_line":"    else"},{"line_number":41,"context_line":"        # This should never happen, but just to be on the safe side."},{"line_number":42,"context_line":"        NOVA_VERIFY_RESOURCE_CLASSES\u003d"},{"line_number":43,"context_line":"    fi"},{"line_number":44,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_45b83fc6","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":68},"in_reply_to":"3f79a3b5_c5de8f3b","updated":"2018-10-08 14:17:54.000000000","message":"Right, it\u0027s a leftover from a previous version. I\u0027ll remove it after the inspector CI in https://review.openstack.org/606349 finishes","commit_id":"1717f0ae246a558a3dca69e9cbc5f75109e9e08f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"254549c614cd9ffeaf605f28c60aed7395108a11","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    NOVA_IRONIC_RESOURCE_CLASS\u003d${IRONIC_DEFAULT_RESOURCE_CLASS:-baremetal}"},{"line_number":36,"context_line":"    # Ironic does not use standard resource classes starting with Stein,"},{"line_number":37,"context_line":"    # verify its custom resource class instead."},{"line_number":38,"context_line":"    NOVA_VERIFY_RESOURCE_CLASSES\u003dCUSTOM_${NOVA_IRONIC_RESOURCE_CLASS^^}"},{"line_number":39,"context_line":"else"},{"line_number":40,"context_line":"    NOVA_VERIFY_RESOURCE_CLASSES\u003d\"VCPU MEMORY_MB DISK_GB\""},{"line_number":41,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3f79a3b5_96920ba0","line":38,"range":{"start_line":38,"start_character":68,"end_line":38,"end_character":70},"updated":"2018-10-08 16:07:24.000000000","message":"O.O\n\nTIL","commit_id":"20c38c929a78d609578bb802c8e7d9dcfe975205"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"234d2edd78131747d90c899f7c8652e2bb010d92","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    NOVA_IRONIC_RESOURCE_CLASS\u003d${IRONIC_DEFAULT_RESOURCE_CLASS:-baremetal}"},{"line_number":36,"context_line":"    # Ironic does not use standard resource classes starting with Stein,"},{"line_number":37,"context_line":"    # verify its custom resource class instead."},{"line_number":38,"context_line":"    NOVA_VERIFY_RESOURCE_CLASSES\u003dCUSTOM_${NOVA_IRONIC_RESOURCE_CLASS^^}"},{"line_number":39,"context_line":"else"},{"line_number":40,"context_line":"    NOVA_VERIFY_RESOURCE_CLASSES\u003d\"VCPU MEMORY_MB DISK_GB\""},{"line_number":41,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3f79a3b5_96d76b51","line":38,"range":{"start_line":38,"start_character":68,"end_line":38,"end_character":70},"in_reply_to":"3f79a3b5_96920ba0","updated":"2018-10-08 16:08:23.000000000","message":"Bash is an infinite source of amusement :)","commit_id":"20c38c929a78d609578bb802c8e7d9dcfe975205"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"285de8f56f7a42f085be4d609214fbacb19b3cc3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    NOVA_IRONIC_RESOURCE_CLASS\u003d${IRONIC_DEFAULT_RESOURCE_CLASS:-baremetal}"},{"line_number":36,"context_line":"    # Ironic does not use standard resource classes starting with Stein,"},{"line_number":37,"context_line":"    # verify its custom resource class instead."},{"line_number":38,"context_line":"    NOVA_VERIFY_RESOURCE_CLASSES\u003dCUSTOM_${NOVA_IRONIC_RESOURCE_CLASS^^}"},{"line_number":39,"context_line":"else"},{"line_number":40,"context_line":"    NOVA_VERIFY_RESOURCE_CLASSES\u003d\"VCPU MEMORY_MB DISK_GB\""},{"line_number":41,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3f79a3b5_e82fd0a3","line":38,"range":{"start_line":38,"start_character":68,"end_line":38,"end_character":70},"in_reply_to":"3f79a3b5_96d76b51","updated":"2018-10-09 08:49:06.000000000","message":"yeah :), it is generating it correctly \n- http://logs.openstack.org/49/606349/3/check/ironic-inspector-grenade-dsvm/8dada54/logs/grenade.sh.txt.gz#_2018-10-09_02_23_42_628","commit_id":"20c38c929a78d609578bb802c8e7d9dcfe975205"}]}