)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"086a96cf83fffe99fac792049cfd31759a431b8d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Swift includes openstack client in its requirements so when it installs"},{"line_number":10,"context_line":"under Python 2 it clobbers the existing openstack client at"},{"line_number":11,"context_line":"/usr/local/bin and any previously installed plugins are wiped out"},{"line_number":12,"context_line":"because their entry points aren\u0027t seen."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"To address this, we do a reinstall at the end of swift\u0027s upgrade."},{"line_number":15,"context_line":"Because python-openstack client is in ENABLED_PYTHON3_PACKAGES,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_2fe79d47","line":12,"range":{"start_line":11,"start_character":15,"end_line":12,"end_character":39},"updated":"2018-11-26 14:30:58.000000000","message":"To be clear, the problem that made you notice this is osc-placement was missing, so when the post-upgrade verify step runs for nova and it checks resource provider inventory, it blew up, correct? And specifically this is a problem in the grenade-py3 job because swift doesn\u0027t support python3? Should have probably had a grenade bug with the details if they aren\u0027t going to be in the commit message (or just add them to the commit message for clarity/posterity).","commit_id":"2c79a327754533d79570329cdc6c7d7d429c7c1b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c93573e88f0c3d3eb6b3255d348ae0a468324ace","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Re-install python-openstackclient after swift"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When running grenade under python3, swift runs under python3.  Swift"},{"line_number":10,"context_line":"includes openstack client in its requirements so when it installs under"},{"line_number":11,"context_line":"Python 2 it clobbers the existing openstack client at /usr/local/bin and"},{"line_number":12,"context_line":"any previously installed plugins are wiped out because their entry"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_8f5a714e","line":9,"range":{"start_line":9,"start_character":53,"end_line":9,"end_character":60},"updated":"2018-11-26 15:00:23.000000000","message":"python2?","commit_id":"e008a306f470c6d64538295f9a6402c4b30a32fd"}],"projects/30_swift/upgrade.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"086a96cf83fffe99fac792049cfd31759a431b8d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"# openstackclient is explicitly listed as python3 supported, this"},{"line_number":85,"context_line":"# does \"the right thing\"."},{"line_number":86,"context_line":"# TODO(cdent): Remove this when swift is part of ENABLED_PYTHON3_PACKAGES."},{"line_number":87,"context_line":"pip_install python-openstackclient"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"set +o xtrace"},{"line_number":90,"context_line":"echo \"*********************************************************************\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_ef77658c","line":87,"updated":"2018-11-26 14:30:58.000000000","message":"I was wondering if we should hook this in after all projects are upgrade, before we call the verify step, which would be sometime between here:\n\nhttps://github.com/openstack-dev/grenade/blob/7bae489f38f8f0c82c8eb284d1841ef68d8e9a43/grenade.sh#L339\n\nAnd here:\n\nhttps://github.com/openstack-dev/grenade/blob/7bae489f38f8f0c82c8eb284d1841ef68d8e9a43/grenade.sh#L353\n\nBut there is no little \"fix things\" hook in grenade like devstack has:\n\nhttps://github.com/openstack-dev/devstack/blob/master/tools/fixup_stuff.sh\n\nThe other thought was that this could be part of a from_rocky upgrade script for swift, but it sounds like this being py3-specific and is not release specific, that wouldn\u0027t be a good long-term answer since we\u0027d just need a from_stein and from_train as well, etc. So this is probably OK for now as far as where this gets fixed.","commit_id":"2c79a327754533d79570329cdc6c7d7d429c7c1b"}]}