)]}'
{"inc/bootstrap":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe9076aba1c8cb2e71dab5ffa6c476abf7f99e44","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    if [ -z $PYTHON3_VERSION ]; then"},{"line_number":280,"context_line":"       USE_PYTHON3_VERSION\u003d$(python3_version)"},{"line_number":281,"context_line":"       USE_PYTHON3_VERSION\u003d${USE_PYTHON3_VERSION:6}"},{"line_number":282,"context_line":"       export PYTHON3_VERSION\u003d${USE_PYTHON3_VERSION:-3.5}"},{"line_number":283,"context_line":"    fi"},{"line_number":284,"context_line":"    install_devstack_tools"},{"line_number":285,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bfdaf3ff_fa5a1228","line":282,"range":{"start_line":282,"start_character":53,"end_line":282,"end_character":56},"updated":"2019-01-16 17:40:02.000000000","message":"we\u0027d set this when there\u0027s no py3 interpreter available, but I\u0027m assuming this doesn\u0027t matter if python3 isn\u0027t enabled in devstack; \n\nline 281 can be \n\n  export PYTHON3_VERSION\u003d${USE_PYTHON3_VERSION:6}","commit_id":"02788d14cb47969ee1c410ba3da05c0d7de9f06a"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8bdace2e39031eee58691f0e2b91e571a30b8248","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    if [ -z $PYTHON3_VERSION ]; then"},{"line_number":280,"context_line":"       USE_PYTHON3_VERSION\u003d$(python3_version)"},{"line_number":281,"context_line":"       USE_PYTHON3_VERSION\u003d${USE_PYTHON3_VERSION:6}"},{"line_number":282,"context_line":"       export PYTHON3_VERSION\u003d${USE_PYTHON3_VERSION:-3.5}"},{"line_number":283,"context_line":"    fi"},{"line_number":284,"context_line":"    install_devstack_tools"},{"line_number":285,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bfdaf3ff_7a9aa26e","line":282,"range":{"start_line":282,"start_character":53,"end_line":282,"end_character":56},"in_reply_to":"bfdaf3ff_fa5a1228","updated":"2019-01-16 17:55:42.000000000","message":"I think it does no harm if there\u0027s no py3 interpreter available and the jobs seem to die if it\u0027s not set even if they are running python2 :(  But that\u0027s a different legacy job bug.\n\nIf we do line 281 the way you suggest then there\u0027s no fallback to 3.5 as value if USE_PYTHON3_VERSION is null, and I think we need that b/c of the bug I just mentioned.","commit_id":"02788d14cb47969ee1c410ba3da05c0d7de9f06a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8d86b444ceb1835ab2984ff3bf7afcd7f81398e7","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    source $TARGET_DEVSTACK_DIR/inc/python"},{"line_number":279,"context_line":"    if [ -z $PYTHON3_VERSION ]; then"},{"line_number":280,"context_line":"       USE_PYTHON3_VERSION\u003d$(python3_version)"},{"line_number":281,"context_line":"       USE_PYTHON3_VERSION\u003d${USE_PYTHON3_VERSION:6}"},{"line_number":282,"context_line":"       export PYTHON3_VERSION\u003d${USE_PYTHON3_VERSION:-3.5}"},{"line_number":283,"context_line":"    fi"},{"line_number":284,"context_line":"    install_devstack_tools"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9fdfeff1_9c20d64b","line":281,"updated":"2019-02-06 22:39:13.000000000","message":"doesn\u0027t this want to be \"3.6\"?  although i\u0027m not sure it makes much sense -- the only platform where there\u0027s no python3 at this point would be centos7\n\nyou can do\n\n _DEFAULT_PYTHON3_VERSION\u003d\"$(_get_python_version python3)\"\n export PYTHON3_VERSION\u003d${PYTHON3_VERSION:-${_DEFAULT_PYTHON3_VERSION:-3.5}}\n\nlike is done in devsatck\u0027s stackrc to \"stack\" the defaults","commit_id":"b820a2e95f2b8fb5ec3bd06a852e38cd127cf4d4"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"281b3a62677c79ca9eab4fba789ae0c936754505","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    source $TARGET_DEVSTACK_DIR/inc/python"},{"line_number":279,"context_line":"    if [ -z $PYTHON3_VERSION ]; then"},{"line_number":280,"context_line":"       USE_PYTHON3_VERSION\u003d$(python3_version)"},{"line_number":281,"context_line":"       USE_PYTHON3_VERSION\u003d${USE_PYTHON3_VERSION:6}"},{"line_number":282,"context_line":"       export PYTHON3_VERSION\u003d${USE_PYTHON3_VERSION:-3.5}"},{"line_number":283,"context_line":"    fi"},{"line_number":284,"context_line":"    install_devstack_tools"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9fdfeff1_9ccf7656","line":281,"in_reply_to":"9fdfeff1_9c20d64b","updated":"2019-02-06 22:48:22.000000000","message":"3.6 was intended as it\u0027s what is available on ubuntu bionic but 3.5 as fallback is fine and doing it the devstack way here makes sense.  Thanks.","commit_id":"b820a2e95f2b8fb5ec3bd06a852e38cd127cf4d4"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"c2468e7e4615ece040d5865cfa4ed4e7b74b322d","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    source $TARGET_DEVSTACK_DIR/inc/python"},{"line_number":279,"context_line":"    if [ -z $PYTHON3_VERSION ]; then"},{"line_number":280,"context_line":"       USE_PYTHON3_VERSION\u003d$(python3_version)"},{"line_number":281,"context_line":"       USE_PYTHON3_VERSION\u003d${USE_PYTHON3_VERSION:6}"},{"line_number":282,"context_line":"       export PYTHON3_VERSION\u003d${USE_PYTHON3_VERSION:-3.5}"},{"line_number":283,"context_line":"    fi"},{"line_number":284,"context_line":"    install_devstack_tools"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9fdfeff1_bcd6fac2","line":281,"in_reply_to":"9fdfeff1_9c20d64b","updated":"2019-02-06 22:56:27.000000000","message":"oh, I forgot, that\u0027s a \"slice\" in bash - drops \"python\" and keeps the \"3.5\".  obscure though.  Will push a revision doing it the devstack\u0027s stackrc way.","commit_id":"b820a2e95f2b8fb5ec3bd06a852e38cd127cf4d4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"56270311d5f712893682b083ffd89c98c54bcfc4","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    source $TARGET_DEVSTACK_DIR/functions-common"},{"line_number":278,"context_line":"    source $TARGET_DEVSTACK_DIR/inc/python"},{"line_number":279,"context_line":"    if [ -z $PYTHON3_VERSION ]; then"},{"line_number":280,"context_line":"       _DEFAULT_PYTHON3_VERSION\u003d\"$(_get_python_version python3)\""},{"line_number":281,"context_line":"       export PYTHON3_VERSION\u003d${PYTHON3_VERSION:-${_DEFAULT_PYTHON3_VERSION:-3.5}}"},{"line_number":282,"context_line":"    fi"},{"line_number":283,"context_line":"    install_devstack_tools"},{"line_number":284,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9fdfeff1_9af776d5","line":281,"range":{"start_line":280,"start_character":7,"end_line":281,"end_character":82},"updated":"2019-02-07 00:40:15.000000000","message":"since this only executes when PYTHON3_VERSION has not been set, shouldn\u0027t this simply be:\n\n  PYTHON3_VERSION\u003d${_DEFAULT_PYTHON3_VERSION:-3.5}","commit_id":"c117edac03a613218c8c8715c69cabcf9e0d4ccc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"216dbd75407a123be6efe3e632aaac51a6437b28","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    source $TARGET_DEVSTACK_DIR/functions-common"},{"line_number":278,"context_line":"    source $TARGET_DEVSTACK_DIR/inc/python"},{"line_number":279,"context_line":"    if [ -z $PYTHON3_VERSION ]; then"},{"line_number":280,"context_line":"       _DEFAULT_PYTHON3_VERSION\u003d\"$(_get_python_version python3)\""},{"line_number":281,"context_line":"       export PYTHON3_VERSION\u003d${PYTHON3_VERSION:-${_DEFAULT_PYTHON3_VERSION:-3.5}}"},{"line_number":282,"context_line":"    fi"},{"line_number":283,"context_line":"    install_devstack_tools"},{"line_number":284,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9fdfeff1_fa2b222d","line":281,"range":{"start_line":280,"start_character":7,"end_line":281,"end_character":82},"in_reply_to":"9fdfeff1_9af776d5","updated":"2019-02-07 00:42:24.000000000","message":"or truly like devstack does it:\n\n _DEFAULT_PYTHON3_VERSION\u003d\"$(_get_python_version python3)\"\n export PYTHON3_VERSION\u003d${PYTHON3_VERSION:${_DEFAULT_PYTHON3_VERSION:-3.5}}","commit_id":"c117edac03a613218c8c8715c69cabcf9e0d4ccc"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4b8d90405684ce4e7015ae63e24895eda9affdc9","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    # Just to be more explicit on the Python 2 version to use."},{"line_number":287,"context_line":"    _DEFAULT_PYTHON2_VERSION\u003d\"$(_get_python_version python2)\""},{"line_number":288,"context_line":"    export PYTHON2_VERSION\u003d${PYTHON2_VERSION:-${_DEFAULT_PYTHON2_VERSION:-2.7}}"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    install_devstack_tools"},{"line_number":291,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"9fdfeff1_5331390a","line":288,"updated":"2019-03-01 19:29:54.000000000","message":"This isn\u0027t any more explicit because nothing uses it, that I can see. So, it would make things more confusing, IMHO. Am I missing where PYTHON2_VERSION is used? Either way, if the threats are real, there will never be anything newer than 2.7, and everything we support (by a long shot) is on 2.7 now, so this seems really unnecessary.","commit_id":"5aaf18eafe9633994cc1caf5ba9b255dbe5f133c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"221eff843defa003016eb581b2f020374a97ad3c","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    # Just to be more explicit on the Python 2 version to use."},{"line_number":287,"context_line":"    _DEFAULT_PYTHON2_VERSION\u003d\"$(_get_python_version python2)\""},{"line_number":288,"context_line":"    export PYTHON2_VERSION\u003d${PYTHON2_VERSION:-${_DEFAULT_PYTHON2_VERSION:-2.7}}"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    install_devstack_tools"},{"line_number":291,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"9fdfeff1_072121b6","line":288,"in_reply_to":"9fdfeff1_0fd94555","updated":"2019-03-03 15:30:15.000000000","message":"yeah, let\u0027s drop PYTHON2_VERSION setting . I think the previous suggestion was to do like devstack way for PYTHON3_VERSION setting only.","commit_id":"5aaf18eafe9633994cc1caf5ba9b255dbe5f133c"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"55bf5051812dc9273ffbb8cb6f19d0bb3dbbede6","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    # Just to be more explicit on the Python 2 version to use."},{"line_number":287,"context_line":"    _DEFAULT_PYTHON2_VERSION\u003d\"$(_get_python_version python2)\""},{"line_number":288,"context_line":"    export PYTHON2_VERSION\u003d${PYTHON2_VERSION:-${_DEFAULT_PYTHON2_VERSION:-2.7}}"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    install_devstack_tools"},{"line_number":291,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"9fdfeff1_0fd94555","line":288,"in_reply_to":"9fdfeff1_5331390a","updated":"2019-03-01 19:47:59.000000000","message":"If you check against the previous patch set, we were just setting the PYTHON3_VERSION but responded to a suggestion to \"do what devstack does\" so I made it match literally iirc.\n\nI\u0027m OK with dropping lines 286-288 if that\u0027s agreeable.","commit_id":"5aaf18eafe9633994cc1caf5ba9b255dbe5f133c"}]}