)]}'
{"PLUGINS.rst":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"042c832ace1edff577aab3b4fd77a0b37c189afe","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"Please note that ``devstack_localrc`` works only when the grenade"},{"line_number":245,"context_line":"performs the configurating of the devstack settings and runs devstack"},{"line_number":246,"context_line":"against the base target. If devstack is configured and executed"},{"line_number":247,"context_line":"before grenade, like on the Zuul grenade job, the function has no effects."},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"Example settings"},{"line_number":250,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1fa4df85_6c73f416","line":247,"range":{"start_line":246,"start_character":25,"end_line":247,"end_character":73},"updated":"2020-02-27 02:07:24.000000000","message":"or you can say if GRENADE_DEVSTACK_EXTERNAL is True","commit_id":"a90be880a1fe42e0a313f569085076c873a90d9d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"8b107f02f665034d6d4b6e46899ac0d1339f0583","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"Please note that ``devstack_localrc`` works only when the grenade"},{"line_number":245,"context_line":"performs the configurating of the devstack settings and runs devstack"},{"line_number":246,"context_line":"against the base target. If devstack is configured and executed"},{"line_number":247,"context_line":"before grenade, like on the Zuul grenade job, the function has no effects."},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"Example settings"},{"line_number":250,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1fa4df85_9ddd0a72","line":247,"range":{"start_line":246,"start_character":25,"end_line":247,"end_character":73},"in_reply_to":"1fa4df85_6c73f416","updated":"2020-03-02 09:56:09.000000000","message":"I already explained it in the other file, but I can add a note.","commit_id":"a90be880a1fe42e0a313f569085076c873a90d9d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"241818cc5987ad05c17e799a7dc93444baec3932","unresolved":false,"context_lines":[{"line_number":241,"context_line":"Which will take all the rest of the stuff on that line and add it to"},{"line_number":242,"context_line":"the localrc for either the base or target devstack."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"Please note that ``devstack_localrc`` works only when the grenade"},{"line_number":245,"context_line":"performs the configurating of the devstack settings and runs devstack"},{"line_number":246,"context_line":"against the base target. When GRENADE_USE_EXTERNAL_DEVSTACK is set"},{"line_number":247,"context_line":"to True, as it happens on the Zuul grenade jobs where devstack is"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1fa4df85_40b48135","line":244,"range":{"start_line":244,"start_character":54,"end_line":244,"end_character":57},"updated":"2020-03-02 17:16:11.000000000","message":"nit: omit","commit_id":"36b35c77840c4fada125fddc8e944b9fe74b62e1"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"241818cc5987ad05c17e799a7dc93444baec3932","unresolved":false,"context_lines":[{"line_number":242,"context_line":"the localrc for either the base or target devstack."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"Please note that ``devstack_localrc`` works only when the grenade"},{"line_number":245,"context_line":"performs the configurating of the devstack settings and runs devstack"},{"line_number":246,"context_line":"against the base target. When GRENADE_USE_EXTERNAL_DEVSTACK is set"},{"line_number":247,"context_line":"to True, as it happens on the Zuul grenade jobs where devstack is"},{"line_number":248,"context_line":"configured and executed before grenade, the function has no effects."}],"source_content_type":"text/x-rst","patch_set":15,"id":"1fa4df85_e0848d60","line":245,"range":{"start_line":245,"start_character":13,"end_line":245,"end_character":26},"updated":"2020-03-02 17:16:11.000000000","message":"nit: configuration","commit_id":"36b35c77840c4fada125fddc8e944b9fe74b62e1"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"241818cc5987ad05c17e799a7dc93444baec3932","unresolved":false,"context_lines":[{"line_number":245,"context_line":"performs the configurating of the devstack settings and runs devstack"},{"line_number":246,"context_line":"against the base target. When GRENADE_USE_EXTERNAL_DEVSTACK is set"},{"line_number":247,"context_line":"to True, as it happens on the Zuul grenade jobs where devstack is"},{"line_number":248,"context_line":"configured and executed before grenade, the function has no effects."},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"Example settings"},{"line_number":251,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1fa4df85_a07e9568","line":248,"range":{"start_line":248,"start_character":60,"end_line":248,"end_character":67},"updated":"2020-03-02 17:16:11.000000000","message":"nit: effect (singular)","commit_id":"36b35c77840c4fada125fddc8e944b9fe74b62e1"}],"README.rst":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d23ea089387929e143d253527da85c4d55475a77","unresolved":false,"context_lines":[{"line_number":108,"context_line":"- perform some sanity checking (currently tempest smoke) to ensure"},{"line_number":109,"context_line":"  everything seems good."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"The script skips the first two steps (devstacks setup and configuration,"},{"line_number":112,"context_line":"installation of the base devstack) if the value of GRENADE_DEVSTACK_EXTERNAL"},{"line_number":113,"context_line":"is set to True."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"1fa4df85_e9232d04","line":112,"range":{"start_line":111,"start_character":38,"end_line":112,"end_character":33},"updated":"2020-02-29 18:10:39.000000000","message":"does not match the above list","commit_id":"a90be880a1fe42e0a313f569085076c873a90d9d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c9f652b7a124aab6350432fc61159ee78ee01893","unresolved":false,"context_lines":[{"line_number":108,"context_line":"- perform some sanity checking (currently tempest smoke) to ensure"},{"line_number":109,"context_line":"  everything seems good."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"The script skips the first two steps (devstacks setup and configuration,"},{"line_number":112,"context_line":"installation of the base devstack) if the value of GRENADE_DEVSTACK_EXTERNAL"},{"line_number":113,"context_line":"is set to True."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"1fa4df85_a1c78445","line":112,"range":{"start_line":111,"start_character":38,"end_line":112,"end_character":33},"in_reply_to":"1fa4df85_1df11a6c","updated":"2020-03-02 10:46:21.000000000","message":"Or make the list more descriptive so that it matches. Devstack had to be configured at some point there.","commit_id":"a90be880a1fe42e0a313f569085076c873a90d9d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"46847439d64c5ef073ca6f5417925e3dd1f61e5b","unresolved":false,"context_lines":[{"line_number":108,"context_line":"- perform some sanity checking (currently tempest smoke) to ensure"},{"line_number":109,"context_line":"  everything seems good."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"The script skips the first two steps (devstacks setup and configuration,"},{"line_number":112,"context_line":"installation of the base devstack) if the value of GRENADE_DEVSTACK_EXTERNAL"},{"line_number":113,"context_line":"is set to True."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"1fa4df85_fdeafea9","line":112,"range":{"start_line":111,"start_character":38,"end_line":112,"end_character":33},"in_reply_to":"1fa4df85_5d6472e4","updated":"2020-03-02 10:10:11.000000000","message":"I agree in that most people using it will be able to correlate that but in general: \"get 2 things\" !\u003d \"things setup and configuration\").","commit_id":"a90be880a1fe42e0a313f569085076c873a90d9d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"85c141fde62a32a378fc1898370b3a2516695d91","unresolved":false,"context_lines":[{"line_number":108,"context_line":"- perform some sanity checking (currently tempest smoke) to ensure"},{"line_number":109,"context_line":"  everything seems good."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"The script skips the first two steps (devstacks setup and configuration,"},{"line_number":112,"context_line":"installation of the base devstack) if the value of GRENADE_DEVSTACK_EXTERNAL"},{"line_number":113,"context_line":"is set to True."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"1fa4df85_c13ba0e8","line":112,"range":{"start_line":111,"start_character":38,"end_line":112,"end_character":33},"in_reply_to":"1fa4df85_a1c78445","updated":"2020-03-02 11:05:18.000000000","message":"I didn\u0027t want to change the basic flow and keep my changes as much as limited as possible.","commit_id":"a90be880a1fe42e0a313f569085076c873a90d9d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"8b107f02f665034d6d4b6e46899ac0d1339f0583","unresolved":false,"context_lines":[{"line_number":108,"context_line":"- perform some sanity checking (currently tempest smoke) to ensure"},{"line_number":109,"context_line":"  everything seems good."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"The script skips the first two steps (devstacks setup and configuration,"},{"line_number":112,"context_line":"installation of the base devstack) if the value of GRENADE_DEVSTACK_EXTERNAL"},{"line_number":113,"context_line":"is set to True."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"1fa4df85_5d6472e4","line":112,"range":{"start_line":111,"start_character":38,"end_line":112,"end_character":33},"in_reply_to":"1fa4df85_e9232d04","updated":"2020-03-02 09:56:09.000000000","message":"I disagree: it\u0027s not the same words, but it\u0027s the same two steps.","commit_id":"a90be880a1fe42e0a313f569085076c873a90d9d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"fc437f9ae2d698856c1a010eb4423be822054b7c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"- perform some sanity checking (currently tempest smoke) to ensure"},{"line_number":109,"context_line":"  everything seems good."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"The script skips the first two steps (devstacks setup and configuration,"},{"line_number":112,"context_line":"installation of the base devstack) if the value of GRENADE_DEVSTACK_EXTERNAL"},{"line_number":113,"context_line":"is set to True."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"1fa4df85_1df11a6c","line":112,"range":{"start_line":111,"start_character":38,"end_line":112,"end_character":33},"in_reply_to":"1fa4df85_fdeafea9","updated":"2020-03-02 10:17:56.000000000","message":"I can make it more descriptive without giving the impression that it\u0027s going to be an excerpt from the list","commit_id":"a90be880a1fe42e0a313f569085076c873a90d9d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d23ea089387929e143d253527da85c4d55475a77","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"The script skips the first two steps (devstacks setup and configuration,"},{"line_number":112,"context_line":"installation of the base devstack) if the value of GRENADE_DEVSTACK_EXTERNAL"},{"line_number":113,"context_line":"is set to True."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Terminology"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1fa4df85_8922b9ff","line":113,"updated":"2020-02-29 18:10:39.000000000","message":"I\u0027d say this level of detail is not for README.rst","commit_id":"a90be880a1fe42e0a313f569085076c873a90d9d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"8b107f02f665034d6d4b6e46899ac0d1339f0583","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"The script skips the first two steps (devstacks setup and configuration,"},{"line_number":112,"context_line":"installation of the base devstack) if the value of GRENADE_DEVSTACK_EXTERNAL"},{"line_number":113,"context_line":"is set to True."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Terminology"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1fa4df85_dda5c205","line":113,"in_reply_to":"1fa4df85_8922b9ff","updated":"2020-03-02 09:56:09.000000000","message":"How would you phrase it? \"Unless set otherwise by using GRENADE_DEVSTACK_EXTERNAL\"? This value is crucial and this file is included by the doc/ files.","commit_id":"a90be880a1fe42e0a313f569085076c873a90d9d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"46847439d64c5ef073ca6f5417925e3dd1f61e5b","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"The script skips the first two steps (devstacks setup and configuration,"},{"line_number":112,"context_line":"installation of the base devstack) if the value of GRENADE_DEVSTACK_EXTERNAL"},{"line_number":113,"context_line":"is set to True."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Terminology"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1fa4df85_dd00626a","line":113,"in_reply_to":"1fa4df85_dda5c205","updated":"2020-03-02 10:10:11.000000000","message":"Ah. Well, that\u0027s not recommended but it really is how you are saying. Let\u0027s leave it be then. Not worth overthinking.","commit_id":"a90be880a1fe42e0a313f569085076c873a90d9d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"241818cc5987ad05c17e799a7dc93444baec3932","unresolved":false,"context_lines":[{"line_number":109,"context_line":"  everything seems good."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"The script skips the first two steps (which take care of setting up the 2"},{"line_number":112,"context_line":"devstack environment and installing the base one) when the value"},{"line_number":113,"context_line":"of GRENADE_USE_EXTERNAL_DEVSTACK is set to True."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"1fa4df85_c0a871dc","line":112,"range":{"start_line":112,"start_character":9,"end_line":112,"end_character":20},"updated":"2020-03-02 17:16:11.000000000","message":"nit: environments (plural)","commit_id":"36b35c77840c4fada125fddc8e944b9fe74b62e1"}],"grenade.sh":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"042c832ace1edff577aab3b4fd77a0b37c189afe","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    # TARGET_DEVSTACK_DIR are now fully populated."},{"line_number":172,"context_line":"    fetch_devstacks"},{"line_number":173,"context_line":"else"},{"line_number":174,"context_line":"    fetch_devstacks_setup_environment"},{"line_number":175,"context_line":"fi"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"# Source the rest of the Grenade functions. For convenience"}],"source_content_type":"text/x-sh","patch_set":13,"id":"1fa4df85_31cc7060","line":174,"range":{"start_line":174,"start_character":4,"end_line":174,"end_character":37},"updated":"2020-02-27 02:07:24.000000000","message":"this can be just devstacks_setup_environment. \u0027fetch\u0027 keyword is confusing here and sounds like it does fetch devstack + setup env. That is what I read till i checked the next file and actual code under this function.","commit_id":"a90be880a1fe42e0a313f569085076c873a90d9d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"8b107f02f665034d6d4b6e46899ac0d1339f0583","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    # TARGET_DEVSTACK_DIR are now fully populated."},{"line_number":172,"context_line":"    fetch_devstacks"},{"line_number":173,"context_line":"else"},{"line_number":174,"context_line":"    fetch_devstacks_setup_environment"},{"line_number":175,"context_line":"fi"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"# Source the rest of the Grenade functions. For convenience"}],"source_content_type":"text/x-sh","patch_set":13,"id":"1fa4df85_dd7e226a","line":174,"range":{"start_line":174,"start_character":4,"end_line":174,"end_character":37},"in_reply_to":"1fa4df85_31cc7060","updated":"2020-03-02 09:56:09.000000000","message":"For the record, I used the fetch_devstacks prefix because those functions are build as subroutines of the fetch_devstacks() function.","commit_id":"a90be880a1fe42e0a313f569085076c873a90d9d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"042c832ace1edff577aab3b4fd77a0b37c189afe","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    devstack_localrc base \"CELLSV2_SETUP\u003dsingleconductor\""},{"line_number":226,"context_line":"    devstack_localrc target \"CELLSV2_SETUP\u003dsingleconductor\""},{"line_number":227,"context_line":"fi"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"# And ensure that we setup the target localrc.auto, because stack.sh"},{"line_number":230,"context_line":"# isn\u0027t run there. This has to be run after load_settings because"},{"line_number":231,"context_line":"# plugins might change the service list during this phase."}],"source_content_type":"text/x-sh","patch_set":13,"id":"1fa4df85_d1c5dc3d","line":228,"range":{"start_line":228,"start_character":0,"end_line":228,"end_character":0},"updated":"2020-02-27 02:07:24.000000000","message":"for reviewer, these are set in job definition where GRENADE_DEVSTACK_EXTERNAL is True - https://review.opendev.org/#/c/548936/107/.zuul.yaml@302","commit_id":"a90be880a1fe42e0a313f569085076c873a90d9d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"8b107f02f665034d6d4b6e46899ac0d1339f0583","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    devstack_localrc base \"CELLSV2_SETUP\u003dsingleconductor\""},{"line_number":226,"context_line":"    devstack_localrc target \"CELLSV2_SETUP\u003dsingleconductor\""},{"line_number":227,"context_line":"fi"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"# And ensure that we setup the target localrc.auto, because stack.sh"},{"line_number":230,"context_line":"# isn\u0027t run there. This has to be run after load_settings because"},{"line_number":231,"context_line":"# plugins might change the service list during this phase."}],"source_content_type":"text/x-sh","patch_set":13,"id":"1fa4df85_7d8dae79","line":228,"range":{"start_line":228,"start_character":0,"end_line":228,"end_character":0},"in_reply_to":"1fa4df85_d1c5dc3d","updated":"2020-03-02 09:56:09.000000000","message":"They can\u0027t be set there; any devstack_localrc call does not work when the external devstack is used.","commit_id":"a90be880a1fe42e0a313f569085076c873a90d9d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"042c832ace1edff577aab3b4fd77a0b37c189afe","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            sed -i \u0027s/stdbuf/$SUB_NODE_ENV_VARS stdbuf/\u0027 ./post-stack.sh"},{"line_number":259,"context_line":"            cat ./post-stack.sh"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"            ./post-stack.sh"},{"line_number":262,"context_line":"            stop $STOP post-stack.sh 15"},{"line_number":263,"context_line":"            echo_summary \"Completed post-stack.sh\""},{"line_number":264,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":13,"id":"1fa4df85_51e7ace5","line":261,"range":{"start_line":261,"start_character":0,"end_line":261,"end_character":27},"updated":"2020-02-27 02:07:24.000000000","message":"I think we do not need this now as we can configure all subnode etc on job side.","commit_id":"a90be880a1fe42e0a313f569085076c873a90d9d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"a6330db26e22d3eaf0e82748061e7908b72b35cf","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            sed -i \u0027s/stdbuf/$SUB_NODE_ENV_VARS stdbuf/\u0027 ./post-stack.sh"},{"line_number":259,"context_line":"            cat ./post-stack.sh"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"            ./post-stack.sh"},{"line_number":262,"context_line":"            stop $STOP post-stack.sh 15"},{"line_number":263,"context_line":"            echo_summary \"Completed post-stack.sh\""},{"line_number":264,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":13,"id":"1fa4df85_044ea66e","line":261,"range":{"start_line":261,"start_character":0,"end_line":261,"end_character":27},"in_reply_to":"1fa4df85_51e7ace5","updated":"2020-03-02 11:20:46.000000000","message":"I kept it for compatibility, as technically if you run with the new variable set to False the workflow should be the same. It can be removed later together with the rest of this code branch.","commit_id":"a90be880a1fe42e0a313f569085076c873a90d9d"}],"inc/bootstrap":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"042c832ace1edff577aab3b4fd77a0b37c189afe","unresolved":false,"context_lines":[{"line_number":261,"context_line":"}"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"function fetch_devstacks {"},{"line_number":264,"context_line":"    fetch_devstacks_clone"},{"line_number":265,"context_line":"    fetch_devstacks_setup_environment"},{"line_number":266,"context_line":"    fetch_devstacks_setup_settings"},{"line_number":267,"context_line":"}"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"function fetch_devstacks_clone {"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"1fa4df85_7144281c","line":266,"range":{"start_line":264,"start_character":0,"end_line":266,"end_character":34},"updated":"2020-02-27 02:07:24.000000000","message":"maybe you can remove the \u0027fetch_\u0027 from these function name.","commit_id":"a90be880a1fe42e0a313f569085076c873a90d9d"}],"inc/plugin":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d23ea089387929e143d253527da85c4d55475a77","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"function devstack_localrc {"},{"line_number":168,"context_line":"    if [ \"${GRENADE_DEVSTACK_EXTERNAL}\" \u003d\u003d \"True\" ]; then"},{"line_number":169,"context_line":"        echo \"DevStack is configure externally, ignoring \\$(devstack_localrc $@)\""},{"line_number":170,"context_line":"        return"},{"line_number":171,"context_line":"    fi"},{"line_number":172,"context_line":"    local settings_file\u003d$(caller | awk \u0027{print $2}\u0027)"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"1fa4df85_697dfde5","line":169,"range":{"start_line":169,"start_character":26,"end_line":169,"end_character":35},"updated":"2020-02-29 18:10:39.000000000","message":"configured","commit_id":"a90be880a1fe42e0a313f569085076c873a90d9d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"a6330db26e22d3eaf0e82748061e7908b72b35cf","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"function devstack_localrc {"},{"line_number":168,"context_line":"    if [ \"${GRENADE_DEVSTACK_EXTERNAL}\" \u003d\u003d \"True\" ]; then"},{"line_number":169,"context_line":"        echo \"DevStack is configure externally, ignoring \\$(devstack_localrc $@)\""},{"line_number":170,"context_line":"        return"},{"line_number":171,"context_line":"    fi"},{"line_number":172,"context_line":"    local settings_file\u003d$(caller | awk \u0027{print $2}\u0027)"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"1fa4df85_c4f3ae09","line":169,"range":{"start_line":169,"start_character":26,"end_line":169,"end_character":35},"in_reply_to":"1fa4df85_697dfde5","updated":"2020-03-02 11:20:46.000000000","message":"Done","commit_id":"a90be880a1fe42e0a313f569085076c873a90d9d"}]}