)]}'
{"doc/requirements.txt":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4db73a4e54f7db094b638e8dc3aa79cfe6374981","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Pygments"},{"line_number":2,"context_line":"docutils"},{"line_number":3,"context_line":"sphinx\u003e\u003d1.8.0,\u003c2.0.0;python_version\u003d\u003d\u00272.7\u0027  # BSD"},{"line_number":4,"context_line":"sphinx\u003e\u003d1.8.0,!\u003d2.1.0;python_version\u003e\u003d\u00273.4\u0027  # BSD"},{"line_number":5,"context_line":"openstackdocstheme\u003e\u003d1.30.0  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":3,"id":"3fa7e38b_0681acfa","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":50},"updated":"2020-01-21 20:57:12.000000000","message":"you can drop python_version things.","commit_id":"e84189861c4e431ab1cf3c23d82715a25ca8e0f2"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"063671c2449c6dbe3708f519fbfa9f9d4d2aad77","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Pygments"},{"line_number":2,"context_line":"docutils"},{"line_number":3,"context_line":"sphinx\u003e\u003d1.8.0,\u003c2.0.0;python_version\u003d\u003d\u00272.7\u0027  # BSD"},{"line_number":4,"context_line":"sphinx\u003e\u003d1.8.0,!\u003d2.1.0;python_version\u003e\u003d\u00273.4\u0027  # BSD"},{"line_number":5,"context_line":"openstackdocstheme\u003e\u003d1.30.0  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":3,"id":"3fa7e38b_6cbde1b0","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":50},"in_reply_to":"3fa7e38b_0681acfa","updated":"2020-01-21 23:10:04.000000000","message":"Oh, I wasn\u0027t sure, because grenade is testing old version, which still does support py2. But, daahh, I guess the docs build is only ever running on py3.\n\nAlso, did we fix the thing that was forcing us to keep the version specifier for 3.4?","commit_id":"e84189861c4e431ab1cf3c23d82715a25ca8e0f2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d61cbdf86548d3b3e405f1c70f9cbdb81d8928fe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Pygments"},{"line_number":2,"context_line":"docutils"},{"line_number":3,"context_line":"sphinx\u003e\u003d1.8.0,!\u003d2.1.0  # BSD"},{"line_number":4,"context_line":"openstackdocstheme\u003e\u003d1.30.0  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"3fa7e38b_ad3f50b0","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":8},"updated":"2020-01-22 08:57:54.000000000","message":"I doubt these are necessary any longer","commit_id":"0d5042b0ce5b402ec023b0f6c8c226a3e02f30ca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"658f7a8724e289869ca642f788c65b7705b9334b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Pygments"},{"line_number":2,"context_line":"docutils"},{"line_number":3,"context_line":"sphinx\u003e\u003d1.8.0,!\u003d2.1.0  # BSD"},{"line_number":4,"context_line":"openstackdocstheme\u003e\u003d1.30.0  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"3fa7e38b_1b76d340","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"3fa7e38b_78cd8db8","updated":"2020-01-22 17:59:59.000000000","message":"Yeah, they\u0027ll be pulled in by Sphinx [1]\n\n[1] https://github.com/sphinx-doc/sphinx/blob/v1.8.0/setup.py#L21-L22","commit_id":"0d5042b0ce5b402ec023b0f6c8c226a3e02f30ca"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"365ea76a3a3fb11e1f0d1396eea512a811a5f30f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Pygments"},{"line_number":2,"context_line":"docutils"},{"line_number":3,"context_line":"sphinx\u003e\u003d1.8.0,!\u003d2.1.0  # BSD"},{"line_number":4,"context_line":"openstackdocstheme\u003e\u003d1.30.0  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"3fa7e38b_78cd8db8","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"3fa7e38b_ad3f50b0","updated":"2020-01-22 16:43:25.000000000","message":"Trying via https://review.opendev.org/703838 on top of this patch.","commit_id":"0d5042b0ce5b402ec023b0f6c8c226a3e02f30ca"}],"doc/source/conf.py":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ac54d03980f55f0893838eb7ac0a500067154c84","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Add any Sphinx extension module names here, as strings. They can be extensions"},{"line_number":38,"context_line":"# coming with Sphinx (named \u0027sphinx.ext.*\u0027) or your custom ones."},{"line_number":39,"context_line":"extensions \u003d []"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"todo_include_todos \u003d True"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8f237606","line":39,"updated":"2020-01-21 17:50:40.000000000","message":"we might want \u0027openstackdocstheme\u0027 instead","commit_id":"42449051140296d3227addcde15b9e3c334d090c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"64fd79540acd1c8359ebf5187cbb49c505b8d47f","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Add any Sphinx extension module names here, as strings. They can be extensions"},{"line_number":38,"context_line":"# coming with Sphinx (named \u0027sphinx.ext.*\u0027) or your custom ones."},{"line_number":39,"context_line":"extensions \u003d []"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"todo_include_todos \u003d True"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_654e5991","line":39,"in_reply_to":"3fa7e38b_0ad9b426","updated":"2020-01-21 19:46:44.000000000","message":"Done","commit_id":"42449051140296d3227addcde15b9e3c334d090c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"416410d3e58f949e79782b95a1d5de3dca2a36e4","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Add any Sphinx extension module names here, as strings. They can be extensions"},{"line_number":38,"context_line":"# coming with Sphinx (named \u0027sphinx.ext.*\u0027) or your custom ones."},{"line_number":39,"context_line":"extensions \u003d []"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"todo_include_todos \u003d True"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8fadb633","line":39,"in_reply_to":"3fa7e38b_8f237606","updated":"2020-01-21 17:57:50.000000000","message":"Probably true. Separate change?","commit_id":"42449051140296d3227addcde15b9e3c334d090c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"d022ca7278eda04dca39296cd227708dd3a950cb","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Add any Sphinx extension module names here, as strings. They can be extensions"},{"line_number":38,"context_line":"# coming with Sphinx (named \u0027sphinx.ext.*\u0027) or your custom ones."},{"line_number":39,"context_line":"extensions \u003d []"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"todo_include_todos \u003d True"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_0ad9b426","line":39,"in_reply_to":"3fa7e38b_8fadb633","updated":"2020-01-21 18:41:56.000000000","message":"I\u0027d say this change: the oslosphinx-\u003eopenstackdocstheme has been an atomic change in other projects","commit_id":"42449051140296d3227addcde15b9e3c334d090c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"658f7a8724e289869ca642f788c65b7705b9334b","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Add any Sphinx extension module names here, as strings. They can be extensions"},{"line_number":38,"context_line":"# coming with Sphinx (named \u0027sphinx.ext.*\u0027) or your custom ones."},{"line_number":39,"context_line":"extensions \u003d [\u0027openstackdocstheme\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"todo_include_todos \u003d True"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_bb6e9f62","line":39,"updated":"2020-01-22 17:59:59.000000000","message":"wow","commit_id":"0d5042b0ce5b402ec023b0f6c8c226a3e02f30ca"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"444df910b2542b7af0ca9f23e00423591986db05","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Add any Sphinx extension module names here, as strings. They can be extensions"},{"line_number":38,"context_line":"# coming with Sphinx (named \u0027sphinx.ext.*\u0027) or your custom ones."},{"line_number":39,"context_line":"extensions \u003d [\u0027openstackdocstheme\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"todo_include_todos \u003d True"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_7bc26704","line":39,"in_reply_to":"3fa7e38b_bb6e9f62","updated":"2020-01-22 18:14:52.000000000","message":"doge? wow, so themed, much extension","commit_id":"0d5042b0ce5b402ec023b0f6c8c226a3e02f30ca"}],"test-requirements.txt":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ac54d03980f55f0893838eb7ac0a500067154c84","unresolved":false,"context_lines":[{"line_number":1,"context_line":"pbr\u003e\u003d0.6,!\u003d0.7,\u003c1.0"},{"line_number":2,"context_line":"Pygments"},{"line_number":3,"context_line":"docutils"},{"line_number":4,"context_line":"sphinx\u003e\u003d1.8.0,\u003c2.0.0;python_version\u003d\u003d\u00272.7\u0027 # BSD"},{"line_number":5,"context_line":"sphinx\u003e\u003d1.8.0,!\u003d2.1.0;python_version\u003e\u003d\u00273.4\u0027  # BSD"},{"line_number":6,"context_line":"bashate \u003e\u003d 0.2"}],"source_content_type":"text/plain","patch_set":1,"id":"3fa7e38b_ef0a2a76","line":4,"range":{"start_line":4,"start_character":42,"end_line":4,"end_character":43},"updated":"2020-01-21 17:50:40.000000000","message":"spacing","commit_id":"42449051140296d3227addcde15b9e3c334d090c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"64fd79540acd1c8359ebf5187cbb49c505b8d47f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"pbr\u003e\u003d0.6,!\u003d0.7,\u003c1.0"},{"line_number":2,"context_line":"Pygments"},{"line_number":3,"context_line":"docutils"},{"line_number":4,"context_line":"sphinx\u003e\u003d1.8.0,\u003c2.0.0;python_version\u003d\u003d\u00272.7\u0027 # BSD"},{"line_number":5,"context_line":"sphinx\u003e\u003d1.8.0,!\u003d2.1.0;python_version\u003e\u003d\u00273.4\u0027  # BSD"},{"line_number":6,"context_line":"bashate \u003e\u003d 0.2"}],"source_content_type":"text/plain","patch_set":1,"id":"3fa7e38b_052d25ad","line":4,"range":{"start_line":4,"start_character":42,"end_line":4,"end_character":43},"in_reply_to":"3fa7e38b_ef0a2a76","updated":"2020-01-21 19:46:44.000000000","message":"Done","commit_id":"42449051140296d3227addcde15b9e3c334d090c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e1e85370a9262d2b99ca6dbd1dff17c077dfa40c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Pygments"},{"line_number":3,"context_line":"docutils"},{"line_number":4,"context_line":"sphinx\u003e\u003d1.8.0,\u003c2.0.0;python_version\u003d\u003d\u00272.7\u0027 # BSD"},{"line_number":5,"context_line":"sphinx\u003e\u003d1.8.0,!\u003d2.1.0;python_version\u003e\u003d\u00273.4\u0027  # BSD"},{"line_number":6,"context_line":"bashate \u003e\u003d 0.2"}],"source_content_type":"text/plain","patch_set":1,"id":"3fa7e38b_4f47bea5","line":5,"updated":"2020-01-21 17:53:03.000000000","message":"I guess sphinx should not be in test-requirements in the first place to avoid triggering all tests when updating it. Best put it in some \u0027doc-requirements.txt\u0027 or \u0027doc/requirements.txt\u0027...","commit_id":"42449051140296d3227addcde15b9e3c334d090c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"d022ca7278eda04dca39296cd227708dd3a950cb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Pygments"},{"line_number":3,"context_line":"docutils"},{"line_number":4,"context_line":"sphinx\u003e\u003d1.8.0,\u003c2.0.0;python_version\u003d\u003d\u00272.7\u0027 # BSD"},{"line_number":5,"context_line":"sphinx\u003e\u003d1.8.0,!\u003d2.1.0;python_version\u003e\u003d\u00273.4\u0027  # BSD"},{"line_number":6,"context_line":"bashate \u003e\u003d 0.2"}],"source_content_type":"text/plain","patch_set":1,"id":"3fa7e38b_ea0a1876","line":5,"in_reply_to":"3fa7e38b_0fba2670","updated":"2020-01-21 18:41:56.000000000","message":"I think it should be part of this change as well, as it happened in other projects.","commit_id":"42449051140296d3227addcde15b9e3c334d090c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"416410d3e58f949e79782b95a1d5de3dca2a36e4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Pygments"},{"line_number":3,"context_line":"docutils"},{"line_number":4,"context_line":"sphinx\u003e\u003d1.8.0,\u003c2.0.0;python_version\u003d\u003d\u00272.7\u0027 # BSD"},{"line_number":5,"context_line":"sphinx\u003e\u003d1.8.0,!\u003d2.1.0;python_version\u003e\u003d\u00273.4\u0027  # BSD"},{"line_number":6,"context_line":"bashate \u003e\u003d 0.2"}],"source_content_type":"text/plain","patch_set":1,"id":"3fa7e38b_0fba2670","line":5,"in_reply_to":"3fa7e38b_4f47bea5","updated":"2020-01-21 17:57:50.000000000","message":"Agree with that in principle. Is that a separate change?","commit_id":"42449051140296d3227addcde15b9e3c334d090c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"cbe44794a58057d136e7f8ec53b91bb9f8dd7dee","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Pygments"},{"line_number":3,"context_line":"docutils"},{"line_number":4,"context_line":"sphinx\u003e\u003d1.8.0,\u003c2.0.0;python_version\u003d\u003d\u00272.7\u0027 # BSD"},{"line_number":5,"context_line":"sphinx\u003e\u003d1.8.0,!\u003d2.1.0;python_version\u003e\u003d\u00273.4\u0027  # BSD"},{"line_number":6,"context_line":"bashate \u003e\u003d 0.2"}],"source_content_type":"text/plain","patch_set":1,"id":"3fa7e38b_8037c3e4","line":5,"in_reply_to":"3fa7e38b_c532ad0e","updated":"2020-01-21 19:51:30.000000000","message":"Done. No idea if it\u0027s going to pass zuul though.","commit_id":"42449051140296d3227addcde15b9e3c334d090c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"64fd79540acd1c8359ebf5187cbb49c505b8d47f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Pygments"},{"line_number":3,"context_line":"docutils"},{"line_number":4,"context_line":"sphinx\u003e\u003d1.8.0,\u003c2.0.0;python_version\u003d\u003d\u00272.7\u0027 # BSD"},{"line_number":5,"context_line":"sphinx\u003e\u003d1.8.0,!\u003d2.1.0;python_version\u003e\u003d\u00273.4\u0027  # BSD"},{"line_number":6,"context_line":"bashate \u003e\u003d 0.2"}],"source_content_type":"text/plain","patch_set":1,"id":"3fa7e38b_c532ad0e","line":5,"in_reply_to":"3fa7e38b_ea0a1876","updated":"2020-01-21 19:46:44.000000000","message":"Okay, I\u0027ll work on that in the next PS.","commit_id":"42449051140296d3227addcde15b9e3c334d090c"}],"tox.ini":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"658f7a8724e289869ca642f788c65b7705b9334b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"[testenv:docs]"},{"line_number":21,"context_line":"basepython \u003d python3"},{"line_number":22,"context_line":"whitelist_externals \u003d bash"},{"line_number":23,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":24,"context_line":"setenv \u003d"},{"line_number":25,"context_line":"  TOP_DIR\u003d{toxinidir}"},{"line_number":26,"context_line":"  INSTALL_SHOCCO\u003dtrue"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_db6b5b51","line":23,"updated":"2020-01-22 17:59:59.000000000","message":"Hmm, no upper constraints here, I guess","commit_id":"0d5042b0ce5b402ec023b0f6c8c226a3e02f30ca"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dceb9201c00969f842b04f341b06e496f5bbbf76","unresolved":false,"context_lines":[{"line_number":20,"context_line":"[testenv:docs]"},{"line_number":21,"context_line":"basepython \u003d python3"},{"line_number":22,"context_line":"whitelist_externals \u003d bash"},{"line_number":23,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":24,"context_line":"setenv \u003d"},{"line_number":25,"context_line":"  TOP_DIR\u003d{toxinidir}"},{"line_number":26,"context_line":"  INSTALL_SHOCCO\u003dtrue"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_fe22c501","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":7},"updated":"2020-01-22 19:16:08.000000000","message":"deps \u003d\n  -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}\n  -r{toxinidir}/doc/requirements.txt","commit_id":"0d5042b0ce5b402ec023b0f6c8c226a3e02f30ca"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"30b76310be881d8f5abb54e906748a4b4cce4d54","unresolved":false,"context_lines":[{"line_number":20,"context_line":"[testenv:docs]"},{"line_number":21,"context_line":"basepython \u003d python3"},{"line_number":22,"context_line":"whitelist_externals \u003d bash"},{"line_number":23,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":24,"context_line":"setenv \u003d"},{"line_number":25,"context_line":"  TOP_DIR\u003d{toxinidir}"},{"line_number":26,"context_line":"  INSTALL_SHOCCO\u003dtrue"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_1ed321d5","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":7},"in_reply_to":"3fa7e38b_7e5d757a","updated":"2020-01-22 19:19:54.000000000","message":"\u003e set in both\n\nOkay, PS2 sets in both","commit_id":"0d5042b0ce5b402ec023b0f6c8c226a3e02f30ca"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"23a3ca58a48f85a05bc86cda65d8d6dd01d703ae","unresolved":false,"context_lines":[{"line_number":20,"context_line":"[testenv:docs]"},{"line_number":21,"context_line":"basepython \u003d python3"},{"line_number":22,"context_line":"whitelist_externals \u003d bash"},{"line_number":23,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":24,"context_line":"setenv \u003d"},{"line_number":25,"context_line":"  TOP_DIR\u003d{toxinidir}"},{"line_number":26,"context_line":"  INSTALL_SHOCCO\u003dtrue"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_7e5d757a","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":7},"in_reply_to":"3fa7e38b_9e7951fc","updated":"2020-01-22 19:17:59.000000000","message":"IMHO followup and set in both, let\u0027s not waste check results.","commit_id":"0d5042b0ce5b402ec023b0f6c8c226a3e02f30ca"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3e71abbd207c356d06e8386fc951a72cf547fb07","unresolved":false,"context_lines":[{"line_number":20,"context_line":"[testenv:docs]"},{"line_number":21,"context_line":"basepython \u003d python3"},{"line_number":22,"context_line":"whitelist_externals \u003d bash"},{"line_number":23,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":24,"context_line":"setenv \u003d"},{"line_number":25,"context_line":"  TOP_DIR\u003d{toxinidir}"},{"line_number":26,"context_line":"  INSTALL_SHOCCO\u003dtrue"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_de6a6916","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":7},"in_reply_to":"3fa7e38b_9e7951fc","updated":"2020-01-22 19:17:52.000000000","message":"https://review.opendev.org/#/c/703860/","commit_id":"0d5042b0ce5b402ec023b0f6c8c226a3e02f30ca"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fe2e25784164785cfd2c2e74fe4ce7fb0e470412","unresolved":false,"context_lines":[{"line_number":20,"context_line":"[testenv:docs]"},{"line_number":21,"context_line":"basepython \u003d python3"},{"line_number":22,"context_line":"whitelist_externals \u003d bash"},{"line_number":23,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":24,"context_line":"setenv \u003d"},{"line_number":25,"context_line":"  TOP_DIR\u003d{toxinidir}"},{"line_number":26,"context_line":"  INSTALL_SHOCCO\u003dtrue"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_be3f6d21","line":23,"in_reply_to":"3fa7e38b_db6b5b51","updated":"2020-01-22 19:14:21.000000000","message":"This work for now but we should use u-c in case future change in sphinx break it.","commit_id":"0d5042b0ce5b402ec023b0f6c8c226a3e02f30ca"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"965c75e290c2da26cfa71707470ddd60e4691aee","unresolved":false,"context_lines":[{"line_number":20,"context_line":"[testenv:docs]"},{"line_number":21,"context_line":"basepython \u003d python3"},{"line_number":22,"context_line":"whitelist_externals \u003d bash"},{"line_number":23,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":24,"context_line":"setenv \u003d"},{"line_number":25,"context_line":"  TOP_DIR\u003d{toxinidir}"},{"line_number":26,"context_line":"  INSTALL_SHOCCO\u003dtrue"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_9e7951fc","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":7},"in_reply_to":"3fa7e38b_fe22c501","updated":"2020-01-22 19:16:54.000000000","message":"Yeah, was just doing that.\n\nShould I put it in the base [testenv] too?","commit_id":"0d5042b0ce5b402ec023b0f6c8c226a3e02f30ca"}]}