)]}'
{"id":"openstack%2Fgrenade~741675","triplet_id":"openstack%2Fgrenade~master~I0a31ff3d22ce63af87610343316fcdcc46425a1c","project":"openstack/grenade","branch":"master","topic":"glance-victoria-wsgi","hashtags":[],"change_id":"I0a31ff3d22ce63af87610343316fcdcc46425a1c","subject":"Disable all import methods if glance is not standalone","status":"ABANDONED","created":"2020-07-17 16:41:28.000000000","updated":"2020-08-27 14:59:55.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"dc593ae91259c037fbe38cecd218bb680bcb26c8","_number":741675,"virtual_id_number":741675,"owner":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"tag":"autogenerated:zuul:check","value":1,"date":"2020-07-20 16:51:39.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":1,"date":"2020-07-20 18:14:17.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":-1,"date":"2020-07-21 22:45:04.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-17 16:46:06.000000000","updated_by":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"reviewer":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"state":"REVIEWER"},{"updated":"2020-07-20 16:51:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-20 18:14:17.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"}],"messages":[{"id":"660faef04b32662228ba054cf9f4934d0b2103b5","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-17 16:41:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ac3910e140eaae97b2197589aec6b63988ae24b4","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-07-17 16:46:06.000000000","message":"Patch Set 1: Code-Review+2\n\nI am pretty sure you will make some (many?) operators unhappy about that new failure but I understand the need.","accounts_in_message":[],"_revision_number":1},{"id":"0c41ea38a93b6b9cf70e36bba32c42219ef59cb2","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-17 17:46:42.000000000","message":"Patch Set 1:\n\n\u003e I am pretty sure you will make some (many?) operators unhappy about\n \u003e that new failure but I understand the need.\n\nYeah, we can either document the upgrade requirement and fail now so they notice and fix, or we can log a warning and then make it fail later. I think the glance PTL is in favor of being explicit right away, since it\u0027s advertising something bad from the API right now. But, of course, we could go the other way if it\u0027s important to people.","accounts_in_message":[],"_revision_number":1},{"id":"14e164c8a5b5b501a797d93f8799306806e6d2a5","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-07-17 17:54:18.000000000","message":"Patch Set 1:\n\n\u003e \u003e I am pretty sure you will make some (many?) operators unhappy\n \u003e about\n \u003e \u003e that new failure but I understand the need.\n \u003e \n \u003e Yeah, we can either document the upgrade requirement and fail now\n \u003e so they notice and fix, or we can log a warning and then make it\n \u003e fail later. I think the glance PTL is in favor of being explicit\n \u003e right away, since it\u0027s advertising something bad from the API right\n \u003e now. But, of course, we could go the other way if it\u0027s important to\n \u003e people.\n\nTo be honest, I usually also err on the side of failing. Just sharing some wisdom. I agree with intentions.","accounts_in_message":[],"_revision_number":1},{"id":"1fc8c496d5560523139f62743e34fa79862fb928","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-18 00:02:02.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b649be4f49a947bea2fcaa785dcdaa4d : SUCCESS in 9m 23s\n- grenade https://zuul.opendev.org/t/openstack/build/51cf8a7fd85d44ca85a09b694cdf71b6 : FAILURE in 56m 18s\n- grenade-heat https://zuul.opendev.org/t/openstack/build/56b1f7fa85cb4f6fb046800d21cf104b : FAILURE in 1h 00m 00s (non-voting)\n- grenade-multinode https://zuul.opendev.org/t/openstack/build/05dd9b6851c54e6da7c758dcc0352543 : FAILURE in 1h 02m 33s\n- ironic-grenade https://zuul.opendev.org/t/openstack/build/90fb2d38734a4f0ab0f5f9e2add4c3dc : FAILURE in 56m 15s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"76a5ae8abe832239b34035bf72950db976b2534d","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-20 14:22:36.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"404a66bdb4f8e1dd5c2ffc978b884b2e66e53c54","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-20 15:21:11.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"d07a14e1f4d677fe30564d060e5e734b1e22ab4d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-20 16:51:39.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6ab3cfccb2224bac810fe50c7a5360d1 : SUCCESS in 15m 20s\n- grenade https://zuul.opendev.org/t/openstack/build/83d33bebdd4d46cdb5edb316f783d1b8 : SUCCESS in 44m 49s\n- grenade-heat https://zuul.opendev.org/t/openstack/build/d56529d927d14824a38f6c1a60b2aa4b : SUCCESS in 1h 22m 53s (non-voting)\n- grenade-multinode https://zuul.opendev.org/t/openstack/build/05727735cbc14a7181fa29e72b05e659 : SUCCESS in 1h 09m 06s\n- ironic-grenade https://zuul.opendev.org/t/openstack/build/49597bb621004f52aa388ea0608bec69 : SUCCESS in 1h 17m 05s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"4a07ba04a2d56c60a9961a897c3a52426662ba91","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-07-20 18:14:17.000000000","message":"Patch Set 3: Code-Review+1\n\nlgtm, waiting for glance patch to be +2 at least. https://review.opendev.org/#/c/741497/4","accounts_in_message":[],"_revision_number":3},{"id":"267c947a0c9a9105fe463fc85840c73b4fc9989e","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-21 22:45:04.000000000","message":"Patch Set 3: Workflow-1\n\nWe\u0027re probably not doing this since we\u0027re aiming for the wsgi server to be able to run import methods properly, so I will -W this for the time being to make it clear we don\u0027t want to merge this right now.","accounts_in_message":[],"_revision_number":3},{"id":"e195d14e0f152485172a40d86fc125231f5ab5aa","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-08-27 14:59:55.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"7a863223d5360482a8e25aaacd009589c74a77d1","revisions":{"223f381484dc77fdcc4d96c4a33eaf375f881f44":{"kind":"REWORK","_number":1,"created":"2020-07-17 16:41:28.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/75/741675/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/grenade","ref":"refs/changes/75/741675/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/grenade refs/changes/75/741675/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/grenade refs/changes/75/741675/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/grenade refs/changes/75/741675/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/grenade refs/changes/75/741675/1"}}},"commit":{"parents":[{"commit":"edb6ddc2db1cf93211bd43a68097a47c5b455582","subject":"Always assume glance is uwsgi mode for grenade","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/edb6ddc2db1cf93211bd43a68097a47c5b455582"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-07-17 16:38:42.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-07-17 16:38:42.000000000","tz":-420},"subject":"Disable all import methods if glance is not standalone","message":"Disable all import methods if glance is not standalone\n\nWhen we upgrade from U-\u003eV, we need to disable all the import methods\nif Glance is not standalone for API correctness. This was introduced\nas a requirement in [1] and devstack now does this on new installs[2].\nDuring an upgrade, this needs to be done against the old config file\nin order to pass the strict check in Victoria Glance.\n\nWe want this to be very visible for operators, because right now\nGlance API is advertising features that are impossible to support\nin pure-WSGI mode.\n\n[1] https://review.opendev.org/#/c/741497/\n[2] https://review.opendev.org/#/c/741507/\n\nChange-Id: I0a31ff3d22ce63af87610343316fcdcc46425a1c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/223f381484dc77fdcc4d96c4a33eaf375f881f44"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/223f381484dc77fdcc4d96c4a33eaf375f881f44"}]},"branch":"refs/heads/master"},"5d97ddefb81a23a8d5bead36fcfbe85ef6569d1e":{"kind":"REWORK","_number":2,"created":"2020-07-20 14:22:36.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/75/741675/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/grenade","ref":"refs/changes/75/741675/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/grenade refs/changes/75/741675/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/grenade refs/changes/75/741675/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/grenade refs/changes/75/741675/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/grenade refs/changes/75/741675/2"}}},"commit":{"parents":[{"commit":"edb6ddc2db1cf93211bd43a68097a47c5b455582","subject":"Always assume glance is uwsgi mode for grenade","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/edb6ddc2db1cf93211bd43a68097a47c5b455582"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-07-17 16:38:42.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-07-20 14:22:48.000000000","tz":-420},"subject":"Disable all import methods if glance is not standalone","message":"Disable all import methods if glance is not standalone\n\nWhen we upgrade from U-\u003eV, we need to disable all the import methods\nif Glance is not standalone for API correctness. This was introduced\nas a requirement in [1] and devstack now does this on new installs[2].\nDuring an upgrade, this needs to be done against the old config file\nin order to pass the strict check in Victoria Glance.\n\nWe want this to be very visible for operators, because right now\nGlance API is advertising features that are impossible to support\nin pure-WSGI mode.\n\n[1] https://review.opendev.org/#/c/741497/\n[2] https://review.opendev.org/#/c/741507/\n\nChange-Id: I0a31ff3d22ce63af87610343316fcdcc46425a1c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/5d97ddefb81a23a8d5bead36fcfbe85ef6569d1e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/5d97ddefb81a23a8d5bead36fcfbe85ef6569d1e"}]},"branch":"refs/heads/master"},"7a863223d5360482a8e25aaacd009589c74a77d1":{"kind":"REWORK","_number":3,"created":"2020-07-20 15:21:11.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/75/741675/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/grenade","ref":"refs/changes/75/741675/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/grenade refs/changes/75/741675/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/grenade refs/changes/75/741675/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/grenade refs/changes/75/741675/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/grenade refs/changes/75/741675/3"}}},"commit":{"parents":[{"commit":"edb6ddc2db1cf93211bd43a68097a47c5b455582","subject":"Always assume glance is uwsgi mode for grenade","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/edb6ddc2db1cf93211bd43a68097a47c5b455582"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-07-17 16:38:42.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-07-20 15:21:24.000000000","tz":-420},"subject":"Disable all import methods if glance is not standalone","message":"Disable all import methods if glance is not standalone\n\nWhen we upgrade from U-\u003eV, we need to disable all the import methods\nif Glance is not standalone for API correctness. This was introduced\nas a requirement in [1] and devstack now does this on new installs[2].\nDuring an upgrade, this needs to be done against the old config file\nin order to pass the strict check in Victoria Glance.\n\nWe want this to be very visible for operators, because right now\nGlance API is advertising features that are impossible to support\nin pure-WSGI mode.\n\n[1] https://review.opendev.org/#/c/741497/\n[2] https://review.opendev.org/#/c/741507/\n\nChange-Id: I0a31ff3d22ce63af87610343316fcdcc46425a1c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/7a863223d5360482a8e25aaacd009589c74a77d1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/7a863223d5360482a8e25aaacd009589c74a77d1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}