)]}'
{"id":"openstack%2Fgrenade~747579","triplet_id":"openstack%2Fgrenade~master~I389e2a4f8135e0e22a70098b95c17457cbedf1cf","project":"openstack/grenade","branch":"master","topic":"fix-horizon-upgrade-screen","hashtags":[],"change_id":"I389e2a4f8135e0e22a70098b95c17457cbedf1cf","subject":"Fix horizon upgrade: remove screen_stop call","status":"MERGED","created":"2020-08-23 14:54:29.000000000","updated":"2020-08-24 08:33:59.000000000","submitted":"2020-08-24 08:32:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"747579-1598257963831-8a9bf4a0","meta_rev_id":"f192f6fa7b1690be4a46971236e6a376a5acd26c","_number":747579,"virtual_id_number":747579,"owner":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"date":"2020-08-23 23:48:26.000000000","_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-24 08:32:43.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":2,"date":"2020-08-23 18:51:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":2,"date":"2020-08-24 07:22:46.000000000","_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":1,"date":"2020-08-24 07:22:46.000000000","_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-23 18:51:40.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2020-08-24 07:22:46.000000000","updated_by":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"reviewer":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"state":"REVIEWER"},{"updated":"2020-08-24 08:32:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cafe99b7282c538ff46e20b31cca3b4f3b8d0ae1","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2020-08-23 14:54:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"16a565ca94d2e65b347bbbf1db54e2dd83ed76e6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-23 16:22:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/81b96a89e3ee4419be6f3f9bc3c7c720 : SUCCESS in 8m 55s\n- grenade https://zuul.opendev.org/t/openstack/build/a3f3822adcd04040adf367194db7939c : SUCCESS in 1h 02m 06s\n- grenade-heat https://zuul.opendev.org/t/openstack/build/cb518e267c384dfea64cf2834f9aeca4 : SUCCESS in 1h 21m 04s (non-voting)\n- grenade-multinode https://zuul.opendev.org/t/openstack/build/7cefbde8d386422fb4bb172a11df3fc1 : SUCCESS in 1h 22m 22s\n- ironic-grenade https://zuul.opendev.org/t/openstack/build/612620e48d7c4fb68b6ec5fc3fa2eef3 : SUCCESS in 1h 17m 10s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"74c2b36670457c4d49efa4dff75434ae93d61cba","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2020-08-23 16:30:19.000000000","message":"Patch Set 1:\n\nExample of usage: https://review.opendev.org/#/c/747260/\n\nPlease compare patch set 8 (failing without this change) and patch set 9 (which depends on this change and it passes).","accounts_in_message":[],"_revision_number":1},{"id":"d39f39fec2af6773d49bb5b1798f981c2aff5951","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2020-08-23 16:47:37.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"c7a60838722247595a55e0a098965ae074ed5062","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2020-08-23 16:49:57.000000000","message":"Patch Set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"6ec43e9f601fac7b003e784ad89c002fdb90c4e7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-23 18:11:14.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8c8e6a7be0ed43c69c508f97a9ace53d : SUCCESS in 5m 56s\n- grenade https://zuul.opendev.org/t/openstack/build/7622e014fb2b4b34bbca69834d3a0079 : SUCCESS in 1h 00m 56s\n- grenade-heat https://zuul.opendev.org/t/openstack/build/a45600a894c04643b517893984a903ee : SUCCESS in 1h 20m 07s (non-voting)\n- grenade-multinode https://zuul.opendev.org/t/openstack/build/a4e90d0438b34b6087d3bbe4697698b7 : SUCCESS in 1h 11m 34s\n- ironic-grenade https://zuul.opendev.org/t/openstack/build/861c908d7e1942558fb618f33de4fd67 : SUCCESS in 1h 13m 02s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"f7e1458dab2aaa4b24b4c53d899a6737f91da62b","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-08-23 18:51:40.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"f88633055b23a3a34a002061d97ee993886ce290","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2020-08-23 23:48:26.000000000","message":"Patch Set 3:\n\ncheck experimental","accounts_in_message":[],"_revision_number":3},{"id":"e4010812a828eefde1bfd079aa48739e7638d166","tag":"autogenerated:zuul:experimental","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 01:38:26.000000000","message":"Patch Set 3:\n\nBuild failed (experimental pipeline).\n\n- grenade-postgresql https://zuul.opendev.org/t/openstack/build/23562a5db19546f38fefa3e864741b64 : SUCCESS in 1h 07m 02s\n- trove-grenade https://zuul.opendev.org/t/openstack/build/8414b879304740bfbf29a521f052c561 : FAILURE in 1h 48m 29s","accounts_in_message":[],"_revision_number":3},{"id":"e859ee48ed6c662cf7be3e0df01ed27d4f7aca28","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-08-24 07:22:46.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"31a9c2fff2633daea64986079afec4817b1abf80","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 07:22:58.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"7e68e91515d5b0036d6df608f05404bd16ed44d6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 08:32:43.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"6ba0530b90d425b54668b3be89f2e3cb6961e93f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 08:32:43.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/06c86edd9cce40f19ceec287b7f9ea1d : SUCCESS in 10m 56s\n- grenade https://zuul.opendev.org/t/openstack/build/81c60192007b4ea49527f35abf16b055 : SUCCESS in 1h 03m 11s\n- grenade-multinode https://zuul.opendev.org/t/openstack/build/3ff3d1ca49d9466b886ecd36adb0a823 : SUCCESS in 53m 37s","accounts_in_message":[],"_revision_number":3},{"id":"0653e8f4c0210bfc5400c21beaefe4368210e442","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 08:33:59.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/926b37adbb5e4ac28cf7320167361363 : SUCCESS in 56s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"290ebb4220e95da85a7906fe0de9bc1c8728b295","revisions":{"39d284e885c1b97e6ca76b26461cdbe40c8f9e5e":{"kind":"REWORK","_number":1,"created":"2020-08-23 14:54:29.000000000","uploader":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"ref":"refs/changes/79/747579/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/grenade","ref":"refs/changes/79/747579/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/grenade refs/changes/79/747579/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/grenade refs/changes/79/747579/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/grenade refs/changes/79/747579/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/grenade refs/changes/79/747579/1"}}},"commit":{"parents":[{"commit":"8b4b463be8b20e2d966c9c0289345a7aa28bc879","subject":"Merge \"Explicitly enable ml2/ovs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/8b4b463be8b20e2d966c9c0289345a7aa28bc879"}]}],"author":{"name":"Luigi Toscano","email":"ltoscano@redhat.com","date":"2020-08-23 14:50:30.000000000","tz":120},"committer":{"name":"Luigi Toscano","email":"ltoscano@redhat.com","date":"2020-08-23 14:50:30.000000000","tz":120},"subject":"Fix horizon upgrade: remove stop_screen call","message":"Fix horizon upgrade: remove stop_screen call\n\nThe stop_screen function was removed some time ago together\nwith the screen support (I8c27182f60b0f5310b3a8bf5feb02beb7ffbb26a)\n\nThis does probably mean no proper horizon/greande testing has happened\nin the past 3 years...\n\nChange-Id: I389e2a4f8135e0e22a70098b95c17457cbedf1cf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/39d284e885c1b97e6ca76b26461cdbe40c8f9e5e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/39d284e885c1b97e6ca76b26461cdbe40c8f9e5e"}]},"branch":"refs/heads/master"},"7f8a78af0642a270045a4429d51345af6876a324":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-08-23 16:47:37.000000000","uploader":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"ref":"refs/changes/79/747579/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/grenade","ref":"refs/changes/79/747579/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/grenade refs/changes/79/747579/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/grenade refs/changes/79/747579/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/grenade refs/changes/79/747579/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/grenade refs/changes/79/747579/2"}}},"commit":{"parents":[{"commit":"8b4b463be8b20e2d966c9c0289345a7aa28bc879","subject":"Merge \"Explicitly enable ml2/ovs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/8b4b463be8b20e2d966c9c0289345a7aa28bc879"}]}],"author":{"name":"Luigi Toscano","email":"ltoscano@redhat.com","date":"2020-08-23 14:50:30.000000000","tz":120},"committer":{"name":"Luigi Toscano","email":"ltoscano@redhat.com","date":"2020-08-23 16:47:34.000000000","tz":0},"subject":"Fix horizon upgrade: remove screen_stop call","message":"Fix horizon upgrade: remove screen_stop call\n\nThe screen_stop function was removed some time ago together\nwith the screen support (I8c27182f60b0f5310b3a8bf5feb02beb7ffbb26a)\n\nThis does probably mean no proper horizon/greande testing has happened\nin the past 3 years...\n\nChange-Id: I389e2a4f8135e0e22a70098b95c17457cbedf1cf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/7f8a78af0642a270045a4429d51345af6876a324"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/7f8a78af0642a270045a4429d51345af6876a324"}]},"branch":"refs/heads/master"},"290ebb4220e95da85a7906fe0de9bc1c8728b295":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2020-08-23 16:49:57.000000000","uploader":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"ref":"refs/changes/79/747579/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/grenade","ref":"refs/changes/79/747579/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/grenade refs/changes/79/747579/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/grenade refs/changes/79/747579/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/grenade refs/changes/79/747579/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/grenade refs/changes/79/747579/3"}}},"commit":{"parents":[{"commit":"8b4b463be8b20e2d966c9c0289345a7aa28bc879","subject":"Merge \"Explicitly enable ml2/ovs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/8b4b463be8b20e2d966c9c0289345a7aa28bc879"}]}],"author":{"name":"Luigi Toscano","email":"ltoscano@redhat.com","date":"2020-08-23 14:50:30.000000000","tz":120},"committer":{"name":"Luigi Toscano","email":"ltoscano@redhat.com","date":"2020-08-23 16:49:53.000000000","tz":0},"subject":"Fix horizon upgrade: remove screen_stop call","message":"Fix horizon upgrade: remove screen_stop call\n\nThe screen_stop function was removed some time ago together\nwith the screen support (I8c27182f60b0f5310b3a8bf5feb02beb7ffbb26a)\n\nThis does probably mean no proper horizon/grenade testing has been\ndone in the past 3 years...\n\nChange-Id: I389e2a4f8135e0e22a70098b95c17457cbedf1cf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/290ebb4220e95da85a7906fe0de9bc1c8728b295"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/290ebb4220e95da85a7906fe0de9bc1c8728b295"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}