)]}'
{"projects/70_cinder/resources.sh":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8d2396a2e633a750b37169f8c9000d138669345c","unresolved":true,"context_lines":[{"line_number":254,"context_line":"    local volume\u003d\"$1\""},{"line_number":255,"context_line":"    echo \"Waiting for volume ${volume} to be deleted.\""},{"line_number":256,"context_line":"    count\u003d0"},{"line_number":257,"context_line":"    status\u003d$(openstack volume list --name ${volume} -f value -c ID | wc -l)"},{"line_number":258,"context_line":"    while [ $status -ne 0 ]"},{"line_number":259,"context_line":"    do"},{"line_number":260,"context_line":"        sleep 1"}],"source_content_type":"text/x-sh","patch_set":2,"id":"4330e022_cde9453f","line":257,"updated":"2020-12-21 10:17:35.000000000","message":"status and count should be declared local, too.","commit_id":"ad5509c3f8071c313358793ab627049d775b39aa"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"11569bfe8f572237ef910a625ebdf72f2595760d","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    local volume\u003d\"$1\""},{"line_number":255,"context_line":"    echo \"Waiting for volume ${volume} to be deleted.\""},{"line_number":256,"context_line":"    count\u003d0"},{"line_number":257,"context_line":"    status\u003d$(openstack volume list --name ${volume} -f value -c ID | wc -l)"},{"line_number":258,"context_line":"    while [ $status -ne 0 ]"},{"line_number":259,"context_line":"    do"},{"line_number":260,"context_line":"        sleep 1"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9ba20219_f00fe039","line":257,"in_reply_to":"4330e022_cde9453f","updated":"2020-12-21 10:56:53.000000000","message":"Ack","commit_id":"ad5509c3f8071c313358793ab627049d775b39aa"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8d2396a2e633a750b37169f8c9000d138669345c","unresolved":true,"context_lines":[{"line_number":261,"context_line":"        count\u003d$((count+1))"},{"line_number":262,"context_line":"        if [ ${count} -eq ${DELETE_TIMEOUT} ]; then"},{"line_number":263,"context_line":"            echo \"Timed out waiting for volume ${volume} to be deleted\""},{"line_number":264,"context_line":"            exit 4"},{"line_number":265,"context_line":"        fi"},{"line_number":266,"context_line":"        status\u003d$(openstack volume list --name ${volume} -f value -c ID | wc -l)"},{"line_number":267,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":2,"id":"071bdec1_14757fb2","line":264,"updated":"2020-12-21 10:17:35.000000000","message":"Shouldn\u0027t this be some \"die ...\" call instead?","commit_id":"ad5509c3f8071c313358793ab627049d775b39aa"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"11569bfe8f572237ef910a625ebdf72f2595760d","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        count\u003d$((count+1))"},{"line_number":262,"context_line":"        if [ ${count} -eq ${DELETE_TIMEOUT} ]; then"},{"line_number":263,"context_line":"            echo \"Timed out waiting for volume ${volume} to be deleted\""},{"line_number":264,"context_line":"            exit 4"},{"line_number":265,"context_line":"        fi"},{"line_number":266,"context_line":"        status\u003d$(openstack volume list --name ${volume} -f value -c ID | wc -l)"},{"line_number":267,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":2,"id":"6c3d537c_d0512d04","line":264,"in_reply_to":"071bdec1_14757fb2","updated":"2020-12-21 10:56:53.000000000","message":"Ack","commit_id":"ad5509c3f8071c313358793ab627049d775b39aa"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"861bb6a38f0e191f5615fb7d2392c581fc3fc9ad","unresolved":true,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    # Volume delete is async so wait for the encrypted volume to be removed"},{"line_number":283,"context_line":"    # before proceeding and trying to delete the volume type below."},{"line_number":284,"context_line":"    _wait_for_volume_delete $CINDER_VOL3"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    openstack security group delete $CINDER_USER"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"31866be9_31882750","line":284,"updated":"2020-12-17 17:00:06.000000000","message":"can we be sure that vol3 gets deleted after vol and vol2 is? should not we (for sanity) just wait for all 3 to really be deleted?","commit_id":"ad5509c3f8071c313358793ab627049d775b39aa"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"a39b90314a6092e7c6245990ba3b531c8a2ee5eb","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    # Volume delete is async so wait for the encrypted volume to be removed"},{"line_number":283,"context_line":"    # before proceeding and trying to delete the volume type below."},{"line_number":284,"context_line":"    _wait_for_volume_delete $CINDER_VOL3"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    openstack security group delete $CINDER_USER"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"a6935201_2b412550","line":284,"in_reply_to":"31866be9_31882750","updated":"2020-12-17 17:16:53.000000000","message":"We could wait for all three to be deleted but CINDER_VOL3 is the only one using the CINDER_VOL_ENCRYPTED_TYPE volume type and that in turn is causing bug #1907157.","commit_id":"ad5509c3f8071c313358793ab627049d775b39aa"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5db640e37b08a2301577c5f845c4b41bad07c97b","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    # Volume delete is async so wait for the encrypted volume to be removed"},{"line_number":283,"context_line":"    # before proceeding and trying to delete the volume type below."},{"line_number":284,"context_line":"    _wait_for_volume_delete $CINDER_VOL3"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    openstack security group delete $CINDER_USER"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"c5d4449c_ee7742c7","line":284,"in_reply_to":"a6935201_2b412550","updated":"2020-12-17 19:40:57.000000000","message":"Ah, did not notice. Makes sense to skip those two.","commit_id":"ad5509c3f8071c313358793ab627049d775b39aa"}]}