)]}'
{"id":"openstack%2Fgrenade~779755","triplet_id":"openstack%2Fgrenade~master~I3960c24665ace97989ea78673f4ef38f38f9d754","project":"openstack/grenade","branch":"master","topic":"lioadm","hashtags":[],"change_id":"I3960c24665ace97989ea78673f4ef38f38f9d754","subject":"zuul: Set CINDER_ISCSI_HELPER explicitly to tgtadm for grenade jobs","status":"ABANDONED","created":"2021-03-10 12:25:08.000000000","updated":"2021-03-12 16:05:16.000000000","total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"d066c1474d96ae3a35abee0547cd9792bcad444d","_number":779755,"virtual_id_number":779755,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-03-11 00:57:30.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":1,"date":"2021-03-11 23:12:31.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-10 14:37:31.000000000","updated_by":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"reviewer":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"state":"CC"},{"updated":"2021-03-10 14:39:14.000000000","updated_by":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"reviewer":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"state":"REVIEWER"},{"updated":"2021-03-10 15:39:54.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-11 23:12:31.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"}],"messages":[{"id":"d37a92878ff4565acc7d7d4c13861a68c6b11f2f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-10 12:25:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f3c206e1985a29ad11e21f2f3ffe165b5a2109e5","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-10 12:46:48.000000000","message":"Topic set to lioadm","accounts_in_message":[],"_revision_number":1},{"id":"858fdc575193b21cfed36aac8bc9b25af41bc92e","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2021-03-10 14:37:31.000000000","message":"Patch Set 1:\n\nJust a note: victoria is already based on Focal. This is maybe more a matter of defaults being set. Maybe you just need to set tgtadm as default on the stable/victoria branch (the upgrade should not change the configuration).","accounts_in_message":[],"_revision_number":1},{"id":"9f25e15a425df3fcdf2824d88c7a2cc0cdd00508","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2021-03-10 14:39:14.000000000","message":"Patch Set 1: Code-Review-1\n\nand if we set this to tgtadm in master (so wallaby), it wouldn\u0027t reflect what the deployment does","accounts_in_message":[],"_revision_number":1},{"id":"33ba980dfd2e645c8b3385ddfbefad0a38bff119","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-10 14:54:57.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e and if we set this to tgtadm in master (so wallaby), it wouldn\u0027t reflect what the deployment does\n\nI\u0027m not sure what you\u0027re trying to say here.\n\nIt\u0027s currently set in the shared local.conf used by devstack to currently deploy stable/victoria and then upgrade to master. If it\u0027s initially set to tgtadm on stable/victoria it *has* to be set to tgtadm on master regardless of what devstack master deploys by default.","accounts_in_message":[],"_revision_number":1},{"id":"e7a9a1fc6b7389df576770eef004023f81101580","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2021-03-10 15:36:35.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1: Code-Review-1\n\u003e \u003e \n\u003e \u003e and if we set this to tgtadm in master (so wallaby), it wouldn\u0027t reflect what the deployment does\n\u003e \n\u003e I\u0027m not sure what you\u0027re trying to say here.\n\u003e \n\u003e It\u0027s currently set in the shared local.conf used by devstack to currently deploy stable/victoria and then upgrade to master. If it\u0027s initially set to tgtadm on stable/victoria it *has* to be set to tgtadm on master regardless of what devstack master deploys by default.\n\nI don\u0027t think so. Grenade doesn\u0027t change the configuration, it only switch to the new code with the existing configuration. Before running the upgrade, the deployment happens using the devstack of the starting branch, which is stable/victoria.","accounts_in_message":[],"_revision_number":1},{"id":"3c7a6886974ed392c0ea3d9b77cc0019d96fd0e0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-10 15:39:54.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/07750557a6df4559ac3cace9b552f11a : TIMED_OUT in 31m 38s\n- grenade https://zuul.opendev.org/t/openstack/build/082319caadca451fbf6c63ad8eab0770 : SUCCESS in 1h 16m 42s\n- grenade-multinode https://zuul.opendev.org/t/openstack/build/5d216d72042e414c9c1c1a57b3d67380 : SUCCESS in 1h 11m 56s\n- ironic-grenade https://zuul.opendev.org/t/openstack/build/e727937d741041eab7f206c783ac40b4 : SUCCESS in 1h 12m 29s (non-voting)\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/4e988129bd9448f194d1dd08d09d1a32 : SUCCESS in 1h 11m 59s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"def976eb0dd28c3580edd4d4ef905c0aa9460ea0","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2021-03-10 15:52:56.000000000","message":"Patch Set 1:\n\nAlso: https://review.opendev.org/c/openstack/grenade/+/779807","accounts_in_message":[],"_revision_number":1},{"id":"63c15f7abb04426b2a84a5391d2a1dea15c13958","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2021-03-10 16:18:33.000000000","message":"Patch Set 1: -Code-Review\n\n(1 comment)\n\nThe discussion is going on on the etherpad of the cinder meeting, and grenade logic with old/ and new/ is always a bit complicated. I\u0027m removing my vote for now, but a note:","accounts_in_message":[],"_revision_number":1},{"id":"7e25a993a175714c685948a1cd33efe766492f01","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-10 16:25:27.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"010cc12400e1bf698cf7c474099382753650b367","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-10 17:10:05.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2feac74f01ca30ae37eb254deefd14ea428025c7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-11 00:57:30.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/62fae007c9864ff8a6e87a722119b3f5 : SUCCESS in 29m 53s\n- grenade https://zuul.opendev.org/t/openstack/build/99593dd8fb344a8a82bcc322c7259b8f : SUCCESS in 1h 05m 55s\n- grenade-multinode https://zuul.opendev.org/t/openstack/build/9d5fd69e8ba041c0b16a46d98c119ef1 : SUCCESS in 1h 06m 18s\n- ironic-grenade https://zuul.opendev.org/t/openstack/build/fbe3f16fbbfe45ecafc7514d6ffdc729 : SUCCESS in 1h 04m 09s (non-voting)\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/cd2195eaacf74cd988f29ca7c294c85a : SUCCESS in 1h 02m 28s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"4e1df5bbc7d9199d6f034c7d42779d592ce2b005","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2021-03-11 23:12:31.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"d066c1474d96ae3a35abee0547cd9792bcad444d","tag":"autogenerated:gerrit:abandon","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-12 16:05:16.000000000","message":"Abandoned\n\nIf57c54828baf4e250ad08fdd95351490010e1b41 should remove the need for this in grenade, both the old and new deployments can use lioadm.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fe5c1be31a7494b9a4722e64099526c62f884b83","revisions":{"aff2499c32e91f7b778d4fea44b36da5edd4671a":{"kind":"REWORK","_number":1,"created":"2021-03-10 12:25:08.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/55/779755/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/grenade","ref":"refs/changes/55/779755/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/grenade refs/changes/55/779755/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/grenade refs/changes/55/779755/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/grenade refs/changes/55/779755/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/grenade refs/changes/55/779755/1"}}},"commit":{"parents":[{"commit":"1cdbb71ffe1f41fbe46694888aa8ba7d2d7917c7","subject":"remove unicode from code","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/1cdbb71ffe1f41fbe46694888aa8ba7d2d7917c7"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-10 12:23:13.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-10 12:24:02.000000000","tz":0},"subject":"zuul: Set CINDER_ISCSI_HELPER explicitly to tgtadm for grenade jobs","message":"zuul: Set CINDER_ISCSI_HELPER explicitly to tgtadm for grenade jobs\n\nWhile grenade jobs are based on Bionic we need to ensure that the tgtadm\nbackend is used for both the original deployment and during the upgrade.\n\nChange-Id: I3960c24665ace97989ea78673f4ef38f38f9d754\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/aff2499c32e91f7b778d4fea44b36da5edd4671a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/aff2499c32e91f7b778d4fea44b36da5edd4671a"}]},"branch":"refs/heads/master"},"fe5c1be31a7494b9a4722e64099526c62f884b83":{"kind":"REWORK","_number":2,"created":"2021-03-10 17:10:05.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/55/779755/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/grenade","ref":"refs/changes/55/779755/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/grenade refs/changes/55/779755/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/grenade refs/changes/55/779755/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/grenade refs/changes/55/779755/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/grenade refs/changes/55/779755/2"}}},"commit":{"parents":[{"commit":"1cdbb71ffe1f41fbe46694888aa8ba7d2d7917c7","subject":"remove unicode from code","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/1cdbb71ffe1f41fbe46694888aa8ba7d2d7917c7"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-10 12:23:13.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-10 17:09:58.000000000","tz":0},"subject":"zuul: Set CINDER_ISCSI_HELPER explicitly to tgtadm for grenade jobs","message":"zuul: Set CINDER_ISCSI_HELPER explicitly to tgtadm for grenade jobs\n\nWhile grenade jobs are based on Bionic we need to ensure that the tgtadm\nbackend is used for both the original deployment and during the upgrade.\n\nChange-Id: I3960c24665ace97989ea78673f4ef38f38f9d754\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/fe5c1be31a7494b9a4722e64099526c62f884b83"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/fe5c1be31a7494b9a4722e64099526c62f884b83"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}