)]}'
{"id":"openstack%2Fgrenade~803317","triplet_id":"openstack%2Fgrenade~master~I1eb352deca11916f4db1010a50d15a83e33a61bb","project":"openstack/grenade","branch":"master","hashtags":[],"change_id":"I1eb352deca11916f4db1010a50d15a83e33a61bb","subject":"Unblock Gate: create encryption type with right params","status":"MERGED","created":"2021-08-03 07:41:51.000000000","updated":"2021-08-04 13:55:25.000000000","submitted":"2021-08-03 18:38:38.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"803317","meta_rev_id":"68a247ab1e7b0e46586b4075883b8c64719ce050","_number":803317,"virtual_id_number":803317,"owner":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-08-03 18:38:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"disliked":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":-1,"date":"2021-08-03 12:56:58.000000000","permitted_voting_range":{"min":-1,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":1,"date":"2021-08-03 08:02:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":1,"date":"2021-08-03 10:56:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":2,"date":"2021-08-03 14:18:16.000000000","_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":2,"date":"2021-08-03 14:03:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":1,"date":"2021-08-03 14:18:16.000000000","_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"}],"reviewers":{"REVIEWER":[{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}],"CC":[{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-03 07:45:00.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"CC"},{"updated":"2021-08-03 07:45:47.000000000","updated_by":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"},{"updated":"2021-08-03 07:45:47.000000000","updated_by":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"reviewer":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"state":"REVIEWER"},{"updated":"2021-08-03 07:45:47.000000000","updated_by":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"reviewer":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"state":"REVIEWER"},{"updated":"2021-08-03 08:02:56.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2021-08-03 09:27:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-03 10:56:42.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2021-08-03 11:21:58.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"CC"},{"updated":"2021-08-03 12:56:58.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2021-08-03 13:16:04.000000000","updated_by":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"reviewer":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"state":"CC"}],"messages":[{"id":"975165e626355a64eca74b4adadecbe071d0f48b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2021-08-03 07:41:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e26b4d83e1c4c6600d1fd0339c9e06b82029d2c1","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2021-08-03 07:45:00.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d1779228317af4def1b74ea1c9ddfa38e4e285df","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2021-08-03 08:01:18.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"e94b4d5c1e5addb8a6293c624306c6f73a64961b","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2021-08-03 08:02:56.000000000","message":"Patch Set 2: Code-Review+1\n\nThank you","accounts_in_message":[],"_revision_number":2},{"id":"5a74eae71d2a85bbd8b29dea6062bc608f27a32d","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2021-08-03 08:04:28.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4a474fece801e87d095677c3dec6d8a1ff3f6cd9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-03 09:27:53.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bf2119f26f3c40c3879db90e7e94e033 : SUCCESS in 13m 53s\n- grenade https://zuul.opendev.org/t/openstack/build/5a4b2fa126b94b7ead3fdf71b6d1cda2 : SUCCESS in 1h 09m 56s\n- grenade-multinode https://zuul.opendev.org/t/openstack/build/bd2bb6dbb474430ba042668ef3b15392 : SUCCESS in 1h 08m 39s\n- grenade-heat-multinode https://zuul.opendev.org/t/openstack/build/41f3c288bd974ec9b258b2b280d41084 : FAILURE in 53m 40s (non-voting)\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/2a799c0a5e56485ea3b76db4d336d60d : SUCCESS in 47m 09s\n- ironic-grenade https://zuul.opendev.org/t/openstack/build/5aeef43f6bfd4256853514a69b07ad2f : SUCCESS in 1h 13m 45s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"a0b132bbd4d1c3d56a2715703fa3bc6e5b29f2cb","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-08-03 10:56:42.000000000","message":"Patch Set 2: Code-Review+1\n\nLGTM thanks!","accounts_in_message":[],"_revision_number":2},{"id":"62d01b114f08878e6eee1c3db9d25aa765c6b75f","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2021-08-03 11:21:58.000000000","message":"Patch Set 2:\n\nSo was the previous invocation broken or did cinder change the client in a way that is not backwards compatible? In the latter case, the fix IMO should happen in cinderclient.","accounts_in_message":[],"_revision_number":2},{"id":"c7f19c7ec4bf2570bfc656700c7b08cd468423d9","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-08-03 11:49:03.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e So was the previous invocation broken or did cinder change the client in a way that is not backwards compatible? In the latter case, the fix IMO should happen in cinderclient.\n\nc-api has changed (Ia4b1c303a057fe70cf88bdbbebc1d4f62474f011) and now validates the provided cipher *before* calling down to create secrets. The previous call without a cipher worked in grenade as we were just using the test only fixed-key backend and not Barbican as documented in bug 1926630.\n\nAdditionally our grenade jobs always use LVM/iSCSI based volumes that pickup a default cipher from dm-crypt if one isn\u0027t provided, this only becomes an issue when using rbd volumes but this change should also correct that case.\n\nIMHO updating this invocation to always provide a valid cipher is the correct thing to do here.","accounts_in_message":[],"_revision_number":2},{"id":"aa441143ec3c77bb81a222dd9eb476dad73452ca","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2021-08-03 12:18:54.000000000","message":"Patch Set 2:\n\nafter applying this, glance gate is reporting success on grenade job\nhttps://review.opendev.org/c/openstack/glance/+/803325","accounts_in_message":[],"_revision_number":2},{"id":"7564aaabe12f9c8d6684485cfdf78f2e5b843f88","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2021-08-03 12:24:05.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e \u003e Patch Set 2:\n\u003e \u003e \n\u003e \u003e So was the previous invocation broken or did cinder change the client in a way that is not backwards compatible? In the latter case, the fix IMO should happen in cinderclient.\n\u003e \n\u003e c-api has changed (Ia4b1c303a057fe70cf88bdbbebc1d4f62474f011) and now validates the provided cipher *before* calling down to create secrets. The previous call without a cipher worked in grenade as we were just using the test only fixed-key backend and not Barbican as documented in bug 1926630.\n\u003e \n\u003e Additionally our grenade jobs always use LVM/iSCSI based volumes that pickup a default cipher from dm-crypt if one isn\u0027t provided, this only becomes an issue when using rbd volumes but this change should also correct that case.\n\u003e \n\u003e IMHO updating this invocation to always provide a valid cipher is the correct thing to do here.\n\nAs Lee mentioned, there was no change in cinderclient rather added a validation on c-api side to fail early which previously failed later in c-vol. This mainly affects rbd driver and filesystem type drivers. IMO this is the right way to create an encrypted volume type and grenade should do the same.","accounts_in_message":[],"_revision_number":2},{"id":"150a1e5e48c474709af30af91e137ef078a10f24","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2021-08-03 12:56:58.000000000","message":"Patch Set 2: Code-Review-1\n\nTo me this still looks like exactly the kind of backwards incompatibility that grenade is meant to guard against, but I\u0027m open to be overruled by other reviewers.","accounts_in_message":[],"_revision_number":2},{"id":"fb21719283e71552a199121a26489fd2483aeb0b","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2021-08-03 13:16:04.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2: Code-Review-1\n\u003e \n\u003e To me this still looks like exactly the kind of backwards incompatibility that grenade is meant to guard against, but I\u0027m open to be overruled by other reviewers.\n\nNot a core reviewer, but this is about the  creation of the resources which are then checked to be still alive after the upgrade, and it will affect the xena-\u003ey upgrade. It is not about a behavioral change, so it should be fine.","accounts_in_message":[],"_revision_number":2},{"id":"65db171907111bf66e1ffa3aea7395d6831908e4","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2021-08-03 14:01:05.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e \u003e Patch Set 2: Code-Review-1\n\u003e \u003e \n\u003e \u003e To me this still looks like exactly the kind of backwards incompatibility that grenade is meant to guard against, but I\u0027m open to be overruled by other reviewers.\n\u003e \n\u003e Not a core reviewer, but this is about the  creation of the resources which are then checked to be still alive after the upgrade, and it will affect the xena-\u003ey upgrade. It is not about a behavioral change, so it should be fine.\n\nHmm, I agree with frickler. This looks as if the backcompat was broken, i.e., previously-fine records are now breaking.","accounts_in_message":[],"_revision_number":2},{"id":"793124ffbcda305d99273bed424f72a94e722fa7","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-08-03 14:03:08.000000000","message":"Patch Set 2: Code-Review+2\n\nI agree with Lee and Rajat. As I understand from the original bug where cinder change happened (https://bugs.launchpad.net/cinder/+bug/1926630) volume creation is going to fail at later stage so it was fixed as bug instead of microversion. I am fine to this change which is now passing what cinder validate in api now.","accounts_in_message":[],"_revision_number":2},{"id":"01bb0a4bcb3c3feefdf98be53de1828d50ff7a13","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2021-08-03 14:18:16.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nIt has been explained to me this was faulty behind the scenes and just never tested.","accounts_in_message":[],"_revision_number":2},{"id":"069483b7609511121820bf5909ce7ca0d9841591","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-03 14:20:08.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"66d88788f776e6292871758db0fa7bbe0b2b2ee7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-03 18:38:38.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/da96909124684642b6af6cbefca5e102 : SUCCESS in 18m 17s\n- grenade https://zuul.opendev.org/t/openstack/build/17953fbdc532413aaa907713b0c88827 : SUCCESS in 49m 53s\n- grenade-multinode https://zuul.opendev.org/t/openstack/build/418e114980ad457aba7d15b037b9af7e : SUCCESS in 1h 07m 53s\n- grenade-heat-multinode https://zuul.opendev.org/t/openstack/build/caa8b339413b4eb29be29c4f07776ea6 : SUCCESS in 1h 24m 49s (non-voting)\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/9222a0628a2a4fbea97a3887ddc47c56 : SUCCESS in 59m 30s","accounts_in_message":[],"_revision_number":2},{"id":"de54135d63be08522a6971ee934a169ae31167a9","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-03 18:38:38.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"5b49d129ff8df02a565a00b6abb0d571a60834bb","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-03 18:42:31.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/906108a33a31414290b28fa9afa7749c : SUCCESS in 55s","accounts_in_message":[],"_revision_number":2},{"id":"68a247ab1e7b0e46586b4075883b8c64719ce050","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-08-04 13:55:25.000000000","message":"Patch Set 2:\n\nenhancing the testing of volume type https://review.opendev.org/c/openstack/grenade/+/803397","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d61a95325b3d052216aa13931c7a6d4a132a5843","revisions":{"882a1b4fce321521bb08bf9f1eb38327f7eeab33":{"kind":"REWORK","_number":1,"created":"2021-08-03 07:41:51.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/17/803317/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/grenade","ref":"refs/changes/17/803317/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/grenade refs/changes/17/803317/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/grenade refs/changes/17/803317/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/grenade refs/changes/17/803317/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/grenade refs/changes/17/803317/1"}}},"commit":{"parents":[{"commit":"f0215b0319cfe037c66efcc66d42ecdcdf6a5f1b","subject":"Merge \"Update IRC network to OFTC\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/f0215b0319cfe037c66efcc66d42ecdcdf6a5f1b"}]}],"author":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2021-07-30 10:32:26.000000000","tz":-240},"committer":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2021-07-30 10:38:56.000000000","tz":-240},"subject":"Unblock Gate: create encryption type with right params","message":"Unblock Gate: create encryption type with right params\n\nRecently we added a check in cinder for cipher algorithm[1]\nCurrently grenade is not passing cipher when creating an\nencrypted type, hence gate is failing.\nThis patch addresses the same by passing the cipher and other\nproperties.\n\n[1] https://review.opendev.org/c/openstack/cinder/+/800268\n\nChange-Id: I1eb352deca11916f4db1010a50d15a83e33a61bb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/882a1b4fce321521bb08bf9f1eb38327f7eeab33"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/882a1b4fce321521bb08bf9f1eb38327f7eeab33"}]},"branch":"refs/heads/master"},"d61a95325b3d052216aa13931c7a6d4a132a5843":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-08-03 08:01:18.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/17/803317/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/grenade","ref":"refs/changes/17/803317/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/grenade refs/changes/17/803317/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/grenade refs/changes/17/803317/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/grenade refs/changes/17/803317/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/grenade refs/changes/17/803317/2"}}},"commit":{"parents":[{"commit":"f0215b0319cfe037c66efcc66d42ecdcdf6a5f1b","subject":"Merge \"Update IRC network to OFTC\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/f0215b0319cfe037c66efcc66d42ecdcdf6a5f1b"}]}],"author":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2021-07-30 10:32:26.000000000","tz":-240},"committer":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2021-08-03 08:01:08.000000000","tz":0},"subject":"Unblock Gate: create encryption type with right params","message":"Unblock Gate: create encryption type with right params\n\nRecently we added a check in cinder for cipher algorithm[1]\nCurrently grenade is not passing cipher when creating an\nencrypted type, hence grenade job is failing in glance and cinder gate.\nThis patch addresses the same by passing the cipher and other\nproperties.\n\n[1] https://review.opendev.org/c/openstack/cinder/+/800268\n\nCloses-Bug: #1938763\n\nChange-Id: I1eb352deca11916f4db1010a50d15a83e33a61bb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/d61a95325b3d052216aa13931c7a6d4a132a5843"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/grenade/commit/d61a95325b3d052216aa13931c7a6d4a132a5843"}]},"branch":"refs/heads/master","description":"Edit commit message"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}