)]}'
{"projects/70_cinder/resources.sh":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c94f882ee7cf0d14d74b3c41437f68e47fd12d9a","unresolved":true,"context_lines":[{"line_number":106,"context_line":"        --encryption-provider nova.volume.encryptors.luks.LuksEncryptor \\"},{"line_number":107,"context_line":"        --encryption-cipher aes-xts-plain64 --encryption-key-size 256 \\"},{"line_number":108,"context_line":"        $CINDER_VOL_ENCRYPTED_TYPE -f shell)"},{"line_number":109,"context_line":"    # to check this encrypted volume type is usable, it will be used"},{"line_number":110,"context_line":"    # for bootable volume create request below."},{"line_number":111,"context_line":"    local volume_type_id\u003d$id"},{"line_number":112,"context_line":"    resource_save cinder cinder_encrypted_volume_type_id $id"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    # set ourselves to the created cinder user"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ecf00061_424f8e63","line":111,"range":{"start_line":109,"start_character":0,"end_line":111,"end_character":28},"updated":"2021-08-05 15:29:29.000000000","message":"This works but why the extra validation for volume types compared to the vast majority of resources in these tests?","commit_id":"f73a8ea16770b0b496340ef33da4172b78c6a829"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c94f882ee7cf0d14d74b3c41437f68e47fd12d9a","unresolved":true,"context_lines":[{"line_number":124,"context_line":"    openstack keypair create $CINDER_KEY \u003e $CINDER_KEY_FILE"},{"line_number":125,"context_line":"    chmod 600 $CINDER_KEY_FILE"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # Create a bootable volume"},{"line_number":128,"context_line":"    eval $(openstack volume create --image $DEFAULT_IMAGE_NAME --size 1 \\"},{"line_number":129,"context_line":"        --type $volume_type_id $CINDER_VOL -f shell)"},{"line_number":130,"context_line":"    resource_save cinder cinder_volume_id $id"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    # Wait for the volume to be marked as bootable"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9c064e5e_0fdfd181","line":129,"range":{"start_line":127,"start_character":0,"end_line":129,"end_character":52},"updated":"2021-08-05 15:29:29.000000000","message":"I don\u0027t see the point in this, we are already creating an encrypted volume and attaching it to our test instance below?","commit_id":"f73a8ea16770b0b496340ef33da4172b78c6a829"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2ce62da2239625503fc933b134adf9a6b7439124","unresolved":true,"context_lines":[{"line_number":124,"context_line":"    openstack keypair create $CINDER_KEY \u003e $CINDER_KEY_FILE"},{"line_number":125,"context_line":"    chmod 600 $CINDER_KEY_FILE"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # Create a bootable volume"},{"line_number":128,"context_line":"    eval $(openstack volume create --image $DEFAULT_IMAGE_NAME --size 1 \\"},{"line_number":129,"context_line":"        --type $volume_type_id $CINDER_VOL -f shell)"},{"line_number":130,"context_line":"    resource_save cinder cinder_volume_id $id"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    # Wait for the volume to be marked as bootable"}],"source_content_type":"text/x-sh","patch_set":5,"id":"c1e97ad7_2e12857d","line":129,"range":{"start_line":127,"start_character":0,"end_line":129,"end_character":52},"in_reply_to":"9c064e5e_0fdfd181","updated":"2021-08-05 16:30:20.000000000","message":"yeah, this is to add it for bootable volume and check the usability of voluem type, kind of extra testing which does not harm.","commit_id":"f73a8ea16770b0b496340ef33da4172b78c6a829"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c94f882ee7cf0d14d74b3c41437f68e47fd12d9a","unresolved":true,"context_lines":[{"line_number":170,"context_line":"    openstack server add volume $CINDER_SERVER $CINDER_VOL2"},{"line_number":171,"context_line":"    _wait_for_volume_update $CINDER_VOL2 \"status\" \"in-use\""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    # Create an encrypted (non-bootable) volume to attach and detach"},{"line_number":174,"context_line":"    eval $(openstack volume create --size 1 $CINDER_VOL3 --type $CINDER_VOL_ENCRYPTED_TYPE -f shell)"},{"line_number":175,"context_line":"    resource_save cinder cinder_volume3_id $id"},{"line_number":176,"context_line":"    _wait_for_volume_update $CINDER_VOL3 \"status\" \"available\""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    # Attach the encrypted volume and ensure it becomes in-use"},{"line_number":179,"context_line":"    openstack server add volume $CINDER_SERVER $CINDER_VOL3"},{"line_number":180,"context_line":"    _wait_for_volume_update $CINDER_VOL3 \"status\" \"in-use\""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    # ping check on the way up so we can add ssh content"},{"line_number":183,"context_line":"    ping_check_public $ip 30"}],"source_content_type":"text/x-sh","patch_set":5,"id":"d4400f2f_9f443b89","line":180,"range":{"start_line":173,"start_character":0,"end_line":180,"end_character":58},"updated":"2021-08-05 15:29:29.000000000","message":"^ FWIW","commit_id":"f73a8ea16770b0b496340ef33da4172b78c6a829"}]}