)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f4e1252512f0fd0a7c4622b3a9882e66bbbf495a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e29ba2f4_d76053ce","updated":"2022-12-16 12:40:21.000000000","message":"Good catch","commit_id":"619f7dc44f2e58bfb70746f920b38adceff0a7ac"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"9600ee019ebceed8fdc0a4d10432b63bb6ca761c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"88a91a3f_5a7f683d","updated":"2022-12-12 12:35:30.000000000","message":"LGTM but got curios on why we or other projects didn\u0027t hit this already, looking at some past changes[1][2] seems it needs to be done differently in more transparent way per release for which it\u0027s required along with upgrade release notes in the project introducing such a change, but someone from grenade can put more light on this.\n\n[1] https://review.opendev.org/c/openstack/grenade/+/438412\n[2] https://review.opendev.org/c/openstack/grenade/+/371015","commit_id":"619f7dc44f2e58bfb70746f920b38adceff0a7ac"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"703de3a9d60ecd0764874ceb3421d483bebe4e21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"265020a0_7d09cea8","updated":"2022-12-20 14:59:33.000000000","message":"ping fellow reviewers, thanks in advance","commit_id":"619f7dc44f2e58bfb70746f920b38adceff0a7ac"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"28cc2132e1de1d579074f7769f5b7b30aaf9d132","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"93100d01_b3c3beb9","updated":"2022-12-12 09:17:38.000000000","message":"recheck tox issue fixed","commit_id":"619f7dc44f2e58bfb70746f920b38adceff0a7ac"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"47a1ac96b9cc11a658703f10c2c0de6416e9dd3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"43e09c1f_27eb0d45","in_reply_to":"88a91a3f_5a7f683d","updated":"2022-12-13 11:20:15.000000000","message":"Cincer, for example, is copying the rootwrap files in the \"install_cincer\" method (devstack).\n\nNeutron needs always to update all files under rootwrap.d and reconfigure the daemon CMD if needed. If we haven\u0027t seen any issue for long time is because we have been migrating rootwrap commands to privsep, reducing the content of the rootwrap filters. But in this case we are introducing new ones.\n\nThis change should be permanent in the default upgrade script, regardless of the version.\n\nIf a reno is needed, please let me know.","commit_id":"619f7dc44f2e58bfb70746f920b38adceff0a7ac"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8f65ea26042d4d96a486632749d95f84b528daf7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"be3dd091_e0da2b4a","updated":"2022-12-22 09:41:18.000000000","message":"thanks","commit_id":"7c3144ce84f9b0c206598e3a8298d1046afcd85a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0864250416f5cd833ae072e53129ebafbc3d6b23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ed64b62c_ba30c2f3","updated":"2022-12-22 01:34:29.000000000","message":"thanks, lgtm","commit_id":"7c3144ce84f9b0c206598e3a8298d1046afcd85a"}],"projects/50_neutron/upgrade.sh":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a4a4aa2bf3ef31319e097b36e5996f8090a612c1","unresolved":true,"context_lines":[{"line_number":133,"context_line":"AGENT_VPN_BINARY\u003d${AGENT_VPN_BINARY:-\"$NEUTRON_BIN_DIR/neutron-vpn-agent\"}"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"# Update the rootwrap configuration"},{"line_number":136,"context_line":"# NOTE(ralonsoh): make this method public in \"devstack\"."},{"line_number":137,"context_line":"_neutron_setup_rootwrap"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"# Start neutron and agents"}],"source_content_type":"text/x-sh","patch_set":1,"id":"b27dc38d_c09f96a4","line":136,"range":{"start_line":136,"start_character":2,"end_line":136,"end_character":6},"updated":"2022-12-20 15:41:36.000000000","message":"More like TODO, no?","commit_id":"619f7dc44f2e58bfb70746f920b38adceff0a7ac"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"058ea335d5376796893861986c48487dae4909a8","unresolved":false,"context_lines":[{"line_number":133,"context_line":"AGENT_VPN_BINARY\u003d${AGENT_VPN_BINARY:-\"$NEUTRON_BIN_DIR/neutron-vpn-agent\"}"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"# Update the rootwrap configuration"},{"line_number":136,"context_line":"# NOTE(ralonsoh): make this method public in \"devstack\"."},{"line_number":137,"context_line":"_neutron_setup_rootwrap"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"# Start neutron and agents"}],"source_content_type":"text/x-sh","patch_set":1,"id":"aa720e09_496c260b","line":136,"range":{"start_line":136,"start_character":2,"end_line":136,"end_character":6},"in_reply_to":"b27dc38d_c09f96a4","updated":"2022-12-21 17:10:29.000000000","message":"Right, I\u0027ll change it","commit_id":"619f7dc44f2e58bfb70746f920b38adceff0a7ac"}]}