)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"3a09362b91d4c5522a6235f3fe65de4f786b7fe6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"edeee26b_9f5f2ef6","updated":"2024-03-04 14:09:45.000000000","message":"Dependency merged!","commit_id":"ae3b03b2cb3bde5f0f78f4b61f23de469b2fa505"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"525475f9ee463a0f3e882807e0980b912774cc07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b248188a_a39153dd","updated":"2024-03-04 14:16:26.000000000","message":"Thank you for review, \n\nThis is the patch to verify the upgrade which depends on this one,\nhttps://review.opendev.org/c/openstack/glance/+/901649?usp\u003dsubmitted-together","commit_id":"ae3b03b2cb3bde5f0f78f4b61f23de469b2fa505"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1c8ff1317e22288471b1abf0549fcdfbac966b4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a5b1ce88_dca707d0","updated":"2023-11-29 19:03:00.000000000","message":"lgtm thanks. upgrade testing job running fine too https://review.opendev.org/c/openstack/glance/+/901649","commit_id":"ae3b03b2cb3bde5f0f78f4b61f23de469b2fa505"}],"projects/40_glance/upgrade.sh":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3cb1e96484ae62fbf4255ee18d3899006ac0f0b5","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# Set image_cache_driver to centralized_db"},{"line_number":62,"context_line":"iniset $GLANCE_API_CONF DEFAULT image_cache_driver centralized_db"},{"line_number":63,"context_line":"iniset $GLANCE_CACHE_CONF DEFAULT image_cache_driver centralized_db"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# Start Glance"},{"line_number":66,"context_line":"start_glance"}],"source_content_type":"text/x-sh","patch_set":2,"id":"2c2ff198_b5eeca9d","line":63,"updated":"2024-03-04 14:11:48.000000000","message":"hmm, are deployments expected to do the same? I would much prefer if the upgrade would be working without this and then you can add a dedicated test job for the cache driver change?","commit_id":"ae3b03b2cb3bde5f0f78f4b61f23de469b2fa505"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"525475f9ee463a0f3e882807e0980b912774cc07","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# Set image_cache_driver to centralized_db"},{"line_number":62,"context_line":"iniset $GLANCE_API_CONF DEFAULT image_cache_driver centralized_db"},{"line_number":63,"context_line":"iniset $GLANCE_CACHE_CONF DEFAULT image_cache_driver centralized_db"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# Start Glance"},{"line_number":66,"context_line":"start_glance"}],"source_content_type":"text/x-sh","patch_set":2,"id":"fac8c86d_26db56cc","line":63,"in_reply_to":"2c2ff198_b5eeca9d","updated":"2024-03-04 14:16:26.000000000","message":"How to verify upgrade will work without this?\n\nWe have deprecated sqlite cache driver this cycle and going to remove it during E cycle, so yes, deployments expected to do the same.","commit_id":"ae3b03b2cb3bde5f0f78f4b61f23de469b2fa505"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"08e78008c811dfe3d00e36c5aeb28337b2377dd0","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# Set image_cache_driver to centralized_db"},{"line_number":62,"context_line":"iniset $GLANCE_API_CONF DEFAULT image_cache_driver centralized_db"},{"line_number":63,"context_line":"iniset $GLANCE_CACHE_CONF DEFAULT image_cache_driver centralized_db"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# Start Glance"},{"line_number":66,"context_line":"start_glance"}],"source_content_type":"text/x-sh","patch_set":2,"id":"aec02130_a7aa2477","line":63,"in_reply_to":"86cda91a_051f2e7c","updated":"2024-03-06 19:39:36.000000000","message":"right. I missed to see the devstack set it and grenade work as mentioned above.","commit_id":"ae3b03b2cb3bde5f0f78f4b61f23de469b2fa505"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"be011e2400b9194ed925bef109ce7b5331b93ea9","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# Set image_cache_driver to centralized_db"},{"line_number":62,"context_line":"iniset $GLANCE_API_CONF DEFAULT image_cache_driver centralized_db"},{"line_number":63,"context_line":"iniset $GLANCE_CACHE_CONF DEFAULT image_cache_driver centralized_db"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# Start Glance"},{"line_number":66,"context_line":"start_glance"}],"source_content_type":"text/x-sh","patch_set":2,"id":"86cda91a_051f2e7c","line":63,"in_reply_to":"fac8c86d_26db56cc","updated":"2024-03-04 15:02:52.000000000","message":"Yeah I think frickler is right here. Usually we expect upgrade to work and then deployments switch to the new stuff once they\u0027re upgraded to make sure they\u0027re good before the *next* upgrade that drops functionality.\n\nThe difference here is that the default switches and glance auto-converts the old to the new. So if they didn\u0027t have a driver set, they\u0027d get the convert-in-place behavior, but if they did, they\u0027d need to switch *after* the upgrade.\n\nSince devstack sets a driver specifically, I think we probably should not change it in upgrade here since it\u0027s not required to make the upgrade work. If you want to test (automated) the case where caching was enabled with the default driver and then upgraded in place, it kinda needs to be a different job I think.","commit_id":"ae3b03b2cb3bde5f0f78f4b61f23de469b2fa505"}]}