)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"d3ce1ca00fbaa3cf8c45c5cc6087db10025b5209","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch brings Ceilometer services into upgrade testing process."},{"line_number":10,"context_line":"For now we test only from Havana to Icehouse and from Icehouse to Juno."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9cb61c5b312e197db80e537bff269b7777dddb31"},{"line_number":13,"context_line":"Signed-off-by: Emilien Macchi \u003cemilien.macchi@enovance.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7adec928_6df3930a","line":11,"updated":"2014-05-22 21:54:23.000000000","message":"Could you link to the ceilometer blueprint:\n\n  https://blueprints.launchpad.net/ceilometer/+spec/grenade-upgrade-testing","commit_id":"c5630dabc3ddca276d4dea40120138ebcdc904fc"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9c33bf3980791a2eeb8f554a3880c2524d77fefe","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch brings Ceilometer services into upgrade testing process."},{"line_number":10,"context_line":"For now we test only from Havana to Icehouse and from Icehouse to Juno."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9cb61c5b312e197db80e537bff269b7777dddb31"},{"line_number":13,"context_line":"Signed-off-by: Emilien Macchi \u003cemilien.macchi@enovance.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7adec928_304ab783","line":11,"in_reply_to":"7adec928_6df3930a","updated":"2014-05-23 09:16:01.000000000","message":"Done","commit_id":"c5630dabc3ddca276d4dea40120138ebcdc904fc"}],"from-havana/upgrade-ceilometer":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"a6e854ae2f23b11571a488ea4043ebaf4fb02317","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# ``upgrade-horizon``"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"configure_ceilometer_upgrade(){"},{"line_number":6,"context_line":"    XTRACE\u003d$(set +o | grep xtrace)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7adec928_7bb3980a","line":3,"updated":"2014-05-20 21:56:49.000000000","message":"upgrade-ceilometer","commit_id":"47edd298e15e20888aeca5cd9401f44708a85beb"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"d3ce1ca00fbaa3cf8c45c5cc6087db10025b5209","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    # reset to previous state"},{"line_number":11,"context_line":"    $XTRACE"},{"line_number":12,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7adec928_6a129963","line":12,"updated":"2014-05-22 21:54:23.000000000","message":"Note that ceilometer did not have any Tempest coverage in the havana timeframe, so testing upgrades from havana would be somewhat limited in that sense.","commit_id":"c5630dabc3ddca276d4dea40120138ebcdc904fc"}],"from-icehouse/upgrade-ceilometer":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"a6e854ae2f23b11571a488ea4043ebaf4fb02317","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# ``upgrade-horizon``"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"configure_ceilometer_upgrade(){"},{"line_number":6,"context_line":"    XTRACE\u003d$(set +o | grep xtrace)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7adec928_fbc6c867","line":3,"updated":"2014-05-20 21:56:49.000000000","message":"upgrade-ceilometer","commit_id":"47edd298e15e20888aeca5cd9401f44708a85beb"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"d3ce1ca00fbaa3cf8c45c5cc6087db10025b5209","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    # reset to previous state"},{"line_number":11,"context_line":"    $XTRACE"},{"line_number":12,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7adec928_4d85f757","line":12,"updated":"2014-05-22 21:54:23.000000000","message":"Not a criticism of the current patch, but I wonder could the \"nothing to see here\" form of configure_*_upgrade be genericized as many (most?) of these functions seem identical.","commit_id":"c5630dabc3ddca276d4dea40120138ebcdc904fc"}],"grenade.sh":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"d3ce1ca00fbaa3cf8c45c5cc6087db10025b5209","unresolved":false,"context_lines":[{"line_number":310,"context_line":"    # Upgrade Ceilometer"},{"line_number":311,"context_line":"    echo_summary \"Running upgrade-ceilometer\""},{"line_number":312,"context_line":"    $GRENADE_DIR/upgrade-ceilometer || die $LINENO \"Failure in upgrade-ceilometer\""},{"line_number":313,"context_line":"    stop $STOP upgrade-ceilometer 280"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    # Upgrade Checks"},{"line_number":316,"context_line":"    echo_summary \"Running upgrade sanity check\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7adec928_2a63311b","line":313,"updated":"2014-05-22 21:54:23.000000000","message":"Showing my ignorance here, but why is the numeric parameter to stop out of the monotonically increasing sequence only for upgrade-horizon \u0026 upgrade-ceilometer?","commit_id":"c5630dabc3ddca276d4dea40120138ebcdc904fc"}],"save-state":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"719259cd521d51cb3a905c7451ca4be152e5cf25","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# --------------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"source $BASE_DEVSTACK_DIR/stackrc"},{"line_number":43,"context_line":"mkdir -p $SAVE_DIR"},{"line_number":44,"context_line":"for db in keystone glance nova cinder ceilometer; do"},{"line_number":45,"context_line":"    mysqldump -uroot -p$MYSQL_PASSWORD $db \u003e$SAVE_DIR/$db.sql.$BASE_RELEASE"},{"line_number":46,"context_line":"done"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7adec928_6372b4ae","line":43,"updated":"2014-05-23 11:02:30.000000000","message":"Would it make sense to only dump the ceilometer DB in this way if mysql is being used?\n\ne.g.\n\n  MYSQL_SERVICES\u003d\"keystone glance nova cinder\"\n  if grep -q \u0027connection *\u003d *mysql\u0027 /etc/ceilometer/ceilometer.conf; then\n      MYSQL_SERVICES+\u003d\" ceilometer\"\n  fi\n\n  for db in $MYSQL_SERVICES ; do\n      mysqldump ...\n  done\n\nActually, it could go one step further and dump the ceilometer mongodb store via mongodump if grep -q \u0027connection *\u003d *mongo\u0027 /etc/ceilometer/ceilometer.conf","commit_id":"ef46ddb4cdb9ad7057480b4f7ab6a5f5a1d153d6"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"c09240c3d09607a1589a2ce065be33dfd4cd8a91","unresolved":false,"context_lines":[{"line_number":44,"context_line":"MYSQL_SERVICES\u003d\"keystone glance nova cinder\""},{"line_number":45,"context_line":"if grep -q \u0027connection *\u003d *mysql\u0027 /etc/ceilometer/ceilometer.conf; then"},{"line_number":46,"context_line":"  MYSQL_SERVICES+\u003d\" ceilometer\""},{"line_number":47,"context_line":"fi"},{"line_number":48,"context_line":"if grep -q \u0027connection *\u003d *mongo\u0027 /etc/ceilometer/ceilometer.conf;then"},{"line_number":49,"context_line":"  mongodump --db ceilometer--out $SAVE_DIR/ceilometer-dump.$BASE_RELEASE"},{"line_number":50,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"7adec928_a1aaf116","line":47,"updated":"2014-05-23 14:37:25.000000000","message":"Would an elif be clearer?","commit_id":"a34bd5cd37fb7407633f5f8a75d23b0d6e1dc689"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a45db98e11af6fcb85fbf7322e93bdf9ecfaf13a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"MYSQL_SERVICES\u003d\"keystone glance nova cinder\""},{"line_number":45,"context_line":"if grep -q \u0027connection *\u003d *mysql\u0027 /etc/ceilometer/ceilometer.conf; then"},{"line_number":46,"context_line":"  MYSQL_SERVICES+\u003d\" ceilometer\""},{"line_number":47,"context_line":"fi"},{"line_number":48,"context_line":"if grep -q \u0027connection *\u003d *mongo\u0027 /etc/ceilometer/ceilometer.conf;then"},{"line_number":49,"context_line":"  mongodump --db ceilometer--out $SAVE_DIR/ceilometer-dump.$BASE_RELEASE"},{"line_number":50,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5adbc538_1d88d321","line":47,"in_reply_to":"7adec928_a1aaf116","updated":"2014-05-23 22:02:58.000000000","message":"Done","commit_id":"a34bd5cd37fb7407633f5f8a75d23b0d6e1dc689"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"c09240c3d09607a1589a2ce065be33dfd4cd8a91","unresolved":false,"context_lines":[{"line_number":45,"context_line":"if grep -q \u0027connection *\u003d *mysql\u0027 /etc/ceilometer/ceilometer.conf; then"},{"line_number":46,"context_line":"  MYSQL_SERVICES+\u003d\" ceilometer\""},{"line_number":47,"context_line":"fi"},{"line_number":48,"context_line":"if grep -q \u0027connection *\u003d *mongo\u0027 /etc/ceilometer/ceilometer.conf;then"},{"line_number":49,"context_line":"  mongodump --db ceilometer--out $SAVE_DIR/ceilometer-dump.$BASE_RELEASE"},{"line_number":50,"context_line":"fi"},{"line_number":51,"context_line":"for db in $MYSQL_SERVICES ; do"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"7adec928_01c005df","line":48,"updated":"2014-05-23 14:37:25.000000000","message":"Nitpick (feel free to ignore):\n\n  s/conf;then/conf; then/","commit_id":"a34bd5cd37fb7407633f5f8a75d23b0d6e1dc689"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a45db98e11af6fcb85fbf7322e93bdf9ecfaf13a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"if grep -q \u0027connection *\u003d *mysql\u0027 /etc/ceilometer/ceilometer.conf; then"},{"line_number":46,"context_line":"  MYSQL_SERVICES+\u003d\" ceilometer\""},{"line_number":47,"context_line":"fi"},{"line_number":48,"context_line":"if grep -q \u0027connection *\u003d *mongo\u0027 /etc/ceilometer/ceilometer.conf;then"},{"line_number":49,"context_line":"  mongodump --db ceilometer--out $SAVE_DIR/ceilometer-dump.$BASE_RELEASE"},{"line_number":50,"context_line":"fi"},{"line_number":51,"context_line":"for db in $MYSQL_SERVICES ; do"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5adbc538_5d825b01","line":48,"in_reply_to":"7adec928_01c005df","updated":"2014-05-23 22:02:58.000000000","message":"Done","commit_id":"a34bd5cd37fb7407633f5f8a75d23b0d6e1dc689"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"c09240c3d09607a1589a2ce065be33dfd4cd8a91","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  MYSQL_SERVICES+\u003d\" ceilometer\""},{"line_number":47,"context_line":"fi"},{"line_number":48,"context_line":"if grep -q \u0027connection *\u003d *mongo\u0027 /etc/ceilometer/ceilometer.conf;then"},{"line_number":49,"context_line":"  mongodump --db ceilometer--out $SAVE_DIR/ceilometer-dump.$BASE_RELEASE"},{"line_number":50,"context_line":"fi"},{"line_number":51,"context_line":"for db in $MYSQL_SERVICES ; do"},{"line_number":52,"context_line":"    mysqldump -uroot -p$MYSQL_PASSWORD $db \u003e$SAVE_DIR/$db.sql.$BASE_RELEASE"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"7adec928_818415b2","line":49,"updated":"2014-05-23 14:37:25.000000000","message":"Is there a space missing in the mongodump commandline between \"ceilometer\" and \"--out\"?","commit_id":"a34bd5cd37fb7407633f5f8a75d23b0d6e1dc689"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a45db98e11af6fcb85fbf7322e93bdf9ecfaf13a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  MYSQL_SERVICES+\u003d\" ceilometer\""},{"line_number":47,"context_line":"fi"},{"line_number":48,"context_line":"if grep -q \u0027connection *\u003d *mongo\u0027 /etc/ceilometer/ceilometer.conf;then"},{"line_number":49,"context_line":"  mongodump --db ceilometer--out $SAVE_DIR/ceilometer-dump.$BASE_RELEASE"},{"line_number":50,"context_line":"fi"},{"line_number":51,"context_line":"for db in $MYSQL_SERVICES ; do"},{"line_number":52,"context_line":"    mysqldump -uroot -p$MYSQL_PASSWORD $db \u003e$SAVE_DIR/$db.sql.$BASE_RELEASE"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5adbc538_7d871710","line":49,"in_reply_to":"7adec928_818415b2","updated":"2014-05-23 22:02:58.000000000","message":"Done","commit_id":"a34bd5cd37fb7407633f5f8a75d23b0d6e1dc689"}],"upgrade-ceilometer":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"a6e854ae2f23b11571a488ea4043ebaf4fb02317","unresolved":false,"context_lines":[{"line_number":46,"context_line":"TOP_DIR\u003d$TARGET_DEVSTACK_DIR"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Upgrade Horizon"},{"line_number":50,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Get functions from current DevStack"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7adec928_9baf8494","line":49,"updated":"2014-05-20 21:56:49.000000000","message":"Upgrade Ceilometer","commit_id":"47edd298e15e20888aeca5cd9401f44708a85beb"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"d3ce1ca00fbaa3cf8c45c5cc6087db10025b5209","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# stop ceilometer services"},{"line_number":59,"context_line":"stop_ceilometer"},{"line_number":60,"context_line":"# Kill ceilometer screen sessions"},{"line_number":61,"context_line":"for serv in ceilometer-acompute ceilometer-acentral ceilometer-collector ceilometer-api ceilometer-alarm-notifier ceilometer-alarm-evaluator; do"},{"line_number":62,"context_line":"  screen -S $SCREEN_NAME -p $serv -X kill"},{"line_number":63,"context_line":"done"},{"line_number":64,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7adec928_ed6163d4","line":61,"updated":"2014-05-22 21:54:23.000000000","message":"If upgrading from stable/icehouse-\u003emaster/juno then the ceilometer-anotification would need to be stopped also.\n\nAlso I think the alarm-evaluator should be killed before the API service, otherwise there\u0027s a race whereby an alarm evaluation cycle happens to roll around just after the API service is killed and hence fails on the stats queries.","commit_id":"c5630dabc3ddca276d4dea40120138ebcdc904fc"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9c33bf3980791a2eeb8f554a3880c2524d77fefe","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# stop ceilometer services"},{"line_number":59,"context_line":"stop_ceilometer"},{"line_number":60,"context_line":"# Kill ceilometer screen sessions"},{"line_number":61,"context_line":"for serv in ceilometer-acompute ceilometer-acentral ceilometer-collector ceilometer-api ceilometer-alarm-notifier ceilometer-alarm-evaluator; do"},{"line_number":62,"context_line":"  screen -S $SCREEN_NAME -p $serv -X kill"},{"line_number":63,"context_line":"done"},{"line_number":64,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7adec928_ba34e5de","line":61,"in_reply_to":"7adec928_ed6163d4","updated":"2014-05-23 09:16:01.000000000","message":"Done","commit_id":"c5630dabc3ddca276d4dea40120138ebcdc904fc"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"719259cd521d51cb3a905c7451ca4be152e5cf25","unresolved":false,"context_lines":[{"line_number":60,"context_line":"# Kill ceilometer screen sessions"},{"line_number":61,"context_line":"for serv in ceilometer-acompute ceilometer-acentral ceilometer-collector ceilometer-alarm-evaluator ceilometer-api ceilometer-alarm-notifier ceilometer-anotification; do"},{"line_number":62,"context_line":"  screen -S $SCREEN_NAME -p $serv -X kill"},{"line_number":63,"context_line":"done"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# install_ceilometer()"},{"line_number":66,"context_line":"install_ceilometer"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7adec928_23ed0c26","line":63,"updated":"2014-05-23 11:02:30.000000000","message":"Is this still needed? (... now that stop_ceilometer is added to the stop-base script?)","commit_id":"ef46ddb4cdb9ad7057480b4f7ab6a5f5a1d153d6"}]}
