)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6052e1b309a49874b89cdf063108436c2ae18f07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4c890511_1cd754b9","updated":"2025-10-17 17:59:16.000000000","message":"it seems failure are valid. Error is in comparison of True !\u003d \\t\\r\\u\\e  (case sentive status ret\u003durn by cinder). This changed in 2025.2 release.\n\n- https://github.com/openstack/grenade/blob/d4e4bb37b816d4263723619f24fa80c4bc4cb708/projects/70_cinder/resources.sh#L62\n\nhttps://zuul.opendev.org/t/openstack/build/cccd175979284cc495a90a5ba623ffcf/log/controller/logs/grenade.sh_log.txt#1597 \n\n2025-10-08 13:26:34.717 | + /opt/stack/new/grenade/projects/70_cinder/resources.sh:_wait_for_volume_update:63 :   [[ True !\u003d \\t\\r\\u\\e ]]\n2025-10-08 13:26:34.719 | + /opt/stack/new/grenade/projects/70_cinder/resources.sh:_wait_for_volume_update:64 :   echo \u0027Volume cinder_grenade_vol bootable is True and not yet true, waiting...\u0027\n2025-10-08 13:26:34.719 | Volume cinder_grenade_vol bootable is True and not yet true, waiting...","commit_id":"a4d78a43a2dc8968c6e9f249f82e8a052e938e65"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a7df14744f5b0e528508843eee72c659f02f06ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a58351e0_1cc8f048","updated":"2025-10-08 12:55:58.000000000","message":"recheck","commit_id":"a4d78a43a2dc8968c6e9f249f82e8a052e938e65"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b6168187214fd87d138a58c3c53ee696bb6fa90b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0e7763a5_0e3cfe32","updated":"2025-09-22 12:04:53.000000000","message":"recheck volume state error\n\n2025-09-22 06:52:45.263 | [ERROR] /opt/stack/new/grenade/projects/70_cinder/resources.sh:68 Timed out waiting for volume cinder_grenade_vol bootable to be true","commit_id":"a4d78a43a2dc8968c6e9f249f82e8a052e938e65"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"61c66e3afaebd25d62d2a46accf73b91c69949fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0cead630_2eafb879","updated":"2025-10-20 15:37:23.000000000","message":"@gmaan thx for digging, with that information I verified that a) the Cinder API still returns lowercase, nothing changed there b) OSC was changed by https://review.opendev.org/c/openstack/python-openstackclient/+/945881 and @stephenfin@redhat.com even had to update the functional tests there in the same way as here. I\u0027ll leave it to others to decide whether that was a good change or not, at least it did make the OSC output more consistent, as other fields like \"multiattach\" were already being treated in the same way.\n\nso let\u0027s just amend grenade as proposed, maybe with a note to even switch to just checking for the new value in the future once we no longer deal with older OSC versions?","commit_id":"e70e6470202409931c61034eba684159d426a97d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7e2a7b461c116c52783eb8b14f039045db38348a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a2dd20d8_05d83dfc","updated":"2025-10-18 08:30:41.000000000","message":"to me this sounds like cinder has made an API change that is not backwards compatible? shouldn\u0027t we rather flag that and get it fixed than pamper over it in grenade?","commit_id":"e70e6470202409931c61034eba684159d426a97d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ece50e35a6c246327bda41445aa1d132ef349830","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cee1e460_c38b4066","in_reply_to":"a2dd20d8_05d83dfc","updated":"2025-10-18 21:17:18.000000000","message":"That is something I investigated and thought about. This issue is happening on the new node (current master)[1] so there is something changed after stable/2025.2 is released. grenade job on stable/2025.2 where new node is stable/2025.2 is running fine so no backward incompatible change happened in stable/2025.2 release.\n\nThis is about \u0027bootable\u0027 field in GET volume API which start returning ``True`` instead of ``true`` and I am not sure if it is backward incompatible change (my findings below) and that is why I thought that grenade should handle the \u0027bootable\u0027 field string value as per the cinder API contract.\n\nBut I can see your point that like grenade this can break the user scripts also. Even though API is behaving as per contact, and this change is highlighting the wrong usage, at least some releasenotes should be there to notify the users. I opened bug for OSC/cinder - https://bugs.launchpad.net/python-openstackclient/+bug/2128903\n\n1. The cinder API contract state this field as type \u0027string\u0027 not boolean and I could not see anything about what all string value allowed to return or it as case sensitive in - https://docs.openstack.org/api-ref/block-storage/v3/index.html#show-a-volume-s-details \n\n2. Cinder code matches the API contract where this field is return as string in lower case - https://github.com/openstack/cinder/blob/d02171164bdd702b12b59888b744d172f30d712d/cinder/api/v2/views/volumes.py#L84\n\n3. Though cinder API take this field as bool in update bootable status API\n- https://docs.openstack.org/api-ref/block-storage/v3/index.html#update-a-volume-s-bootable-status\nand valid boolean values in API contract is: https://docs.openstack.org/api-ref/block-storage/v3/index.html#valid-boolean-values\n\n4. There is no change in either of the above cinder APIs (\u0027bootable\u0027 field) happened after stable/2025.2 release[2].\n\nFrom above I do not see any issue or backward incompatible change in cinder side.\n\nNo relevant change in sdk side also since 2025.2 sdk version is released - https://github.com/openstack/openstacksdk/commits/master/\n\nNot sure is anything related or commonly changed something in OSC.\n\n\n[1] https://zuul.opendev.org/t/openstack/build/cccd175979284cc495a90a5ba623ffcf/log/controller/logs/grenade.sh_log.txt#1597\n\n[2] https://github.com/openstack/cinder/commits/master/cinder/api","commit_id":"e70e6470202409931c61034eba684159d426a97d"}]}
