)]}'
{"grenade.sh":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3285f295acbcfcc028d3c1edef427f536b5f3d3e","unresolved":false,"context_lines":[{"line_number":227,"context_line":"    cd $GRENADE_DIR"},{"line_number":228,"context_line":"    # Create a project, users and instances"},{"line_number":229,"context_line":"    echo_summary \"Creating Javelin project\""},{"line_number":230,"context_line":"    $(source $BASE_DEVSTACK_DIR/openrc admin admin;"},{"line_number":231,"context_line":"        javelin2 -m check -r resources.yaml)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    # Save some stuff before we shut that whole thing down"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ae5cdf2_9c9c66c2","line":230,"updated":"2014-06-03 10:48:19.000000000","message":"Isn\u0027t it meant to be without \u0027$\u0027 at the beginning?","commit_id":"8b7d83ea452125e76d136807c20149090ab55ffe"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d7b28eed8c1709163fa9a6d2b9e477ba2ec24c78","unresolved":false,"context_lines":[{"line_number":338,"context_line":"    cd $GRENADE_DIR"},{"line_number":339,"context_line":"    echo_summary \"Validating Javelin resources\""},{"line_number":340,"context_line":"    (source $BASE_DEVSTACK_DIR/openrc admin admin;"},{"line_number":341,"context_line":"        javelin2 -m check -r resources.yaml)"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    # Validate the upgrade"},{"line_number":344,"context_line":"    if [[ \"$TARGET_RUN_SMOKE\" \u003d\u003d \"True\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"baada198_17054b10","line":341,"updated":"2014-07-14 12:59:28.000000000","message":"-d will be a required option, once change If5f2674179eea4972ad43a1581073d483bb75d79 is merged.","commit_id":"89e1941bfa3e9b2f8c376fb7093c278c481d0f56"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"41f2e5978e60bac866f93450c343e64a3cae1829","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    # Create a project, users and instances"},{"line_number":235,"context_line":"    echo_summary \"Creating Javelin project\""},{"line_number":236,"context_line":"    (source $BASE_DEVSTACK_DIR/openrc admin admin;"},{"line_number":237,"context_line":"        javelin2 -m create -r $GRENADE_DIR/resources.yaml -d $BASE_DEVSTACK_DIR)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    # Save some stuff before we shut that whole thing down"},{"line_number":240,"context_line":"    echo_summary \"Saving current state information\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"baada198_2a11a453","line":237,"updated":"2014-07-16 14:19:58.000000000","message":"Are the actions performed during \u0027create\u0027 sufficient to validate that the resources were created properly and in the proper form before the upgrade is done? I have been assuming that there would be a \u0027check\u0027 mode run both before and after the upgrade, which impacts the kinds of tests can done (at least for telemetry) on the samples gathered.\n\nAs an example, when I was working with javelin in a devstack that was accidentally configured with neutron, the create mode run would exit with 0, but the created instances would not actually be running because they would error out trying to get connected to the network, thus when a check mode was run it would exit with 1, because not private network information was available for the instances.\n\nSee the comments from 16-July on https://review.openstack.org/#/c/102354/ for a bit more context.","commit_id":"41a9c25fd59178d603c56fc2d4904f5f92a26bae"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"cb48006747e98c230713135a5becbaae905c7ade","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    # Create a project, users and instances"},{"line_number":258,"context_line":"    echo_summary \"Creating Javelin project\""},{"line_number":259,"context_line":"    (source $BASE_DEVSTACK_DIR/openrc admin admin;"},{"line_number":260,"context_line":"        javelin2 -m create -r $GRENADE_DIR/resources.yaml -d $BASE_DEVSTACK_DIR)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    # Save some stuff before we shut that whole thing down"},{"line_number":263,"context_line":"    echo_summary \"Saving current state information\""}],"source_content_type":"text/x-sh","patch_set":11,"id":"baada198_63f529ca","line":260,"updated":"2014-07-24 18:28:57.000000000","message":"It looks like javelin isn\u0027t waiting to make sure the resources are fully up before moving on.\n\nWhen I tried this locally I got failures because the instances didn\u0027t finish booting before nova-compute was turned off.","commit_id":"b762c9e94cceb4e8839fa4c886bd6a98e240b25c"}]}