)]}'
{".pre-commit-config.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c8ae365b1e4db2b6469f2ecc392a742e2f05c93d","unresolved":true,"context_lines":[{"line_number":55,"context_line":"      types_or: [ python, pyi ]"},{"line_number":56,"context_line":"      args: [ --fix ]"},{"line_number":57,"context_line":"    # Run the formatter."},{"line_number":58,"context_line":"    - id: ruff-format"},{"line_number":59,"context_line":"      types_or: [ python, pyi ]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- repo: https://github.com/PyCQA/doc8"},{"line_number":62,"context_line":"  rev: v1.1.2"},{"line_number":63,"context_line":"  hooks:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"79bca1bf_5f33dbd3","side":"PARENT","line":60,"range":{"start_line":58,"start_character":2,"end_line":60,"end_character":1},"updated":"2026-03-26 19:13:22.000000000","message":"oh we already have ruff\n\nok then ya lest drop it and we can add ruffs isort rules later","commit_id":"94868c0e95a8741e1247bfb4d9ac784862975817"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"726ae00dcf39efea80a4730c1cec9a6d01c63b2e","unresolved":true,"context_lines":[{"line_number":55,"context_line":"      types_or: [ python, pyi ]"},{"line_number":56,"context_line":"      args: [ --fix ]"},{"line_number":57,"context_line":"    # Run the formatter."},{"line_number":58,"context_line":"    - id: ruff-format"},{"line_number":59,"context_line":"      types_or: [ python, pyi ]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- repo: https://github.com/PyCQA/doc8"},{"line_number":62,"context_line":"  rev: v1.1.2"},{"line_number":63,"context_line":"  hooks:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"533f28bd_314c8c84","side":"PARENT","line":60,"range":{"start_line":58,"start_character":2,"end_line":60,"end_character":1},"in_reply_to":"6692f812_029f7822","updated":"2026-03-27 10:32:32.000000000","message":"Changed submitted for review here https://review.opendev.org/c/openstack/grian-ui/+/982387","commit_id":"94868c0e95a8741e1247bfb4d9ac784862975817"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c4cd9e6c8bf7b617807ed610c877681720a12fe","unresolved":true,"context_lines":[{"line_number":55,"context_line":"      types_or: [ python, pyi ]"},{"line_number":56,"context_line":"      args: [ --fix ]"},{"line_number":57,"context_line":"    # Run the formatter."},{"line_number":58,"context_line":"    - id: ruff-format"},{"line_number":59,"context_line":"      types_or: [ python, pyi ]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- repo: https://github.com/PyCQA/doc8"},{"line_number":62,"context_line":"  rev: v1.1.2"},{"line_number":63,"context_line":"  hooks:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6692f812_029f7822","side":"PARENT","line":60,"range":{"start_line":58,"start_character":2,"end_line":60,"end_character":1},"in_reply_to":"79bca1bf_5f33dbd3","updated":"2026-03-26 19:15:07.000000000","message":"todo that we would add\n```\n[tool.ruff.lint.isort]\nknown-first-party \u003d [\"grian_ui\"]\nforce-single-line \u003d true\nlines-after-imports \u003d 2\nlines-between-types \u003d 1\nsection-order \u003d [\"future\", \"standard-library\", \"third-party\",  \"first-party\"]\n# this is the default but just being explicit about the behavior\n# in case that ever changes.\nforce-sort-within-sections \u003d false\n```\n\nto pyproject.toml","commit_id":"94868c0e95a8741e1247bfb4d9ac784862975817"}],"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b1525196a7e86ccc9685ed57eb8ae73cc4703308","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix hacking pre-commit hook for Python 3.14 compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove flake8-import-order dependency from the hacking hook as"},{"line_number":10,"context_line":"version 0.18.2 is incompatible with Python 3.14 due to its use"},{"line_number":11,"context_line":"of the deprecated pkg_resources module. The hacking hook (v7.0.0)"},{"line_number":12,"context_line":"provides comprehensive linting without this dependency."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"20c7dad1_9bf19f36","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":26},"updated":"2026-03-26 19:12:21.000000000","message":"flake8-import-order actully sorts your import for you if i recall \nso we could also just do https://review.opendev.org/c/openstack/grian-ui/+/980495\n\nperhas for nwo we shoudl drop it\n\nwould you be open to using ruff in this repo?","commit_id":"e7c923b8d961c038bc671f9d4ed52f198b2b41d7"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"de977c878c4046fe132c0479d81b1a85e3867e19","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix hacking pre-commit hook for Python 3.14 compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove flake8-import-order dependency from the hacking hook as"},{"line_number":10,"context_line":"version 0.18.2 is incompatible with Python 3.14 due to its use"},{"line_number":11,"context_line":"of the deprecated pkg_resources module. The hacking hook (v7.0.0)"},{"line_number":12,"context_line":"provides comprehensive linting without this dependency."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d6368de0_3ec25d64","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":26},"in_reply_to":"20c7dad1_9bf19f36","updated":"2026-03-27 09:24:24.000000000","message":"100%, 980495 is the proper fix\n\nAnd let\u0027s do a follow up for the ruff config","commit_id":"e7c923b8d961c038bc671f9d4ed52f198b2b41d7"}]}