)]}'
{"HACKING.rst":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"fe1c6741a12693b9b6282715ac69f3ac0a82bc8d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- [H904] Wrap long lines in parentheses and not a backslash for line continuation."},{"line_number":12,"context_line":"- [H201] Do not write ``except:``, use ``except Exception:`` at the very least"},{"line_number":13,"context_line":"- [H101] Include your name with TODOs as in ``# TODO(yourname)``"},{"line_number":14,"context_line":"- [H105] Do no include vim configuration in source files."},{"line_number":15,"context_line":"- Do not shadow a built-in or reserved word. Example::"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    def list():"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab895d6_0576b53e","line":14,"updated":"2014-06-29 19:18:20.000000000","message":"I think if we\u0027re going to make a rule, it should actually be \"do not include editor configuration in source files\" - and we should probably check for emacs modelines as well.","commit_id":"58b6e6545a37b5b74edb843cfd83e8d701028f06"}],"hacking/checks/comments.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"cf354a3efd415b64f90032fe04938596646ba72b","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        return (0, \"H104: File contains nothing but comments\")"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"VIM_HEADER_RE \u003d re.compile(r\"^#\\s+vim?:.+\")"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"@core.flake8ext"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_5ecd645c","line":102,"updated":"2014-06-26 08:01:05.000000000","message":"-1: I think \\s* would be more common, since someone may write \"#vim:\"\n\nnit: there can be space before \u0027#\u0027, but I think it\u0027s too odd","commit_id":"a4ca3b3c31ac58c21bba52a4fa4a7338a161b0b6"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"cf354a3efd415b64f90032fe04938596646ba72b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"def hacking_no_vim_config(physical_line, line_number, lines):"},{"line_number":107,"context_line":"    \"\"\"Do not include vim configuration in source files."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    Check if vim configuration is present in the first 5 or the last 5 lines"},{"line_number":110,"context_line":"    of the file, if present return an error."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    N105"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_1e367c51","line":109,"updated":"2014-06-26 08:01:05.000000000","message":"nit: maybe s/is present/presents/","commit_id":"a4ca3b3c31ac58c21bba52a4fa4a7338a161b0b6"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"cf354a3efd415b64f90032fe04938596646ba72b","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    \"\"\"Do not include vim configuration in source files."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    Check if vim configuration is present in the first 5 or the last 5 lines"},{"line_number":110,"context_line":"    of the file, if present return an error."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    N105"},{"line_number":113,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_7e44e0b7","line":110,"updated":"2014-06-26 08:01:05.000000000","message":"nit: s/present/presents/ ?","commit_id":"a4ca3b3c31ac58c21bba52a4fa4a7338a161b0b6"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"cf354a3efd415b64f90032fe04938596646ba72b","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    Check if vim configuration is present in the first 5 or the last 5 lines"},{"line_number":110,"context_line":"    of the file, if present return an error."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    N105"},{"line_number":113,"context_line":"    \"\"\""},{"line_number":114,"context_line":"    if line_number \u003c\u003d 5 or line_number \u003e len(lines) - 5:"},{"line_number":115,"context_line":"        if VIM_HEADER_RE.match(physical_line):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_3e25f809","line":112,"updated":"2014-06-26 08:01:05.000000000","message":"nit: maybe we can keep consistent with other checks, add  \"Don\u0027t put vim configuration in source files\" after \"N105\"?","commit_id":"a4ca3b3c31ac58c21bba52a4fa4a7338a161b0b6"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"9d2ec1805d6b5533888e8de7dc8ad3be1652e3d9","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    of the file, if yes then return an error."},{"line_number":112,"context_line":"    Current editor checks: vim, emacs."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    N105 Do not include editor configuration in source files."},{"line_number":115,"context_line":"    \"\"\""},{"line_number":116,"context_line":"    if line_number \u003c\u003d 5 or line_number \u003e len(lines) - 5:"},{"line_number":117,"context_line":"        if VIM_RE.match(physical_line) or EMACS_RE.match(physical_line):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_5587e9d6","line":114,"updated":"2014-07-03 22:10:15.000000000","message":"Shouldn\u0027t it be H105?","commit_id":"5366dc9888e3c7a8d84bd61b38c3908d3d3c0ea8"},{"author":{"_account_id":5892,"name":"pritesh","email":"pritesh@romana.io","username":"pritkoth"},"change_message_id":"b8b364f315f76b245d59f4c2c9878d519816b088","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    of the file, if yes then return an error."},{"line_number":112,"context_line":"    Current editor checks: vim, emacs."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    N105 Do not include editor configuration in source files."},{"line_number":115,"context_line":"    \"\"\""},{"line_number":116,"context_line":"    if line_number \u003c\u003d 5 or line_number \u003e len(lines) - 5:"},{"line_number":117,"context_line":"        if VIM_RE.match(physical_line) or EMACS_RE.match(physical_line):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_3543556d","line":114,"in_reply_to":"baada198_5587e9d6","updated":"2014-07-03 22:19:30.000000000","message":"yep, done","commit_id":"5366dc9888e3c7a8d84bd61b38c3908d3d3c0ea8"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"9d2ec1805d6b5533888e8de7dc8ad3be1652e3d9","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    \"\"\""},{"line_number":116,"context_line":"    if line_number \u003c\u003d 5 or line_number \u003e len(lines) - 5:"},{"line_number":117,"context_line":"        if VIM_RE.match(physical_line) or EMACS_RE.match(physical_line):"},{"line_number":118,"context_line":"            return (0, \"N105: Don\u0027t include editor configuration \""},{"line_number":119,"context_line":"                    \"in source files\")"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_b575a5fb","line":118,"updated":"2014-07-03 22:10:15.000000000","message":"Same here.","commit_id":"5366dc9888e3c7a8d84bd61b38c3908d3d3c0ea8"},{"author":{"_account_id":5892,"name":"pritesh","email":"pritesh@romana.io","username":"pritkoth"},"change_message_id":"b8b364f315f76b245d59f4c2c9878d519816b088","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    \"\"\""},{"line_number":116,"context_line":"    if line_number \u003c\u003d 5 or line_number \u003e len(lines) - 5:"},{"line_number":117,"context_line":"        if VIM_RE.match(physical_line) or EMACS_RE.match(physical_line):"},{"line_number":118,"context_line":"            return (0, \"N105: Don\u0027t include editor configuration \""},{"line_number":119,"context_line":"                    \"in source files\")"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_955d014a","line":118,"in_reply_to":"baada198_b575a5fb","updated":"2014-07-03 22:19:30.000000000","message":"yep, done","commit_id":"5366dc9888e3c7a8d84bd61b38c3908d3d3c0ea8"}]}
