)]}'
{"HACKING.rst":[{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"c63227370b768b4e8c4789163e3f016577539273","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":"These modules are \"incubating\" in oslo-incubator and are kept in sync"},{"line_number":303,"context_line":"with the help of oslo-incubator\u0027s update.py script. See:"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  https://wiki.openstack.org/wiki/Oslo#Incubation"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"da86d52c_a5a18c47","line":304,"updated":"2015-02-06 13:08:41.000000000","message":"It should not catch this :)","commit_id":"2e0f68879913f09a30aa9dfe849fb96c0ead4a2f"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"343f0738506dc95ce8f6dbc19c3360c015800993","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":"These modules are \"incubating\" in oslo-incubator and are kept in sync"},{"line_number":303,"context_line":"with the help of oslo-incubator\u0027s update.py script. See:"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  https://wiki.openstack.org/wiki/Oslo#Incubation"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"da86d52c_453450fb","line":304,"in_reply_to":"da86d52c_a5a18c47","updated":"2015-02-06 13:13:45.000000000","message":"It only checks for Openstack and not openstack.","commit_id":"2e0f68879913f09a30aa9dfe849fb96c0ead4a2f"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"c63227370b768b4e8c4789163e3f016577539273","unresolved":false,"context_lines":[{"line_number":348,"context_line":"For further information on constructing high quality commit messages,"},{"line_number":349,"context_line":"and how to split up commits into a series of changes, consult the"},{"line_number":350,"context_line":"project wiki:"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"   https://wiki.openstack.org/GitCommitMessages"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da86d52c_258d9cd3","line":351,"updated":"2015-02-06 13:08:41.000000000","message":"ditto","commit_id":"2e0f68879913f09a30aa9dfe849fb96c0ead4a2f"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"343f0738506dc95ce8f6dbc19c3360c015800993","unresolved":false,"context_lines":[{"line_number":348,"context_line":"For further information on constructing high quality commit messages,"},{"line_number":349,"context_line":"and how to split up commits into a series of changes, consult the"},{"line_number":350,"context_line":"project wiki:"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"   https://wiki.openstack.org/GitCommitMessages"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da86d52c_a53d0cdf","line":351,"in_reply_to":"da86d52c_258d9cd3","updated":"2015-02-06 13:13:45.000000000","message":"It only checks for Openstack and not openstack.","commit_id":"2e0f68879913f09a30aa9dfe849fb96c0ead4a2f"}],"hacking/checks/comments.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"5c0b724f280cc01d80116e1d520d4632c1fb10d5","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"@core.flake8ext"},{"line_number":186,"context_line":"def hacking_openstack_correct_capitalization(physical_line):"},{"line_number":187,"context_line":"    \"\"\"Check that the correct capitalization of OpenStack is used."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    H106 use the correct capitalization of OpenStack"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_3e002f34","line":186,"updated":"2015-05-12 23:39:04.000000000","message":"Instead of just checking the physical line, you should check if this is inside of a comment only.","commit_id":"2e0f68879913f09a30aa9dfe849fb96c0ead4a2f"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"9cfab0dd26c63126b31f50fa8d4268e5e12e1698","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    H106 use the correct capitalization of OpenStack"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    Okay: OpenStack"},{"line_number":192,"context_line":"    H106: Openstack"},{"line_number":193,"context_line":"    H106: OpenStack Openstack"},{"line_number":194,"context_line":"    \"\"\""},{"line_number":195,"context_line":"    if \u0027Openstack\u0027 in physical_line:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_7559f38d","line":192,"updated":"2015-02-06 21:39:48.000000000","message":"u","commit_id":"2e0f68879913f09a30aa9dfe849fb96c0ead4a2f"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"f56a337fcc6c157ffa4ea90ed5a15e53da17fc6b","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    Okay: OpenStack"},{"line_number":192,"context_line":"    H106: Openstack"},{"line_number":193,"context_line":"    H106: OpenStack Openstack"},{"line_number":194,"context_line":"    \"\"\""},{"line_number":195,"context_line":"    if \u0027Openstack\u0027 in physical_line:"},{"line_number":196,"context_line":"        pos \u003d physical_line.find(\u0027Openstack\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_251afcc5","line":193,"updated":"2015-02-06 13:06:34.000000000","message":"When we have this scenario?\n\n H106: OpenStack Openstack","commit_id":"2e0f68879913f09a30aa9dfe849fb96c0ead4a2f"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"dbd82d02e952e1a4319c1fd14d033ba837015ee5","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    Okay: OpenStack"},{"line_number":192,"context_line":"    H106: Openstack"},{"line_number":193,"context_line":"    H106: OpenStack Openstack"},{"line_number":194,"context_line":"    \"\"\""},{"line_number":195,"context_line":"    if \u0027Openstack\u0027 in physical_line:"},{"line_number":196,"context_line":"        pos \u003d physical_line.find(\u0027Openstack\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_80563604","line":193,"in_reply_to":"da86d52c_251afcc5","updated":"2015-02-06 13:15:07.000000000","message":"That is just to check that the test still matches when Openstack is used together with  OpenStack on one line. This will probably never happen.","commit_id":"2e0f68879913f09a30aa9dfe849fb96c0ead4a2f"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"8029c1e26e8295d65943be62938e28ededb83afb","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    Okay: OpenStack"},{"line_number":192,"context_line":"    H106: Openstack"},{"line_number":193,"context_line":"    H106: OpenStack Openstack"},{"line_number":194,"context_line":"    \"\"\""},{"line_number":195,"context_line":"    if \u0027Openstack\u0027 in physical_line:"},{"line_number":196,"context_line":"        pos \u003d physical_line.find(\u0027Openstack\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_20b82a10","line":193,"in_reply_to":"da86d52c_80563604","updated":"2015-02-06 13:22:41.000000000","message":"Instead I would recommend to test for this:\n\nhttps://wiki.openstack.org/wiki/Oslo#Incubation or only  \u0027openstack\u0027\n\nand remove H106: OpenStack Openstack\n\nI feel this hacking rule is fine to have assurance.","commit_id":"2e0f68879913f09a30aa9dfe849fb96c0ead4a2f"}]}