)]}'
{"hacking/core.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"85bffc0349351ca348fa75c7ee8b51b7916ce888","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            for check_path in set(local_check):"},{"line_number":158,"context_line":"                if check_path.strip():"},{"line_number":159,"context_line":"                    checker \u003d pbr.util.resolve_name(check_path)"},{"line_number":160,"context_line":"                    pep8.register_check(checker)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        if local_check_fact:"},{"line_number":163,"context_line":"            factory \u003d pbr.util.resolve_name(local_check_fact)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_1756125c","line":160,"updated":"2016-11-16 15:34:18.000000000","message":"This is backwards incompatible. It prevents local checks from ever being able to register their own flake8 config values or command-line options.","commit_id":"75c09ca65997b05d184f1b50a002c336876a95a6"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"513b04fb68e8f0acb4f49a5be767ac38c2bc208d","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            for check_path in set(local_check):"},{"line_number":158,"context_line":"                if check_path.strip():"},{"line_number":159,"context_line":"                    checker \u003d pbr.util.resolve_name(check_path)"},{"line_number":160,"context_line":"                    pep8.register_check(checker)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        if local_check_fact:"},{"line_number":163,"context_line":"            factory \u003d pbr.util.resolve_name(local_check_fact)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_a99a6261","line":160,"in_reply_to":"7a77a97e_1756125c","updated":"2016-11-16 15:48:35.000000000","message":"Not sure I understand. You seem to imply that hacking check functions themselves need to act as flake8 extensions? Can you please provide a sample of where this is done to clarify?\n\n\nIIUC, consumers that want to register their own conf/cli opts, do so ask flake8 extensions; this has nothing to do with actual hacking check functions themselves and therefore I don\u0027t see the issue you are referring to.\n\n\nFor example, I have a flake8 extension [1] that continues to function the same with the change herein.\n\n\n[1] https://review.openstack.org/#/c/395776/2/neutron_lib/hacking/checks.py@257","commit_id":"75c09ca65997b05d184f1b50a002c336876a95a6"}]}