)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"ee1eadad147b824a21be9c4a73f0611ce63a5031","unresolved":false,"context_lines":[{"line_number":16,"context_line":"now exists in hacking."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"It is understood that this is an edge case and if any future commits"},{"line_number":19,"context_line":"to hacking break Python 2.4 compatibility, it is known and will be"},{"line_number":20,"context_line":"handled at that time."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Iea3867b84212ab30bdd168b5dbd43c11a4dc535e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAARH%2F%2F8gQ%3D","line":19,"updated":"2013-08-14 19:53:10.000000000","message":"This is the important part, hacking is not trying to support python 2.4.   A patch won\u0027t be held up / reverted if it breaks anything py24 related. \n\nCan you add something like that.","commit_id":"7770f14186ff7cdee4766c788e26265b11c223f5"}],"hacking/core.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9082985cb163f2f5b268b1bb6c083a165c43944b","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    \"\"\""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    if pep8.noqa(physical_line):"},{"line_number":276,"context_line":"        return"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def is_old_style_except(logical_line):"},{"line_number":279,"context_line":"        return (\u0027,\u0027 in logical_line"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAARH%2F%2F4xk%3D","line":276,"updated":"2013-08-15 18:01:36.000000000","message":"Should this be a decorator that can be used everywhere? it is odd to me that # noqa would only work for some checks and not others.","commit_id":"277428b073447bbccf398233afe8aaeccfbfdd0c"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"fdf85f1afeab13b9b1b6593762d3cba52e2d7561","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    \"\"\""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    if pep8.noqa(physical_line):"},{"line_number":276,"context_line":"        return"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def is_old_style_except(logical_line):"},{"line_number":279,"context_line":"        return (\u0027,\u0027 in logical_line"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAARH%2F%2F4p8%3D","line":276,"in_reply_to":"AAAARH%2F%2F4xk%3D","updated":"2013-08-15 18:35:22.000000000","message":"I am not sure we want the ability to ignore any rule.  But I am not against the idea ... as long as its not abused.","commit_id":"277428b073447bbccf398233afe8aaeccfbfdd0c"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"21612580efd7e9c700abfebe44d4f1d1a44d59ea","unresolved":false,"context_lines":[{"line_number":391,"context_line":"    # pass the doctest, since the relativity depends on the file\u0027s locality"},{"line_number":392,"context_line":"    #TODO(mordred: We need to split this into 4 different checks so that they"},{"line_number":393,"context_line":"    # can be disabled by command line switches properly"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    if pep8.noqa(physical_line):"},{"line_number":396,"context_line":"        return"},{"line_number":397,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAARn%2F%2F4Bo%3D","line":394,"updated":"2013-08-20 20:36:16.000000000","message":"here","commit_id":"69f6aa64e03fa4463e75918c5ba11c51eb9b329c"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"77a61a5144d88bdf77407bbf26565b88f7037896","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        physical_line as one of its arguments and also has \u0027# noqa\u0027 in the"},{"line_number":63,"context_line":"        value of the physical_line argument.  Otherwise, it will return"},{"line_number":64,"context_line":"        the parent function with its original arguments."},{"line_number":65,"context_line":"        \"\"\""},{"line_number":66,"context_line":"        if \u0027physical_line\u0027 in f.func_code.co_varnames:"},{"line_number":67,"context_line":"            index \u003d f.func_code.co_varnames.index(\u0027physical_line\u0027)"},{"line_number":68,"context_line":"            if pep8.noqa(args[index]):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASX%2F%2F6J4%3D","line":65,"updated":"2013-08-23 21:44:47.000000000","message":"Is this docstring compatible with the hacking dosctring check? I thought a newline was needed between lines 60 and 61. It doesn\u0027t fail the pep8 test which should be running hacking on hacking? I will defer to Joe on this one.","commit_id":"03019d73f038d36b2ccb856bbb63e2a6fb237e7f"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"c1456b4282f099adde05c0e1e8d714831cf78aee","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        physical_line as one of its arguments and also has \u0027# noqa\u0027 in the"},{"line_number":63,"context_line":"        value of the physical_line argument.  Otherwise, it will return"},{"line_number":64,"context_line":"        the parent function with its original arguments."},{"line_number":65,"context_line":"        \"\"\""},{"line_number":66,"context_line":"        if \u0027physical_line\u0027 in f.func_code.co_varnames:"},{"line_number":67,"context_line":"            index \u003d f.func_code.co_varnames.index(\u0027physical_line\u0027)"},{"line_number":68,"context_line":"            if pep8.noqa(args[index]):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASX%2F%2F1wo%3D","line":65,"in_reply_to":"AAAASX%2F%2F6J4%3D","updated":"2013-08-26 14:20:40.000000000","message":"We don\u0027t have this test yet, but you are correct.  Normally i would say this is fine, but since this is hacking itself, we should hold it to a higher standard.\n\nAlso using a wrapper then silently failing if physcial_line isn\u0027t present is not a good behavior IMHO.  This will make things a confusing,  I would prefer this to fail loudly if phyiscal_line is missing, or  possibly explicitly add physical_line as a param.","commit_id":"03019d73f038d36b2ccb856bbb63e2a6fb237e7f"}]}
