)]}'
{"id":"openstack%2Fhacking~41713","triplet_id":"openstack%2Fhacking~master~Iea3867b84212ab30bdd168b5dbd43c11a4dc535e","project":"openstack/hacking","branch":"master","topic":"allow_pep8_no_qa_for_H231","hashtags":[],"change_id":"Iea3867b84212ab30bdd168b5dbd43c11a4dc535e","subject":"Adds ability to ignore hacking validations with noqa","status":"MERGED","created":"2013-08-13 15:57:56.000000000","updated":"2013-08-27 22:08:32.000000000","submitted":"2013-08-27 22:08:32.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9b27b4c6ef52666e1b0949177c2bc6841c5ba616","_number":41713,"virtual_id_number":41713,"owner":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":2,"date":"2013-08-27 22:08:32.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"all":[{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},{"value":2,"date":"2013-08-27 08:25:21.000000000","_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},{"value":2,"date":"2013-08-27 22:03:40.000000000","_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"all":[{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},{"value":0,"date":"2013-08-27 08:25:21.000000000","_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},{"value":1,"date":"2013-08-27 22:03:40.000000000","_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-08-20 13:57:51.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2013-08-20 15:05:18.000000000","updated_by":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"reviewer":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"state":"REVIEWER"},{"updated":"2013-08-20 19:56:32.000000000","updated_by":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"reviewer":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"state":"REVIEWER"},{"updated":"2013-08-21 14:56:39.000000000","updated_by":{"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},"reviewer":{"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},"state":"REVIEWER"},{"updated":"2013-08-23 21:44:47.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"},{"updated":"2013-08-27 08:25:21.000000000","updated_by":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"reviewer":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"state":"REVIEWER"},{"updated":"2013-08-27 22:03:40.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2013-08-27 22:08:32.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7e82083fb48e3b6a1632a23ece050dcfea47b26d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-13 16:02:30.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/13/41713/1/check/gate-hacking-pep8/88fe876 : FAILURE in 1m 10s\n- http://docs-draft.openstack.org/13/41713/1/check/gate-hacking-docs/9e78a6e/doc/build/html/ : SUCCESS in 1m 08s\n- http://logs.openstack.org/13/41713/1/check/gate-hacking-python26/da9c040 : SUCCESS in 1m 24s\n- http://logs.openstack.org/13/41713/1/check/gate-hacking-python27/a057128 : SUCCESS in 1m 09s\n- http://logs.openstack.org/13/41713/1/check/gate-hacking-python33/9ac88b8 : FAILURE in 4m 21s (non-voting)\n- http://logs.openstack.org/13/41713/1/check/gate-hacking-integration-nova/48bc1f1 : SUCCESS in 3m 22s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"22cc96c88ee75b6ac7044e153a6cac948d6ce3fe","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-08-13 16:08:12.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nWe don\u0027t support python 2.4 in hacking, and don\u0027t want to make sure things work for python 2.4 unless we have a testing harness.  But going back to the first part we don\u0027t support python 2.4, and I don\u0027t think it makes sense to add it.","accounts_in_message":[],"_revision_number":1},{"id":"ef7d86997bdeabc7f8c9a66f508a1aae5506b485","author":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"date":"2013-08-13 19:01:02.000000000","message":"Patch Set 1:\n\nI understand not wanting to support Python 2.4.  We aren\u0027t able to run hacking validations against the XenServer plugin in nova because it complains about Python2x or Python3x hacking validations.  Not allowing someone to apply noqa and bypass those validations explicitly seems a bit unfriendly.  If this isn\u0027t allowed, is it safe to assume we don\u0027t care to run the hacking validations against XenServer plugin in nova?  XenServer environments use Python 2.4.","accounts_in_message":[],"_revision_number":1},{"id":"1876dc64bfb02b50b7b1da3ca0d3f729c9bc3ab8","author":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"date":"2013-08-13 19:02:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b32154a8bce1f9d4919563f2c1e2219085abf1cb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-13 19:10:53.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/13/41713/2/check/gate-hacking-pep8/f6ad9c4 : SUCCESS in 45s\n- http://docs-draft.openstack.org/13/41713/2/check/gate-hacking-docs/9d65488/doc/build/html/ : SUCCESS in 43s\n- http://logs.openstack.org/13/41713/2/check/gate-hacking-python26/74b5f9b : SUCCESS in 1m 23s\n- http://logs.openstack.org/13/41713/2/check/gate-hacking-python27/fbbe186 : SUCCESS in 46s\n- http://logs.openstack.org/13/41713/2/check/gate-hacking-python33/9cfe6b4 : FAILURE in 4m 18s (non-voting)\n- http://logs.openstack.org/13/41713/2/check/gate-hacking-integration-nova/c249df6 : SUCCESS in 2m 58s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"c364de831445f295891274c9c46c62e33b8f3184","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-08-13 20:10:53.000000000","message":"Patch Set 2:\n\nJason, yes it is a bit unfriendly and I am sorry about that.  Note I did not minus this patch based on that.\n\nWhile this request seems reasonable I am concerned about the precedent, making sure hacking can run against py24 code. I will not block a patch to hacking if it breaks py24 compat.\n\nWith that in mind, I am fine with approving this patch and running hacking against the XenServer plugins, as long as the commit message makes the distinction above clear.","accounts_in_message":[],"_revision_number":2},{"id":"9636e1004d17ce17e244ca053b1f01efd1793db5","author":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"date":"2013-08-13 20:49:39.000000000","message":"Patch Set 2:\n\nThank you for understanding and your concern is valid, but would limit development for people who can\u0027t use environments with Python 2.6 or less, which you have agreed.  \n\nTo be clear, are you asking me to modify this commit message to be more clear?  Or are you asking/hoping that future commits on nova that have the \u0027noqa\u0027 comment need to be clear?  Thank you for clarifying.","accounts_in_message":[],"_revision_number":2},{"id":"46b9f572b203c547bb6371e31615dffcd164f05a","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-08-13 20:54:01.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nI am asking you to clarify this commit message.","accounts_in_message":[],"_revision_number":2},{"id":"3a9540d14870f9aaf4ccd6fc0720bc4846474db3","author":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"date":"2013-08-14 03:48:08.000000000","message":"Patch Set 2:\n\nGotta be honest, can you be a bit clearer on what you want in the commit message?  I think I give a good explanation, but please let me know what is missing.  I appreciate the guidance/help.","accounts_in_message":[],"_revision_number":2},{"id":"e315d6626953143f62eb78d02c35a7df51e8af47","author":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"date":"2013-08-14 17:34:49.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f56b989b6ec0088f224a7730befabc83a8d7dabc","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-08-14 17:34:54.000000000","message":"Patch Set 3:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":3},{"id":"766757d55321d98bba3bb08c09b7ed1d2ad83f05","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-14 18:12:00.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/13/41713/3/check/gate-hacking-pep8/fa15997 : SUCCESS in 36s\n- http://docs-draft.openstack.org/13/41713/3/check/gate-hacking-docs/d409587/doc/build/html/ : SUCCESS in 40s\n- http://logs.openstack.org/13/41713/3/check/gate-hacking-python26/97efc02 : SUCCESS in 54s\n- http://logs.openstack.org/13/41713/3/check/gate-hacking-python27/6f306da : SUCCESS in 44s\n- http://logs.openstack.org/13/41713/3/check/gate-hacking-python33/31bb92c : FAILURE in 4m 00s (non-voting)\n- http://logs.openstack.org/13/41713/3/check/gate-hacking-integration-nova/064fe6d : SUCCESS in 2m 57s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"ee1eadad147b824a21be9c4a73f0611ce63a5031","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-08-14 19:53:10.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"231184a4be4ddcf5869ec2dd02600111efd03427","author":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"date":"2013-08-14 20:16:40.000000000","message":"Patch Set 3:\n\nSo....you say that part I added to the commit is important.  Ok.  Does that mean you want that to be the whole commit message or what?  Why\u0027d you -1?  Thought you said you\u0027d accept this patch?\n\nCan you please bit a bit clearer.","accounts_in_message":[],"_revision_number":3},{"id":"9d60846e04c0c7afac17a39950cec9e1280150e5","author":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"date":"2013-08-14 20:32:17.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"e466fb268f95291d78722b06d9c7501c40fa0ae2","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-08-14 20:32:22.000000000","message":"Patch Set 4:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":4},{"id":"6a55166d2acc73915dfbf0298b50761aaf64a32e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-14 21:06:56.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/13/41713/4/check/gate-hacking-pep8/f389924 : SUCCESS in 36s\n- http://docs-draft.openstack.org/13/41713/4/check/gate-hacking-docs/c408626/doc/build/html/ : SUCCESS in 37s\n- http://logs.openstack.org/13/41713/4/check/gate-hacking-python26/232bed8 : SUCCESS in 1m 06s\n- http://logs.openstack.org/13/41713/4/check/gate-hacking-python27/baf2a75 : SUCCESS in 40s\n- http://logs.openstack.org/13/41713/4/check/gate-hacking-python33/1dc9d2d : FAILURE in 3m 58s (non-voting)\n- http://logs.openstack.org/13/41713/4/check/gate-hacking-integration-nova/5069349 : SUCCESS in 2m 50s (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"5b62c3004119ebbe9d0f85ab636282ff17d98868","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2013-08-15 00:02:35.000000000","message":"Patch Set 4: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"9082985cb163f2f5b268b1bb6c083a165c43944b","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2013-08-15 18:01:36.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nSmall suggestion to make this more generic so that we don\u0027t have to fix some other check in the same way in the future. I am fine with this merging as is to meet the immediate need so don\u0027t let this -1 hold up approval if necessary.","accounts_in_message":[],"_revision_number":4},{"id":"a1bbf8aaae98c74011ddaedcee5382c92dfadc1f","author":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"date":"2013-08-15 18:12:01.000000000","message":"Patch Set 4:\n\nI agree with making this more generic.  I realized I\u0027ll need this for H233 also.  Working on updating this patch.  Thank you for the feedback.","accounts_in_message":[],"_revision_number":4},{"id":"fdf85f1afeab13b9b1b6593762d3cba52e2d7561","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-08-15 18:35:22.000000000","message":"Patch Set 4: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"c3cde0dd62caec72ecd201af780131624a720ab0","author":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"date":"2013-08-19 14:41:35.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"ebaee36f3b7f81e76ec27e81dc0636c10856cab7","author":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"date":"2013-08-19 14:46:59.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"378714dc1f3bb8001c369f20b50be325454eda49","author":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"date":"2013-08-19 14:47:46.000000000","message":"Patch Set 6:\n\nFixed a typo in the decorator wrapper function\u0027s docstring","accounts_in_message":[],"_revision_number":6},{"id":"fff6a5634c4539090b996983f33775cbf24f8fd9","author":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"date":"2013-08-19 15:29:09.000000000","message":"Patch Set 6:\n\nShould I go ahead and decorate all of the core functions or just leave the decorator on the ones I need to bypass?  So a person who wants to bypass them doesn\u0027t have to push upstream to here.","accounts_in_message":[],"_revision_number":6},{"id":"f0b446eba04c4c119fa6e1c2e7df95279fdbccf6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-19 16:28:52.000000000","message":"Patch Set 6: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- gate-hacking-pep8 http://logs.openstack.org/13/41713/6/check/gate-hacking-pep8/f21d51b : FAILURE in 42s\n- gate-hacking-docs http://docs-draft.openstack.org/13/41713/6/check/gate-hacking-docs/6bf67bc/doc/build/html/ : SUCCESS in 49s\n- gate-hacking-python26 http://logs.openstack.org/13/41713/6/check/gate-hacking-python26/ec2aa38 : SUCCESS in 1m 03s\n- gate-hacking-python27 http://logs.openstack.org/13/41713/6/check/gate-hacking-python27/f8ae5a9 : SUCCESS in 54s\n- gate-hacking-python33 http://logs.openstack.org/13/41713/6/check/gate-hacking-python33/1ece362 : FAILURE in 4m 01s (non-voting)\n- gate-hacking-integration-nova http://logs.openstack.org/13/41713/6/check/gate-hacking-integration-nova/4406a84 : SUCCESS in 7m 18s (non-voting)\n","accounts_in_message":[],"_revision_number":6},{"id":"cddc4b8a82cc28b8a459b2ffab0e754780cf4432","author":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"date":"2013-08-19 16:39:50.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"2965494941b4c52dc9cc0221e24f59dd917380e2","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-08-19 16:39:55.000000000","message":"Patch Set 7:\n\nNew patchset patch-id matches previous patchset, but whitespace content has changed.","accounts_in_message":[],"_revision_number":7},{"id":"22d6c41e078028ae32c8c2d394c8be1524dd62de","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-19 18:11:42.000000000","message":"Patch Set 7: Works for me\n\nBuild succeeded.\n\n- gate-hacking-pep8 http://logs.openstack.org/13/41713/7/check/gate-hacking-pep8/30f8dc6 : SUCCESS in 41s\n- gate-hacking-docs http://docs-draft.openstack.org/13/41713/7/check/gate-hacking-docs/6d8bdb6/doc/build/html/ : SUCCESS in 50s\n- gate-hacking-python26 http://logs.openstack.org/13/41713/7/check/gate-hacking-python26/0b9a228 : SUCCESS in 1m 13s\n- gate-hacking-python27 http://logs.openstack.org/13/41713/7/check/gate-hacking-python27/364ed4c : SUCCESS in 57s\n- gate-hacking-python33 http://logs.openstack.org/13/41713/7/check/gate-hacking-python33/2c40bd8 : FAILURE in 3m 56s (non-voting)\n- gate-hacking-integration-nova http://logs.openstack.org/13/41713/7/check/gate-hacking-integration-nova/84fbae2 : SUCCESS in 3m 46s (non-voting)\n","accounts_in_message":[],"_revision_number":7},{"id":"b6ac754bd0e7085b44bad303c9b2b02c8906bf58","author":{"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},"date":"2013-08-19 18:13:54.000000000","message":"Patch Set 7: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":7},{"id":"4941bc4f4e07adef0905dbdabb8fe8ecbf3e1a8c","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2013-08-20 13:57:51.000000000","message":"Patch Set 7: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"f61f2d68b274fe027709af19a5efcaee755b5d7c","author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"date":"2013-08-20 15:05:18.000000000","message":"Patch Set 7: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":7},{"id":"7488a2433ff4fa82000c76578f47c2ad9be73c06","author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"date":"2013-08-20 19:56:32.000000000","message":"Patch Set 7: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":7},{"id":"21612580efd7e9c700abfebe44d4f1d1a44d59ea","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-08-20 20:36:16.000000000","message":"Patch Set 7: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nThere are some other cases of the noqa flag, can you convert those to use this decorator as well, I don\u0027t want half the code to do it one way and the other half another.  I highlighted one example.","accounts_in_message":[],"_revision_number":7},{"id":"020f07ad5d3a08fa69492c6a050fd37bf25536f6","author":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"date":"2013-08-20 20:39:06.000000000","message":"Patch Set 7:\n\nJoe: Good suggestions.\n\nShould I go ahead and decorate all of the methods with this so that if someone wants to use noqa they don\u0027t have to push an upstream change to hacking (adding the decorator)?","accounts_in_message":[],"_revision_number":7},{"id":"664e894615ce8e13edb31949b931a2cbd5e11dc4","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-08-20 22:07:48.000000000","message":"Patch Set 7:\n\n\"Should I go ahead and decorate all of the methods with this so that if someone wants to use noqa they don\u0027t have to push an upstream change to hacking (adding the decorator)?\"\n\nNo, I don\u0027t think we want to support noqa for every check, only checks that there are good reasons to potentially skip. noqa should be saved for special cases. (pep8.readthedocs.org/en/latest/intro.html#error-codes)","accounts_in_message":[],"_revision_number":7},{"id":"c13442182e23056df7b63679c38945e928b60542","author":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"date":"2013-08-21 03:58:04.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"b883e63053dd859db0bee32ede2af1e81edf18b6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-21 04:37:39.000000000","message":"Patch Set 8: Works for me\n\nBuild succeeded.\n\n- gate-hacking-pep8 http://logs.openstack.org/13/41713/8/check/gate-hacking-pep8/e8be36b : SUCCESS in 37s\n- gate-hacking-docs http://docs-draft.openstack.org/13/41713/8/check/gate-hacking-docs/94d23cb/doc/build/html/ : SUCCESS in 51s\n- gate-hacking-python26 http://logs.openstack.org/13/41713/8/check/gate-hacking-python26/cba7e4f : SUCCESS in 58s\n- gate-hacking-python27 http://logs.openstack.org/13/41713/8/check/gate-hacking-python27/de74bcf : SUCCESS in 45s\n- gate-hacking-python33 http://logs.openstack.org/13/41713/8/check/gate-hacking-python33/e8c9e51 : FAILURE in 4m 03s (non-voting)\n- gate-hacking-integration-nova http://logs.openstack.org/13/41713/8/check/gate-hacking-integration-nova/0cae504 : SUCCESS in 2m 49s (non-voting)\n","accounts_in_message":[],"_revision_number":8},{"id":"aaf8670139c493aae6aa98b9fa5918f60ca41a0b","author":{"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},"date":"2013-08-21 14:56:39.000000000","message":"Patch Set 8: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":8},{"id":"4024355e7aced4754f821362ff7400fa7a747758","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-08-23 13:05:22.000000000","message":"Patch Set 8: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":8},{"id":"77a61a5144d88bdf77407bbf26565b88f7037896","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2013-08-23 21:44:47.000000000","message":"Patch Set 8: Looks good to me, but someone else must approve\n\n(1 inline comment)\n\nSee inline comment for why this is a +1 and not a +2.","accounts_in_message":[],"_revision_number":8},{"id":"c1456b4282f099adde05c0e1e8d714831cf78aee","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-08-26 14:20:40.000000000","message":"Patch Set 8: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":8},{"id":"baa41e8edb2374c74d9fb83e5be0bf45a6015be3","author":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"date":"2013-08-26 15:54:54.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"444631aa360d9f79620790e1672e755429704c80","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-26 15:58:52.000000000","message":"Patch Set 9: Works for me\n\nBuild succeeded.\n\n- gate-hacking-pep8 http://logs.openstack.org/13/41713/9/check/gate-hacking-pep8/a83b2e1 : SUCCESS in 33s\n- gate-hacking-docs http://docs-draft.openstack.org/13/41713/9/check/gate-hacking-docs/a881bfb/doc/build/html/ : SUCCESS in 38s\n- gate-hacking-python26 http://logs.openstack.org/13/41713/9/check/gate-hacking-python26/01b5a39 : SUCCESS in 42s\n- gate-hacking-python27 http://logs.openstack.org/13/41713/9/check/gate-hacking-python27/ce46f3b : SUCCESS in 40s\n- gate-hacking-python33 http://logs.openstack.org/13/41713/9/check/gate-hacking-python33/711dd05 : FAILURE in 3m 53s (non-voting)\n- gate-hacking-integration-nova http://logs.openstack.org/13/41713/9/check/gate-hacking-integration-nova/5bb6cf5 : SUCCESS in 2m 44s (non-voting)\n","accounts_in_message":[],"_revision_number":9},{"id":"3e0543e9cc8f510971cede67f46af667852c9c1d","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-08-27 08:25:21.000000000","message":"Patch Set 9: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":9},{"id":"584cb23721a4caf86cd4715538c4598421a7bb37","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-27 22:03:40.000000000","message":"Patch Set 9: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":9},{"id":"f7ab62d78a2e7abf4c8bb4bb2bd7308fc084e77e","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-08-27 22:03:40.000000000","message":"Patch Set 9: Looks good to me (core reviewer); Approved\n\nThanks","accounts_in_message":[],"_revision_number":9},{"id":"739da807f4a05997f1a628ad0deb20bbd0170aa2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-27 22:08:32.000000000","message":"Patch Set 9: Verified\n\nBuild succeeded.\n\n- gate-hacking-docs http://docs-draft.openstack.org/13/41713/9/gate/gate-hacking-docs/6ddbc4e/doc/build/html/ : SUCCESS in 37s\n- gate-hacking-pep8 http://logs.openstack.org/13/41713/9/gate/gate-hacking-pep8/9dd65e1 : SUCCESS in 36s\n- gate-hacking-python26 http://logs.openstack.org/13/41713/9/gate/gate-hacking-python26/29029d2 : SUCCESS in 46s\n- gate-hacking-python27 http://logs.openstack.org/13/41713/9/gate/gate-hacking-python27/e084051 : SUCCESS in 33s\n- gate-hacking-python33 http://logs.openstack.org/13/41713/9/gate/gate-hacking-python33/2fce622 : FAILURE in 3m 54s (non-voting)\n- gate-hacking-integration-nova http://logs.openstack.org/13/41713/9/gate/gate-hacking-integration-nova/69b7c38 : SUCCESS in 2m 42s (non-voting)\n","accounts_in_message":[],"_revision_number":9},{"id":"ac07d0dcfc0c1f7ed23e8e86e5ad02a26d52d291","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-27 22:08:32.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":9}],"current_revision_number":9,"current_revision":"ce4f1f35c9465fc88e764527fc987328f66f7c89","revisions":{"a2cd81386be347b91011e9b352b757abe86e117c":{"kind":"REWORK","_number":1,"created":"2013-08-13 15:57:56.000000000","uploader":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"ref":"refs/changes/13/41713/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/hacking","ref":"refs/changes/13/41713/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/hacking refs/changes/13/41713/1"}}},"commit":{"parents":[{"commit":"57e14d627a3621c042763eedfc0493a24808c1af","subject":"Reword H404 description to match check","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/57e14d627a3621c042763eedfc0493a24808c1af"}]}],"author":{"name":"jmeridth","email":"jmeridth@gmail.com","date":"2013-08-13 15:52:58.000000000","tz":0},"committer":{"name":"jmeridth","email":"jmeridth@gmail.com","date":"2013-08-13 15:55:37.000000000","tz":0},"subject":"Adds ability to ignore H231, python3x except compatability check","message":"Adds ability to ignore H231, python3x except compatability check\n\nCheck the existence of \u0027noqa\u0027 comment on except line to bypass\nH231 validation.  Need this feature because nova XenServer uses\nPython 2.4 and pep8 is failing on older except clauses.  This\nis currently N308 in nova checks.py,\nhttps://github.com/openstack/nova/blob/master/nova/hacking/checks.py#L34\n\nI will be submitting a review to nova to remove N308 since H23\nnow exists in hacking.\n\nChange-Id: Iea3867b84212ab30bdd168b5dbd43c11a4dc535e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/a2cd81386be347b91011e9b352b757abe86e117c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/a2cd81386be347b91011e9b352b757abe86e117c"}]},"branch":"refs/heads/master"},"6ea0f8515ff7c6ef11a284fe34ccd2927b3d0cd8":{"kind":"REWORK","_number":2,"created":"2013-08-13 19:02:34.000000000","uploader":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"ref":"refs/changes/13/41713/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/hacking","ref":"refs/changes/13/41713/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/hacking refs/changes/13/41713/2"}}},"commit":{"parents":[{"commit":"57e14d627a3621c042763eedfc0493a24808c1af","subject":"Reword H404 description to match check","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/57e14d627a3621c042763eedfc0493a24808c1af"}]}],"author":{"name":"jmeridth","email":"jmeridth@gmail.com","date":"2013-08-13 15:52:58.000000000","tz":0},"committer":{"name":"jmeridth","email":"jmeridth@gmail.com","date":"2013-08-13 19:02:33.000000000","tz":0},"subject":"Adds ability to ignore H231, python3x except compatability check","message":"Adds ability to ignore H231, python3x except compatability check\n\nCheck the existence of \u0027noqa\u0027 comment on except line to bypass\nH231 validation.  Need this feature because nova XenServer uses\nPython 2.4 and pep8 is failing on older except clauses.  This\nis currently N308 in nova checks.py,\nhttps://github.com/openstack/nova/blob/master/nova/hacking/checks.py#L34\n\nI will be submitting a review to nova to remove N308 since H23\nnow exists in hacking.\n\nChange-Id: Iea3867b84212ab30bdd168b5dbd43c11a4dc535e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/6ea0f8515ff7c6ef11a284fe34ccd2927b3d0cd8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/6ea0f8515ff7c6ef11a284fe34ccd2927b3d0cd8"}]},"branch":"refs/heads/master"},"7770f14186ff7cdee4766c788e26265b11c223f5":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2013-08-14 17:34:49.000000000","uploader":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"ref":"refs/changes/13/41713/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/hacking","ref":"refs/changes/13/41713/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/hacking refs/changes/13/41713/3"}}},"commit":{"parents":[{"commit":"57e14d627a3621c042763eedfc0493a24808c1af","subject":"Reword H404 description to match check","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/57e14d627a3621c042763eedfc0493a24808c1af"}]}],"author":{"name":"jmeridth","email":"jmeridth@gmail.com","date":"2013-08-13 15:52:58.000000000","tz":0},"committer":{"name":"jmeridth","email":"jmeridth@gmail.com","date":"2013-08-14 17:32:32.000000000","tz":0},"subject":"Adds ability to ignore H231, python3x except compatability check","message":"Adds ability to ignore H231, python3x except compatability check\n\nCheck the existence of \u0027noqa\u0027 comment on except line to bypass\nH231 validation.  Need this feature because nova XenServer uses\nPython 2.4 and pep8 is failing on older except clauses.  This\nis currently N308 in nova checks.py,\nhttps://github.com/openstack/nova/blob/master/nova/hacking/checks.py#L34\n\nI will be submitting a review to nova to remove N308 since H231\nnow exists in hacking.\n\nIt is understood that this is an edge case and if any future commits\nto hacking break Python 2.4 compatibility, it is known and will be\nhandled at that time.\n\nChange-Id: Iea3867b84212ab30bdd168b5dbd43c11a4dc535e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/7770f14186ff7cdee4766c788e26265b11c223f5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/7770f14186ff7cdee4766c788e26265b11c223f5"}]},"branch":"refs/heads/master"},"277428b073447bbccf398233afe8aaeccfbfdd0c":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2013-08-14 20:32:17.000000000","uploader":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"ref":"refs/changes/13/41713/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/hacking","ref":"refs/changes/13/41713/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/hacking refs/changes/13/41713/4"}}},"commit":{"parents":[{"commit":"57e14d627a3621c042763eedfc0493a24808c1af","subject":"Reword H404 description to match check","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/57e14d627a3621c042763eedfc0493a24808c1af"}]}],"author":{"name":"jmeridth","email":"jmeridth@gmail.com","date":"2013-08-13 15:52:58.000000000","tz":0},"committer":{"name":"jmeridth","email":"jmeridth@gmail.com","date":"2013-08-14 20:31:13.000000000","tz":0},"subject":"Adds ability to ignore H231, python3x except compatability check","message":"Adds ability to ignore H231, python3x except compatability check\n\nCheck the existence of \u0027noqa\u0027 comment on except line to bypass\nH231 validation.  Need this feature because nova XenServer uses\nPython 2.4 and pep8 is failing on older except clauses.  This\nis currently N308 in nova checks.py,\nhttps://github.com/openstack/nova/blob/master/nova/hacking/checks.py#L34\n\nI will be submitting a review to nova to remove N308 since H231\nnow exists in hacking.\n\nIt is understood that a patch to hacking won\u0027t be held up or reverted\nif it breaks anything Python 2.4 related, including breaking of this\npatch.\n\nChange-Id: Iea3867b84212ab30bdd168b5dbd43c11a4dc535e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/277428b073447bbccf398233afe8aaeccfbfdd0c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/277428b073447bbccf398233afe8aaeccfbfdd0c"}]},"branch":"refs/heads/master"},"692611e3192b72f7208410f032169bd6e838c265":{"kind":"REWORK","_number":5,"created":"2013-08-19 14:41:35.000000000","uploader":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"ref":"refs/changes/13/41713/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/hacking","ref":"refs/changes/13/41713/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/hacking refs/changes/13/41713/5"}}},"commit":{"parents":[{"commit":"57e14d627a3621c042763eedfc0493a24808c1af","subject":"Reword H404 description to match check","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/57e14d627a3621c042763eedfc0493a24808c1af"}]}],"author":{"name":"jmeridth","email":"jmeridth@gmail.com","date":"2013-08-13 15:52:58.000000000","tz":0},"committer":{"name":"jmeridth","email":"jmeridth@gmail.com","date":"2013-08-19 14:41:28.000000000","tz":0},"subject":"Adds ability to ignore hacking validations with noqa","message":"Adds ability to ignore hacking validations with noqa\n\nAdd allownoqa decorator that can be applied to any of the hacking\ncore functions.  This allows a using application to bypass that\nparticular hacking validation.  The reason this is being introduced\nis because I need to bypass H231 and H233, both Python 3.x\nvalidations.  I need to bypass these so we can run pep8 validations\non the nova XenServer plugins.  XenServer usese Python 2.4 in its\nenvironment and therefore the code won\u0027t pass those two or future\nPython 3.x validations.\n\nIt is understood that a patch to hacking won\u0027t be held up or reverted\nif it breaks anything Python 2.4 related, including breaking of this\npatch.\n\nChange-Id: Iea3867b84212ab30bdd168b5dbd43c11a4dc535e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/692611e3192b72f7208410f032169bd6e838c265"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/692611e3192b72f7208410f032169bd6e838c265"}]},"branch":"refs/heads/master"},"0ddcf84dbda01e0b00644ece89b8b5042d5f037b":{"kind":"REWORK","_number":6,"created":"2013-08-19 14:46:59.000000000","uploader":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"ref":"refs/changes/13/41713/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/hacking","ref":"refs/changes/13/41713/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/hacking refs/changes/13/41713/6"}}},"commit":{"parents":[{"commit":"57e14d627a3621c042763eedfc0493a24808c1af","subject":"Reword H404 description to match check","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/57e14d627a3621c042763eedfc0493a24808c1af"}]}],"author":{"name":"jmeridth","email":"jmeridth@gmail.com","date":"2013-08-13 15:52:58.000000000","tz":0},"committer":{"name":"jmeridth","email":"jmeridth@gmail.com","date":"2013-08-19 14:46:54.000000000","tz":0},"subject":"Adds ability to ignore hacking validations with noqa","message":"Adds ability to ignore hacking validations with noqa\n\nAdd allownoqa decorator that can be applied to any of the hacking\ncore functions.  This allows a using application to bypass that\nparticular hacking validation.  The reason this is being introduced\nis because I need to bypass H231 and H233, both Python 3.x\nvalidations.  I need to bypass these so we can run pep8 validations\non the nova XenServer plugins.  XenServer usese Python 2.4 in its\nenvironment and therefore the code won\u0027t pass those two or future\nPython 3.x validations.\n\nIt is understood that a patch to hacking won\u0027t be held up or reverted\nif it breaks anything Python 2.4 related, including breaking of this\npatch.\n\nChange-Id: Iea3867b84212ab30bdd168b5dbd43c11a4dc535e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/0ddcf84dbda01e0b00644ece89b8b5042d5f037b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/0ddcf84dbda01e0b00644ece89b8b5042d5f037b"}]},"branch":"refs/heads/master"},"69f6aa64e03fa4463e75918c5ba11c51eb9b329c":{"kind":"REWORK","_number":7,"created":"2013-08-19 16:39:50.000000000","uploader":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"ref":"refs/changes/13/41713/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/hacking","ref":"refs/changes/13/41713/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/hacking refs/changes/13/41713/7"}}},"commit":{"parents":[{"commit":"57e14d627a3621c042763eedfc0493a24808c1af","subject":"Reword H404 description to match check","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/57e14d627a3621c042763eedfc0493a24808c1af"}]}],"author":{"name":"jmeridth","email":"jmeridth@gmail.com","date":"2013-08-13 15:52:58.000000000","tz":0},"committer":{"name":"jmeridth","email":"jmeridth@gmail.com","date":"2013-08-19 16:39:42.000000000","tz":0},"subject":"Adds ability to ignore hacking validations with noqa","message":"Adds ability to ignore hacking validations with noqa\n\nAdd allownoqa decorator that can be applied to any of the hacking\ncore functions.  This allows a using application to bypass that\nparticular hacking validation.  The reason this is being introduced\nis because I need to bypass H231 and H233, both Python 3.x\nvalidations.  I need to bypass these so we can run pep8 validations\non the nova XenServer plugins.  XenServer usese Python 2.4 in its\nenvironment and therefore the code won\u0027t pass those two or future\nPython 3.x validations.\n\nIt is understood that a patch to hacking won\u0027t be held up or reverted\nif it breaks anything Python 2.4 related, including breaking of this\npatch.\n\nChange-Id: Iea3867b84212ab30bdd168b5dbd43c11a4dc535e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/69f6aa64e03fa4463e75918c5ba11c51eb9b329c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/69f6aa64e03fa4463e75918c5ba11c51eb9b329c"}]},"branch":"refs/heads/master"},"03019d73f038d36b2ccb856bbb63e2a6fb237e7f":{"kind":"REWORK","_number":8,"created":"2013-08-21 03:58:04.000000000","uploader":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"ref":"refs/changes/13/41713/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/hacking","ref":"refs/changes/13/41713/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/hacking refs/changes/13/41713/8"}}},"commit":{"parents":[{"commit":"57e14d627a3621c042763eedfc0493a24808c1af","subject":"Reword H404 description to match check","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/57e14d627a3621c042763eedfc0493a24808c1af"}]}],"author":{"name":"jmeridth","email":"jmeridth@gmail.com","date":"2013-08-13 15:52:58.000000000","tz":0},"committer":{"name":"jmeridth","email":"jmeridth@gmail.com","date":"2013-08-21 03:57:53.000000000","tz":0},"subject":"Adds ability to ignore hacking validations with noqa","message":"Adds ability to ignore hacking validations with noqa\n\nAdd allownoqa decorator that can be applied to any of the hacking\ncore functions.  This allows a using application to bypass that\nparticular hacking validation.  The reason this is being introduced\nis because I need to bypass H231 and H233, both Python 3.x\nvalidations.  I need to bypass these so we can run pep8 validations\non the nova XenServer plugins.  XenServer usese Python 2.4 in its\nenvironment and therefore the code won\u0027t pass those two or future\nPython 3.x validations.\n\nIt is understood that a patch to hacking won\u0027t be held up or reverted\nif it breaks anything Python 2.4 related, including breaking of this\npatch.\n\nChange-Id: Iea3867b84212ab30bdd168b5dbd43c11a4dc535e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/03019d73f038d36b2ccb856bbb63e2a6fb237e7f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/03019d73f038d36b2ccb856bbb63e2a6fb237e7f"}]},"branch":"refs/heads/master"},"ce4f1f35c9465fc88e764527fc987328f66f7c89":{"kind":"REWORK","_number":9,"created":"2013-08-26 15:54:54.000000000","uploader":{"_account_id":7924,"name":"Jason Meridth","email":"jmeridth@gmail.com","username":"jmeridth"},"ref":"refs/changes/13/41713/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/hacking","ref":"refs/changes/13/41713/9","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/hacking refs/changes/13/41713/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/hacking refs/changes/13/41713/9"}}},"commit":{"parents":[{"commit":"57e14d627a3621c042763eedfc0493a24808c1af","subject":"Reword H404 description to match check","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/57e14d627a3621c042763eedfc0493a24808c1af"}]}],"author":{"name":"jmeridth","email":"jmeridth@gmail.com","date":"2013-08-13 15:52:58.000000000","tz":0},"committer":{"name":"jmeridth","email":"jmeridth@gmail.com","date":"2013-08-26 15:54:37.000000000","tz":0},"subject":"Adds ability to ignore hacking validations with noqa","message":"Adds ability to ignore hacking validations with noqa\n\nAdd allownoqa decorator that can be applied to any of the hacking\ncore functions.  This allows a using application to bypass that\nparticular hacking validation.  The reason this is being introduced\nis because I need to bypass H231 and H233, both Python 3.x\nvalidations.  I need to bypass these so we can run pep8 validations\non the nova XenServer plugins.  XenServer usese Python 2.4 in its\nenvironment and therefore the code won\u0027t pass those two or future\nPython 3.x validations.\n\nIt is understood that a patch to hacking won\u0027t be held up or reverted\nif it breaks anything Python 2.4 related, including breaking of this\npatch.\n\nChange-Id: Iea3867b84212ab30bdd168b5dbd43c11a4dc535e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/ce4f1f35c9465fc88e764527fc987328f66f7c89"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/ce4f1f35c9465fc88e764527fc987328f66f7c89"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
