)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"b813b9e4e56f55278a3e680fe098f2a0b2197e8d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"that the used logger is named \u0027LOG\u0027, so we ensure that"},{"line_number":13,"context_line":"hacking checks will run."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1]: https://github.com/openstack-dev/hacking/blob/master/hacking/checks/other.py#L18"},{"line_number":16,"context_line":"[2]: https://github.com/openstack/nova/blob/master/nova/hacking/checks.py#L78"},{"line_number":17,"context_line":"[3]: https://github.com/openstack/trove/blob/master/trove/hacking/translation_checks.py#L29"},{"line_number":18,"context_line":"[4]: https://github.com/openstack/neutron/blob/master/neutron/hacking/checks.py#L71"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a30ddce_a0aecb95","line":15,"updated":"2017-03-09 15:07:56.000000000","message":"Please use SHA unique links like:\n\nhttps://github.com/openstack-dev/hacking/blob/635d5d34e65d6a91da57e843c26ab1c682efb3fc/hacking/checks/other.py#L18\n\nAs content will change as time goes on and the links as they are now will end up being wrong.","commit_id":"6615f9ce62b2efa2e6c15bf3424ef34266e72705"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"b21c55c05d3e918762bfce8fffa400047976c709","unresolved":false,"context_lines":[{"line_number":12,"context_line":"that the used logger is named \u0027LOG\u0027, so we ensure that"},{"line_number":13,"context_line":"hacking checks will run."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1]: https://github.com/openstack-dev/hacking/blob/master/hacking/checks/other.py#L18"},{"line_number":16,"context_line":"[2]: https://github.com/openstack/nova/blob/master/nova/hacking/checks.py#L78"},{"line_number":17,"context_line":"[3]: https://github.com/openstack/trove/blob/master/trove/hacking/translation_checks.py#L29"},{"line_number":18,"context_line":"[4]: https://github.com/openstack/neutron/blob/master/neutron/hacking/checks.py#L71"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a30ddce_c0565f5b","line":15,"in_reply_to":"9a30ddce_a0aecb95","updated":"2017-03-09 15:13:07.000000000","message":"Thanks, that is a nice idea!","commit_id":"6615f9ce62b2efa2e6c15bf3424ef34266e72705"}],"HACKING.rst":[{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"2cc4547d264add1ffb883350cc7c92d597db5040","unresolved":false,"context_lines":[{"line_number":33,"context_line":"- [H105] Don\u0027t use author tags. We use version control instead."},{"line_number":34,"context_line":"- [H106] Don\u0027t put vim configuration in source files (off by default)."},{"line_number":35,"context_line":"- [H904] Delay string interpolations at logging calls (off by default)."},{"line_number":36,"context_line":"- [H905] Logger name always should be \"LOG\"."},{"line_number":37,"context_line":"- Do not shadow a built-in or reserved word. Shadowing built -in or reserved"},{"line_number":38,"context_line":"  words makes the code harder to understand. Example::"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f436f4f_0eb15e90","line":36,"updated":"2017-08-08 09:49:53.000000000","message":"(off by default).","commit_id":"649075eacb5e41e1a1a36b8cb5f3796ab3b74a8d"}],"hacking/checks/other.py":[{"author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"change_message_id":"2665f0238d41615e1ed9881ef7b0b7f460e7e147","unresolved":false,"context_lines":[{"line_number":59,"context_line":"def check_logger_name(logical_line, noqa):"},{"line_number":60,"context_line":"    r\"\"\"Check that logger is named to LOG."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    H905: logger \u003d logging.getLogger(__name__)"},{"line_number":63,"context_line":"    Okay: LOG \u003d logging.getLogger(__name__)"},{"line_number":64,"context_line":"    \"\"\""},{"line_number":65,"context_line":"    msg \u003d (\"H905: Logger\u0027s name always should be \u0027LOG\u0027 as lots of hacking \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_3d9699f0","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":46},"updated":"2017-03-09 02:18:53.000000000","message":"In fact, in addition to logger I have also seen _logging, I think this line maybe can delete...","commit_id":"1dde84effec791073a49add8ea8fcc6f3d4ee0e9"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"9d45bd30c78bdbf320f74cfd7c6a56c8a573bace","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    Okay: LOG \u003d logging.getLogger(__name__)"},{"line_number":64,"context_line":"    \"\"\""},{"line_number":65,"context_line":"    msg \u003d (\"H905: Logger\u0027s name always should be \u0027LOG\u0027 as lots of hacking \""},{"line_number":66,"context_line":"           \"checks expect that logger\u0027s name is \u0027LOG\u0027.\")"},{"line_number":67,"context_line":"    if noqa:"},{"line_number":68,"context_line":"        return"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_0952cbde","line":66,"range":{"start_line":66,"start_character":12,"end_line":66,"end_character":53},"updated":"2017-07-05 18:08:07.000000000","message":"I wonder if we should try to fix those checks instead of adding a new one that arbitrarily forces variable naming on projects, some of which may not even be able to comply with the rule (tripleoclient for example uses self.log frequently and cannot reasonably change to use the LOG name).","commit_id":"29dc4fdb90a6fb94bc51aaf68f257ded622be426"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7c5bfbc3ca533e9fff8b59bfc3085b272b037709","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    Okay: LOG \u003d logging.getLogger(__name__)"},{"line_number":64,"context_line":"    \"\"\""},{"line_number":65,"context_line":"    msg \u003d (\"H905: Logger\u0027s name always should be \u0027LOG\u0027 as lots of hacking \""},{"line_number":66,"context_line":"           \"checks expect that logger\u0027s name is \u0027LOG\u0027.\")"},{"line_number":67,"context_line":"    if noqa:"},{"line_number":68,"context_line":"        return"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_8212cd08","line":66,"range":{"start_line":66,"start_character":12,"end_line":66,"end_character":53},"in_reply_to":"3f1d235d_0952cbde","updated":"2017-07-20 17:59:02.000000000","message":"This is an \"off by default\" check. So if a project wants to use it they can enable. Other projects are unaffected.","commit_id":"29dc4fdb90a6fb94bc51aaf68f257ded622be426"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"2cc4547d264add1ffb883350cc7c92d597db5040","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    if \u0027getLogger(\u0027 in logical_line:"},{"line_number":71,"context_line":"        try:"},{"line_number":72,"context_line":"            logger_name \u003d logical_line[:logical_line.index(\u0027\u003d\u0027)].strip()"},{"line_number":73,"context_line":"            use_log \u003d re.search(r\"\\.LOG\", logger_name)"},{"line_number":74,"context_line":"            if logger_name !\u003d \"LOG\" and use_log is None:"},{"line_number":75,"context_line":"                yield 0, msg"},{"line_number":76,"context_line":"        except ValueError:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_ee205ab3","line":73,"range":{"start_line":73,"start_character":22,"end_line":73,"end_character":40},"updated":"2017-08-08 09:49:53.000000000","message":"Globalize this regex will help us increase performance. Let\u0027s see my commit https://review.openstack.org/#/c/482795/","commit_id":"649075eacb5e41e1a1a36b8cb5f3796ab3b74a8d"}]}