)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"89fc4ca7ae5ca10c2ef86168a1eaccb752bbcd20","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chang Bo Guo \u003cguochbo@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-10 01:04:49 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add check for removed mouldes in Python 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some modules like commands were removed in Python 3."},{"line_number":10,"context_line":"Add H236 rule to check this."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9hnI%3D","line":7,"updated":"2013-12-10 15:46:36.000000000","message":"Typo in word \u0027mouldes\u0027.","commit_id":"adb480a985942460749852fc3a5ce781c33b6c0b"}],"hacking/core.py":[{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"89fc4ca7ae5ca10c2ef86168a1eaccb752bbcd20","unresolved":false,"context_lines":[{"line_number":371,"context_line":"                \"H235: assert_ is deprecated, use assertTrue\")"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    # NOTE(guochbo): This is removed module list from reference:"},{"line_number":374,"context_line":"    # http://python3porting.com/stdlib.html#removed-modules"},{"line_number":375,"context_line":"    removed_modules \u003d[\u0027audiodev\u0027, \u0027Bastion\u0027, \u0027bsddb185\u0027, \u0027bsddb3\u0027,"},{"line_number":376,"context_line":"                      \u0027Canvas\u0027, \u0027cfmfile\u0027, \u0027cl\u0027, \u0027commands\u0027, \u0027compiler\u0027"},{"line_number":377,"context_line":"                      \u0027dircache\u0027, \u0027dl\u0027, \u0027exception\u0027, \u0027fpformat\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9hm8%3D","line":374,"updated":"2013-12-10 15:46:36.000000000","message":"It looks ok, but in addition could we probably use six for adding more checks and/or helpful exceptions on this topic?","commit_id":"adb480a985942460749852fc3a5ce781c33b6c0b"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"e7ca8ca6070f5fa00b81a4b9fb4b3d998f109b82","unresolved":false,"context_lines":[{"line_number":371,"context_line":"                \"H235: assert_ is deprecated, use assertTrue\")"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    # NOTE(guochbo): This is removed module list from reference:"},{"line_number":374,"context_line":"    # http://python3porting.com/stdlib.html#removed-modules"},{"line_number":375,"context_line":"    removed_modules \u003d[\u0027audiodev\u0027, \u0027Bastion\u0027, \u0027bsddb185\u0027, \u0027bsddb3\u0027,"},{"line_number":376,"context_line":"                      \u0027Canvas\u0027, \u0027cfmfile\u0027, \u0027cl\u0027, \u0027commands\u0027, \u0027compiler\u0027"},{"line_number":377,"context_line":"                      \u0027dircache\u0027, \u0027dl\u0027, \u0027exception\u0027, \u0027fpformat\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F8zjA%3D","line":374,"in_reply_to":"AAAATn%2F9Mgg%3D","updated":"2013-12-20 05:57:40.000000000","message":"Never mind, it just was an idea about using six internals to make a check for using six.","commit_id":"adb480a985942460749852fc3a5ce781c33b6c0b"},{"author":{"_account_id":6722,"name":"ChangBo Guo(gcb)","email":"guochbo@cn.ibm.com","username":"guochbo"},"change_message_id":"caa4490f23e4fc3d6476f4a3a9fac14d97c9413f","unresolved":false,"context_lines":[{"line_number":371,"context_line":"                \"H235: assert_ is deprecated, use assertTrue\")"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    # NOTE(guochbo): This is removed module list from reference:"},{"line_number":374,"context_line":"    # http://python3porting.com/stdlib.html#removed-modules"},{"line_number":375,"context_line":"    removed_modules \u003d[\u0027audiodev\u0027, \u0027Bastion\u0027, \u0027bsddb185\u0027, \u0027bsddb3\u0027,"},{"line_number":376,"context_line":"                      \u0027Canvas\u0027, \u0027cfmfile\u0027, \u0027cl\u0027, \u0027commands\u0027, \u0027compiler\u0027"},{"line_number":377,"context_line":"                      \u0027dircache\u0027, \u0027dl\u0027, \u0027exception\u0027, \u0027fpformat\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9Mgg%3D","line":374,"in_reply_to":"AAAATn%2F9dsY%3D","updated":"2013-12-14 15:11:21.000000000","message":"This is not addressed in new patchset .","commit_id":"adb480a985942460749852fc3a5ce781c33b6c0b"},{"author":{"_account_id":6722,"name":"ChangBo Guo(gcb)","email":"guochbo@cn.ibm.com","username":"guochbo"},"change_message_id":"0534b208a51cdf509cad9ce4d44affc19d131f31","unresolved":false,"context_lines":[{"line_number":371,"context_line":"                \"H235: assert_ is deprecated, use assertTrue\")"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    # NOTE(guochbo): This is removed module list from reference:"},{"line_number":374,"context_line":"    # http://python3porting.com/stdlib.html#removed-modules"},{"line_number":375,"context_line":"    removed_modules \u003d[\u0027audiodev\u0027, \u0027Bastion\u0027, \u0027bsddb185\u0027, \u0027bsddb3\u0027,"},{"line_number":376,"context_line":"                      \u0027Canvas\u0027, \u0027cfmfile\u0027, \u0027cl\u0027, \u0027commands\u0027, \u0027compiler\u0027"},{"line_number":377,"context_line":"                      \u0027dircache\u0027, \u0027dl\u0027, \u0027exception\u0027, \u0027fpformat\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9dsY%3D","line":374,"in_reply_to":"AAAATn%2F9hm8%3D","updated":"2013-12-11 08:50:11.000000000","message":"Hi,\nSorry , I couldn\u0027t get your point :), Can you provide more details ?","commit_id":"adb480a985942460749852fc3a5ce781c33b6c0b"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"5081b78c79060ccde477f6c09a1b004f6ee2925a","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    \u0027new\u0027, \u0027popen2\u0027, \u0027posixfile\u0027, \u0027pure\u0027, \u0027rexec\u0027"},{"line_number":397,"context_line":"    \u0027rfc822\u0027, \u0027sha\u0027, \u0027sgmllib\u0027, \u0027sre\u0027, \u0027stat\u0027"},{"line_number":398,"context_line":"    \u0027stringold\u0027, \u0027sunaudio\u0027 \u0027sv\u0027, \u0027test.testall\u0027,"},{"line_number":399,"context_line":"    \u0027thread\u0027, \u0027timing\u0027, \u0027toaiff\u0027, \u0027user\u0027"},{"line_number":400,"context_line":"]"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAT3%2F%2F51Q%3D","line":399,"updated":"2013-12-27 13:16:58.000000000","message":"I guess, that this list is incomplete. What about urrlib, for example? See http://docs.python.org/2/library/urllib.html","commit_id":"1c7c53b3e18d3f556d140fb537ca157e1dca5a66"},{"author":{"_account_id":6722,"name":"ChangBo Guo(gcb)","email":"guochbo@cn.ibm.com","username":"guochbo"},"change_message_id":"cb241a568992308dc7eea426c2804dabefbcd530","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    \u0027new\u0027, \u0027popen2\u0027, \u0027posixfile\u0027, \u0027pure\u0027, \u0027rexec\u0027"},{"line_number":397,"context_line":"    \u0027rfc822\u0027, \u0027sha\u0027, \u0027sgmllib\u0027, \u0027sre\u0027, \u0027stat\u0027"},{"line_number":398,"context_line":"    \u0027stringold\u0027, \u0027sunaudio\u0027 \u0027sv\u0027, \u0027test.testall\u0027,"},{"line_number":399,"context_line":"    \u0027thread\u0027, \u0027timing\u0027, \u0027toaiff\u0027, \u0027user\u0027"},{"line_number":400,"context_line":"]"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAT3%2F%2F5oE%3D","line":399,"in_reply_to":"AAAAT3%2F%2F51Q%3D","updated":"2013-12-27 14:29:48.000000000","message":"Victor, the urllib is not removed , it is renamed. This patch doesn\u0027t cover the renamed libraries.","commit_id":"1c7c53b3e18d3f556d140fb537ca157e1dca5a66"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"095ea8e4c31f18bd9d98377f32fa05add26b886e","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    \u0027new\u0027, \u0027popen2\u0027, \u0027posixfile\u0027, \u0027pure\u0027, \u0027rexec\u0027"},{"line_number":397,"context_line":"    \u0027rfc822\u0027, \u0027sha\u0027, \u0027sgmllib\u0027, \u0027sre\u0027, \u0027stat\u0027"},{"line_number":398,"context_line":"    \u0027stringold\u0027, \u0027sunaudio\u0027 \u0027sv\u0027, \u0027test.testall\u0027,"},{"line_number":399,"context_line":"    \u0027thread\u0027, \u0027timing\u0027, \u0027toaiff\u0027, \u0027user\u0027"},{"line_number":400,"context_line":"]"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAT3%2F%2F5go%3D","line":399,"in_reply_to":"AAAAT3%2F%2F5hg%3D","updated":"2013-12-27 15:08:09.000000000","message":"My opinion is - it\u0027s better to keep all these checks in a single rule. But\u0027 I\u0027m not insist.","commit_id":"1c7c53b3e18d3f556d140fb537ca157e1dca5a66"},{"author":{"_account_id":6722,"name":"ChangBo Guo(gcb)","email":"guochbo@cn.ibm.com","username":"guochbo"},"change_message_id":"960abea89a5fcf0aa10e97a4cdbeec568806c6a2","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    \u0027new\u0027, \u0027popen2\u0027, \u0027posixfile\u0027, \u0027pure\u0027, \u0027rexec\u0027"},{"line_number":397,"context_line":"    \u0027rfc822\u0027, \u0027sha\u0027, \u0027sgmllib\u0027, \u0027sre\u0027, \u0027stat\u0027"},{"line_number":398,"context_line":"    \u0027stringold\u0027, \u0027sunaudio\u0027 \u0027sv\u0027, \u0027test.testall\u0027,"},{"line_number":399,"context_line":"    \u0027thread\u0027, \u0027timing\u0027, \u0027toaiff\u0027, \u0027user\u0027"},{"line_number":400,"context_line":"]"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAT3%2F%2F5hg%3D","line":399,"in_reply_to":"AAAAT3%2F%2F5lk%3D","updated":"2013-12-27 15:02:50.000000000","message":"Yes, we need a new rule for renamed libraries, better in another patch. then we can add suggestions  with six . That\u0027s also the suggestion from other reviewer.\n\nBut for removed libraries , we can\u0027t add more suggestion, just like line 421.","commit_id":"1c7c53b3e18d3f556d140fb537ca157e1dca5a66"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"f23b218df072c318cc6f7e53cdd999b3c760dd1f","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    \u0027new\u0027, \u0027popen2\u0027, \u0027posixfile\u0027, \u0027pure\u0027, \u0027rexec\u0027"},{"line_number":397,"context_line":"    \u0027rfc822\u0027, \u0027sha\u0027, \u0027sgmllib\u0027, \u0027sre\u0027, \u0027stat\u0027"},{"line_number":398,"context_line":"    \u0027stringold\u0027, \u0027sunaudio\u0027 \u0027sv\u0027, \u0027test.testall\u0027,"},{"line_number":399,"context_line":"    \u0027thread\u0027, \u0027timing\u0027, \u0027toaiff\u0027, \u0027user\u0027"},{"line_number":400,"context_line":"]"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAT3%2F%2F5lk%3D","line":399,"in_reply_to":"AAAAT3%2F%2F5oE%3D","updated":"2013-12-27 14:44:53.000000000","message":"I\u0027m not sure, but I guess, that it\u0027s would be better do not use renamed libraries also. What do you think about it?","commit_id":"1c7c53b3e18d3f556d140fb537ca157e1dca5a66"}]}
