)]}'
{"hacking/tests/test_doctest.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"43781764170368bbb55910a5e9a28be8765c4a24","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            self.assertNotEqual(\u0027\u0027, out)"},{"line_number":57,"context_line":"            self.assertEqual(self.code, out.split(\u0027\\t\u0027)[0].rstrip(\u0027:\u0027), out)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        os.remove(f.name)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def _get_lines(check):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_d8a568b5","line":59,"updated":"2019-12-11 18:07:20.000000000","message":"Should this be in a try...finally block in case something raises an exception? I think if an assert failed above it would cause this to be skipped.","commit_id":"172d34813dfbcbbba68552f7f607483c8f5eca5f"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"984cd7363abf57f3ccf3ea070dd17357cd81ecf6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            self.assertNotEqual(\u0027\u0027, out)"},{"line_number":57,"context_line":"            self.assertEqual(self.code, out.split(\u0027\\t\u0027)[0].rstrip(\u0027:\u0027), out)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        os.remove(f.name)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def _get_lines(check):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_552372be","line":59,"in_reply_to":"3fa7e38b_18b780da","updated":"2019-12-12 15:09:41.000000000","message":"Fair enough. I guess they\u0027re just temp files so they\u0027ll get cleaned up eventually anyway.","commit_id":"172d34813dfbcbbba68552f7f607483c8f5eca5f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"972d3431b6556cb6f19551d91a7179d70df6a8c1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            self.assertNotEqual(\u0027\u0027, out)"},{"line_number":57,"context_line":"            self.assertEqual(self.code, out.split(\u0027\\t\u0027)[0].rstrip(\u0027:\u0027), out)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        os.remove(f.name)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def _get_lines(check):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_18b780da","line":59,"in_reply_to":"3fa7e38b_d8a568b5","updated":"2019-12-11 18:08:38.000000000","message":"I purposefully kept this here so we\u0027d have something to examine after the test had run. Previously, I had if before the if-else","commit_id":"172d34813dfbcbbba68552f7f607483c8f5eca5f"}],"requirements.txt":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"43781764170368bbb55910a5e9a28be8765c4a24","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# The order of packages is significant, because pip processes them in the order"},{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":"pbr # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"3fa7e38b_188ea026","side":"PARENT","line":1,"updated":"2019-12-11 18:07:20.000000000","message":"Nit: I generally prefer to keep these headers because people like to alphabetize files otherwise.","commit_id":"b6bca99c62570a534cb6b7720ab81fd354f2f38e"}]}