)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"079a7b8ce26e70d4d551bd6611e9827c554c455a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Julien Danjou \u003cjulien@danjou.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-28 14:30:38 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow to have noqa on H202"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If4bc560edf2cbc982b45b32be20aebced3e4a586"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2BOCc%3D","line":7,"updated":"2014-01-28 23:32:45.000000000","message":"this is way to short of a commit message.\n\nWhy do you want to allow noqa for H202?","commit_id":"7a9f59b6afe6fcdde4849ae208f74565f2cf6413"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"63b91f863eb62a1d9609466f2848ce724d9c96e2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Julien Danjou \u003cjulien@danjou.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-28 14:30:38 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow to have noqa on H202"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If4bc560edf2cbc982b45b32be20aebced3e4a586"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2BJ6o%3D","line":7,"in_reply_to":"AAAAUH%2F%2BKMU%3D","updated":"2014-01-29 16:30:58.000000000","message":"Done","commit_id":"7a9f59b6afe6fcdde4849ae208f74565f2cf6413"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"dda3137afeee25bde6138de9d4a3b431a1da623d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Julien Danjou \u003cjulien@danjou.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-28 14:30:38 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow to have noqa on H202"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If4bc560edf2cbc982b45b32be20aebced3e4a586"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2BKMU%3D","line":7,"in_reply_to":"AAAAUH%2F%2BL1g%3D","updated":"2014-01-29 15:55:14.000000000","message":"Perhaps just explain your example here.\n\n  self.assertRaises(Exception)\n\nis not allowed under H202 because just asserting an Exception is raised is usually to general of a test and can easily hide real errors (as it will pass if any exception is raised not just the one you are looking for).","commit_id":"7a9f59b6afe6fcdde4849ae208f74565f2cf6413"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"93902e909d423f4a96e84e1275ff74446aeca52c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Julien Danjou \u003cjulien@danjou.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-28 14:30:38 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow to have noqa on H202"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If4bc560edf2cbc982b45b32be20aebced3e4a586"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2BL1g%3D","line":7,"in_reply_to":"AAAAUH%2F%2BOCc%3D","updated":"2014-01-29 10:19:49.000000000","message":"I don\u0027t know what to answer to this question. \"Because I need it\"? But if I wouldn\u0027t need it I wouldn\u0027t have written that patch.","commit_id":"7a9f59b6afe6fcdde4849ae208f74565f2cf6413"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"09235002eb1bd01553efd12098b2da4700d6f851","unresolved":false,"context_lines":[{"line_number":9,"context_line":"`self.assertRaises(Exception)` is not allowed per H202. But in certain"},{"line_number":10,"context_line":"contexts, there can be a lot of different exception that can be raised"},{"line_number":11,"context_line":"without that being a problem (KeyError, ValueError…) nor a bug, so"},{"line_number":12,"context_line":"having the ability to noqa it is useful."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If4bc560edf2cbc982b45b32be20aebced3e4a586"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2BJ0A%3D","line":12,"updated":"2014-01-29 16:46:54.000000000","message":"I\u0027m still not sure I follow, do you have an example you can point me to.","commit_id":"abb136f74c38b65449ea11d59e1b9a519842d499"}],"hacking/core.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"4fc9a41ef1e0abe9a45d5f95c0204bfef528abb7","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    if pep8.noqa(physical_line):"},{"line_number":264,"context_line":"        return"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    if re.match(r\"self\\.assertRaises\\(Exception[,\\)]\", logical_line):"},{"line_number":267,"context_line":"        yield 1, \"H202: assertRaises Exception too broad\""},{"line_number":268,"context_line":""},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BHoc%3D","line":266,"updated":"2014-01-29 23:57:36.000000000","message":"exception can be a tuple, but we don\u0027t check for that, so it looks like there is a bug where you can do:\n\n assertRaises((Exception))\n\nAlthough that is sorta ugly.","commit_id":"abb136f74c38b65449ea11d59e1b9a519842d499"}]}