)]}'
{"id":"openstack%2Fhacking~698473","triplet_id":"openstack%2Fhacking~master~Iaa7528030c2feba493a08e713870ac3cd742802e","project":"openstack/hacking","branch":"master","topic":"bump-flake8","hashtags":[],"change_id":"Iaa7528030c2feba493a08e713870ac3cd742802e","subject":"WIP: Migrate tests","status":"ABANDONED","created":"2019-12-11 13:10:13.000000000","updated":"2019-12-11 16:49:50.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3cf56f6c4c98a15084ff82f0726ba57e9043ebce","_number":698473,"virtual_id_number":698473,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2019-12-11 14:46:22.000000000","_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2019-12-11 13:21:29.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-12-11 13:21:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-12-11 14:46:22.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"}],"messages":[{"id":"ffb69fbb238825ab556fa4c30e38a41d40d43f98","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-12-11 13:10:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6f7fd8c9e38312d8e36e9c416cbc0c51c6d981de","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-11 13:21:29.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c493ae1266ea4b0a827d961c895d1e4c : SUCCESS in 3m 18s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/963d4dc5996843d091dce02a3e8b9082 : FAILURE in 2m 54s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ecd98fa5e6f14d519b3813e8a431163a : FAILURE in 3m 32s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1ea675546ca740eeba8ebac506ead3ba : FAILURE in 2m 24s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a5e9feb9e6814058b85584a96bb062f1 : FAILURE in 3m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e9bdc161d7fa425fa643ef01beca81fc : FAILURE in 3m 00s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/55b6b977897948ffbdeb05e948d4a093 : FAILURE in 3m 13s\n- openstack-tox-pypy https://zuul.opendev.org/t/openstack/build/dc4f7025a4e842e4b7f0e8d32fdefa81 : FAILURE in 2m 50s (non-voting)\n- hacking-integration-nova https://zuul.opendev.org/t/openstack/build/098de56ba01a4a0f824db783819eadcb : FAILURE in 4m 52s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"06d4204c8b5a36a159b636b1845c397ea46421e3","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-12-11 14:31:09.000000000","message":"Patch Set 1:\n\nSome feedbacks from my side.\n\nRelated to the flake8 issue\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nI can run tests without issue for https://review.opendev.org/#/c/651566/\n\nThen tests start to fails during https://review.opendev.org/#/c/651565/\n\nAnd continue to fail for this review.\n\nBy running `tox -e py37` I get the following error:\n```\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nFailures during discovery\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n--- import errors ---\nFailed to import test module: hacking.tests.test_doctest\nTraceback (most recent call last):\n  File \"/usr/lib64/python3.7/unittest/loader.py\", line 436, in _find_test_path\n    module \u003d self._get_module_from_name(name)\n  File \"/usr/lib64/python3.7/unittest/loader.py\", line 377, in _get_module_from_name\n    __import__(name)\n  File \"/home/hberaud/dev/openstack/hacking/hacking/tests/test_doctest.py\", line 19, in \u003cmodule\u003e\n    from flake8.api import legacy as engine\nModuleNotFoundError: No module named \u0027flake8.api\u0027\n```\n\nzuul side\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nA lot of failures exist appear on\n```\n019-12-11 13:21:06.834929 | ubuntu-bionic |     b\u0027Traceback (most recent call last):\u0027\n2019-12-11 13:21:06.835048 | ubuntu-bionic |     b\u0027  File \"/home/zuul/src/opendev.org/openstack/hacking/hacking/tests/test_doctest.py\", line 48, in test_pycodestyle\u0027\n2019-12-11 13:21:06.835122 | ubuntu-bionic |     b\u0027    report \u003d pycodestyle.BaseReport(self.options)\u0027\n2019-12-11 13:21:06.835245 | ubuntu-bionic |     b\u0027  File \"/home/zuul/src/opendev.org/openstack/hacking/.tox/py37/lib/python3.7/site-packages/pycodestyle.py\", line 2027, in __init__\u0027\n2019-12-11 13:21:06.835311 | ubuntu-bionic |     b\u0027    self._benchmark_keys \u003d options.benchmark_keys\u0027\n2019-12-11 13:21:06.835380 | ubuntu-bionic |     b\"AttributeError: \u0027Values\u0027 object has no attribute \u0027benchmark_keys\u0027\"\n2019-12-11 13:21:06.835396 | ubuntu-bionic |     b\u0027\u0027\n2019-12-11 13:21:06.835580 | ubuntu-bionic | {0} hacking.tests.test_doctest.HackingTestCase.test_pycodestyle(H106-no_vim_headers-line-3) [0.000246s] ... FAILED\n```\n\nc.f https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_1df/651565/2/check/openstack-tox-py37/1df8aeb/job-output.txt\n\nit can be worth to check recent changes and issues on https://github.com/PyCQA/pycodestyle/\n\nSide things\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nI think we need to blacklist sphinx 2.1.0 in https://review.opendev.org/#/c/651566/2/doc/requirements.txt\n\n```\nsphinx!\u003d1.6.6,!\u003d1.6.7,!\u003d2.1.0,\u003e\u003d1.6.2;python_version\u003e\u003d\u00273.4\u0027  # BSD\n```\n\nc.f \u003d\u003e https://review.opendev.org/#/c/687800/ and https://github.com/sphinx-doc/sphinx/issues/6440","accounts_in_message":[],"_revision_number":1},{"id":"d9267f54e8a0ffcccd6235f7b1ee4db843e3561f","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-12-11 14:46:22.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e185d8bce69a47d07e5cd876915347aa8eb9b00c","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-12-11 16:49:50.000000000","message":"Abandoned\n\nFixed this in [1] at last. Only took a few months :/\n\n[1] https://review.opendev.org/#/c/651565/3","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5913298ae06bab7655046ce4ce27bc5553fc86ac","revisions":{"5913298ae06bab7655046ce4ce27bc5553fc86ac":{"kind":"REWORK","_number":1,"created":"2019-12-11 13:10:13.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/73/698473/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/hacking","ref":"refs/changes/73/698473/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/hacking refs/changes/73/698473/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/hacking refs/changes/73/698473/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/hacking refs/changes/73/698473/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/hacking refs/changes/73/698473/1"}}},"commit":{"parents":[{"commit":"df1bd977e05b44caee9f84fa198ab066d08174d5","subject":"Bump flake8 version to something modern","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/df1bd977e05b44caee9f84fa198ab066d08174d5"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-12-11 11:01:08.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-12-11 13:09:48.000000000","tz":0},"subject":"WIP: Migrate tests","message":"WIP: Migrate tests\n\nThis isn\u0027t working and I can\u0027t for the life of me figure out why. It\nworks if I run things manually, like so:\n\n  env -i .tox/py27/bin/python2.7 -mflake8 --isolated --select\u003d$CODE --ignore\u003dF $FILE\n\nwhere $CODE and $FILE are in the output printed by the test.\n\nflake8 also seems to be doing something funny with stdout and I\u0027m not\nable to capture things properly. WTF?\n\nChange-Id: Iaa7528030c2feba493a08e713870ac3cd742802e\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/5913298ae06bab7655046ce4ce27bc5553fc86ac"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/5913298ae06bab7655046ce4ce27bc5553fc86ac"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}