)]}'
{"id":"openstack%2Fhacking~757912","triplet_id":"openstack%2Fhacking~master~Ie4e3f95d24dc954deb7336835a6f9b7bf54c9674","project":"openstack/hacking","branch":"master","topic":"hacking","hashtags":[],"change_id":"Ie4e3f95d24dc954deb7336835a6f9b7bf54c9674","subject":"Handle formatting of args in string interpolation check","status":"MERGED","created":"2020-10-13 17:05:52.000000000","updated":"2020-11-09 19:13:45.000000000","submitted":"2020-11-09 19:11:45.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"757912-1604949105362-6545178d","meta_rev_id":"e7ade91c2d033646d46e97298810ee332f321453","_number":757912,"virtual_id_number":757912,"owner":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-11-09 19:11:45.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"all":[{"value":2,"date":"2020-11-09 18:59:13.000000000","_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},{"value":2,"date":"2020-11-09 18:49:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"all":[{"value":1,"date":"2020-11-09 18:59:13.000000000","_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-09 18:49:07.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"},{"updated":"2020-11-09 18:59:13.000000000","updated_by":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"reviewer":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"state":"REVIEWER"},{"updated":"2020-11-09 19:11:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"370a60146402b37f1af970620b06177339c26f41","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-10-13 17:05:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"935a7c487bdb145397330d45a20d72d1abfc2221","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-13 17:28:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c5e931ea8ad8458084fd4ba79695b5b1 : SUCCESS in 4m 33s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f0ccd25d628640d5adee279845c9d811 : SUCCESS in 3m 00s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/14b299ee097e420b8f284b22f953f089 : SUCCESS in 3m 21s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/ceabf1578dc54ac1a130c1bb4e74d608 : SUCCESS in 3m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/419ce9f697244d0497e4f69a86bb07e3 : SUCCESS in 3m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4968dbe050cf494b9932a06f818c2501 : SUCCESS in 3m 32s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/48050297a4814d5f8a1faf536371526b : SUCCESS in 5m 04s\n- hacking-integration-nova https://zuul.opendev.org/t/openstack/build/b6679effa4684fcdaa075c9e5baee7d8 : FAILURE in 5m 15s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8cae6562d60fe4871ca15607dcc07a7a7b98a142","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-11-09 18:49:07.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"8e5dbc514c7714b00baeca85d05adc85ced0c5a4","author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"date":"2020-11-09 18:59:13.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nthis looks good to exclude the case where string formatting is being used in value args.","accounts_in_message":[],"_revision_number":1},{"id":"258f43778be21db01c2fe9f6d53c6dfb523235c7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-09 18:59:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"7a574e4cab16f64ee7c63c654da4e935eb446b28","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-09 19:11:45.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"943789f1500507b6761a803922d08426e23d8a03","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-09 19:11:45.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5e8d4778585a4b4b9146d43ae14aa511 : SUCCESS in 7m 54s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5e1041faa8a842f294f22aacc4cbed70 : SUCCESS in 4m 21s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/4382fc8df39a4232a3bd3eb504bf5670 : SUCCESS in 3m 47s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2b13003d41514ec0ad069b1a3d604445 : SUCCESS in 4m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0ee3f52aa4c1430a9774eb1e8afb44fb : SUCCESS in 4m 27s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/952feb699ce14af8859a7c79a506cb7b : SUCCESS in 4m 27s","accounts_in_message":[],"_revision_number":1},{"id":"cbdcfad3df030b0b89a57e3c0e94618b1b230dc9","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-09 19:13:45.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7dd92591198d4b398a231fe3ef9e781b : SUCCESS in 1m 18s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"31e9c8751e10dd4e267c8a37728bb9448d1fe4b5","revisions":{"31e9c8751e10dd4e267c8a37728bb9448d1fe4b5":{"kind":"REWORK","_number":1,"created":"2020-10-13 17:05:52.000000000","uploader":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"ref":"refs/changes/12/757912/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/hacking","ref":"refs/changes/12/757912/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/hacking refs/changes/12/757912/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/hacking refs/changes/12/757912/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/hacking refs/changes/12/757912/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/hacking refs/changes/12/757912/1"}}},"commit":{"parents":[{"commit":"711ca6eb6032700380df7cd42455a93dcbe62b0d","subject":"Merge \"Fix H903 hacking_no_cr\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/711ca6eb6032700380df7cd42455a93dcbe62b0d"}]}],"author":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2020-10-13 17:00:16.000000000","tz":-300},"committer":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2020-10-13 17:00:16.000000000","tz":-300},"subject":"Handle formatting of args in string interpolation check","message":"Handle formatting of args in string interpolation check\n\nWe have added a check to make sure format strings and any args are being\npassed in to be formatted as needed by the logger. The check did not\ntake into account string formatting that may be needed in preparing the\nvalue args. There are some cases where this is needed, and we should not\nbe raising an error if the string formatting is being done there.\n\nThis adds a new test string and updates the hacking check to account for\nthese cases so the new hacking release does not raise unnecessary\nerrors.\n\nChange-Id: Ie4e3f95d24dc954deb7336835a6f9b7bf54c9674\nSigned-off-by: Sean McGinnis \u003csean.mcginnis@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/31e9c8751e10dd4e267c8a37728bb9448d1fe4b5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/31e9c8751e10dd4e267c8a37728bb9448d1fe4b5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}