)]}'
{"id":"openstack%2Fhacking~766718","triplet_id":"openstack%2Fhacking~master~Ie51ab50dc1215d9a503067595532302de4338fbd","project":"openstack/hacking","branch":"master","topic":"bug/1907807","hashtags":[],"change_id":"Ie51ab50dc1215d9a503067595532302de4338fbd","subject":"Revert \"Catch .format() use in log string interpoliation check\"","status":"ABANDONED","created":"2020-12-11 11:30:59.000000000","updated":"2022-02-11 17:28:42.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8fcb64d6904e10e419dfe7ebc766ba6e259278d3","_number":766718,"virtual_id_number":766718,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-12-11 11:41:54.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-12-11 11:41:54.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-01 09:48:27.000000000","updated_by":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"reviewer":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"state":"REVIEWER"},{"updated":"2021-07-22 09:28:18.000000000","updated_by":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"reviewer":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"state":"REMOVED"}],"messages":[{"id":"e4116ac5f172c5a291bcb9b92081674bbf0bd143","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-12-11 11:30:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fbb0f22442f427435d5d10c983ea133dea5529d4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-11 11:41:54.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0a86a80b6f9b4fb9b2a84f980932af31 : SUCCESS in 4m 33s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e395f53b5c28489592aec585b93e3687 : SUCCESS in 3m 06s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0fe1833876944cbeb0cce0c7d4b95d30 : FAILURE in 2m 38s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/a840db1cb0f349e49acc1824d18361a4 : SUCCESS in 3m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d2acb19ab1c247a489c263391f8fbe65 : SUCCESS in 2m 46s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7a547e3289794f28b76ec560ce45b4b2 : SUCCESS in 3m 03s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/fc1c09da757440c2b7104f057fa7f2ad : SUCCESS in 3m 16s\n- hacking-integration-nova https://zuul.opendev.org/t/openstack/build/61de31dc29904c41ab417054c388cba1 : FAILURE in 5m 04s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"93204bb2b46012b734cddc02228545d62917e11f","author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"date":"2021-04-01 09:48:27.000000000","message":"Patch Set 1: Code-Review+1\n\nIf i remember well pylint does a good job in that area already, not sure why we need to have our own custom checks.","accounts_in_message":[],"_revision_number":1},{"id":"77d16d399c4c6da2b24d91a2aa3e4d8419722173","author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"date":"2021-04-20 08:08:50.000000000","message":"Patch Set 1: Code-Review-1\n\nInstead of a plain revert, how about including a fail-safe test that would prevent us from reintroducing a bug like this in the future? Can you include an example which was a false-positive so we prevent this from happening?","accounts_in_message":[],"_revision_number":1},{"id":"989e33f2c8e096bb0dded55b33bfbcdf30201e3a","tag":"autogenerated:gerrit:deleteReviewer","author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"date":"2021-07-22 09:28:18.000000000","message":"Removed reviewer Sorin Sbârnea with the following votes:\n\n* Code-Review-1 by Sorin Sbârnea \u003cssbarnea@redhat.com\u003e\n","accounts_in_message":[],"_revision_number":1},{"id":"8fcb64d6904e10e419dfe7ebc766ba6e259278d3","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-02-11 17:28:42.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f4287ebe1c01d8bbe57181107768b17b7b497964","revisions":{"f4287ebe1c01d8bbe57181107768b17b7b497964":{"kind":"REWORK","_number":1,"created":"2020-12-11 11:30:59.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/18/766718/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/hacking","ref":"refs/changes/18/766718/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/hacking refs/changes/18/766718/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/hacking refs/changes/18/766718/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/hacking refs/changes/18/766718/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/hacking refs/changes/18/766718/1"}}},"commit":{"parents":[{"commit":"4069b0c4f50177dbcaa188aff0de67b4d316a873","subject":"Add separate releasenotes page per version","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/4069b0c4f50177dbcaa188aff0de67b4d316a873"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2020-12-11 11:29:53.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2020-12-11 11:30:41.000000000","tz":0},"subject":"Revert \"Catch .format() use in log string interpoliation check\"","message":"Revert \"Catch .format() use in log string interpoliation check\"\n\nThis reverts commit f82f995d022f5e1786460900266dc0e54786eacd. This check\nis overly broad and catches many things other than \u0027str.format()\u0027, as\nnoted in the bug.\n\nChange-Id: Ie51ab50dc1215d9a503067595532302de4338fbd\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\nCloses-Bug: #190787\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/f4287ebe1c01d8bbe57181107768b17b7b497964"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/hacking/commit/f4287ebe1c01d8bbe57181107768b17b7b497964"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}