)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"ad5d6e4080ded040229c3659bc18aa7698d4edce","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Cyril Roelandt \u003ccyril.roelandt@enovance.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-03-03 15:04:58 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Port to Python 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some tests raise an E901 (SyntaxError or IndentationError) unrelated to what\u0027s"},{"line_number":10,"context_line":"actually being tested. Also, we cannot make sure that \"0755\" will raise an H232"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAVn%2F%2F3tY%3D","line":7,"updated":"2014-03-03 17:58:05.000000000","message":"Nit: I don\u0027t think the term port make a lot of sense here, how about: \u0027make python 3 compatable\u0027","commit_id":"795c2eed1bed616c81a9b0c225d2a1e07beb8484"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"a2c3b2b5181b116081a1a514a6e50c0473a2d416","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Cyril Roelandt \u003ccyril.roelandt@enovance.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-03-03 15:04:58 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Port to Python 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some tests raise an E901 (SyntaxError or IndentationError) unrelated to what\u0027s"},{"line_number":10,"context_line":"actually being tested. Also, we cannot make sure that \"0755\" will raise an H232"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAVn%2F%2F3eA%3D","line":7,"in_reply_to":"AAAAVn%2F%2F3tY%3D","updated":"2014-03-03 18:20:15.000000000","message":"OK.","commit_id":"795c2eed1bed616c81a9b0c225d2a1e07beb8484"}],"hacking/core.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"5da05c700ad319f81c1dd423fca853fe97d90bac","unresolved":false,"context_lines":[{"line_number":49,"context_line":"def flake8ext(f):"},{"line_number":50,"context_line":"    f.name \u003d __name__"},{"line_number":51,"context_line":"    f.version \u003d \u00270.0.1\u0027"},{"line_number":52,"context_line":"    f.skip_on_py3 \u003d False"},{"line_number":53,"context_line":"    return f"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FwI0%3D","line":52,"updated":"2014-03-04 09:43:44.000000000","message":"IMO thre is no need to set the attribute to False, use getattr instead.","commit_id":"8ba354fad1f7ab061766e4227a58d27b4a0086d6"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"9292dea032936a3b07658ababe2c78e9bddca24a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"def flake8ext(f):"},{"line_number":50,"context_line":"    f.name \u003d __name__"},{"line_number":51,"context_line":"    f.version \u003d \u00270.0.1\u0027"},{"line_number":52,"context_line":"    f.skip_on_py3 \u003d False"},{"line_number":53,"context_line":"    return f"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FAJA%3D","line":52,"in_reply_to":"AAAAVn%2F%2FwI0%3D","updated":"2014-03-10 19:11:00.000000000","message":"I like making this explicit","commit_id":"8ba354fad1f7ab061766e4227a58d27b4a0086d6"}],"hacking/tests/test_doctest.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"557df03fa061f5b04ed404bf732e8f44bb240a9b","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if not name.startswith(\"hacking_\"):"},{"line_number":78,"context_line":"            continue"},{"line_number":79,"context_line":"        for (lineno, (raw, (code, source))) in enumerate(_get_lines(check)):"},{"line_number":80,"context_line":"            if \u0027SKIP_PY3\u0027 in source:"},{"line_number":81,"context_line":"                if six.PY3:"},{"line_number":82,"context_line":"                    continue"},{"line_number":83,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2F508%3D","line":80,"updated":"2014-03-03 14:37:52.000000000","message":"What are the chances that SKIP_PY3 would appear somewhere in a legitimate line of code? Should we look for it only in the comment portion of the line?","commit_id":"795c2eed1bed616c81a9b0c225d2a1e07beb8484"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"47a348119959644a54fa524717f06ed9f02a6f9b","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if not name.startswith(\"hacking_\"):"},{"line_number":78,"context_line":"            continue"},{"line_number":79,"context_line":"        for (lineno, (raw, (code, source))) in enumerate(_get_lines(check)):"},{"line_number":80,"context_line":"            if \u0027SKIP_PY3\u0027 in source:"},{"line_number":81,"context_line":"                if six.PY3:"},{"line_number":82,"context_line":"                    continue"},{"line_number":83,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2F5xU%3D","line":80,"in_reply_to":"AAAAVn%2F%2F508%3D","updated":"2014-03-03 14:43:09.000000000","message":"I was actually thinking of using \"SKIP_PY3\" as a \"reserved keyword\", kind of like  \"noqa\". IIUC, you\u0027d rather be willing to look for \"# SKIP_PY3\" ? I can do that :)","commit_id":"795c2eed1bed616c81a9b0c225d2a1e07beb8484"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"ad5d6e4080ded040229c3659bc18aa7698d4edce","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if not name.startswith(\"hacking_\"):"},{"line_number":78,"context_line":"            continue"},{"line_number":79,"context_line":"        for (lineno, (raw, (code, source))) in enumerate(_get_lines(check)):"},{"line_number":80,"context_line":"            if \u0027SKIP_PY3\u0027 in source:"},{"line_number":81,"context_line":"                if six.PY3:"},{"line_number":82,"context_line":"                    continue"},{"line_number":83,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2F3ss%3D","line":80,"in_reply_to":"AAAAVn%2F%2F5xU%3D","updated":"2014-03-03 17:58:05.000000000","message":"I don\u0027t like the idea of adding a skip just for python 3. Furthermore \u0027noqa\u0027 isn\u0027t a hacking concept its a flake8 concept.","commit_id":"795c2eed1bed616c81a9b0c225d2a1e07beb8484"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"5da05c700ad319f81c1dd423fca853fe97d90bac","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    for name, check in hacking.core.__dict__.items():"},{"line_number":77,"context_line":"        if not name.startswith(\"hacking_\"):"},{"line_number":78,"context_line":"            continue"},{"line_number":79,"context_line":"        if six.PY3 and check.skip_on_py3:"},{"line_number":80,"context_line":"            continue"},{"line_number":81,"context_line":"        for (lineno, (raw, (code, source))) in enumerate(_get_lines(check)):"},{"line_number":82,"context_line":"            lines \u003d [part.replace(r\u0027\\t\u0027, \u0027\\t\u0027) + \u0027\\n\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FwIo%3D","line":79,"updated":"2014-03-04 09:43:44.000000000","message":"Replace check.skip_on_py3 with getattr(check, \u0027skip_on_py3\u0027, False)","commit_id":"8ba354fad1f7ab061766e4227a58d27b4a0086d6"}]}
