)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9453,"name":"James Polley","email":"jp@jamezpolley.com","username":"tchaypo"},"change_message_id":"7b3c8d24714518b190e3d3b5a3762d29f7a2c38b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1ae5cdf2_59f43d5a","updated":"2014-06-06 06:15:08.000000000","message":"In keeping with https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages, I\u0027d like this commit message to explain why this change is being made (ie, explain the original problem that\u0027s being solved to the reviewer). \n\nThis message describes what is happening, but I can see that from the code; it doesn\u0027t explain why this is needed.","commit_id":"c6ad33256470948adbbb15ddd6f46c7f472977a0"},{"author":{"_account_id":9453,"name":"James Polley","email":"jp@jamezpolley.com","username":"tchaypo"},"change_message_id":"7b3c8d24714518b190e3d3b5a3762d29f7a2c38b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Christian Berendt \u003cberendt@b1-systems.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-06 08:00:44 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add H804: enforce title case in commit messages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the hacking check H804 to enforce the usage of the"},{"line_number":10,"context_line":"title case for the first word in the title of a commit message."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_197b95be","line":7,"updated":"2014-06-06 06:15:08.000000000","message":"I don\u0027t think this describes what is being done here. If this line was in title case as I understand it, it would read:\n\nAdd H804: Enforce Title Case in Commit Messages\n\nI think a better description would be \"Enforce capatilisation of the first character of commit message title\".\n\nEnforcing title case would mean that a commit message such as \"OVERCLOUD_IP must be set before use\" would not be permitted; but the check you\u0027ve implemented would actually allow it.","commit_id":"c6ad33256470948adbbb15ddd6f46c7f472977a0"}],"hacking/checks/git.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"ad94f92cb6a6827a2e29eaa3574e456f3bd39603","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def run_once(self):"},{"line_number":128,"context_line":"        title \u003d self._get_commit_title()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        if title and not title.strip().isupper():"},{"line_number":131,"context_line":"            return ("},{"line_number":132,"context_line":"                1, 0,"},{"line_number":133,"context_line":"                \"H804: git commit title (\u0027%s\u0027) should start capatilized\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_3b0213b4","line":130,"updated":"2014-06-05 18:45:58.000000000","message":"This appears to apply isupper() to the whole title string, not just the first letter of the first word.","commit_id":"ae1a76913201e2405e150fdb8073c49978d5f051"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"da27eeea08733ade508acfd67ca7e471cddf29dd","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        if title and not title.strip().isupper():"},{"line_number":131,"context_line":"            return ("},{"line_number":132,"context_line":"                1, 0,"},{"line_number":133,"context_line":"                \"H804: git commit title (\u0027%s\u0027) should start capatilized\""},{"line_number":134,"context_line":"                % title.strip(),"},{"line_number":135,"context_line":"                self.name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_c87a4c87","line":133,"updated":"2014-06-05 16:36:19.000000000","message":"Typo: capitalized","commit_id":"ae1a76913201e2405e150fdb8073c49978d5f051"}]}