)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"0493cb85045c0c2cdcd80ae54c1e9e86f0b24e94","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add exit_codes option to docker-cmd hook"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some command we need to run with \u0027exec\u0027 or \u0027run\u0027 have custom"},{"line_number":10,"context_line":"exit codes that are valid if the command completes sucessfully."},{"line_number":11,"context_line":"This patch adds an \u0027exit_codes\u0027 option which takes an array"},{"line_number":12,"context_line":"of integers that are meant to represent the valid exit codes"},{"line_number":13,"context_line":"for this hook. If for example 0 or 1 is meant to be considered"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3c09a3_8c064a84","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":62},"updated":"2017-01-17 09:42:34.000000000","message":"May be I\u0027m missing something. Is there an example for this? I had the impression that non-zero is always an error and it follows the chroot standard[1].\n\n[1] https://docs.docker.com/engine/reference/run/#/exit-status","commit_id":"408c3f8642c7cfdb50edb906dcd4a04194c77f38"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"91bad51143ea59ec4500322a4fb0a1ae09bea21d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add exit_codes option to docker-cmd hook"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some command we need to run with \u0027exec\u0027 or \u0027run\u0027 have custom"},{"line_number":10,"context_line":"exit codes that are valid if the command completes sucessfully."},{"line_number":11,"context_line":"This patch adds an \u0027exit_codes\u0027 option which takes an array"},{"line_number":12,"context_line":"of integers that are meant to represent the valid exit codes"},{"line_number":13,"context_line":"for this hook. If for example 0 or 1 is meant to be considered"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3c09a3_a213ffb6","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":62},"in_reply_to":"7a3c09a3_5fa87820","updated":"2017-01-17 14:47:36.000000000","message":"Ok, it\u0027s successful non zero exit codes from the contained commands. I would probably have named it differently. May be \u0027exit_success_codes\u0027.","commit_id":"408c3f8642c7cfdb50edb906dcd4a04194c77f38"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"6fba242ca2b5b9f2cd37a985465479749d1d2f21","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add exit_codes option to docker-cmd hook"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some command we need to run with \u0027exec\u0027 or \u0027run\u0027 have custom"},{"line_number":10,"context_line":"exit codes that are valid if the command completes sucessfully."},{"line_number":11,"context_line":"This patch adds an \u0027exit_codes\u0027 option which takes an array"},{"line_number":12,"context_line":"of integers that are meant to represent the valid exit codes"},{"line_number":13,"context_line":"for this hook. If for example 0 or 1 is meant to be considered"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3c09a3_5fa87820","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":62},"in_reply_to":"7a3c09a3_8c064a84","updated":"2017-01-17 14:29:52.000000000","message":"Rabi, it isn\u0027t the \"docker\" exit status that I\u0027m worried about here. That all seems to work correctly. It is the exit status of the commands that I\u0027m executing with this hook. Some of the openstack initialization commands: (like Nova\u0027s new cell setup commands) can return non-zero exit status\u0027s even if they run correctly within a container. Ditto for puppet which if you use --detailed-exit-codes will also return non-zero exit status\u0027s for some things that are actually successful.","commit_id":"408c3f8642c7cfdb50edb906dcd4a04194c77f38"}]}