)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"dc3364059bfd5012620130eb38dd6f03fab7ea82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f6649386_07630332","updated":"2026-10-15 06:46:02.000000000","message":"Hi Takashi,\n\nThanks for the review. I still think what I wrote is correct, and shouldn\u0027t be changed, which I explained as follow-up to your comments. Let me know your thoughts.","commit_id":"69ed053d8445ad9db0d5ed0795f26ea997b43e8e"}],"heat_tempest_plugin/tests/api/test_heat_api.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9cc3b613a9930720ef100edb32d8e7213d57522b","unresolved":true,"context_lines":[{"line_number":47,"context_line":"            # ($ENVIRON[\u0027OS_TOKEN\u0027]) at listing time: test runners that"},{"line_number":48,"context_line":"            # flatten test suites, such as stestr\u0027s dynamic scheduler,"},{"line_number":49,"context_line":"            # never run the per-yaml suite-level fixtures that normally"},{"line_number":50,"context_line":"            # authenticate and set it, causing a KeyError at runtime."},{"line_number":51,"context_line":"            os.environ[\u0027OS_TOKEN\u0027] \u003d manager.identity_client.auth_token"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Catch the authentication exceptions that can happen if one of the"}],"source_content_type":"text/x-python","patch_set":1,"id":"70826af9_2b0713a9","line":50,"range":{"start_line":50,"start_character":61,"end_line":50,"end_character":68},"updated":"2026-10-12 14:05:32.000000000","message":"(nit) You mean listing time, not runtime ?","commit_id":"69ed053d8445ad9db0d5ed0795f26ea997b43e8e"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"dc3364059bfd5012620130eb38dd6f03fab7ea82","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            # ($ENVIRON[\u0027OS_TOKEN\u0027]) at listing time: test runners that"},{"line_number":48,"context_line":"            # flatten test suites, such as stestr\u0027s dynamic scheduler,"},{"line_number":49,"context_line":"            # never run the per-yaml suite-level fixtures that normally"},{"line_number":50,"context_line":"            # authenticate and set it, causing a KeyError at runtime."},{"line_number":51,"context_line":"            os.environ[\u0027OS_TOKEN\u0027] \u003d manager.identity_client.auth_token"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Catch the authentication exceptions that can happen if one of the"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa77e61_32189529","line":50,"range":{"start_line":50,"start_character":61,"end_line":50,"end_character":68},"in_reply_to":"70826af9_2b0713a9","updated":"2026-10-15 06:46:02.000000000","message":"The KeyError actually happens at request time, not listing time — gabbi evaluates $ENVIRON[...] in HTTPTestCase._run_test() while building each request, and raises a KeyError if the variable is missing. The variable is set early only so it already exists in runners where the fixtures never ran.","commit_id":"69ed053d8445ad9db0d5ed0795f26ea997b43e8e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0ed3fd7388428d0f3dd8b57ba55d1206eef8baba","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            # ($ENVIRON[\u0027OS_TOKEN\u0027]) at listing time: test runners that"},{"line_number":48,"context_line":"            # flatten test suites, such as stestr\u0027s dynamic scheduler,"},{"line_number":49,"context_line":"            # never run the per-yaml suite-level fixtures that normally"},{"line_number":50,"context_line":"            # authenticate and set it, causing a KeyError at runtime."},{"line_number":51,"context_line":"            os.environ[\u0027OS_TOKEN\u0027] \u003d manager.identity_client.auth_token"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Catch the authentication exceptions that can happen if one of the"}],"source_content_type":"text/x-python","patch_set":1,"id":"d996faa4_06087010","line":50,"range":{"start_line":50,"start_character":61,"end_line":50,"end_character":68},"in_reply_to":"baa77e61_32189529","updated":"2026-10-15 08:43:46.000000000","message":"I though \"at runtime\" means \"when you run these test actually\" but I was wrong.","commit_id":"69ed053d8445ad9db0d5ed0795f26ea997b43e8e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2513fe41d0e9b20ec632887a21e7d4cfa9fc51ea","unresolved":true,"context_lines":[{"line_number":48,"context_line":"            # flatten test suites, such as stestr\u0027s dynamic scheduler,"},{"line_number":49,"context_line":"            # never run the per-yaml suite-level fixtures that normally"},{"line_number":50,"context_line":"            # authenticate and set it, causing a KeyError at runtime."},{"line_number":51,"context_line":"            os.environ[\u0027OS_TOKEN\u0027] \u003d manager.identity_client.auth_token"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Catch the authentication exceptions that can happen if one of the"},{"line_number":54,"context_line":"        # following conditions occur:"},{"line_number":55,"context_line":"        #   1. conf.auth_url IP/port is incorrect or keystone not available"}],"source_content_type":"text/x-python","patch_set":1,"id":"4aa61111_6c67f648","line":52,"range":{"start_line":51,"start_character":37,"end_line":52,"end_character":1},"updated":"2026-10-12 14:17:51.000000000","message":"I wonder if it\u0027s enough to set OS_TOKEN to an empty value, if it does not exist. I\u0027m a bit concerned about adding it always, which may cause unexpected effect to implicit logic to load these env vars.","commit_id":"69ed053d8445ad9db0d5ed0795f26ea997b43e8e"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"dc3364059bfd5012620130eb38dd6f03fab7ea82","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            # flatten test suites, such as stestr\u0027s dynamic scheduler,"},{"line_number":49,"context_line":"            # never run the per-yaml suite-level fixtures that normally"},{"line_number":50,"context_line":"            # authenticate and set it, causing a KeyError at runtime."},{"line_number":51,"context_line":"            os.environ[\u0027OS_TOKEN\u0027] \u003d manager.identity_client.auth_token"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Catch the authentication exceptions that can happen if one of the"},{"line_number":54,"context_line":"        # following conditions occur:"},{"line_number":55,"context_line":"        #   1. conf.auth_url IP/port is incorrect or keystone not available"}],"source_content_type":"text/x-python","patch_set":1,"id":"8230487e_b81f0ce4","line":52,"range":{"start_line":51,"start_character":37,"end_line":52,"end_character":1},"in_reply_to":"4aa61111_6c67f648","updated":"2026-10-15 06:46:02.000000000","message":"With stestr --dynamic, the suite-level AuthenticationFixture never runs, so an empty value would just turn the KeyError into a 401 for every request — the tests would still all fail. Setting the real token here is what makes them actually pass in that mode; it\u0027s exactly what AuthenticationFixture.start_fixture() does at runtime, just earlier.\n\nIn a normal run the fixture still overwrites OS_TOKEN with a fresh token at suite setup before any request is made, so the listing-time value is never used. Nothing else in this path reads OS_TOKEN from the environment (tempest clients authenticate from tempest.conf), and this module already sets PREFIX at listing time for the same reason.\n\nIf you\u0027d rather not clobber an operator-provided OS_TOKEN, I can switch to os.environ.setdefault(...) — though the fixture overwrite makes that moot in normal runs.","commit_id":"69ed053d8445ad9db0d5ed0795f26ea997b43e8e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0ed3fd7388428d0f3dd8b57ba55d1206eef8baba","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            # flatten test suites, such as stestr\u0027s dynamic scheduler,"},{"line_number":49,"context_line":"            # never run the per-yaml suite-level fixtures that normally"},{"line_number":50,"context_line":"            # authenticate and set it, causing a KeyError at runtime."},{"line_number":51,"context_line":"            os.environ[\u0027OS_TOKEN\u0027] \u003d manager.identity_client.auth_token"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Catch the authentication exceptions that can happen if one of the"},{"line_number":54,"context_line":"        # following conditions occur:"},{"line_number":55,"context_line":"        #   1. conf.auth_url IP/port is incorrect or keystone not available"}],"source_content_type":"text/x-python","patch_set":1,"id":"961a3b33_0f552993","line":52,"range":{"start_line":51,"start_character":37,"end_line":52,"end_character":1},"in_reply_to":"8230487e_b81f0ce4","updated":"2026-10-15 08:43:46.000000000","message":"ok if we need the token during listing too, then I\u0027m ok with keeping it now.","commit_id":"69ed053d8445ad9db0d5ed0795f26ea997b43e8e"}]}
