)]}'
{"translator/hot/tosca/etsi_nfv/tosca_nfv_vducp.py":[{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"4fa33a708b8f7458b5e1f7690482760bc74a8600","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \"\"\"Translate TOSCA node type tosca.nodes.nfv.VduCp.\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    toscatype \u003d \u0027tosca.nodes.nfv.VduCp\u0027"},{"line_number":34,"context_line":"    EXTERNAL_VL \u003d \u0027REPLACE_TO_EXTERNAL_VL\u0027"},{"line_number":35,"context_line":"    ALLOWED_VNIC_TYPES \u003d (\u0027normal\u0027, \u0027direct-physical\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __init__(self, nodetemplate, csar_dir\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_e2c22386","line":34,"range":{"start_line":34,"start_character":19,"end_line":34,"end_character":41},"updated":"2019-12-09 07:44:57.000000000","message":"I prefer \u0027#ADD_YOUR_NETWORK_HERE\u0027","commit_id":"57d6688fd0a5e54a17bd33a380a4938a447cb833"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"68a92b2c28b644a521366237e9a8368a57465a1c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \"\"\"Translate TOSCA node type tosca.nodes.nfv.VduCp.\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    toscatype \u003d \u0027tosca.nodes.nfv.VduCp\u0027"},{"line_number":34,"context_line":"    EXTERNAL_VL \u003d \u0027REPLACE_TO_EXTERNAL_VL\u0027"},{"line_number":35,"context_line":"    ALLOWED_VNIC_TYPES \u003d (\u0027normal\u0027, \u0027direct-physical\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __init__(self, nodetemplate, csar_dir\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_350dd3e6","line":34,"range":{"start_line":34,"start_character":19,"end_line":34,"end_character":41},"in_reply_to":"3fa7e38b_e2c22386","updated":"2019-12-09 10:38:30.000000000","message":"Done","commit_id":"57d6688fd0a5e54a17bd33a380a4938a447cb833"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"4fa33a708b8f7458b5e1f7690482760bc74a8600","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            if \u0027virtual_link\u0027 in req:"},{"line_number":52,"context_line":"                vl_val \u003d req.get(\u0027virtual_link\u0027)"},{"line_number":53,"context_line":"                if isinstance(vl_val, dict):"},{"line_number":54,"context_line":"                    if vl_val.get(\u0027node\u0027) is not None:"},{"line_number":55,"context_line":"                        self.virtual_link \u003d vl_val[\u0027node\u0027]"},{"line_number":56,"context_line":"                else:"},{"line_number":57,"context_line":"                    self.virtual_link \u003d vl_val"},{"line_number":58,"context_line":"            elif \u0027virtual_binding\u0027 in req:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_8239efa3","line":55,"range":{"start_line":54,"start_character":19,"end_line":55,"end_character":58},"updated":"2019-12-09 07:44:57.000000000","message":"IMO, the following code works enough here:\n\n  self.virtual_link \u003d vl_val.get(\u0027node\u0027)\n\nIf vl_val doesn\u0027t have \u0027node\u0027 attribute, this result in \u0027\u0027 into self.virtual_link but this isn\u0027t a problem.","commit_id":"57d6688fd0a5e54a17bd33a380a4938a447cb833"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"68a92b2c28b644a521366237e9a8368a57465a1c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            if \u0027virtual_link\u0027 in req:"},{"line_number":52,"context_line":"                vl_val \u003d req.get(\u0027virtual_link\u0027)"},{"line_number":53,"context_line":"                if isinstance(vl_val, dict):"},{"line_number":54,"context_line":"                    if vl_val.get(\u0027node\u0027) is not None:"},{"line_number":55,"context_line":"                        self.virtual_link \u003d vl_val[\u0027node\u0027]"},{"line_number":56,"context_line":"                else:"},{"line_number":57,"context_line":"                    self.virtual_link \u003d vl_val"},{"line_number":58,"context_line":"            elif \u0027virtual_binding\u0027 in req:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_d57a3f23","line":55,"range":{"start_line":54,"start_character":19,"end_line":55,"end_character":58},"in_reply_to":"3fa7e38b_8239efa3","updated":"2019-12-09 10:38:30.000000000","message":"Done","commit_id":"57d6688fd0a5e54a17bd33a380a4938a447cb833"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"4fa33a708b8f7458b5e1f7690482760bc74a8600","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            own_props[\u0027network\u0027] \u003d \u0027{ get_resource: %s }\u0027 % ("},{"line_number":86,"context_line":"                self.virtual_link"},{"line_number":87,"context_line":"            )"},{"line_number":88,"context_line":"        # If no virtual_binding is specified in VNFD, users"},{"line_number":89,"context_line":"        # have to input external VL given in instantiation VNF request."},{"line_number":90,"context_line":"        else:"},{"line_number":91,"context_line":"            own_props[\u0027network\u0027] \u003d \u0027%s\u0027 % ("},{"line_number":92,"context_line":"                self.EXTERNAL_VL"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_22c59b90","line":89,"range":{"start_line":88,"start_character":8,"end_line":89,"end_character":71},"updated":"2019-12-09 07:44:57.000000000","message":"This comment should be put in \"else\" statement.","commit_id":"57d6688fd0a5e54a17bd33a380a4938a447cb833"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"68a92b2c28b644a521366237e9a8368a57465a1c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            own_props[\u0027network\u0027] \u003d \u0027{ get_resource: %s }\u0027 % ("},{"line_number":86,"context_line":"                self.virtual_link"},{"line_number":87,"context_line":"            )"},{"line_number":88,"context_line":"        # If no virtual_binding is specified in VNFD, users"},{"line_number":89,"context_line":"        # have to input external VL given in instantiation VNF request."},{"line_number":90,"context_line":"        else:"},{"line_number":91,"context_line":"            own_props[\u0027network\u0027] \u003d \u0027%s\u0027 % ("},{"line_number":92,"context_line":"                self.EXTERNAL_VL"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_9514c7eb","line":89,"range":{"start_line":88,"start_character":8,"end_line":89,"end_character":71},"in_reply_to":"3fa7e38b_22c59b90","updated":"2019-12-09 10:38:30.000000000","message":"Done","commit_id":"57d6688fd0a5e54a17bd33a380a4938a447cb833"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"4fa33a708b8f7458b5e1f7690482760bc74a8600","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                self.EXTERNAL_VL"},{"line_number":93,"context_line":"            )"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        # Get \u0027order\u0027 from properties."},{"line_number":96,"context_line":"        for key, value in tosca_props.items():"},{"line_number":97,"context_line":"            if key \u003d\u003d \u0027order\u0027:"},{"line_number":98,"context_line":"                self.order \u003d value"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_02c09f7b","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":38},"updated":"2019-12-09 07:44:57.000000000","message":"Put this comment in \"if\" statement (Or I think we can remove it).","commit_id":"57d6688fd0a5e54a17bd33a380a4938a447cb833"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"68a92b2c28b644a521366237e9a8368a57465a1c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                self.EXTERNAL_VL"},{"line_number":93,"context_line":"            )"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        # Get \u0027order\u0027 from properties."},{"line_number":96,"context_line":"        for key, value in tosca_props.items():"},{"line_number":97,"context_line":"            if key \u003d\u003d \u0027order\u0027:"},{"line_number":98,"context_line":"                self.order \u003d value"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_75beebd4","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":38},"in_reply_to":"3fa7e38b_02c09f7b","updated":"2019-12-09 10:38:30.000000000","message":"OK, I removed it.","commit_id":"57d6688fd0a5e54a17bd33a380a4938a447cb833"}],"translator/hot/tosca/etsi_nfv/tosca_nfv_vnfvirtuallink.py":[{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"4fa33a708b8f7458b5e1f7690482760bc74a8600","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                nodetemplate,"},{"line_number":58,"context_line":"                csar_dir\u003dcsar_dir"},{"line_number":59,"context_line":"            )"},{"line_number":60,"context_line":"            log.warning((\u0027Unsupported layer_protocols:%s\u0027) % lp)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def handle_properties(self):"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_e2cc638b","line":60,"range":{"start_line":60,"start_character":26,"end_line":60,"end_character":56},"updated":"2019-12-09 07:44:57.000000000","message":"Would you include the node name(self.name) to this message?","commit_id":"57d6688fd0a5e54a17bd33a380a4938a447cb833"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"68a92b2c28b644a521366237e9a8368a57465a1c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                nodetemplate,"},{"line_number":58,"context_line":"                csar_dir\u003dcsar_dir"},{"line_number":59,"context_line":"            )"},{"line_number":60,"context_line":"            log.warning((\u0027Unsupported layer_protocols:%s\u0027) % lp)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def handle_properties(self):"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_15077772","line":60,"range":{"start_line":60,"start_character":26,"end_line":60,"end_character":56},"in_reply_to":"3fa7e38b_e2cc638b","updated":"2019-12-09 10:38:30.000000000","message":"Done","commit_id":"57d6688fd0a5e54a17bd33a380a4938a447cb833"}],"translator/tests/data/etsi_nfv/tosca_nfv_vl.yaml":[{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"46d4f8a7596d63434afdc8d989ac4253d7e36e24","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_0"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  Template for deploying one VirtualLink."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_29d642c6","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2019-12-19 08:54:37.000000000","message":"trilling unicode `\u003cU+FEFF\u003e`","commit_id":"bba9c926e81f882864a38e08e15427a1303b926c"}],"translator/tests/data/etsi_nfv/tosca_nfv_vl_with_unsupported_protocol.yaml":[{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"46d4f8a7596d63434afdc8d989ac4253d7e36e24","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_0"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  Template for VirtualLink with unsupported layer_protocols."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_e9dfcad4","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2019-12-19 08:54:37.000000000","message":"same as rest of yaml file","commit_id":"bba9c926e81f882864a38e08e15427a1303b926c"}]}