)]}'
{"heat/engine/resources/wait_condition.py":[{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"09206adcfa583a292091f0fef127ff53e0173e67","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        ),"},{"line_number":207,"context_line":"    }"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def __init__(self, name, json_snippet, stack):"},{"line_number":210,"context_line":"        super(HeatWaitCondition, self).__init__(name, json_snippet, stack)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def _get_handle_resource(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_af8aca18","line":209,"updated":"2014-07-03 13:58:01.000000000","message":"I would suggest to rename json_snippet to definition to be in line with zaneb\u0027s ResourceDefinition changes that landed in the meantime.","commit_id":"1993131e48bc2c63fa7732a9ef8ee7d4d33799fa"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"fd9e22d5622f21fbf291b971bd0a816fa50bee7b","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        ),"},{"line_number":207,"context_line":"    }"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def __init__(self, name, json_snippet, stack):"},{"line_number":210,"context_line":"        super(HeatWaitCondition, self).__init__(name, json_snippet, stack)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def _get_handle_resource(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_e31f796a","line":209,"in_reply_to":"baada198_af8aca18","updated":"2014-07-03 15:12:36.000000000","message":"Hmm, OK - I don\u0027t see any other resources which have adopted this convention, but since it aligns with the Resource base class then I guess it makes sense.","commit_id":"1993131e48bc2c63fa7732a9ef8ee7d4d33799fa"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"02afae4524bcd26c09a2539f87d34956e6232718","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        ),"},{"line_number":207,"context_line":"    }"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def __init__(self, name, json_snippet, stack):"},{"line_number":210,"context_line":"        super(HeatWaitCondition, self).__init__(name, json_snippet, stack)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def _get_handle_resource(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_d91fc46a","line":209,"in_reply_to":"baada198_e31f796a","updated":"2014-07-03 15:46:00.000000000","message":"Right, existing resources did not change and Zane did not touch all resources. But __init__ in the Resource class uses the new name so I thought new resources should stick to it.","commit_id":"1993131e48bc2c63fa7732a9ef8ee7d4d33799fa"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"09206adcfa583a292091f0fef127ff53e0173e67","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    def check_create_complete(self, runner):"},{"line_number":244,"context_line":"        return runner.step()"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def handle_update(self, json_snippet, tmpl_diff, prop_diff):"},{"line_number":247,"context_line":"        if prop_diff:"},{"line_number":248,"context_line":"            self.properties \u003d json_snippet.properties(self.properties_schema,"},{"line_number":249,"context_line":"                                                      self.context)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_ef3922f3","line":246,"updated":"2014-07-03 13:58:01.000000000","message":"json_snippet is actually also a ResourceDefinition and should be called \u0027definition\u0027 IMO, but zaneb did not rename it in this place, I think because it would have caused too many changes in his patch set.\n\n... i.e. no need to rename here, just wanted to raise this and see if we are motivated to do general renaming of json_snippet to definition ;-)","commit_id":"1993131e48bc2c63fa7732a9ef8ee7d4d33799fa"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"f928cb1dbbc2b52943474fb3a3304397f753e142","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        handle \u003d self._get_handle_resource()"},{"line_number":252,"context_line":"        runner \u003d scheduler.TaskRunner(self._wait, handle)"},{"line_number":253,"context_line":"        runner.start(timeout\u003dfloat(self.properties[self.TIMEOUT]))"},{"line_number":254,"context_line":"        return runner"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def check_update_complete(self, runner):"},{"line_number":257,"context_line":"        return runner.step()"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_19909294","line":254,"updated":"2014-07-10 11:00:03.000000000","message":"to avoid the code duplication, can you just call the handle_create method here?","commit_id":"790e6305d054898ade72c7db32d335948d7c0534"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"be435ce8b0fd57f8829ff9ab1818d7eb61308f73","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        handle \u003d self._get_handle_resource()"},{"line_number":252,"context_line":"        runner \u003d scheduler.TaskRunner(self._wait, handle)"},{"line_number":253,"context_line":"        runner.start(timeout\u003dfloat(self.properties[self.TIMEOUT]))"},{"line_number":254,"context_line":"        return runner"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def check_update_complete(self, runner):"},{"line_number":257,"context_line":"        return runner.step()"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_cb76353e","line":254,"in_reply_to":"baada198_19909294","updated":"2014-07-10 16:23:48.000000000","message":"I\u0027d rather not, as it would be a bit confusing, and runs the risk of futuer bugs when someone adds something create specific to handle_create without noticing it will also happen on update.\n\nI could refactor the handle/runner lines into a _wait_runner function and save two lines, but I\u0027m not really sure it\u0027s worth it.","commit_id":"790e6305d054898ade72c7db32d335948d7c0534"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"a72dec86bbbb0e175546fefd00d9c5752b78500e","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        handle \u003d self._get_handle_resource()"},{"line_number":252,"context_line":"        runner \u003d scheduler.TaskRunner(self._wait, handle)"},{"line_number":253,"context_line":"        runner.start(timeout\u003dfloat(self.properties[self.TIMEOUT]))"},{"line_number":254,"context_line":"        return runner"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def check_update_complete(self, runner):"},{"line_number":257,"context_line":"        return runner.step()"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_0b32ed0f","line":254,"in_reply_to":"baada198_cb76353e","updated":"2014-07-10 16:33:17.000000000","message":"ok thanks, maybe next time we need to work on this code we could implement the _wait_runner function. \nThanks","commit_id":"790e6305d054898ade72c7db32d335948d7c0534"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"aff31fff40512334cf5d1ba7fa3976c91aba2b12","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    }"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def __init__(self, name, definition, stack):"},{"line_number":206,"context_line":"        super(HeatWaitCondition, self).__init__(name, definition, stack)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def _get_handle_resource(self):"},{"line_number":209,"context_line":"        return self.stack.resource_by_refid(self.properties[self.HANDLE])"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_e53f5623","line":206,"updated":"2014-07-14 01:00:35.000000000","message":"pointless constructor.","commit_id":"98f7e3a1865edb72cd0b71a33851502904be8303"}]}
