)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"0412c8d123f964aec279324d90ef6ca44cd25a86","unresolved":false,"context_lines":[{"line_number":19,"context_line":"In future, we could consider exposing the resource_data via a separate API"},{"line_number":20,"context_line":"call, so the resource-metadata could revert to being a pure representation"},{"line_number":21,"context_line":"of the template-defined metadata, with resource_data being the data created"},{"line_number":22,"context_line":"by the resource itself."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Id68d11b584734fbb828aabaca6cc75aab0f4ee4c"},{"line_number":25,"context_line":"Closes-Bug: #1337772"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_588c1236","line":22,"updated":"2014-07-08 15:13:31.000000000","message":"We considered it during software deployments, and the idea was rejected. IMO It complicates the user experience unnecessarily.","commit_id":"1b9985864eacda0587d1e2b1cd2f3d6727862d28"}],"heat/tests/test_metadata_refresh.py":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"0412c8d123f964aec279324d90ef6ca44cd25a86","unresolved":false,"context_lines":[{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        # called by metadata_update()"},{"line_number":357,"context_line":"        server.Server.FnGetAtt(\u0027first_address\u0027).AndReturn(\u002710.0.0.5\u0027)"},{"line_number":358,"context_line":"        server.Server.FnGetAtt(\u0027first_address\u0027).AndReturn(\u002710.0.0.5\u0027)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        self.m.ReplayAll()"},{"line_number":361,"context_line":"        self.stack.create()"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_58bed2d5","line":358,"updated":"2014-07-08 15:13:31.000000000","message":"Please use TEST-NET\u0027s from http://tools.ietf.org/html/rfc5737","commit_id":"1b9985864eacda0587d1e2b1cd2f3d6727862d28"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"05e8b4d972b121a6a1ebf1fa522332d42e48a099","unresolved":false,"context_lines":[{"line_number":370,"context_line":"        self.assertEqual({u\u0027template_data\u0027: \u0027192.0.2.1\u0027}, md)"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        s1.metadata_update()"},{"line_number":373,"context_line":"        s2.metadata_update()"},{"line_number":374,"context_line":"        md \u003d s1.metadata_get()"},{"line_number":375,"context_line":"        self.assertEqual({u\u0027template_data\u0027: \u0027192.0.2.2\u0027}, md)"},{"line_number":376,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_d5ffe0a8","line":373,"updated":"2014-07-09 15:39:03.000000000","message":"It\u0027s not clear to me why we need to call the metadata_update for s2.\nProbably because you want to test that the update doesn\u0027t change value defined just in the template (or something similar)? If so would you mind to put that logic in a separate test?","commit_id":"637de10416d309b81e7610218dbe5e038d3de315"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c724f15a162faff6e04537e225f61d4dc4b48b23","unresolved":false,"context_lines":[{"line_number":370,"context_line":"        self.assertEqual({u\u0027template_data\u0027: \u0027192.0.2.1\u0027}, md)"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        s1.metadata_update()"},{"line_number":373,"context_line":"        s2.metadata_update()"},{"line_number":374,"context_line":"        md \u003d s1.metadata_get()"},{"line_number":375,"context_line":"        self.assertEqual({u\u0027template_data\u0027: \u0027192.0.2.2\u0027}, md)"},{"line_number":376,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_d030cbea","line":373,"in_reply_to":"baada198_60e2d404","updated":"2014-07-09 17:16:55.000000000","message":"Andrea: The reason is basically just to ensure that all resources in the stack have been hit with a metadata_update and everything still works and resolves as expected.\n\nYou are right though, if I was being really thorough I should\u0027ve added a check for the \"{\u0027apples\u0027: \u0027pears\u0027}\" metadata for s2 in this test, but I forgot - feel free to propose that improvement if you wish :)\n\nStrictly speaking you are correct, we could remove the s2.metadata_update and the test would still work OK, it\u0027s just a minor cut/paste artefact from the previous test, and I think it\u0027s harmless (or even mildly beneficial) to just leave it in.","commit_id":"637de10416d309b81e7610218dbe5e038d3de315"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"0e05f0b12fbaad881420373047490065db897b33","unresolved":false,"context_lines":[{"line_number":370,"context_line":"        self.assertEqual({u\u0027template_data\u0027: \u0027192.0.2.1\u0027}, md)"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        s1.metadata_update()"},{"line_number":373,"context_line":"        s2.metadata_update()"},{"line_number":374,"context_line":"        md \u003d s1.metadata_get()"},{"line_number":375,"context_line":"        self.assertEqual({u\u0027template_data\u0027: \u0027192.0.2.2\u0027}, md)"},{"line_number":376,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_60e2d404","line":373,"in_reply_to":"baada198_d5ffe0a8","updated":"2014-07-09 15:56:42.000000000","message":"I don\u0027t think that is worthy of a whole second test. The code path is fully exercised and the test makes sense this way.","commit_id":"637de10416d309b81e7610218dbe5e038d3de315"}]}
