)]}'
{"heat/engine/api.py":[{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"b8777c7de332dc580bf17772c6f06aa8047c1e42","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    adopt_data \u003d params.get(api.PARAM_ADOPT_STACK_DATA)"},{"line_number":54,"context_line":"    if adopt_data:"},{"line_number":55,"context_line":"        adopt_data \u003d template_format.simple_parse(adopt_data)"},{"line_number":56,"context_line":"        kwargs[api.PARAM_ADOPT_STACK_DATA] \u003d adopt_data"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    return kwargs"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_94007d67","line":55,"updated":"2014-09-12 07:59:48.000000000","message":"The error message will be incorrect after your change.","commit_id":"67596f14eac7eac0c9ea060bf88bbe483d6fd21d"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"ed96d1c5b43ddca8c917522aa834d736b09c1f21","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    adopt_data \u003d params.get(api.PARAM_ADOPT_STACK_DATA)"},{"line_number":54,"context_line":"    if adopt_data:"},{"line_number":55,"context_line":"        adopt_data \u003d template_format.simple_parse(adopt_data)"},{"line_number":56,"context_line":"        kwargs[api.PARAM_ADOPT_STACK_DATA] \u003d adopt_data"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    return kwargs"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_465c1dee","line":55,"in_reply_to":"fa98f980_040dbb37","updated":"2014-09-18 02:19:36.000000000","message":"I don\u0027t think so, IIUC, the adopt_data is not define in template, so if the adopt_data parse failed we shouldn\u0027t raise template invalid.","commit_id":"67596f14eac7eac0c9ea060bf88bbe483d6fd21d"},{"author":{"_account_id":9189,"name":"Anderson Mesquita","email":"andersonvom@gmail.com","username":"andersonvom"},"change_message_id":"5f80f78201898b15e1d3b385aa5e8058f3aab548","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    adopt_data \u003d params.get(api.PARAM_ADOPT_STACK_DATA)"},{"line_number":54,"context_line":"    if adopt_data:"},{"line_number":55,"context_line":"        adopt_data \u003d template_format.simple_parse(adopt_data)"},{"line_number":56,"context_line":"        kwargs[api.PARAM_ADOPT_STACK_DATA] \u003d adopt_data"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    return kwargs"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_040dbb37","line":55,"in_reply_to":"fa98f980_94007d67","updated":"2014-09-17 17:25:05.000000000","message":"The error message should be that of an invalid template being parsed, right?  IMO, not changing this message makes error messages more consistent.\n\nIn particular, the previous message was actually incorrect, since adopt data would\u0027ve been parsed fine even if it was YAML and not JSON.","commit_id":"67596f14eac7eac0c9ea060bf88bbe483d6fd21d"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"455cfe8daed046208ecbd9af54237b06d47f51d7","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            adopt_data \u003d template_format.simple_parse(adopt_data)"},{"line_number":57,"context_line":"        except ValueError as exc:"},{"line_number":58,"context_line":"            raise ValueError(_(\u0027Adopt data is invalid: %s\u0027) % exc)"},{"line_number":59,"context_line":"        kwargs[api.PARAM_ADOPT_STACK_DATA] \u003d adopt_data"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    return kwargs"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9df570_da2e59a5","line":58,"updated":"2014-09-20 00:58:09.000000000","message":"How about remain the old error message.","commit_id":"f83b52e2eeb2c2b86736a1b133c8544ddb2a1e25"},{"author":{"_account_id":9189,"name":"Anderson Mesquita","email":"andersonvom@gmail.com","username":"andersonvom"},"change_message_id":"951917f693586670872c18d97c3bff1b1be589c0","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            adopt_data \u003d template_format.simple_parse(adopt_data)"},{"line_number":57,"context_line":"        except ValueError as exc:"},{"line_number":58,"context_line":"            raise ValueError(_(\u0027Adopt data is invalid: %s\u0027) % exc)"},{"line_number":59,"context_line":"        kwargs[api.PARAM_ADOPT_STACK_DATA] \u003d adopt_data"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    return kwargs"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_c3525166","line":58,"in_reply_to":"da9df570_da2e59a5","updated":"2014-10-06 15:48:46.000000000","message":"IMO the old message is wrong.  Adopt data does not have to be a dict.  It could be either a JSON object or a YAML mapping, and both would work fine, which is precisely what the message from simple_parse conveys.","commit_id":"f83b52e2eeb2c2b86736a1b133c8544ddb2a1e25"}],"heat/tests/test_engine_api_utils.py":[{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"b8777c7de332dc580bf17772c6f06aa8047c1e42","unresolved":false,"context_lines":[{"line_number":944,"context_line":"    def test_invalid_adopt_stack_data(self):"},{"line_number":945,"context_line":"        p \u003d {\u0027adopt_stack_data\u0027: json.dumps(\"foo\")}"},{"line_number":946,"context_line":"        error \u003d self.assertRaises(ValueError, api.extract_args, p)"},{"line_number":947,"context_line":"        self.assertEqual("},{"line_number":948,"context_line":"            \u0027Unexpected adopt data \"foo\". Adopt data must be a dict.\u0027,"},{"line_number":949,"context_line":"            six.text_type(error))"},{"line_number":950,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_94379d4c","side":"PARENT","line":947,"updated":"2014-09-12 07:59:48.000000000","message":"don\u0027t just remove the assertEqual","commit_id":"b3cb23e5b33c99db5e80d639a56e7dec4ea27e65"},{"author":{"_account_id":9189,"name":"Anderson Mesquita","email":"andersonvom@gmail.com","username":"andersonvom"},"change_message_id":"5f80f78201898b15e1d3b385aa5e8058f3aab548","unresolved":false,"context_lines":[{"line_number":944,"context_line":"    def test_invalid_adopt_stack_data(self):"},{"line_number":945,"context_line":"        p \u003d {\u0027adopt_stack_data\u0027: json.dumps(\"foo\")}"},{"line_number":946,"context_line":"        error \u003d self.assertRaises(ValueError, api.extract_args, p)"},{"line_number":947,"context_line":"        self.assertEqual("},{"line_number":948,"context_line":"            \u0027Unexpected adopt data \"foo\". Adopt data must be a dict.\u0027,"},{"line_number":949,"context_line":"            six.text_type(error))"},{"line_number":950,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_7a71c243","side":"PARENT","line":947,"in_reply_to":"fa98f980_94379d4c","updated":"2014-09-17 17:25:05.000000000","message":"IMO, asserting on the error message from a different method would make this test brittle.","commit_id":"b3cb23e5b33c99db5e80d639a56e7dec4ea27e65"}]}
